summaryrefslogtreecommitdiff
path: root/unoidl
AgeCommit message (Collapse)AuthorFilesLines
2016-05-12Massage code to avoid warningsStephan Bergmann2-8/+6
Change-Id: I112f5e7c845184b9aa5285ecfa40b5bbb34ffde1
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-1/+1
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-04-26loplugin:nullptrStephan Bergmann1-106/+121
Change-Id: I02e177e07fc5fef225351392c9cd5743a2212967
2016-03-17loplugin:constantparam in registryNoel Grandin1-1/+1
Change-Id: Ic3c60325a722422912d06fe21d072c5f5c4bccb1 Reviewed-on: https://gerrit.libreoffice.org/23322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-06Fix prev. commitStephan Bergmann1-3/+5
Change-Id: I1dd71d6e35ac2dc5f27a11a3dd269247b1b35d39
2016-02-06Clean up for loops in unoidlStephan Bergmann7-823/+442
Change-Id: I9c2e0a10699580026fbf38f0c857ac148de74f9c
2016-02-04Add --ignore-unpublished to unoidl-checkStephan Bergmann1-17/+35
...to make it a better replacement for SDK's regcompare Change-Id: I7b5eee3d449b8dc7c03601083d06a6d13e4607be
2015-12-14Use emplace_backStephan Bergmann3-184/+126
Change-Id: I006e3c8f411b480917d9cfb9c4f3d082b79c833d
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann1-2/+2
Change-Id: I06921ce068a3ffc9c1502326f03e9b13ee1c6ef6
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann8-37/+37
Change-Id: I7c8f90ae3cb496def3bee9a8a84974dd63478af3
2015-11-06coverity#1338263 Uncaught exceptionCaolán McNamara1-0/+3
Change-Id: Ide3aec7a352786ed441be1f506a5cf488843ea29
2015-11-06coverity#1338262 Uncaught exceptionCaolán McNamara1-0/+3
Change-Id: I95f00b63f21b29bc3c22a4891ebc5668fed723fc
2015-11-06coverity#1338259 Uncaught exceptionCaolán McNamara1-0/+6
Change-Id: I36e2194c304adae5b5c3377519eccc5ef78fd9ea
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann9-23/+23
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-08-21Use sal_uInt16, as required, and use < in for loop conditionMatteo Casalin1-4/+4
Change-Id: Iae44d45d749c6f51be72c0b2d16639c7287c42b2
2015-06-02cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
2015-05-28new clang plugin: loopvartoosmallNoel Grandin1-3/+3
Idea from bubli - look for loops where the index variable is of such size that it cannot cover the range revealed by examining the length part of the condition. So far, I have only run the plugin up till the VCL module. Also the plugin deliberately excludes anything more complicated than a straightforward incrementing for loop. Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-26cppcheck: noExplicitConstructorCaolán McNamara2-3/+3
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann1-0/+1
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-09convert RTReferenceType to scoped enumNoel Grandin1-3/+3
Change-Id: I8320f6f42d5579fbd09450ddca61c4c066de98e4
2015-04-09convert RTMethodMode to scoped enumNoel Grandin1-7/+7
Change-Id: I81599570698eb92abf14fa6386d8545c2031e863
2015-04-09convert RT_ACCESS fields to scoped enumNoel Grandin1-18/+15
Change-Id: Ifef0aaae6208f18c1352fef7c471deb60a97820d
2015-04-09convert RegError to scoped enumNoel Grandin1-22/+22
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
2015-04-09convert RegValueType to scoped enumNoel Grandin1-2/+2
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
2015-04-09convert REG_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
2015-03-09V801: Decreased performanceCaolán McNamara1-1/+1
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-02remove executable bit from c / h / cxx / hxx / l filesMichael Stahl1-0/+0
Change-Id: I90d7788208fb86c8aea36c4944ca11d881f11720
2014-12-19unoidl: Use appropriate OUString functions on string constantsStephan Bergmann1-2/+2
Change-Id: I6ff256e091770d67f98b1b6b8d447a22fd720d4e
2014-11-21Silence unhelpful cid#1213376 untrusted loop bound warningsStephan Bergmann1-0/+14
Change-Id: I0a1fcebb268bea942d4bc2d6bf835c3ffb24df3e
2014-11-20This should ideally be consistency-checked in UnoidlProviderStephan Bergmann1-3/+8
...but is not, for performance reasons. Change-Id: I2518eb1f1a2f84cfd836c390a418a2fcb516b82c
2014-11-19Guard against cyclic entity dependenciesStephan Bergmann1-9/+20
...in unoidl-read, although it would be better (but more expensive at start- up) to check consistency in unoidl::Manager. Change-Id: I5f5894fcd51af3aa999fe30621f52bfd11d0e610
2014-11-19Check entity and type name syntaxStephan Bergmann1-50/+181
(For types, only checks their syntax, but not whether they semantically fit in a certain situation, e.g., "boolean" cannot be used as a base interface.) Change-Id: I12f617e74ca13ce2afcec8f611bfdb4912c62960
2014-11-19Check for recursive mapsStephan Bergmann2-38/+83
Change-Id: I50227c41c5b4c5c410939ddfa078b996b5804965
2014-11-19Revert "cosmetic 'en-passant'...."Stephan Bergmann1-746/+696
This reverts commit d4810a814c7c7f3db2df15b62367bd1edc7040f6. Change-Id: Ia062e070c7d7dac5cc4388d1c8e812fb97851d52
2014-11-18Avoid overflowStephan Bergmann1-3/+9
Change-Id: Ia80682aeb87225b9bde7398186e121b1d3bdc2ad
2014-11-18Check that UNOIDL enum has membersStephan Bergmann1-0/+4
Change-Id: I5b362ad374dad5fd4a79b8a7706defb749e25eb3
2014-11-18Avoid overflowStephan Bergmann1-1/+1
Change-Id: I4afe86dc29788a7b2d2d9c438f182726f80b1cbd
2014-11-05coverity#1103678 Unchecked dynamic_castCaolán McNamara1-2/+2
Change-Id: Ic87cc3d968447051e52012e59d92e95280d9d35a
2014-10-24coverity#1242422 Unchecked dynamic_castCaolán McNamara1-3/+2
Change-Id: If5e8b90f32c167bafeb3649f4bc6c31198635947
2014-07-10cosmetic 'en-passant'....Norbert Thiebaud1-696/+746
Change-Id: I9a787065898004ece4bd55839c563b7395e3a314
2014-07-10coverity#1224979 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I539ba11497a8c7384b5ca8ee4792548dca139811
2014-07-10coverity#1224980 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I17379f596fd8b48bd1015538eacc5265cfa83a82
2014-07-07fix build error 'strlen' is not a member of 'std' locallyDouglas Mencken1-0/+1
Change-Id: I587ef2c38fd9377eef2073a49cd8497b2bd4bf9f Reviewed-on: https://gerrit.libreoffice.org/10076 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-27tweak assert so comment appears in abort messageCaolán McNamara3-14/+14
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
2014-05-23Remove circular references between unoidl::Manager and its providersStephan Bergmann5-15/+11
Change-Id: Ic6ad3e2c7f69dd123077a913f35f1971f1e8ca13
2014-05-23Combine unoidl::loadProvider and unoidl::Manager::addProviderStephan Bergmann5-37/+36
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
2014-04-29coverity#1210179 Uninitialized pointer fieldCaolán McNamara1-1/+1
Change-Id: I09534eab67c0ae38cd6965c3b63227d92b72c646
2014-04-11unoidl-check: Also check for invalid UNOIDL identifiersStephan Bergmann1-0/+270
...but only in those parts of registry B that are not also in registry A. That way, we can detect newly introduced violations while ignoring the old (published) violations for backwards compatibility. Change-Id: Ifb8ea98fffca29647aa6677a5ade86e5b194ddee
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann9-23/+23
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin1-3/+3
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361