summaryrefslogtreecommitdiff
path: root/unodevtools
AgeCommit message (Collapse)AuthorFilesLines
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin3-74/+74
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24clang-tidy performance-unnecessary-copy-init in test..xmlscriptNoel Grandin1-2/+1
Change-Id: I1ae16467a8e58e8a50f59b7a140e9f8b68bde07e Reviewed-on: https://gerrit.libreoffice.org/62254 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17Simplify containers iterations in unodevtools, unoidlArkadiy Illarionov6-398/+246
Use range-based loop or replace with STL functions. Change-Id: I3089a4d4a94eea849cad442b04906908908e4c27 Reviewed-on: https://gerrit.libreoffice.org/61854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-17New loplugin:externalStephan Bergmann5-52/+52
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-02Add missing sal/log.hxx headersGabor Kelemen1-0/+1
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from test to vbahelper Change-Id: Ia7f773511624099505d6a36a8d6e23c0cde4a737 Reviewed-on: https://gerrit.libreoffice.org/58225 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-15Fix typosAndrea Gelmini1-5/+5
Change-Id: Icb2d5f8bb9eb781d6a59384e1aac75abf6145774 Reviewed-on: https://gerrit.libreoffice.org/51337 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-27loplugin:unnecessaryparen: Warn about parentheses around literalsStephan Bergmann1-1/+1
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet warn about Boolean literals, which are sometimes wrapped in parentheses to silence unreachable-code warnings. To avoid multiple warnings about code like f((0)) switch to generally using a set of ParenExpr to keep track of which occurrences have already been handled. Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc Reviewed-on: https://gerrit.libreoffice.org/45317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-23loplugin:includeform: unodevtoolsStephan Bergmann11-40/+40
Change-Id: Iac0a22dd68a39cf5f71907c8f1e289fbd0c95249
2017-10-01Prefer prefix operatorJulien Nabet1-2/+2
Change-Id: I82f3f66bfc675dbc4a5d5b57d8715c3de01d9620 Reviewed-on: https://gerrit.libreoffice.org/42994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-29loplugin:flatten check for throw in then clauseNoel Grandin2-6/+4
also make the plugin ignore the case where we have var decl's in the clause we want to flatten, which could lead to problematic extension of variable lifetime Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59 Reviewed-on: https://gerrit.libreoffice.org/42889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin1-1/+1
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin1-1/+1
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14use more OUString::operator== in test..xmlsecurityNoel Grandin1-1/+1
Change-Id: If5bdd1532be44a47ff7cc3b769be3ea585aea562 Reviewed-on: https://gerrit.libreoffice.org/39685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin1-4/+2
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06use OString::operator== in preference to ::equalsNoel Grandin3-5/+5
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf Reviewed-on: https://gerrit.libreoffice.org/39646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-13fix bug in skeletonmakerNoel Grandin1-1/+1
how this got missed for so long I don't know Change-Id: I5c4bbb880f364fdbb8c88e80c6329184c0bd48a5 Reviewed-on: https://gerrit.libreoffice.org/38725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin3-10/+7
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:checkunusedparams in configmgr and vclNoel Grandin1-2/+2
Change-Id: I7226d01f38e6edaf3868d7267d9b02dbdbc9e5ba Reviewed-on: https://gerrit.libreoffice.org/36975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10New loplugin:conststringvar: unodevtoolsStephan Bergmann2-3/+3
Change-Id: I7bbe7f78b8e62962f907a598e8405be7d4be03c9
2016-11-01Omit the default comparatorTakeshi Abe1-2/+1
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0 Reviewed-on: https://gerrit.libreoffice.org/30319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-08-11loplugin:countusersofdefaultparams in svl..unodevtoolsNoel Grandin2-3/+3
Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2 Reviewed-on: https://gerrit.libreoffice.org/28017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27Get rid of unnecessary directory levels $D/inc/$DTor Lillqvist3-5/+5
Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48 Reviewed-on: https://gerrit.libreoffice.org/25532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-02Remove unused pbOpt parameterStephan Bergmann3-20/+18
Change-Id: I4c566a122d600d41d7d8049779628a08e68ca277
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-2/+2
Change-Id: Ife577280d5176d9f48bff719c7b52fc829ae49f1
2016-03-08Remove ornamental noiseStephan Bergmann1-3/+3
Change-Id: Ic8d33142b6bd7d271e94ec93661f0260bb2ea6e2
2016-03-08tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-26/+3
I removed the fprintf statements and replaced them with SAL_WARN statements. Change-Id: Id75e310e3a95b249fdf92a4dd5a9bcf1b7fb9be6 Reviewed-on: https://gerrit.libreoffice.org/22984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-24convert codemaker::UnoType::Sort to scoped enumNoel Grandin4-132/+132
Change-Id: I70a84f777e714bcc20c2d7b06b918e3be0f3ce4a
2015-12-14Use emplace_backStephan Bergmann1-15/+13
Change-Id: I006e3c8f411b480917d9cfb9c4f3d082b79c833d
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann5-12/+12
Change-Id: Ic89c5fb56e1f11fa17f6014a8c9722592b144337
2015-11-09new loplugin: oncevarNoel Grandin1-4/+2
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06coverity#1338260 Uncaught exceptionCaolán McNamara1-0/+3
Change-Id: Ib969223cb5c8acdad0e97ff9b944703d3ee43825
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin1-4/+2
Change-Id: Id57ccff7ea6cf5c7053b51268b1190f5459bb357
2015-08-11loplugin: defaultparamsNoel Grandin4-6/+6
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
2015-08-10cppcheck: badBitmaskCheckCaolán McNamara1-1/+1
Change-Id: I0a6787379317e5077c5a4520e5144fe091a01538
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:redundantAssignmentNoel Grandin1-1/+1
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl1-3/+3
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2014-12-16unodevtools: Use appropriate OUString functions on string constantsStephan Bergmann3-18/+18
Change-Id: I70a86543c0269cbaeefc9cbe1da30c2ad7e48333
2014-12-04unodevtools: loplugin:cstylecastStephan Bergmann2-12/+12
Change-Id: Id4bd8bb8361204ae281a090840b08c502e5b4a7a
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-1/+1
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini1-1/+1
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin7-9/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-01New loplugin:stringconcatStephan Bergmann5-55/+53
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-21cppcheck: Redundant checking of STL containerJulien Nabet1-11/+4
Change-Id: I83a8671e90431bbc4f41392f062d37c452b018ff
2014-06-05various: remove SAL_THROW macroNoel Grandin1-1/+1
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-04compareTo -> equalsNoel Grandin1-6/+6
convert OUString::compareTo usage to equals to startsWith where it is more appropriate Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin2-2/+2
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-08Clean up function declarationsStephan Bergmann5-35/+31
Change-Id: I18125ac6c58c89f76c3a6cfb3a7ee77b1059aeb1
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin1-1/+1
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-03-18Make parameters const too.Andrzej Hunt1-2/+2
(Following on from loplugin:passstringbyref) Change-Id: I9100f51aa7420b237c84de7d36d2374ac6612d00
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-01 09:50:52 +0000