summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)AuthorFilesLines
2013-03-28Remove RTL_CONSTASCII_(U)STRINGPARAM in ucbChr. Rossmanith4-36/+22
and use append() instead of appendAscii() Change-Id: I7c9dd0e03e24a39240a82fc245b4722d4c424842
2013-03-27clear -Werror=write-strings in NeonUri.cxxChr. Rossmanith1-3/+3
Change-Id: I7a67c1858b2954ca0522320b9008d70ed1afd64c
2013-03-27Remove RTL_CONSTASCII_STRINGPARAM in ucbChr. Rossmanith3-111/+58
Change-Id: Ib450c1463add267ad64707c7a2d71e7f6a9c0849
2013-03-27-Wunused-macrosStephan Bergmann2-5/+0
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-25remove external include guardsThomas Arnhold1-8/+0
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
2013-03-26Bin ASCII art and pointless commentsTor Lillqvist10-226/+6
Change-Id: I9c510a0edb2a04d1378d488cc724e8f9982b5ba3
2013-03-26WaE: unused function 'matchIgnoreAsciiCase'Tor Lillqvist1-15/+0
Change-Id: I5a270b7375807d1eaad9e22acea4457a0ceb5c54
2013-03-25Remove RTL_CONSTASCII_STRINGPARAM in NeonUri.cxxChr. Rossmanith1-4/+2
Change-Id: Ibfce9af9bec2e1bac435514ad6d3d27eac5f1a17 Reviewed-on: https://gerrit.libreoffice.org/2975 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-03-25Introduce HAVE_GCC_PRAGMA_DIAGNOSTIC_{MODIFY,SCOPE}Stephan Bergmann1-7/+2
...replacing hard-coded GCC version checks. Those checks that guard #pragma GCC diagnostic ignored "-Wnon-virtual-dtor" appear relevant only for GCC itself, not Clang (which used to fail the old guards because it typically announces itself with a rather low __GNUC__/__GNUC_MINOR__ version), see 6e67c03dc0225fc66343546b14e902b9d238b1a3 "Enable -Wnon-virtual-dtor for GCC 4.6" Change-Id: I6bfa4d5caa6192e7a203ce829682bf6bb8d61a1b
2013-03-24Does not compileStephan Bergmann1-7/+7
Change-Id: If7d24a6378a6645baf9d0c40e3c3cf0ae7d4f317
2013-03-24Remove RTL_CONSTASCII_(U)STRINGPARAM in ucb(ucp)Chr. Rossmanith12-80/+54
Change-Id: Iae4ea99e6eff6de8db3d40a6b86e5fd28ff857d0
2013-03-20Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)Thomas Arnhold1-13/+7
Now all should be gone. Change-Id: Iaaaebfbb85535d95eab6a2043e7d5e2e845d9782
2013-03-20Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)Stephan Bergmann3-19/+9
...which is a confusing overload with unexpectedly different semantics from the one-parameter form. In preparation of marking it as deprecated. Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-20simplify OUString assignmentsChr. Rossmanith1-2/+2
Change-Id: Ieffd80aa84c9a041785bb81b3a904a32d00cb2bb Reviewed-on: https://gerrit.libreoffice.org/2863 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold1-1/+1
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Reviewed-on: https://gerrit.libreoffice.org/2835 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19coverity#982271 Copy-paste errorJulien Nabet1-1/+1
Change-Id: I42800a846ba0cb935f97f8e99f774f58f3b525f8 Reviewed-on: https://gerrit.libreoffice.org/2802 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-19Simplify equalsIgnoreAsciiCaseAscii[L] callsStephan Bergmann1-3/+1
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold21-516/+407
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19trailing whitespacesThomas Arnhold1-1/+1
Change-Id: I3d0e2015e4c9f0ea6118fd92892022607fe4bde6
2013-03-18incorrect NEON_VERSION usageLuboš Luňák1-5/+1
First of all, NEON_VERSION is undefined, and second, it's actually a text string, so this is all broken. Change-Id: Iba841c78e9034bf9ef74eb4f31c9893608180b77
2013-03-15fprintf -> SAL_WARNStephan Bergmann1-4/+3
Change-Id: Ifab1415fafa93551d8bed1e77c38f04bec8d2eba
2013-03-15Revert "Conditionalize call of ne_debug_init() using the SAL_INFO() mechanism"Tor Lillqvist1-11/+11
It won't work, ne_debug_init() will be called always (in non-release builds). This reverts commit b6f6c3a2ed19cc34cce5d19c32c921227165bdd0.
2013-03-15Conditionalize call of ne_debug_init() using the SAL_INFO() mechanismTor Lillqvist1-11/+11
Instead of #if OSL_DEBUG_LEVEL>0. Change-Id: I2329de4deff4687fb1249c47f2e24eaf6ea6a248
2013-03-15Lock document that is opened for potential modificationTor Lillqvist1-0/+5
Part of fix for bnc#805901. (No locking of documents edited through WebDAV.) Seems to work, can it really be this simple... I am a bit unsure if any explicit UNLOCK operation happens, but WebDAV locks typically time out relatively quickly, don't they? And WebDAV implementations (often/always?) have the possibility for a user to force open a lock. Change-Id: Ia32d8b1517361f702b4f469d9f1aa17de6d7ba54
2013-03-15SAL_INFO instead of OSL_TRACETor Lillqvist1-4/+3
Change-Id: I40a2e6ea708aa037172bc6e9f9882c88f1d486c3
2013-03-15Use default set of root certificates, if available, when using SSLTor Lillqvist1-0/+5
Part of fix for the WebDAV https server authentication problem noticed when fixing bnc#805901. Change-Id: Ic54c59bdadaf34cdba32949400d5da69712017f3
2013-03-15Turn on Neon lock and SSL debugging too (when OSL_DEBUG_LEVEL>0)Tor Lillqvist1-1/+2
Change-Id: I4acb7ab1aeba31bfeedd4dfbcd76d6bf517b8944
2013-03-14remove legacy build.pl prj/build.lst files.Michael Meeks1-5/+0
2013-03-14fdo#54275: Fix GVFS UCP, so saving docs works againStephan Bergmann1-9/+13
Similar to 8722f0e7ef690205d042c8a6b1fdf342a34ecbe1 "rhbz#895690: Make GIO UCP less brittle, so saving docs works again" the alternative, older GVFS UCP (--enable-gnome-vfs --disable-gio, as used e.g. in distro-configs/LibreOfficeLinux.conf) no longer works well in LO 3.6 and later: * For one, "getPropertyValues" did not work for non-existing files, just like in the GIO UCP case. * For another, creating the .~XXX# lock file uses "insert" with !bReplaceExisting, which apparently never worked for the GVFS UCP. Change-Id: Ie4dc032225697ff7b866a75327891c796d559392
2013-03-13rhbz#895690: Make GIO UCP less brittle, so saving docs works againStephan Bergmann1-16/+15
966d20e35d5a2be2fce6c204af5c156c3ead7063 "CMIS ucp: write documents back to CMIS server" had introduced changes to sfx2/source/doc/docfile.cxx in LO 3.6 that changed the exact commands that this code issued for UCP content nodes. The GIO UCP was not prepared to handle that, causing saving of documents via it to fail with rather obscure error messages: * For one, docfile.cxx started to call "getPropertyValues" to obtain the "Title" of a non-existent content. That lead to an InteractiveAugmentedIOException instead of silently returning a void value. * For another, docfile.cxx started to call "transfer" on a folder content whose URL did not have a trailing slash, so the code computed a wrong URL for the child element, resulting in various problems depending on context. Change-Id: I1a9c0c094f5320456940e3af4c802711828ab5ac
2013-03-12Remove RTL_CONSTASCII_USTRINGPARAM in ucb/ucbhelperChr. Rossmanith6-83/+74
Change-Id: I7419a328012962b6b72d2596df034ff912fc12cd
2013-03-11use startsWith() instead of compareToAscii()Thomas Arnhold2-3/+3
brain damage... Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold3-8/+8
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-08some further OUString cleanupThomas Arnhold1-20/+20
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-06fdo#60724 change spelling error REMOVEABLE -> REMOVABLEKenneth Beck2-8/+8
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments. All other instances of the misspelling have remained the same. Example: AF_REMOVEABLE Change-Id: I391f4101bbc3e06689318235a37d616065bc1686 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-05Call ne_debug_init() in a debug buildTor Lillqvist1-1/+1
Change-Id: I08d540bdbe32ba9df994528bac97ac76e587795a
2013-03-05doubled usingThomas Arnhold1-1/+0
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-04doubled includesThomas Arnhold4-13/+0
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04Fix "may be used uninitialized" warningStephan Bergmann1-1/+1
Change-Id: I6d2ac90177bd3194e0e3c23ee7c8dd634bb64228
2013-03-04fdo#46808, convert singleton util::theOfficeInstallationDirectoriesNoel Grandin1-8/+2
.. to new-style UNO. And deprecate old service in favour of singleton. Change-Id: I67244097c22af02530214d7c529dd0d32f5964c1
2013-03-03Related to fdo#60724: correct spellingThomas Arnhold8-8/+8
Using the autocorrect list of LibreOffice extras/source/autotext/lang/en-US/acor/DocumentList.xml Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657 Script: http://pastebin.ca/2327716
2013-03-01Related rhbz#915743: Do not call into DAVResourceAccess with mutex lockedStephan Bergmann2-69/+80
...from webdav Content::getResourceType, as otherwise Content::abort would be blocked waiting for the mutex (in code that would call abort, which will be required to fix rhbz#915743 "thread deadlock/slow join in insert->hyperlink in impress"). This required to get the odd reference to enum return type of getResourceType straight. Also, propagate information about !shouldAccessNetworkAfterException from getResourceType out to getPropertyValues, to avoid further calls that would again block/fail. Change-Id: I8b9d43a61eb4078acb90079c4eb7aa98a59a8983
2013-03-01neon commands cannot be abortedStephan Bergmann2-9/+3
See <http://lists.manyfish.co.uk/pipermail/neon/2013-February/001533.html> "Re: About ne_set_read_timeout" for why ne_close_connection is not a solution here (and currently would not work anyway, for the thread calling abort would block on the aGlobalNeonMutex introduced with 510da29131e56ba0e1783e505e7131e6f7e0d6b4 "forced to make certain neon api calls thread-safe due to cups" until the blocking thread was done with its neon call) and "a new, dedicated, thread-safe ne_session_* API call will be needed to allow aborting of a running request." So enable DAVResourceAccess::abort again and instead disable the underlying NeonSession::abort. i#106766 "Crash when cancelling extension update" does not give any good rationale why DAVResourceAccess::abort had to be disabled, so it might well have been because the underlying NeonSession::abort was bogus to begin with. Change-Id: If8293b93a960907726208bb2f93c375d83357ed3
2013-02-28remove all d.lstMichael Stahl1-0/+0
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-28remove useless comment linesMarkus Mohrhard1-21/+0
Change-Id: I884a97d36ff2ed2f4526cf96af9cac214af4db31
2013-02-28coverity#705769: fix memory leakMarkus Mohrhard1-0/+1
Change-Id: I77454dd6c33c8309991108343a2895792095f95d
2013-02-25loplugin: unused variablesThomas Arnhold7-19/+0
Change-Id: I07b82471f0f32e9e894d4eb392beedeafc6be0c7
2013-02-24fdo#38838 searched, replaced and removed String::CreateFromInt32().Jean-Noël Rouvignac1-1/+1
I ran the following code replace: s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/ And finally removed String::CreateFromInt32(). Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5 Reviewed-on: https://gerrit.libreoffice.org/2279 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-23Fix typo "fuction" -> "function"Julien Nabet1-1/+1
Change-Id: I369da2262d42fbc7cc3cfeeef4920606522237cd
2013-02-22s/the the/the/Tor Lillqvist2-4/+4
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3