path: root/ucb
AgeCommit message (Collapse)AuthorFilesLines
2013-03-04Fix "may be used uninitialized" warningStephan Bergmann1-1/+1
Change-Id: I6d2ac90177bd3194e0e3c23ee7c8dd634bb64228
2013-03-04fdo#46808, convert singleton util::theOfficeInstallationDirectoriesNoel Grandin1-8/+2
.. to new-style UNO. And deprecate old service in favour of singleton. Change-Id: I67244097c22af02530214d7c529dd0d32f5964c1
2013-03-03Related to fdo#60724: correct spellingThomas Arnhold8-8/+8
Using the autocorrect list of LibreOffice extras/source/autotext/lang/en-US/acor/DocumentList.xml Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657 Script:
2013-03-01Related rhbz#915743: Do not call into DAVResourceAccess with mutex lockedStephan Bergmann2-69/+80
...from webdav Content::getResourceType, as otherwise Content::abort would be blocked waiting for the mutex (in code that would call abort, which will be required to fix rhbz#915743 "thread deadlock/slow join in insert->hyperlink in impress"). This required to get the odd reference to enum return type of getResourceType straight. Also, propagate information about !shouldAccessNetworkAfterException from getResourceType out to getPropertyValues, to avoid further calls that would again block/fail. Change-Id: I8b9d43a61eb4078acb90079c4eb7aa98a59a8983
2013-03-01neon commands cannot be abortedStephan Bergmann2-9/+3
See <> "Re: About ne_set_read_timeout" for why ne_close_connection is not a solution here (and currently would not work anyway, for the thread calling abort would block on the aGlobalNeonMutex introduced with 510da29131e56ba0e1783e505e7131e6f7e0d6b4 "forced to make certain neon api calls thread-safe due to cups" until the blocking thread was done with its neon call) and "a new, dedicated, thread-safe ne_session_* API call will be needed to allow aborting of a running request." So enable DAVResourceAccess::abort again and instead disable the underlying NeonSession::abort. i#106766 "Crash when cancelling extension update" does not give any good rationale why DAVResourceAccess::abort had to be disabled, so it might well have been because the underlying NeonSession::abort was bogus to begin with. Change-Id: If8293b93a960907726208bb2f93c375d83357ed3
2013-02-28remove all d.lstMichael Stahl1-0/+0
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-28remove useless comment linesMarkus Mohrhard1-21/+0
Change-Id: I884a97d36ff2ed2f4526cf96af9cac214af4db31
2013-02-28coverity#705769: fix memory leakMarkus Mohrhard1-0/+1
Change-Id: I77454dd6c33c8309991108343a2895792095f95d
2013-02-25loplugin: unused variablesThomas Arnhold7-19/+0
Change-Id: I07b82471f0f32e9e894d4eb392beedeafc6be0c7
2013-02-24fdo#38838 searched, replaced and removed String::CreateFromInt32().Jean-Noël Rouvignac1-1/+1
I ran the following code replace: s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/ And finally removed String::CreateFromInt32(). Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5 Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Thomas Arnhold <> Tested-by: Thomas Arnhold <>
2013-02-23Fix typo "fuction" -> "function"Julien Nabet1-1/+1
Change-Id: I369da2262d42fbc7cc3cfeeef4920606522237cd
2013-02-22s/the the/the/Tor Lillqvist2-4/+4
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-19coverity#983214 Resource leakMichael Stahl2-35/+24
... and some more general cleanup by using boost stuff. Change-Id: I90b2f429f864c39cda70d42d061da14c0faba8e5
2013-02-14CMIS: made it work with Lotus LiveCédric Bosdonnat3-34/+135
Making libcmis and LibreOffice work with Lotus Live service needed a few hacks to either better implement CMIS or workaround some bad implementations. As a general improvement, the CheckOut InfoBar isn't shown if the document can't be checked out.
2013-02-14CMIS: URL-decode username or it won't be shown properly in dialogCédric Bosdonnat1-3/+3
2013-02-13Some cppcheck cleaningJulien Nabet1-13/+27
Change-Id: I099171d85a51095f0ff6d592c1260d931f9769b2
2013-02-12CMIS: proxy was setin to ":-1" is no proxy is defined in the UICédric Bosdonnat2-2/+6
Don't output the port number if that one is not valid.
2013-02-11fdo#46808, Use singleton util::theMacroExpander new-style constructorNoel Grandin1-6/+3
And deprecate the old-style service util::MacroExpander Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-02-08fdo#38838 Some removal/replacement of the String/UniString with OUStringJean-Noël Rouvignac1-15/+15
Change-Id: I6daea312198fae3a9717bd8d4fea6371aa4cd275 Reviewed-on: Reviewed-by: Tor Lillqvist <> Tested-by: Tor Lillqvist <>
2013-01-30Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRINGJean-Noël Rouvignac1-8/+7
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd Reviewed-on: Tested-by: Luboš Luňák <> Reviewed-by: Luboš Luňák <>
2013-01-28fdo#46808, Convert some bits to new-style UNONoel Grandin1-5/+3
Change-Id: I505910ae117588d54b79e72c12368224b4632fb9
2013-01-26gbuild: do not copy boost headers aroundMichael Stahl7-1/+13
- do not use gb_UnpackedTarball_copy_header_files for boost - adapt the optimization in concat-deps.c for new path - use boost_headers in all LinkTargets that require it - add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2013-01-26Remove redundant braces around for loopsStephan Bergmann2-12/+22
...that had once been workarounds for compilers that did not yet support the C++98 scoping rules for declarations in for-init-statements. Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
2013-01-24CMIS: use the proxy settings from the optionsCédric Bosdonnat2-0/+18
Change-Id: I5b856ac166b67097e1921ec71eb5b7e1819fec41
2013-01-21Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()Jean-Noël Rouvignac1-4/+4
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de Reviewed-on: Reviewed-by: Luboš Luňák <> Tested-by: Luboš Luňák <>
2013-01-21gvfs UCP: silence -Werror=deprecated-declarationsMichael Stahl1-0/+2
Seems to me there's no point to that since GVFS itself is deprecated anyway. Change-Id: Ibceba3bbe33a3a37dd088d0f24bfdd4211095589
2013-01-20Fix missing parenthesisJulien Nabet1-40/+40
Change-Id: I9b8b42465fc9246b9a85b5779a3073992ac82379
2013-01-13Add missing parenthesisJulien Nabet1-1/+1
Like this since 29/06/2001 (5ef2de612d973bc747ff4a107e4e4c4ecb273429) Change-Id: Ic86d6ca473a8bdf8f4c6f216fb6dd20af4694911
2013-01-13fdo#38838 Some removal/replacement of the String/UniString with OUStringJean-Noël Rouvignac1-270/+102
Change-Id: Ibce0f8542aa398147d74f7acf53b2898dc3e4eff
2012-12-30fdo#39440 - cppcheck cleanlinessRadu Ioan1-1/+1
Correct some strings Change-Id: Ic019cb11b87cd51e7ffd1fb8f16b79dff381936c Reviewed-on: Reviewed-by: Markus Mohrhard <> Tested-by: Markus Mohrhard <>
2012-12-25Get rid of (most uses of) GUITor Lillqvist1-2/+2
GUI only takes values UNX or WNT, so it is fairly pointless. One can check whether OS is WNT or not instead. Change-Id: I78ae32c03536a496a563e5deeb0fca78aebf9c34 Reviewed-on: Reviewed-by: Peter Foley <> Tested-by: Peter Foley <>
2012-12-20Some cppcheck cleaningJulien Nabet1-4/+4
Change-Id: Idb363bc9d1d9f650d85e002ae0c6dda4a298fcd2
2012-12-15Some cppcheck cleaningJulien Nabet1-5/+5
Change-Id: I73b5eb0f12f0e9fcc4b691fadca17cd97e5fd079
2012-12-12Remove xml2cmp leftoversStephan Bergmann1-128/+0
Change-Id: I7c0ba8b653b8e0534ae17bd879b93b75c6554893
2012-12-10fdo#46808, use service constructor for embed::StorageFactoryNoel Grandin4-23/+17
Change-Id: I26cd1cf86118122f392f16801a646df753a7df26
2012-12-05Bye bye ODMATor Lillqvist22-4476/+0
SUSE has no interest in it any longer, and I doubt anybody else has either.
2012-11-30One more blind Windows-only ucp/odma fix attemptStephan Bergmann1-2/+2
Change-Id: I7b0e2eaba06b77fa7f71c66f25839c8de6c61c71
2012-11-30fix build on windows in ucb/source/ucp/odma/*Noel Grandin4-14/+11
because I messed up the UNO changes in commit 58e9686da63f8082c5d3078745a8ed89f0d79b4d. Change-Id: I0d2a9dc1c33009c963bc13301dafbbc69e15a1da
2012-11-30fdo#46808, remove some more XMultiServiceFactory fieldsNoel Grandin50-252/+242
Change-Id: I8d039a933c9fde1a24b35954bb5a1f151e9aa160
2012-11-30fdo#46808, use service constructor for ucb::CachedDynamicResultSetStubFactoryNoel Grandin46-137/+134
Change-Id: Iea7b21621c5d341468976507684a9c01f0822034
2012-11-30fdo#46808, convert ucbhelper::ResultSet to XComponentContextNoel Grandin14-33/+36
Along the way, remove the XMultiServiceFactory member from a few classes that were not using it. Change-Id: I9ee2c2ebc01144301ed8e489bd92b4695ff263d0
2012-11-28We only support MSVC 2008 (_MSC_VER 1500) or laterTor Lillqvist1-5/+0
We can drop or simplify many conditionals. Change-Id: I37e820e515cc09845c30b62c89ddb3b6ff370f97
2012-11-28fdo#46808, Adapt reflection::ProxyFactory UNO service to new styleNoel Grandin3-38/+21
The service is deprecated, but we still have a handful of in-tree users, and converting it lets me thread XComponentContext through a bunch of classes. Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-28fdo#46808, use service constructor for ucb::SortedDynamicResultSetFactoryNoel Grandin1-4/+3
Change-Id: I8eefa129a481e47659d488cbe57f9624d3cdb19e
2012-11-26API CHANGE: Stahl2-8/+8
... derives from instead of Only test that breaks with this change is jurt_uno/AnyConverter_Test, which for mysterious reasons effectively tests that IllegalArgumentException is a subclass of Exception and not RuntimeException. Presumably this is just a generic exception test that happens to use IllegalArgumentException. Some further testing indicates there are no problems expected at runtime: Running "make subsequentcheck" with all Java test code compiled against a ridl.jar that does not contain the change, running against a soffice that uses ridl.jar and rdbs with the change + ridl.jar with the change on the test side yields exactly the same AnyConverter_Test failure, with no other failures. Change-Id: Iad183de76ec7e0d56648084e97cdcc160b5b033d
2012-11-06cppCheck: Possible inefficient checking for emptinessjailletc362-2/+2
Change-Id: Ief04fa81abbba9e66353c57eb586f864c37deed0 Signed-off-by: jailletc36 <> Reviewed-on: Tested-by: Caolán McNamara <> Reviewed-by: Caolán McNamara <>
2012-11-06re-base on ALv2 code. Includes (at least) relevant parts of:Michael Meeks31-148/+0
linecap: Reintegrating finished LineCap feature Patch contributed by Regina Henschel Patches contributed by Sven Jacobi impress212: #i81610# fixed animation export impress212: drawinglayer gbuild environment changes impress212: DffPropSet -> minor code improvements, removing table impress212: #158494# fixed excel import (text rotation) Patches contributed by Armin Le Grand Svg: Reintegrated Svg replacement from /branches/alg/svgreplavement #118728# changed indentifying definitions for Svg file detection #118838# LineGeometry creation for complicated cases optimized to create single Polygons #119176# corrected file type detection for SVG for svg files without xml header #118728# Extended Svg file detection #118529# solve break converters and convert commands for OLEs and images svg: added WaE changes from branch svgreplacement to trunc svg: corrected missing member initialization fix for #118525#: Using primitives for chart sub-geometry visualisation #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles to bitmapEx ... fix for #118525#: removed no longer used variable maOriginalMapMode, one more exception eliminated #16758# Added buffering to the VDev usages of the VclProcessor2D derivates... #116758# Secured VDev buffer device to Vcl deinit #116758# added remembering allocated VDevs for VDevBuffer to be able to also delete these when vcl goes down; it should never happen, but You never know #118730# Changed SvgClipPathNode to use MaskPrimitive2D for primitive representation instead of TransparencePrimitive2D #118822# secured 3D geometry creation (slices) by subdividing the 2D source polyPolygon early #118829# enhanced Svg gradient quality, obstacles avoided #118834# Unified usage of TextBreakupHelper as single tooling class for i18n text primitive breakup #118853# added square pixel size limit to conversion of TransparencePrimitive2D to Metafile action #118824# coreccted mirroring and boundrect when the graphicmanager is used for bitmap output #115092# Corrected VclProcessor2D::RenderPolygonStrokePrimitive2D for various optimization scenarios #118783# Corrected errors in ID strings, corrected Svg line/fill export, corrected polygon close state #118796# corrected null-pointer usage in SVG text exporter #118729# Use GraphicStreamUrl and GraphicUrl to allow multi image import with linked graphics, too #118898# corrected error in GDIMetaFile::GetBoundRect in handling MetaFloatTransparentAction #118855# Corrected handling of possibly created empty clipRegions after PolyPolygon clipping #115962# Better (but not yet optimal, see comments in task) handling of MetaFloatTransparentAction in PDF export IP clearance: #118466# This patch removes librsvg, libcroco, libgsf, ... 118779# Added svg content streaming in/out to ImpGraphic stream operators linecap: correctons for WaE and mac drawing svg: uses current system Dpi for Svg replacement image creation Patches contributed by Mathias Bauer (and others) gnumake4 work variously Remove duplicate header includes. cws mba34issues01: #i117720#: convert assertion into warning 118485 - Styles for OLEs are not saved. Submitted by Armin Le Grand. cws mba34issues01: #i117714#: remove assertion Patch contributed by Jurgen Schmidt add some additional checks to ensure proper reading operations mostly prefer our stream / bounds checking work. Patches contributed by Herbert Duerr #i118816# add clarifying comment regarding Font::*Color*() methods extend macro->string handling for empty strings avoid magic constants for SALCOLOR_NONE initialize slant properly in ImplFontMetricData constructor (author=iorsh) #i118675# make check for extension updates more stable #a118617# remove VBasicEventListener.dll binary There are no known users depending on its CLSID Patches contributed by Ariel Constenla-Haile Fix build breaker on Linux/gcc Fix crash when trying to instantiate css.graphic.GraphicRasterizer_RSVG Patches contributed by Oliver-Rainer Wittmann sw34bf06: #i117962# - method <SwFlyFrm::IsPaint(..)> - consider instances of <SwFlyDrawObj> sw34bf06: #i117783# - Writer's implementation of XPagePrintable - apply print settings to new printing routines gnumake4 work variously from Hans-Joachim Lankenau plus some amount of re-splitting of legacy headers. Patch contributed by Pavel Janik WaE: Remove unused variables. Patches contributed by Takashi Ono mingwport35: i#117795: MinGW port fix for vcl2gnumake mingwport35: i#117795: MinGW port fix for vcl2gnumake Patch contributed by Christian Lippka impress212: #i98044# re enable Text menu for outline and title shapes Patch contributed by Andre Fischer 118674: Made category B code optional and disabled by default. 118881: Ignore empty paragraphs after bullets. Patches contributed by Philipp Lohmann ooo340fixes: #i117780# use rtl allocator ooo34gsl02: #i117807# fix an off by one error (index actually inside the pfb section header) various cleanups, related compilation fixes, warning cleanups, re-working of obsolete stl template pieces to use boost instead, changed string classes, re-adapt KDE about data, about dialog, fixing warnings, and other fixes & improvements. Disable svg import / render for about/ branding code-paths for now. Restore full icon theme set. Remove OS/2 conditionals and sources. Remove conflicting gtk/full-screen monitors support. Retain existing svg rasterizer files - temporarily disabled. Standardize stringificaiton and fixup dllpostfix issues. Rename SvgGradientHelper::== to equalTo to avoid overloading issues. Use the flat GdiPlus API for LineCaps calls.
2012-11-06fdo#46808: Further fix of Windows-only odma_providerStephan Bergmann1-1/+1
Change-Id: I6559dd00ea6f238a4f31e384fd31b4fb05ebd5c1
2012-11-06fdo#46808 adapt GIO providerDavid Tardon3-8/+9
Change-Id: I63d2c4a3e4b83ef94c309223c78fb2f93ccf251e
2012-11-05fdo#46808: Adapt odma_provider to recent commitStephan Bergmann2-4/+4
Change-Id: I217f2732f7a2ddb4f0fee19b304b162a79a17351