summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)AuthorFilesLines
2015-11-24loplugin:unusedfields in ucb/Noel Grandin20-91/+23
Change-Id: Ic9ca044aa2465a197397bec6632e1a5aa5fe7110
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin1-11/+2
and use them Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec Reviewed-on: https://gerrit.libreoffice.org/20055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17use unique_ptr for pImpl in ucb/Noel Grandin10-16/+13
Change-Id: I9a626a11d665b081a7b05db52955598dbd90721e
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin2-9/+3
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin11-28/+14
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-2/+1
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin2-4/+2
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-11new loplugin: memoryvarNoel Grandin1-18/+2
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann75-372/+372
Change-Id: I72bf3e008a8941d6e0fdea81b6b3e4a959ff28c5
2015-11-09com::sun::star->css in tools/ and ucb/Noel Grandin143-3784/+3104
Change-Id: I695ff721efd63b8ca0dd3c61ba5a4fef2c43cde6 Reviewed-on: https://gerrit.libreoffice.org/19854 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06coverity#1338238 Uncaught exceptionCaolán McNamara2-5/+2
Change-Id: If822954d8355df879da8315e1c006571d3a26139
2015-11-06coverity#1338237 Uncaught exceptionCaolán McNamara2-3/+5
Change-Id: I7a7604f250a571708225fa347e80585baaa2f03d
2015-11-06coverity#1338236 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ia2fc54862dfc0f6367f52fd471d6066d915264b6
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann15-94/+93
Change-Id: Ifb9832022c92cc9996000d0515e81c53c36bfae8
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin34-110/+66
Change-Id: Id036f867e75d03d8347cc32a1011c5cdda1dcc73
2015-11-04yyyyyNoel Grandin6-67/+37
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin2-9/+6
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01Remove last stdio.h from ucb moduleJulien Nabet1-2/+0
Change-Id: Ic44c39bb4f880fe3b14470fdd3d5761aa5f2a084
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin4-6/+6
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26tdf#75637: Resolve help images via a vnd.libreoffice.image UCPStephan Bergmann4-0/+223
...which uses the logic already available in VCL's ImplImageTree to locate the image zip files and find fallbacks for incomplete themes and for localized images. Change-Id: Ic1c15fcacb6596a27a2b051093232902202bf472
2015-10-23ucb: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl1-26/+27
Change-Id: I05c64aaed4aaea813b369dccc721f9d10167f161
2015-10-15cppcheck:variableScopeNoel Grandin1-2/+1
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13tdf#91054 cleanup weirdo function prototypeskerem1-33/+17
Change-Id: I1002a25e0349263f286d3e3752579660a1ee5728 Reviewed-on: https://gerrit.libreoffice.org/19328 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-13remove some useless commentsNoel Grandin1-1/+0
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann105-1273/+1273
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann3-7/+7
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12loplugin:mergeclassesNoel Grandin4-72/+13
Change-Id: I6266369912413d51c9f1595b13dca97d3d74225f
2015-10-11cppcheck: Prefer prefix ++/-- operators for non-primitive typesJulien Nabet2-4/+4
Change-Id: I93b65c89cc7475460e0e7339f939cc058f36f0da
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-6/+2
Change-Id: Ic94b5fdcf88a9580e816aceb199753e88636810a
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+0
Change-Id: I5f5eb507e1c5bbdc8a0517244e867724249f3661
2015-10-05tdf#83531 Opening WebDAV URL WebDav fails if write is restrictedGiuseppe Castagno1-0/+22
Happened because LOCK method was not allowed without credentials. Change-Id: I7b204e67079791a08211410ced4b0b4f015d524a Reviewed-on: https://gerrit.libreoffice.org/17856 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-05tdf#82744: fix WebDAV lock/unlock behaviour - part 3Giuseppe Castagno5-77/+301
Changes done to the code in sfx2, ucbhelper, ucb, unotools in no particular order - add method helpers to call the ucb lock/unlock - add lock/unlock 'real' management - make DateChange property retrieval working for WebDAV as well - add check for changed content of a WebDAV file, in order to reload it correctly when 'Edit Mode' command is activated from GUI - Unlock WebDAV file while saving only if explicitly enabled Needed in order to avoid the small window of file unlocked state that opens while saving a file. When saving LO actually does as follows: - unlock the prevoius version of the file - prepares operations to save the modified version - lock the new file - save the new version - the lock method is enabled if the DAV resource supports it. In case the lock is not supported, for example example DAV with lock disabled, the lock method is disabled. Exception: when the resource is first created and the lock is not supported: a lock command is sent anyway, because if the resource is not yet present, there is no method to detect the lock/unlock availability in this case. - cppcheck:noExplicitConstructor Change-Id: I0aa876c4e3364d86e5740977b97f3db9a01e4491 Reviewed-on: https://gerrit.libreoffice.org/17189 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-01remove old standalone Sun bug numbersNoel Grandin6-9/+8
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini4-6/+6
Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34 Reviewed-on: https://gerrit.libreoffice.org/18990 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin1-11/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-24boost->stdCaolán McNamara4-28/+28
Change-Id: I24ecb1173af3711dfd6e8a9284f5d7a095d9c544 Reviewed-on: https://gerrit.libreoffice.org/18819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-23boost::scoped_ptr->std::unique_ptrCaolán McNamara9-42/+40
Change-Id: I03020e3536ee692a96224a517794c0d0a294f607 Reviewed-on: https://gerrit.libreoffice.org/18793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17"unnamed namespaces don't work well yet" is no longer trueStephan Bergmann1-6/+3
Change-Id: I7a04c2d04e3fc52982d83119755e0b349d232a47
2015-09-16Related rhbz#1259746: Buffer file content read from GIO UCPStephan Bergmann3-35/+13
...for one, this avoids sending seek requests down the GIO/GVFS stack, which can silently fail with corrupt data read from certain broken servers for current versions of the GIO/GVFS stack; for another, it should considerably speed up loading documents via the GIO UCP, as LO's document type detection is notorious for issuing lots of seek and (small-chunk and/or re-) read operations on a file. (This issue has become more relevant after 51e0d789c344547956764c3b5f0ef5a304f4e0aa "rhbz#1134285: Access dav, davs URLs via GVFS," where the old route via the WebDAV UCP was apparently not affected by those broken servers, so happened to start affecting opening certain remote files in LO via Nautilus.) Change-Id: I91f91128b2d1a16f976eafeacf216a91747f4df1
2015-09-10ucb: fix another duplicate WeakImplHelper<XInteractionRequest>Michael Stahl3-34/+19
Change-Id: I0728601cd7abd8f8d718728d5983aed94355bdc0
2015-09-10ucb: fix mergedlib duplicate WeakImplHelper<XInteractionRequest>Michael Stahl3-36/+20
Change-Id: I0666bb38e43240a0cbd972a141ecc36573c2ad6a
2015-09-09ucb: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe21-58/+55
with the variadic variants. Change-Id: I0e4c7e26af86806e75bb75b7eb6c70b57e1c9514 Reviewed-on: https://gerrit.libreoffice.org/18427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-02ditch gnome-vfs2 supportCaolán McNamara11-3407/+0
Change-Id: I882c04fd3a255f55511b1884157de26e7574e6db Reviewed-on: https://gerrit.libreoffice.org/18262 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann10-52/+52
Change-Id: I18420ed24918d77be30a1b4b3a7d55f5299fb82e
2015-08-27Add vnd.sun.star.webdavs URL schemeStephan Bergmann6-3/+40
...as https-equivalent to complement vnd.sun.star.webdav scheme. See the mail thread starting at <http://lists.freedesktop.org/archives/libreoffice/2015-August/069929.html> "What autogen.sh for an alternative ContentProvider for dav:// scheme?" for why it is considered beneficial to have the WebDAV UCP support---in addition to the standard pair of http[s] schemes---a non-standard pair of vnd.sun.star.webdav[s] schemes different from the "accidentally supported" non-standard pair of dav[s]. Change-Id: I7032aa1ed599f735969cf0163cd9dc121a1fdcb3
2015-08-27Apply webdav-neon/ fix to webdav/, tooStephan Bergmann1-3/+7
cf. 9228f41209b1a043e4ec29af8c2f71bb5ad7f798 "Missing davs URL scheme handling" Change-Id: Ia161691cc213b5b2c1a3a589ce05b6ad8558013c
2015-08-27Missing davs URL scheme handlingStephan Bergmann1-3/+7
...looks like it was just forgotten in e557f06cb172dfa5ca04d215226b30e8ca4af4aa "INTEGRATION: CWS tkr10: i84676 neon and gnome-vfs2"? Change-Id: I1bae95273f43e58425181bbc4667f87a6389e3a9
2015-08-27Clean up initialization of UcbPropertiesManager::m_pPropsStephan Bergmann2-311/+150
(which is a single-instance service, so there is likely no benefit in initializing it lazily anyway) Change-Id: Ie7e8272f11372149391a1190d5e71137dddaa03b Reviewed-on: https://gerrit.libreoffice.org/18016 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-08-21remove last WeakImplHelper8 usesCaolán McNamara2-7/+5
Change-Id: I7ecadedb77832fb3073870880dbfba121fdae826
2015-08-21loplugin: defaultparamsNoel Grandin5-8/+7
Change-Id: If1d183f32079548645b4974a16161dc997c026b7