summaryrefslogtreecommitdiff
path: root/ucb/source
AgeCommit message (Collapse)AuthorFilesLines
3 daystdf#149921 ucb: webdav-curl: WNT: certificate revocation checkMichael Stahl1-1/+10
- don't require it to be successful. Trying to connect to a server with self-signed CA results in: warn:ucb.ucp.webdav.curl:6796:6568:ucb/source/ucp/webdav-curl/CurlSession.cxx:946: curl_easy_perform failed: (35) schannel: next InitializeSecurityContext failed: Unknown error (0x80092012) - The revocation function was unable to check revocation for the certificate. Apparently schannel wants to check by default (called with SCH_CRED_REVOCATION_CHECK_CHAIN) that all the certificates aren't revoked, but the self-signed CA doesn't specify how to check. Set it to only check revocation when the way to do so actually works, via CURLSSLOPT_REVOKE_BEST_EFFORT, which sets these flags: SCH_CRED_IGNORE_NO_REVOCATION_CHECK | SCH_CRED_IGNORE_REVOCATION_OFFLINE | SCH_CRED_REVOCATION_CHECK_CHAIN Change-Id: I6d77ca23fe2012d8a5d65000b14775070b5c9a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138204 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
14 dayscid#1507745 return localNoel Grandin1-2/+2
regression from commit b4b4c129e9f00189978cd7b71fd74d0dca4c9ebc Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Aug 1 09:09:05 2022 +0200 clang-tidy modernize-pass-by-value in ucb Change-Id: Ie5d7d78ebde6fdee1234a0da496ff9692ee3c2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137796 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-01clang-tidy modernize-pass-by-value in ucbNoel Grandin83-216/+269
Change-Id: I641d05e360c3208845a2fa6721ac8ba1ad0f3309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137667 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-20elide some makeStringAndClear() callsNoel Grandin4-4/+4
Change-Id: Id1657c6b9399780c81e8fbf0ff0a71371a66600f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-19tdf#128196: filenames containing # get truncated when saving to GVFSJulien Nabet1-2/+8
+ replace getLength() by a call to isEmpty() since we're here Change-Id: I77a318ea3e8ceeeddd6c64cee25aa6700cb3457b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136084 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-10new loplugin:moveitNoel Grandin1-1/+1
look for local variables that can be std::move'd to parameters off by default, since it doesn't do proper data flow analysis Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23std::unordered_set->o3tl::sorted_vector in TaskManagerNoel Grandin2-15/+9
avoids repeated allocation Change-Id: Ie3f380ab2f38314b9c8a51fdcd1985329254f5dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-20osl::Mutex->std::mutex in DataSupplierNoel Grandin2-15/+35
Change-Id: I60fccc5d419d42571e768bd4b4ec5fe14d709896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134676 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-19add ByteWriter to reduce memory copying when writing dataNoel Grandin2-4/+4
similarly to ByteReader move both of them down to comphelper, since we want to use it from comphelper, and comphelper is "below" unotools in the module dependency graph Change-Id: Ic98fa2268e125fd8e4378fb899ad5f97de721713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-19add utl::ByteReader pure classNoel Grandin2-1/+37
which lets us skip the inefficiency of needing an extra buffer when reading via XInputStream Change-Id: Ic5334b7d11ea6a57bc1800f508fc69611a053af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-17osl::Mutex->std::mutex in HierarchyDataSourceNoel Grandin2-19/+12
HierarchyDataSource::createInstanceWithArguments does not need locking since it does not access local state. Change-Id: Ia29f9a5ca20095d51e4eb168cdc0a080d178f9bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134087 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-17osl::Mutex->std::mutex in HierarchyResultSetDataSupplierNoel Grandin2-16/+32
Change-Id: I61bcbc85fbbae469c5463a69dc835b7d1ac0575c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14pass-by-value in TaskManager::MyProperty::setValueNoel Grandin2-3/+3
cheaper to move a temporary from some call-sites rather than copy-construct Change-Id: Ic1f994d0253c8368548295a08e83dfbbfae0a008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134307 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-12speed up simple use of NamedValueCollectionNoel Grandin1-3/+1
where instantiating and allocating a whole map just to extract a single key is way inefficient Change-Id: I55248bc71a9e8826cab9b76fa6916bfa888efa0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-10osl::Mutex->std::mutex in ucb::BaseContentNoel Grandin3-113/+63
Change-Id: I03c25405b7e4206d6c81bc9c98b6cb07e376cd01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-10osl::Mutex->std::mutex in ucb::XResultSet_implNoel Grandin2-69/+43
Change-Id: I67f70774c94d953880ebcf9fe9bf24a0492456f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-10osl::Mutex->std::mutex in HierarchyEntryNoel Grandin2-14/+7
Several methods actually do not need locking because they are calling other methods which are already locked, and thereafter they touch only function-local state. Change-Id: Ic0c55df65988fcc64899a31586f6a426825cba81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05loplugin:unusedvariableplusNoel Grandin1-7/+0
Change-Id: Id93086be1224b6f6bf0bdaa1d50b4f289099027e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133876 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05Just use Any ctor instead of makeAny (Linux, sequel)Stephan Bergmann1-7/+7
Change-Id: Idcf537a838bb0e47cfa31db8bc09e477b277ee37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05ucb: webdav-curl: if LOCK fails, display error messageMichael Stahl1-32/+48
Sharepoint may reject LOCK with HTTP/1.1 403 FORBIDDEN and then a dialog pops up via UUIInteractionHelper that says "Server error message: ." Let's actually put some error message in the dialog, why not the HTTP status line, plus a little prefix to see which method failed. Change-Id: Ied895787f813c5cddcb18eb4f693d5bfc8c62076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133835 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-04ucb: webdav-curl: fix handling of non-standard propertiesMichael Stahl2-6/+16
Sharepoint uses properties like these: "http://schemas.microsoft.com/repl/resourcetag" "urn:schemas-microsoft-com:Win32CreationTime" They aren't standard and don't match our own ucbprops namespace, and it looks like they should be handled by an encoding to a name like "<prop:Win32CreationTime xmlns:prop=\"urn:schemas-microsoft-com:\">" Unfortunately WebDAVResponseParser::endElement() didn't do that when handling a PROPFIND reply to get the property names. This causes a crash when all properties are copied in UniversalContentBroker::globalTransfer(), which is called by SfxMedium::DoBackup_Impl() when the setting "/org.openoffice.Office.Common/Save/Document/CreateBackup" is in effect. Change-Id: I2d6480bfd2f828b6e7fc431ba4b333d95ec12718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133769 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-03Just use Any ctor instead of makeAny in ucbStephan Bergmann18-228/+225
Change-Id: I5e6964b5fa02d27d37ee772c761c72ed5b50492c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-03tdf#148426 ucb: webdav-curl: fall-back to GET if OPTIONS status 500Michael Stahl1-1/+3
With the ndr.de server, OPTIONS on an image URL results in a status 500 Internal Server Error and an unexpected closed connection: 16.591:info:ucb.ucp.webdav.curl:1634132:1634170:ucb/source/ucp/webdav-curl/CurlSession.cxx:285: debug log: 0x7f9c94004988: transfer closed with 222 bytes remaining to read Apparently Neon always reported the closed connection problem with a string: "Could not read response body: connection was closed by server" The HTTP status code is extracted in makeStatusCode() and the string doesn't contain it, so the status is reported as 0 up the stack. With curl, it can apparently happen that either CURLE_PARTIAL_FILE is returned, in which case the status is ignored and reported as 0, or CURLE_OK is returned and the status 500 is reported up the stack. Adapt the handling in Content::open() to fall back to GET in case of a 500 status. Change-Id: I5f3dce7f67ce25c87bf3882c89e7ff2d386bcbad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133707 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-01use more string_view in variousNoel Grandin4-13/+14
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-29use more string_view in INetURLObjectNoel Grandin3-4/+4
Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-26Improve some signed vs. unsigned comparisonsStephan Bergmann1-2/+3
p2-fwd will always be non-negative Change-Id: I143d7fd3c5ec192ffaeb56bc2e9f45ac5e83cb6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133439 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-20tdf#146460 tdf#148429 ucb: webdav-curl: censor "curl" in UserAgentMichael Stahl1-3/+4
This is now the second bug filed because a server replies with 403 if the UserAgent contains the string "curl". Change-Id: I25ca2d255af76a7ff4e64dad900b1bf0b78de59f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133212 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-20loplugin:passstuffbyrefNoel Grandin1-1/+1
Change-Id: I336fd329b577b6fa141265d8bc7ce67784bd7306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-20ucb: webdav-curl: restore CppunitTest_ucb_webdav_coreMichael Stahl1-0/+2
First commit 2177f48b16b8cd68c0ef4ec817ca391f28324418 forgot to adapt one use of WITH_WEBDAV so the test didn't run and then commit 2cbf83e20889351e2d2a6e29e5c7d9250af58647 removed some functions that were only called by the test. Change-Id: I46c8b065d37aa072a8966cce30d9e63d63b1145c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133206 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-20ucb: webdav-curl: check UseUserData before sending user nameMichael Stahl1-1/+5
Hope this should be acceptable. Change-Id: I567e0cb358c8693db8f1c674b4fa6f841506f331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133188 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-19ucb: webdav-curl: put user name from config into LOCK requestMichael Stahl1-2/+2
... so that the dialog in SfxMedium::LockOrigFileOnDemand() can show something more useful than hard-coded URL, which has been used since commit 99bdd887a6141883878978bad9beb35e7b326cd1 in 2009 when locking was added. This is half of the user info that is put into LO's own lock files (see svt::LockFileCommon::GenerateOwnEntry()). Change-Id: Iefac724644a536fc37c3c79ce862e25bd9be38af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133186 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-19ucb: webdav-curl: fix getting DAV:lockdiscovery propertyMichael Stahl1-2/+20
commit b4576f3da4d90139fc5140962d13cb91dab98797 "tdf#82744: fix WebDAV lock/unlock behaviour - part 3" added a call to get the DAV:lockdiscovery property. But WebDAVResponseParser puts lock related properties into a separate return value maResult_Lock that is only returned for LOCK requests. Just add it as a normal property too, then PROPFIND can get it, and the dialog in SfxMedium::LockOrigFileOnDemand() no longer displays "Unknown user". Change-Id: Icee920588ea40b6e203b18287d75484528cfdebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133185 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-14use more string_view in ucbNoel Grandin3-10/+10
Change-Id: I0aa83a1496436d6fb77ad85d24ba088a7ff75f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-13ucb: webdav-curl: oops, increment after checkingMichael Stahl1-1/+1
Change-Id: I8c51fa88253dbda595eb859d58408ad70ad661e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132982 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-04-13ucb: webdav-curl: only allow system credentials for auth onceMichael Stahl1-2/+18
... and in any case abort authentication after 10 failed attempts. Apparently some PasswordContainer can turn this into an infinite loop. Change-Id: Ib2333b371a770999e8407ce7e1af21512aadb70d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132974 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-04-13loplugin:stringviewparam whitelist some more functionsNoel Grandin2-11/+12
for which we have o3tl:: equivalents Change-Id: I4670fd8b703ac47214be213f41e88d1c6ede7032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132913 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-12Recheck modules [uU]* with IWYUGabor Kelemen54-75/+17
See tdf#42949 for motivation Change-Id: If710445176681de8e0a0b6c65f58ecaca19dbccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132768 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-11loplugin:stringview add check for getToken().toInt32Noel Grandin1-1/+2
where we can convert that to o3tl::toInt32(o3tl::getToken( and avoid the heap allocation of a temporary string Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-10use more string_viewNoel Grandin1-2/+2
found by tweaking the loplugin:stringview and making it whitelist getLength Change-Id: Ic15d3703d1fb07658e99e1db1c89e2fa5bc70c19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132771 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-02loplugin:stringviewparam convert methods using indexOfNoel Grandin2-3/+3
.. and lastIndexOf, which convert to find and rfind Change-Id: I6c4156cf904774c0d867f85a4c2785dba7593f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132445 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-11loplugin:constparamsNoel Grandin2-2/+2
Change-Id: I5f184f93dbdb414514855c85c9dc1624e7ec8636 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-07do not pass XComponentContext to officecfg::...::get() callsLuboš Luňák2-7/+7
It's used only for the ConfigurationWrapper singleton, so it's used only the first time and then ignored. It also causes calls to comphelper::getProcessComponentContext() for every single invocation despite the value not being needed, and the calls may not be cheap (it's ~5% CPU during ODS save because relatively frequent calls to officecfg::Office::Common::Save::ODF::DefaultVersion::get()). Change-Id: I02c17a1a9cb498aeef220ddd5a0bde5523cb0ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131056 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-17loplugin:unusedmethodsNoel Grandin1-2/+0
Change-Id: I58c60262ca543bafb4db4433dbb98b195f7571ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-08ucb: webdav-curl: fix deadlock in SerfLockStore::refreshLocks()Michael Stahl2-7/+7
... and removeLock() (regression from commit 03c7cd9bbe3d46bb13a5cf1ad72ba0eaf702747e) Change-Id: I4029a7079c7331a7a00c11e2bec5639086bcc928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129666 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-02-08ucb: webdav: fix "__lll_lock_wait () "Henry Castro1-4/+5
0 0x00007ffff74bc29c in __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:103 1 0x00007ffff74b5714 in __GI___pthread_mutex_lock (mutex=0x7fffbfad04c0 <(anonymous namespace)::g_Init>) at ../nptl/pthread_mutex_lock.c:80 2 0x00007fffbf996ed2 in __gthread_mutex_lock(__gthread_mutex_t*) (__mutex=0x7fffbfad04c0 <(anonymous namespace)::g_Init>) at /usr/include/x86_64-linux-gnu/c++/8/bits/gthr-default.h:748 3 0x00007fffbf9b0b56 in std::mutex::lock() (this=0x7fffbfad04c0 <(anonymous namespace)::g_Init>) at /usr/include/c++/8/bits/std_mutex.h:103 4 0x00007fffbf9b69dd in std::unique_lock<std::mutex>::lock() (this=0x7fffffff97e0) at /usr/include/c++/8/bits/std_mutex.h:267 5 0x00007fffbf9e0878 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7fffffff97e0, __m=...) at /usr/include/c++/8/bits/std_mutex.h:197 6 0x00007fffbf9f01e7 in http_dav_ucp::SerfLockStore::startTicker() (this=0x7fffbfad04c0 <(anonymous namespace)::g_Init>) at /home/hcastro/projects/online/lib/core/sid/ucb/source/ucp/webdav-curl/SerfLockStore.cxx:107 7 0x00007fffbf9f0728 in http_dav_ucp::SerfLockStore::addLock(rtl::OUString const&, com::sun::star::ucb::Lock const&, rtl::OUString const&, rtl::Reference<http_dav_ucp::CurlSession> const&, int) Change-Id: I01d3c1f67281ceab38e0452ba9cc714d4aacdbcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129447 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-31ucb: webdav-curl: suppress libcurl proxy detectionMichael Stahl1-8/+9
The UCP already reads proxy configuration from configmgr, including a list of hosts that should ignore proxy: Inet::Settings::ooInetNoProxy Hence also set an empty string with CURLOPT_PROXY, disabling the detect_proxy() function. (The neon library was never built with the libproxy dependency it needs to detect proxies.) Change-Id: I279d1b85dbdd2455791d393e634a1fa7c1c17ce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129220 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-20ucb: webdav-curl: fix the debug logging moreMichael Stahl1-41/+50
Unfortunately didn't work in the cases where it needed to work. Change-Id: Ia132ba38fb6f0be4481dce48da2d713d47fa8bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128658 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-18ucb: webdav-curl: add even more loggingMichael Stahl1-1/+38
Some servers like to put error messages in the body if there's a problem, let's try to to dump that via SAL_INFO, unless it's too big. Change-Id: I9a29de59ab299f4bfda08ecc3be838972cf0c71d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128513 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-15Let loplugin:nullptr look into template instantiationsStephan Bergmann1-4/+4
It missed some occurrences of 0 when only looking into uninstantiated template code, as Clang doesn't model them with an ImplicitCastExpr, even if the target is known to be a (dependent) pointer type. Looking into all template instantiations of course carries the risk that a given use of 0 is meant to be interpreted as a pointer in some and as an integer in other instantiations. But the only case where that happened in the current code base is RegistryValueList::getElement (include/registry/registry.hxx), where {} is arguably a better choice anyway. (And which would presumably also hold for any future such cases.) Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-14ucb: webdav-curl: build debug callback also in release buildsMichael Stahl1-5/+10
And fix the Authorization header redaction, it was assuming there is one call per header line, but all headers are passed in one call. Change-Id: Idf86b9e0a4a8f8e9fb39098402a002abc394a589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128395 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>