summaryrefslogtreecommitdiff
path: root/ucb/source
AgeCommit message (Collapse)AuthorFilesLines
2017-01-20new loplugin: useuniqueptr: ucb..ucbhelperNoel Grandin24-83/+55
Change-Id: Ib19ca3225b96d1bfec8a43bb762e16597f33b690 Reviewed-on: https://gerrit.libreoffice.org/33297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ucbStephan Bergmann53-77/+524
Change-Id: I39a50e3f066776ac670a99120e12624af39fa83a
2017-01-18use rtl::Reference in DynamicResultSetWrapperNoel Grandin2-10/+8
instead of storing both a raw pointer and an uno::Reference Change-Id: Ia155ebcb856884461871d5992380c364da07a1d3
2017-01-18use rtl::Reference in ContentResultSetWrapperNoel Grandin2-14/+12
instead of storing both a raw pointer and an uno::Reference Change-Id: Iba7317e37046c62411bae9d943f9e81f23ff3554
2017-01-18use rtl::Reference in CachedContentResultSetNoel Grandin2-15/+10
instead of storing both a raw pointer and an uno::Reference Change-Id: I868530ba1697baae88a4322eda6c467c9f8e8eb6
2017-01-17use rtl::Reference OFileAccessNoel Grandin1-31/+29
instead of storing both a raw pointer and an uno::Reference Change-Id: I36f1788510e7233ae3de4610370528e24ca03e1d Reviewed-on: https://gerrit.libreoffice.org/33170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17use rtl::Reference in SortedDynamicResultSetNoel Grandin2-38/+22
instead of storing both raw pointers and uno::Reference Change-Id: Ifcc9daf95d4b2583c9bc4b06deb65a2e618ac1e0 Reviewed-on: https://gerrit.libreoffice.org/33168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-09ucb: cmis::DataSupplier::queryContent() looks rather questionableMichael Stahl1-4/+6
It's not immediately obvious if the caller is responsible for checking the index validity here, but all the other sub-classes of ResultSetDataSupplier that i looked at do check the index so do the same here. Change-Id: Ib0c5c38cb28282f08752cdb03202e4d6f3566693
2017-01-09ucb: ReacquireableGuard::reacquire() is a no-opMichael Stahl3-80/+76
So remove this junk and use osl::ResettableGuard instead which actually works. Change-Id: Ieb49fab16c94f0a2847ee5a1b95b52f2c141c674
2017-01-09New loplugin:externvar: ucbStephan Bergmann3-4/+4
Change-Id: Idfab6f0d16b85ca280056db88264e5234361bce0
2016-12-30cleanup tailing backslashesJochen Nitschke1-1/+1
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-30unexpected exception seen in tinderboxCaolán McNamara2-4/+2
#1 0x00002b464842f53a in __GI_abort () at abort.c:89 save_stage = 2 act = {__sigaction_handler = {sa_handler = 0x2b4648169a60 <typeinfo name for com::sun::star::uno::RuntimeException>, sa_sigaction = 0x2b4648169a60 <typeinfo name for com::sun::star::uno::RuntimeException>}, sa_mask = {__val = {47580863731936, 47582668825824, 47580850742064, 47580863731456, 2, 47580871027780, 0, 47582668825824, 47580863731456, 47580873315224, 47580863731936, 47582791173728, 47582791173728, 1, 33350960, 47582668313696}}, sa_flags = -1151509448, sa_restorer = 0x1fce530} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x00002b4648e3efdd in __gnu_cxx::__verbose_terminate_handler() () at ../../../../libstdc++-v3/libsupc++/vterminate.cc:95 terminating = true t = <optimized out> #3 0x00002b4648e3ce56 in __cxxabiv1::__terminate(void (*)()) (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:47 #4 0x00002b4648e3cea1 in std::terminate() () at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:57 #5 0x00002b4648e3ceb6 in __cxxabiv1::__unexpected(void (*)()) (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:63 #6 0x00002b4648e3cae2 in __cxxabiv1::__cxa_call_unexpected(void*) (exc_obj_in=0x2b46b40ad4b0) at ../../../../libstdc++-v3/libsupc++/eh_personality.cc:759 info = {Start = 47582791163104, LPStart = 47582996646024, ttype_base = 0, TType = 0x2b46bb5d5e30 "", action_table = 0xffffffff <error: Cannot access memory at address 0xffffffff>, ttype_encoding = 1 ´\001´, call_site_encoding = 0 ´\000´} xh_lsda = 0x2b46c7aab0d4 "\377\233\261\201\200\200" xh_switch_value = -1 exc_obj = 0x2b46b40ad4b0 xh_terminate_handler = 0x2b4648e3ee70 <__gnu_cxx::__verbose_terminate_handler()> #7 0x00002b46c79c6af9 in webdav_ucp::DAVResourceAccess::GET(std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&, webdav_ucp::DAVResource&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x2b46b410ceb0, rHeaderNames=std::__debug::vector of length 0, capacity 0, rResource=..., xEnv=uno::Reference to ((anonymous namespace)::UpdateInformationProvider *) 0x2b46bb153918) at /home/tinderbox/master/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx:497 errorCount = 0 bRetry = false xStream = empty uno::Reference Change-Id: Iaa3ec435af6bed267235a9025fc9334058f20475
2016-12-22Revert "[API CHANGE] createSecurityContext() was always called with an empty ↵Tor Lillqvist3-3/+3
string" I got cold feet. I don't want to have to revert this many years later instead, when some obscure 3rd-party software stops working. This reverts commit e1ce7bad62f07faf8f21adac6c3848d142f61953.
2016-12-21[API CHANGE] createSecurityContext() was always called with an empty stringTor Lillqvist3-3/+3
So drop the parameter then and propagate fallout in the Windows implementation in xmlsecurity. The NSS implementation already ignored the parameter completely. This interface is not 'published' and the parameter was even marked as 'reserved for internal use' so I doubt any external code has used it. Change-Id: I5915b941b79cfddadc8137c32ed07c20c9ccaa37
2016-12-19vcl: separate ImplImageTree - ImageTree singleton and public ifaceTomaž Vajngerl1-3/+3
ImplImageTree was used outside of VCL which is not consistent with the name and the header also contains a lot of implementation detail. This separates the implementation to ImplImageTree and the public interface and singleton to ImageTree only. Change-Id: I3a26444f0f6971a6b1d83472e9cef19c93192d3e Reviewed-on: https://gerrit.libreoffice.org/32134 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-12-14Merge shell into TaskManager base classStephan Bergmann28-3633/+3517
(arbitrarily decided to keep the latter, being the less odd class name) Change-Id: I5c061a0f12b8f3095e283b4896f7c910948ac50f
2016-12-13loplugin:staticanonymousTor Lillqvist1-7/+7
Change-Id: I8c08a303026219dbf87af7165a3f9a99134d5091
2016-12-13loplugin:salboolTor Lillqvist2-6/+6
Change-Id: Ia2a2c900bf8bf8ecee2edf130b8ca58f7f35b6aa
2016-12-13loplugin:stringconstantTor Lillqvist4-46/+29
Change-Id: Ifc100e8ece6ea826b745919583beac315c41b100
2016-12-13loplugin:nullptrTor Lillqvist7-11/+11
Change-Id: I2cd1e82d86d8776155db2f70bc92c7c448f81ce0
2016-12-13loplugin:overrideTor Lillqvist7-7/+7
Change-Id: Idb5e16bae0fe573b22c86d1c4d6d4ab8da790557
2016-12-13loplugin:refcountingTor Lillqvist9-19/+21
Change-Id: I5ca4c1599a1abc4281bac9a4d0164d4b0cb3e24a
2016-12-12-Werror,-Wimplicit-fallthroughTor Lillqvist2-0/+2
Change-Id: I7ea9c1af7568ce37f29df14f8dc4345031c20eb8
2016-12-12Revert "loplugin:refcounting"Tor Lillqvist1-1/+1
Bah, the reverted change actually of course breaks the compilation, I had missed that accidentally. More intrusive chnages are needed to change css::uno::Reference to rtl::Reference, also in parameters to constructors and other calls here. This reverts commit 073f8cdbb77d62a6838c78ff63fca73896b86c79. Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f
2016-12-12coverity#1397041 Unchecked return valueCaolán McNamara1-6/+6
Change-Id: Ia8c601475bea142faad9c1f1e9b797d0ebc13679
2016-12-11fix out of bounds accessJochen Nitschke1-1/+1
since commit 96ec36cf261eec3ec07f3caa2673a916571c4287 Date: Thu Dec 8 21:49:47 2016 +0100 ucb: replace "SimpleList" trash found by cppcheck Change-Id: I13d62bdb6cb1a714182f90078d4a2990c790301a Reviewed-on: https://gerrit.libreoffice.org/31856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-12-11cmis: add error handling on checkinThorsten Behrens1-3/+23
Change-Id: I3951a237789ee4b7697f70bc527ffbb6a626206a Reviewed-on: https://gerrit.libreoffice.org/31776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-12-09loplugin:refcountingTor Lillqvist1-1/+1
Fixes: "uno::Reference field with template parameter that does not contain ::static_type() css::uno::Reference<SerfInputStream>, parent is http_dav_ucp::SerfGetReqProcImpl, should probably be using rtl::Reference instead [loplugin:refcounting]" Change-Id: I43211bb397031a4961df77ee39038e6ef9da6bb1
2016-12-09ucb: replace "SimpleList" trashMichael Stahl2-123/+43
* pointless use of void* * stupid casting everywhere * ridiculously overloaded Remove() * defensively programmed implementation Change-Id: I1c86ffac636cafbe3e13e668a65a2b14377b6e95
2016-12-08OSL_TRACE -> SAL in sw..ucbNoel Grandin2-8/+7
Change-Id: I18f5511f70232d91095ac8527a6c5883c36294f5 Reviewed-on: https://gerrit.libreoffice.org/31762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08-Werror=return-local-addrStephan Bergmann2-6/+6
(the first case with OUString would technically be OK, but better change all three of them) regression introduced with 0e4ca9b0cfe015f7ab3b964d1b90de7c2cba42de "Clean up uses of Any::getValue() in ucb"; thanks to tml for finding it via --enable-fuzz-options Change-Id: I79e70cff8d8b96e1eb6b0bacda52be06eb0f108b
2016-12-08loplugin:overrideparamTor Lillqvist1-2/+2
Change-Id: I9b70fbc344a02a058fbb7af694edad560244c930
2016-12-08loplugin:overrideTor Lillqvist12-12/+12
Change-Id: I57b5572d81e6da53d82fbbb6dbcb35c9802ec3f1
2016-12-08loplugin:nullptrTor Lillqvist20-64/+65
Change-Id: Id8fd27ed20bc67a49d6863b63b07cf1573733744
2016-12-05fix the generally unused non-neon webdav MapDAVExceptionCaolán McNamara1-1/+1
Change-Id: I82caa1686a8855c484050f129d5095f95eab7ece
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin3-32/+32
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-11-23New o3tl::runtimeToOUString to convert from C++ runtime NTBS to OUStringStephan Bergmann1-7/+8
Change-Id: I613bb70b6828f615fd45af38b2d873ece55ace60
2016-11-23loplugin:unnecessaryoverride (dtors) in ucbStephan Bergmann4-28/+0
Change-Id: Ic19075cf0b237415c47a358c677eb19969e98fa5
2016-11-22remove some more global OUStringsNoel Grandin3-65/+38
Change-Id: Ic02754f98bfda3b7cd8c06857123d363a96e8d0e Reviewed-on: https://gerrit.libreoffice.org/31071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18loplugin:datamembershadowNoel Grandin1-2/+0
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16straighten weirdo exception message, inserting a comma and a blank helps..Eike Rathke1-4/+2
Has ever been like that since commit 54bd83fe93ff3253fbcde2f8c0b97eccbdac52e5 Date: Thu Oct 31 15:24:42 2002 +0000 Change-Id: Ifa52dc10458a91054675900a55c1eee14899d80d
2016-11-13Change remaining sal_Int32 to ContinuationFlags ...Korrawit Pruegsanusak1-1/+1
from 7f97b5e72c61066ea1ddd0f782e50070ce5f6363 Change-Id: I064e35f879ecba61d7ef71a0a177e760c3d263c4 Reviewed-on: https://gerrit.libreoffice.org/30793 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:unnecessaryvirtual in test..vbahelperNoel Grandin2-6/+6
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965 Reviewed-on: https://gerrit.libreoffice.org/30649 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe2-19/+2
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-27Cosmetic: Move function member around...Giuseppe Castagno1-28/+28
...so it's nearer to the other function member that uses the class variables it initializes. Change-Id: I199621fbcad36313e0948627d47445a1de211d02 Reviewed-on: https://gerrit.libreoffice.org/30313 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-26const-ness fixesStephan Bergmann1-13/+13
Change-Id: I83858c0cbca0fc493ac506e2b839e43310f3bb2f
2016-10-26loplugin:expandablemethods in ucb..ucbhelperNoel Grandin22-130/+144
Change-Id: I42d077d7ebcfb77447d011644f8d64e80eae69c2 Reviewed-on: https://gerrit.libreoffice.org/30266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-23Fix typosAndrea Gelmini1-1/+1
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-21tdf#102499 (9): Fix eXo Platform WebDAV on 'Save Remote File'Giuseppe Castagno3-6/+77
Change-Id: I2d2aceed3804f653b79d48eeb02468fc77374eb7 Reviewed-on: https://gerrit.libreoffice.org/29884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-21tdf#102499 (8): Return empty property when not present.Giuseppe Castagno1-0/+24
Change-Id: If5afa4f33ac5b5dfec123960c2e9660183576256 Reviewed-on: https://gerrit.libreoffice.org/30142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>