summaryrefslogtreecommitdiff
path: root/tools
AgeCommit message (Collapse)AuthorFilesLines
2014-11-03checker type doesn't work, try event typeCaolán McNamara1-1/+1
Change-Id: I8b92c583bf1d6167b713648f417ba5569b3593ba
2014-11-01tools & vcl: move OutputDevice::ImplRotatePos() to Point::RotateAbout()Chris Sherlock2-0/+80
OutputDevice has a private function that rotates a point around another point. However, there is no real reason why OutputDevice should be responsible for this - it's really the responsibility of the Point class in the tools module. Therefore, I've moved this functionality out of OutputDevice and into Point, but I've renamed it from the rather confusing name "ImplRotatePos" to "RotateAround", which is what it actually does. Change-Id: If12fb40a7b476653224d4edfc01887bc91a80c7d Reviewed-on: https://gerrit.libreoffice.org/12171 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-01coverity#1250404 Operands don't affect resultCaolán McNamara1-0/+1
trying to auto-ignore this one, so don't touch it manually in the UI so I can experiment if this syntax will correctly auto-triage in all coverity instances Change-Id: I4ae42a6828041f40c6ab8cb3cfc631c8dd38e8c8
2014-10-31Removed duplicated includesAndrea Gelmini1-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-28WaE: C4101: 'unused' : unreferenced local variableTor Lillqvist1-1/+1
Change-Id: I511c2df37c7feda8a3ffa311074bcf2fe669a73a
2014-10-28fix build on android-arm tinderboxDavid Tardon1-2/+2
Change-Id: If528f3cbaab66ceec07e35b479b4fe2ed55aa3c7
2014-10-28fdo#81356: use boost::rational internally in FractionJuan Picca2-304/+190
Change-Id: I6f40eafee7652209395bd471e3508fe3a3d19d73 Reviewed-on: https://gerrit.libreoffice.org/12085 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-28coverity#1242531 Untrusted loop boundCaolán McNamara1-0/+6
Change-Id: I94308a517028a62ecf7018f6d7a4e9d37c0f56a6
2014-10-27cid#705051 Dereference after null checkNoel Grandin1-1/+1
Change-Id: I6b7adb593efa137bb09b3b8d49539f6cd405dd20
2014-10-24Explicitly include the cmath std::abs overloadsStephan Bergmann1-0/+1
Change-Id: I501edd8f3301f70e6130d844dcd64cac8b18598f
2014-10-24Fix Fraction(-2147483648.0) for 32-bit wide longStephan Bergmann2-1/+8
Change-Id: I6465377de1edff5d0ccc0049fb6d24f6f1223fd2
2014-10-24Fract: enable testsJuan Picca2-9/+1
Change-Id: I00650503f15f2dcd45b07e3c529965336e8391e6 Reviewed-on: https://gerrit.libreoffice.org/12080 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky6-276/+616
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "just check if the fraction is < 0"Jan Holesovsky1-1/+1
This reverts commit 8afab33d161ddd39a3e6094b5daa08b156ef0421.
2014-10-23Fraction: Revert "simplify condition"Jan Holesovsky1-1/+1
This reverts commit ad1f796b1dc710a02ade17c95e99d11412f1280a.
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky2-9/+9
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23coverity#440777 Resource leak in objectCaolán McNamara1-16/+20
rework to avoid the warning Change-Id: Id104c01b04e07ffaaf503a842c978acbc8a22a19
2014-10-18work around windows whiningNorbert Thiebaud1-3/+4
Change-Id: If2922bca25c93edc25e1171001def8ce3011cf4c
2014-10-17another blind attempt to fix the testDavid Tardon1-2/+2
Change-Id: I7ac53b340cf3a9f72a90414e09ddd37148ecd28a
2014-10-17correct castDavid Tardon1-2/+2
Change-Id: Ic79ce25bf4ceb4d715aabdabf3824304b02b1f38
2014-10-17now why did i do this?David Tardon1-1/+1
Change-Id: Icf1fc5643271672761b565c30382e70c689c29b4
2014-10-17fix long long -> BigInt for LONG_MAX valueDavid Tardon1-7/+7
Change-Id: I1cf551299bae925b5a5cf0a488b6cc3497d010bf
2014-10-17fix copypastaDavid Tardon1-1/+0
Change-Id: I08383e3086eef8e7c8136293d51b7108807a7def
2014-10-17fix comparisonDavid Tardon1-4/+4
Change-Id: Ia7f65d69c186056527a2beb72a18f4a66e4c6586
2014-10-17correct function nameDavid Tardon1-1/+1
Change-Id: Ibc3ab15bc830d68bf9d3d1d9ac9595d82c7fb6aa
2014-10-17allow construction of BigInt from sal_Int64 on 32 bitDavid Tardon3-0/+142
Change-Id: Ib68920fc9bd693d2f2679b4fc27d9956dc42fc86
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon2-9/+9
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16Strip svidl down to what is still usedStephan Bergmann1-79/+0
...the generated .ilb, .lst, and .sid outputs requested by SdiTarget were apparently unused. Change-Id: I1abb2abc7945070451fce4a98a11d955515e3f63
2014-10-14fdo#75757: remove inheritance to std::mapTakeshi Abe1-18/+18
from UniqueIndexImpl. Change-Id: Iaa9040dff117ed5b05955c9f6eef31878dccf3b0 Reviewed-on: https://gerrit.libreoffice.org/11951 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-14simplify conditionDavid Tardon1-1/+1
Change-Id: Idceac888c57cc27142877d0cf83dd525ab3f92ca
2014-10-14just check if the fraction is < 0David Tardon1-1/+1
Change-Id: I23f631898f29d8285d3da333686da8d3f28a00f8
2014-10-11initialize nPolyCountCaolán McNamara1-3/+3
Change-Id: I774f0ea2576063b7d1f7005e7df41ae52fa9037c
2014-10-10coverity#1240260 Operands don't affect resultCaolán McNamara1-1/+1
see can we silence these false positives coverity#1240259 Operands don't affect result coverity#1240254 Operands don't affect result coverity#1240264 Operands don't affect result coverity#1240267 Operands don't affect result Change-Id: Ieca40474c231e33a516b70f7693346ac73babd61
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca6-616/+275
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09remove SvRefBase::QueryDeleteNoel Grandin1-10/+0
Move it's functionality into the only place that needs it, in the dbase driver. Removes an extra virtual call from a widely used class. The dbase driver seems to be using to perform some kind of whacky object recycling, so it's not like we want this functionality to be used somewhere else. Change-Id: I41018f71e0b0a79fdd3d527536f0ac95c788e614 Reviewed-on: https://gerrit.libreoffice.org/11786 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-08coverity#705326 deliberate fallthrough in switchCaolán McNamara1-0/+1
I imagine its deliberate anyway, always has been this way since 2000 Change-Id: I45fd654aeec2a5c753c38d20febd2f820044bb32
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin1-1/+1
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02coverity#708208 Uninitialized scalar fieldCaolán McNamara1-21/+24
Change-Id: I5f1e889746067bad478d8fa3acd8c41c893b135a
2014-10-01fdo#82577: Handle TimeNoel Grandin5-49/+57
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin1-17/+21
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-26WaE: implicit conversion of NULL constant to 'nullptr_t'Tor Lillqvist1-2/+2
Change-Id: I47ebbac21f48854eb737dd7e8119bd863a5d7ed9
2014-09-26tools: change INetURLObject::getData to return std::unique_ptrMichael Stahl2-10/+12
Life-cycle becomes a lot more obvious this way. Change-Id: I1ca99607f609a2223011c40447ad1cd9ca5ccaa5
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin1-1/+1
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin1-9/+9
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26remove pointless commentsNoel Grandin3-4/+0
Change-Id: I8edfe830b8f6ca7f1809332870e06d1d286b90e8
2014-09-26remove unnecessary casts'sNoel Grandin3-14/+10
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26remove unnecessary static_cast'sNoel Grandin1-5/+5
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-26SvStream - rename WriteNumber methodsNoel Grandin1-2/+2
to Write?Int32AsString. Since the original name was so generic as to be meaningless. Change-Id: Iaaaf592904af51f2b9988fa8efb344c1b2bf9b0f
2014-09-26cleanup GUID/ClsId/CLSID typesNoel Grandin1-129/+67
- rename GUID to SvGUID so we don't need an #ifdef WIN32 - drop ClsId struct, since it is used interchangeably with GUID and has the same structure Change-Id: Idf5c14c82a6861ef585fb57896a9b12cfe40374c
2014-09-25fdo#84000: Sort out problems with short timeouts & long callbacks.Jan Holesovsky1-7/+6
Previously, the timer events could have accumulated in that scenario leading to unresponsiveness to user events. Change-Id: I455d726ae7475f7dbf98d871c54d8c156cb64e52