summaryrefslogtreecommitdiff
path: root/tools
AgeCommit message (Collapse)AuthorFilesLines
2014-02-12more SvStream:operator>> conversionNoel Grandin3-8/+8
Convert the template based read_lenPrefixed methods to regular methods. Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019 Reviewed-on: https://gerrit.libreoffice.org/7895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin12-58/+58
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-11coverity#705324 Missing break in switchCaolán McNamara1-1/+1
Change-Id: I72c9a16c5236824424b33df353606e3e14aa4607
2014-02-07Simplify InternalStreamLock instance handlingStephan Bergmann1-57/+32
Change-Id: Id5bd445ad4f2397cbff01099ba3779736bb47e61
2014-02-07coverity#708893 unused pointer valueNoel Grandin1-1/+1
Change-Id: Ib029e08f7dc29330b1a0b5d93c1c0a356dbd59dd
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin6-11/+11
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04fdo#74425 Remove deprecated static function ResMgr::GetLang()Chris Sherlock1-180/+0
ResMgr::GetLang() has been deprecated for a long time now. It is used by only one function, SubstitutePathVariables::SetPredefinedPathVariables() in the framework module. I have therefore removed it from ResMgr and placed it as a function in framework/source/services/substitutepathvars.cxx where it is actually used. Change-Id: I5f0d8f701aa45f8653020affeff6339f8fc9bc0e Reviewed-on: https://gerrit.libreoffice.org/7791 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-03At least warn when DBG_TESTSOLARMUTEX has not been set upStephan Bergmann1-0/+3
Change-Id: I5ae5318685ffe45bd9616d06eea21a93585715f2
2014-01-29coverity#100870 : Uninitialized scalar fieldNorbert Thiebaud1-0/+1
Change-Id: Ica1af6017aedf94ad4daa92352691675bf6378fd
2014-01-28bool improvementsStephan Bergmann1-2/+2
Change-Id: Ia3fd76aa70564cbc683d0d66cc39aa368bea29d9
2014-01-22remove SvStream::operator<< methodsNoel Grandin1-2/+2
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-21TOOLS : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini3-99/+0
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: Id75ca6991af0bf75e979c7bc2da452f323f389ea Reviewed-on: https://gerrit.libreoffice.org/7531 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21bool improvementsStephan Bergmann1-1/+1
Change-Id: I5237197595b1b892e7720de13fc835b64470505e
2014-01-16Avoid warnings: unused parameterTor Lillqvist1-1/+5
Change-Id: I92fd33e020772eac735f133f467207da9635e9b4
2014-01-16always build an empty DbgUnhandledException, to allow debug=t builds without ↵Bjoern Michaelsen1-3/+2
--enable-dbgutils
2014-01-16Missing adaption to WriteSvPersistBaseStephan Bergmann1-1/+1
...introduced in c648d0872058941ed18499a8bf1993037d9b5532 "convert SvStream::operator<< overloads to more explicit methods." Change-Id: I8343cd3d1e92ccd3ca3fc6292ebd1114ada444e1
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin8-13/+13
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-10Use boolStephan Bergmann1-3/+3
Change-Id: I1cb9aa1a06fde24d0b7c7ec0ad56994598ee1d4b
2014-01-10Massage odd TODO code some moreStephan Bergmann1-1/+1
Change-Id: I0e4fab72a6384eab41eeb1357eaf88be876a6b52
2014-01-10Use boolStephan Bergmann1-1/+1
Change-Id: I643f7d13b95c6bb89ee00be706e384338ed8b79a
2014-01-10Use boolStephan Bergmann1-3/+3
Change-Id: I1317aebafaae3c80a2016d23f93411a610fa349d
2014-01-10Use boolStephan Bergmann1-5/+5
Change-Id: I7b48d8b9e162f9e4447bfcfcc0bbd1158bd35f5b
2014-01-10WildCard::ImpMatch should return boolStephan Bergmann1-6/+4
Change-Id: Ib851cbe072bca0d594440cc28164e112d0fe37cb
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin10-62/+62
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-10Clang plugin to re-write SvStream operator<< to non-overloaded methodsNoel Grandin1-23/+84
Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteUInt32. Note that the rewriter is not perfect, and hand-tweaking the output is necessary. Change-Id: I0291c8192ca74d6334ed3cf8cb713212b2f0c67d Reviewed-on: https://gerrit.libreoffice.org/7307 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-17Unnecessary use of OUString constructor inside OUStringBuffer constructorNoel Grandin1-1/+1
Convert code like: OUStringBuffer sVal(OUString("0x")); to: OUStringBuffer sVal("0x"); Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-12remove unnecessary castsNoel Grandin1-64/+63
It is no longer necessary to cast to sal_Unicode when calling OUStringBuffer::append Change-Id: Iab3d1e12eef472cfe11f1d0d1969ca404091dd7d
2013-11-27Unwind occurrences of deprecated sal_sChar, sal_uCharStephan Bergmann3-12/+12
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
2013-11-26Moved 'DateTimeToOString' from 'filter' package to 'tools' packageAdam Co2-0/+57
After the move now other classes can convert DateTime to OString also Reviewed on: https://gerrit.libreoffice.org/6816 Change-Id: I0ceb9a5cc26103a6cb36d7765a717770ec3fbe7d
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin2-10/+10
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-13unused header fileCaolán McNamara1-31/+0
Change-Id: I179cc3dc58484ab1e21af3b1d776188d52f3974c
2013-11-13xub_StrLen->sal_Int32Caolán McNamara1-4/+3
Change-Id: Ia52a898fa0a6b47eb7f78b03ef8c8648ddf72e28
2013-11-13implement very simple SvScriptStream to read from processMatúš Kukan1-0/+57
It inherits from SvStream, so it could be used easily. Basically, it's just a simple wrapper around osl_executeProcess_WithRedirectedIO() and osl_readFile(). Change-Id: Ifa225c87d2c9be7e71ea113b0832a4fe83ec65b3
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin1-56/+38
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin1-4/+3
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-23clean up places accessing the NULL at the of an OUStringNoel Grandin1-6/+6
There were only a couple of real bugs fixed, but we're a little bit safer now. This also fixes the assert and the comment in OUString::operator[] about this. Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist4-5/+5
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22Resolves: fdo#38838 remove UniStringCaolán McNamara4-291/+0
hammer silver nails into coffin and bury in concrete Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-22move ResId::toStringCaolán McNamara2-45/+43
Change-Id: I287a92de9ae30255990595263c3302d753fdbccf
2013-10-22Related: fdo#38838 remove UniString::UniString(const ResId&)Caolán McNamara1-19/+0
Change-Id: Id881fe3f9c7c89a7bcc1a5d8f653e18494ffa913
2013-10-21Related: fdo#38838 remove UniString::CopyCaolán McNamara1-34/+0
Change-Id: I566e3ade54962bbc6ace9b757f79c1b8ed9ffd00
2013-10-21Related: fdo#38838 remove a pile of ctorsCaolán McNamara2-27/+0
Change-Id: I5d19eadc3dc24b0aeeb61c677f440eef83af78c2
2013-10-21Related: fdo#38838 remove/privatize String::AppendCaolán McNamara1-21/+0
Change-Id: I5ae90b02e7ae5ddd19495fd0847b7e9dfc4419e8
2013-10-21Related: fdo#38838 remove String::InsertCaolán McNamara2-54/+0
Change-Id: I37e35b5a16d37b1fccc6aa47f5027ff406c67d98
2013-10-21Related: fdo#38838 remove String::ToInt32Caolán McNamara1-5/+0
Change-Id: I6f90e9a06acaa5af88cd011015938dba2059ee0e
2013-10-21Related: fdo#38838 remove String::[G|S]etCharCaolán McNamara1-9/+0
Change-Id: I64711aa3e6580eff7c64a92243e3161ef2d7cb9e
2013-10-21drop DBGCHECKSTRINGCaolán McNamara4-54/+0
Change-Id: I0c60becfd3a61cffb46c76e6f1488528c59b46e9
2013-10-21Related: fdo#38838 remove non OUString ::AppendCaolán McNamara2-23/+0
Change-Id: I084ce5c4833964018849617632a1308dc74adda3
2013-10-20Related: fdo#38838 remove String::EqualsCaolán McNamara1-26/+4
Change-Id: Ib85907c9e274ba4e4f4c9394f3d4ecf0c9374603
2013-10-20Related: fdo#38838 remove the unused String::InsertCaolán McNamara1-43/+0
Change-Id: I39f4c68b76d8816fc91e4dc39bf2305142d1fb93