summaryrefslogtreecommitdiff
path: root/toolkit
AgeCommit message (Collapse)AuthorFilesLines
2015-10-15java: 'final static' to 'static final'Noel Grandin1-2/+2
this is the canonical order, and it makes the code easier to read Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org> (cherry picked from commit 0c18bedb7328493040c1a20822b345e624d6041f) Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
2015-08-06Resolves: tdf#90609 SolarMutex assert on threaded loadCaolán McNamara1-0/+2
Change-Id: I81a784ab506d0d3ae266d7341b8ff7a163dcd8d2 (cherry picked from commit 442b788bc80e20783bdb881aa0cbbc253f1a47b0) Reviewed-on: https://gerrit.libreoffice.org/17327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-06Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann4-2/+14
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5 (cherry picked from commit 8e1ad966262932516b3368d9b5c44becb29524d4) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-08-06vclptr fix in ScrollableWrapperNoel Grandin1-1/+1
Change-Id: I28b0c9712d3eb35181ccd323e583d947db06094d (cherry picked from commit f6e5a0ac09eb1b02caf62980e4caaf3f239b9ca7)
2015-08-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin1-2/+2
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-06Resolves: tdf#46440 SIGSEGV on toolkit bootstrap without running instanceCaolán McNamara1-0/+20
Change-Id: I9a78a75b3d72586b1702ed6fa63bb0b62ce6cd72 (cherry picked from commit 3f69547397e5841d0915921be5be8b3edfdfdbc5)
2015-05-29convert WINDOW_POSSIZE constants to scoped enumNoel Grandin1-2/+2
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin4-15/+15
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin2-18/+17
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-27tdf#91416 - fix some incorrectly allocated VirtualDevices.Michael Meeks1-1/+1
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe (cherry picked from commit f849d96463d967214bc063f6de912a082272c395)
2015-05-20convert IMAGE_DRAW_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I75619eeb902af4953a5ac1525605cf3f0f15e2c0
2015-05-20convert TEXT_DRAW constants to scoped enumNoel Grandin1-11/+11
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
2015-05-15conver MENU_FLAG_ constants to scoped enumNoel Grandin1-4/+4
Change-Id: I969d99fa8881cc89601696a2d8621905a82b147b
2015-05-15convert POPUPMENU_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
2015-05-14convert KERNING_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I58031485aaa9ebdeb986a3ee0376f36a9f667947
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin1-2/+2
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann1-1/+1
Change-Id: I9873e5be7c9ea97a44baf13f8ca720aff0ff2793
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann1-1/+1
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-06cleanup DIALOG_NO_PARENT, follow on to tdf#91090Noel Grandin2-4/+5
remove the DIALOG_NO_PARENT abomination and replace it with a flags parameter Change-Id: I71b7dc46c619f2db56af6d4dc2c17daf0a2c8534 Reviewed-on: https://gerrit.libreoffice.org/15645 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-06convert BMP_SCALE constant to scoped enumNoel Grandin1-1/+1
Change-Id: Ibc9f88d2588c028cd71aa86c26d970a73025ef22
2015-05-05typo: strech -> stretchAndras Timar1-1/+1
Change-Id: I0de1cfaa0df460c7bc8e49752b31056f95c30053 Reviewed-on: https://gerrit.libreoffice.org/15628 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-04-30Gradually typed LinkStephan Bergmann2-3/+3
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of the initial :: for the vcl namespaceTor Lillqvist1-22/+22
We used it all over the place without leading :: already anyway, even in many files in include. So let's be consistent. In the majority of cases, prefer the easier-on-the-eyes choice, not the "safe" one. In those files in include where *all* existing uses of ::vcl:: indeed used the :: prefix, there let's keep it for consistency. Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann1-1/+1
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29convert INITOUTDEV constants to scoped enumNoel Grandin1-22/+22
Change-Id: Ic2443b557620bd269851d64f42107b304f6b4082
2015-04-28Merge remote-tracking branch 'origin/feature/vclptrmerge2'Michael Meeks13-449/+423
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks13-449/+423
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28css.awt.ItemEvent.Highlighted is of type longStephan Bergmann1-4/+4
Change-Id: Iff42783f04a9a037a6183784478ea66b04aa7d32
2015-04-24loplugin:simplifyboolStephan Bergmann6-8/+8
Change-Id: Ib238714477fdeadad07c470e1d9ed64b2b18f25d
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann6-8/+8
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-21Get rid of trivial comphelper::in-/decrement wrappersStephan Bergmann1-4/+4
Change-Id: Id3a12ef9d56c30719f483e610c8a8b08caf05def
2015-04-20java: remove some unused codeNoel Grandin1-3/+0
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
2015-04-16UnoControls, toolkit, uuoi, xmlsecurity: convert new to ::Create.Michael Meeks4-69/+69
Change-Id: I7b8c7ece656589c50fb066e9fa1565fd59f930da
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin2-4/+4
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-11Fix more misc. lifecycle mistakes.Michael Meeks1-1/+2
Change-Id: Iadf0767d41830296a441299bf10aaa1e7629a824
2015-04-10Fixup toolkit's printer code.Michael Meeks2-7/+3
Change-Id: I1d9b0cee1c04e853d38135b84c5c8db24538176e
2015-04-10toolkit: much safer WindowDestroyed handler.Michael Meeks1-13/+15
Change-Id: I0c72231a932186130246bab343653ecb563a41f2
2015-04-10svtools: switch UNO pieces to use VclPtr enabled toolkit.Michael Meeks1-1/+1
Change-Id: Ib243b14e3476d3a65ad1414e3843511420201c7c
2015-04-10toolkit: more VclPtr pieces.Michael Meeks3-64/+62
Change-Id: I0393d906657b94cc547986a2165960a85d36cf48
2015-04-10toolkit: more cleanup.Michael Meeks1-105/+99
Change-Id: I2aa5c818d4f2c07926bda539da30ada63620f69d
2015-04-10toolkit: first cut at switching to VclPtr.Michael Meeks7-184/+152
Toolkit has traditionally had a very odd lifecycle relationship with VCL - start to fix that; first partial cut. Change-Id: I77e5e62ebde101d32746d12d83dae92c49970001
2015-04-09svtools: apply vcl::window refcounting changesNoel Grandin1-16/+31
Change-Id: I308f045eaf5c50de26175a2f00f8b0791cdd8ab9 Conflicts: svtools/source/control/tabbar.cxx
2015-04-07loplugin:staticmethodsNoel Grandin1-2/+2
Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann3-3/+3
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann3-3/+3
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-01loplugin:staticfunctionNoel Grandin5-5/+5
Change-Id: I89f5984d73e7d42269189dc1d1bc2d59e5ab193f
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann6-24/+24
Change-Id: I2f084bd6de707d21857e2182aebb96b446b51dcc
2015-03-31Resolves: tdf#90228 1.06 turns into a monsterCaolán McNamara1-2/+3
Change-Id: I8ebb57fe8b94da2569593ffa7cf374cae64a846a
2015-03-29Clean up template-parameter-dependent C-style castsStephan Bergmann1-1/+1
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann8-28/+28
Change-Id: I98cf0c0eee558662d1e3dd20cca99ec1ca8c9a2c
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-15 06:33:07 +0000