summaryrefslogtreecommitdiff
path: root/toolkit
AgeCommit message (Collapse)AuthorFilesLines
2014-11-18java: make fields final where possibleNoel Grandin28-97/+71
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2-2/+3
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl2-0/+2
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini6-21/+21
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin5-43/+23
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-20/+16
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10fix spelling implemenation -> implementationNoel Grandin1-1/+1
Change-Id: I5ac499df1f4063a80a5d41f60778106a7b96940d
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-2/+2
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+1
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-1/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05idle: allow processing pending handlers remotely.Michael Meeks1-0/+9
Change-Id: Idb835f1fb04a3f9ca2430781cabeb785285ccf7b
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-33/+27
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30accessibility: shift by zeroRobert Antoni Buj i Gelonch2-4/+4
Change-Id: I4e25b0a6929cc88aa2ec1d213b8f1115de6be607 Reviewed-on: https://gerrit.libreoffice.org/12146 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30java: Method uses the same code for two switch clausesRobert Antoni Buj i Gelonch1-6/+0
Change-Id: Ied82b0a39ff9dc9c7cc9539dec2b963059f3d4a5 Reviewed-on: https://gerrit.libreoffice.org/12139 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky2-3/+3
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky1-2/+2
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin2-6/+7
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-19accessibility: The if statement is redundantRobert Antoni Buj i Gelonch1-9/+6
Change-Id: I70dd50d8d588c71d391936195bb13ccb767470be Reviewed-on: https://gerrit.libreoffice.org/11890 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon1-2/+2
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16java: always use braces for while loopsNoel Grandin7-10/+18
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16java: reduce the depth of some deeply nested if blocksNoel Grandin3-103/+101
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-13java: Collections.addAll for adding an array of elements to a CollectionRobert Antoni Buj i Gelonch1-4/+2
Change-Id: I4689aa73e1e261c6461e04b9e814ffefa5817c09 Reviewed-on: https://gerrit.libreoffice.org/11953 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13accessibility: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch1-4/+31
Change-Id: Ib46d24be831b5c9bda0582bd7064f34528e1d609 Reviewed-on: https://gerrit.libreoffice.org/11938 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11accessibility: Calling String.toString()Robert Antoni Buj i Gelonch1-1/+1
Change-Id: I125d2c337df606c6388ddbd41030e51a558ad054 Reviewed-on: https://gerrit.libreoffice.org/11920 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10unchecked call to getDeclaredMethod(String,Class<?>...)Robert Antoni Buj i Gelonch1-1/+1
http://docs.oracle.com/javase/tutorial/reflect/class/classTrouble.html Change-Id: I293e7ad3ace1a8876c34d7ffd070b49807a8b0a6 Reviewed-on: https://gerrit.libreoffice.org/11882 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09As of JDK version 1.5, show() and hide() in Dialog have been deprecatedRobert Antoni Buj i Gelonch3-4/+5
Change-Id: If96e40ebe2c59f31ca4e2b81c6583eb7f8d5ec81 Reviewed-on: https://gerrit.libreoffice.org/11873 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca2-3/+3
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08complex: Use 'import com.sun.star.beans.UnknownPropertyException;'Robert Antoni Buj i Gelonch1-3/+3
Change-Id: Ib42baf6f18fd407a879313c042efd74c8f724aa4 Reviewed-on: https://gerrit.libreoffice.org/11864 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke1-1/+1
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08spelling: instanciated -> instantiatedNoel Grandin1-1/+1
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-07java: use isEmpty() instead of "size() == 0"Noel Grandin2-2/+2
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07java: remove unnecessary adding of empty stringsNoel Grandin3-5/+4
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
2014-10-07java: no need to check for null before calling instanceofNoel Grandin1-2/+2
the instanceof check returns false when passed a null value Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
2014-10-04fix for invalid dynamic_castNoel Grandin1-3/+4
after my loplugin-cstylecast commits. this is a follow on to the bug reported in fdo#84608 Change-Id: Icc4f4baf3690e939c07a71a949200270bf1f4614
2014-10-01fdo#82577: Handle TimeNoel Grandin1-1/+1
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin1-1/+1
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin2-6/+6
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29toolkit: std::auto_ptr -> std::unique_ptrStephan Bergmann1-42/+43
Change-Id: I4566a0b7215b729f04591bed0ad5bed42f71f227
2014-09-29loplugin: cstylecastNoel Grandin10-259/+261
Change-Id: I20358c271e32b4af11d3258c950bde836596933a
2014-09-26remove unnecessary casts'sNoel Grandin1-1/+1
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-25comphelper: std::auto_ptr -> std::unique_ptrStephan Bergmann1-1/+1
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-23fdo#82577: Handle WindowNoel Grandin19-197/+197
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin8-24/+24
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-12toolkit: sal_Bool -> boolStephan Bergmann2-2/+2
Change-Id: I8819d408e8556bbf38605c2feef2fa87d8dd41c3
2014-09-10Typo: (N|n)ormaly->(N|n)ormallyJulien Nabet1-1/+1
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-10vcl: sal_Bool -> boolStephan Bergmann7-14/+14
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
2014-09-09toolkit: use String.length()==0 instead of String.equals(empty string)rbuj1-1/+1
Change-Id: Id38f28e7138460493fde982cc1ebc75c3cb0b386 Reviewed-on: https://gerrit.libreoffice.org/11365 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02toolkit: fix javadoc errorsrbuj2-6/+6
Change-Id: I6d2268786d22f967be2d5e0dbcda14a074af4475 Reviewed-on: https://gerrit.libreoffice.org/11248 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>