summaryrefslogtreecommitdiff
path: root/toolkit
AgeCommit message (Collapse)AuthorFilesLines
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin1-1/+1
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin1-1/+1
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin3-41/+10
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-10Fix long/sal_IntPtr mismatch on x86_64 platform on windowsDavid Ostrovsky1-2/+2
25e291438231611823dadc195fd26d26a1b8ece4 changed Link class to use sal_IntPtr instead of long, but missed to adjust number of occurrences. Change-Id: I966185083a41b41c7385947a03369a8ce65c61b8 Reviewed-on: https://gerrit.libreoffice.org/13852 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-01-09Revert "Use SVLIBRARY instead of gb_Library_get_runtime_filename"Matúš Kukan2-1/+2
$(call gb_Library__get_name,foo) returns "libmerged" if library foo is merged. This reverts commit ee567a63fad9e755b11ca28696da35f00ed3b0fc. Change-Id: I6ab9b7f0b01262a6f9d5a6834a6cffdd6ffc6f8a
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl2-2/+2
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin2-3/+3
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-06Use SVLIBRARY instead of gb_Library_get_runtime_filenameStephan Bergmann2-2/+1
Change-Id: I0d21d9685cdc801f7d6975a752999788c1f132e4
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann1-1/+1
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05java: unnecessary method overridesNoel Grandin1-6/+0
these methods did nothing but call their super implementation. found by CodePro Change-Id: Iba40d10ca1db0b4a3b4b971cacc2f299c4d5f389
2015-01-05java: remove more dead codeNoel Grandin4-7/+9
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05java: was passing the wrong thing to the remove methodNoel Grandin1-2/+2
on a Map, we need to pass the key, not the value, to be deleted Found by FindBugs. Change-Id: If6fd3d8d56a7c7dfabac31d8ee268939e582f4eb
2015-01-05java: remove unnecessary reflection in toolkit testsNoel Grandin3-323/+29
and delete a dead class Change-Id: I7822ecff670d6036d0cf35f4b2d299b738f9061b
2015-01-05java: remove dead codeNoel Grandin27-1501/+1
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-04cppcheck: Possible inefficient checking for <var> emptinessJulien Nabet1-1/+1
Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara2-7/+7
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-1/+1
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: fix access to always null fieldNoel Grandin1-4/+1
this cannot have ever worked, but at least it'll stop bugging me now Change-Id: Idd9738358d18770258ca0648afe4b9256458a4d6
2014-12-19java: synching on a global object is not very usefulNoel Grandin1-2/+1
when you're using it as a local lock Change-Id: Ie7f42176f7b582c6dad426d9f8eb0a846a3519c2
2014-12-19java: dodgy synchronisation around clearNoel Grandin1-1/+1
if we want to synchronize access to this datastructure, and we want to use it as a lock object, creating a new one is not a good idea Change-Id: I99c2f665242ef16611bc15a0690b8da222085efb
2014-12-18toolkit: Use appropriate OUString functions on string constantsStephan Bergmann6-8/+8
Change-Id: Iad8c0ffce9f0b17556f5305929715ddc0cce1042
2014-12-18No need for libotouch any more hereTor Lillqvist1-6/+0
Change-Id: Ie092b9475e5dbf8d16bc8b02128c3a6858643abd
2014-12-18Kill createScreenCompatibleDeviceUsingBufferTor Lillqvist1-24/+1
A certain 3rd party uses processEventsToIdle() from XToolkitExperimental, and their code is not C++, so it should be OK to change the ABI of XToolkitExperimental, says mmeeks. Change-Id: I4ba641ad98c17ae42a2ae2eff389fd3354618597
2014-12-15java: remove some unused fields and variablesNoel Grandin2-6/+0
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12toolkit: Use appropriate OUString functions on string constantsStephan Bergmann7-133/+74
Change-Id: I3bb1e560eb325046f5b170da0c4c46c1139f3225
2014-12-11java: remove some unnecessary interfacesNoel Grandin2-10/+0
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8 Reviewed-on: https://gerrit.libreoffice.org/13435 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin34-112/+112
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin2-5/+2
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10Split into individual definitions, one per lineStephan Bergmann1-54/+108
Change-Id: Ib64def97e04273e66f7a2e514c49f0caecc10fe6
2014-12-08fdo#38835 strip out OUString globalsNoel Grandin3-9/+6
Change-Id: I1a435214af102461e02217f7d95248dac14e5f1a
2014-12-05java: remove some unused local variablesNoel Grandin2-2/+0
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-11-22vcl: remove unnecessary typedef VCLXGraphicsList_implChris Sherlock2-4/+4
Change-Id: Iaaf2f0edf721567f88ffc948501548fddd648428
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl17-1/+17
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-18java: make fields final where possibleNoel Grandin28-97/+71
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2-2/+3
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl2-0/+2
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini6-21/+21
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin5-43/+23
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-20/+16
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10fix spelling implemenation -> implementationNoel Grandin1-1/+1
Change-Id: I5ac499df1f4063a80a5d41f60778106a7b96940d
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-2/+2
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+1
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-1/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05idle: allow processing pending handlers remotely.Michael Meeks1-0/+9
Change-Id: Idb835f1fb04a3f9ca2430781cabeb785285ccf7b
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-33/+27
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30accessibility: shift by zeroRobert Antoni Buj i Gelonch2-4/+4
Change-Id: I4e25b0a6929cc88aa2ec1d213b8f1115de6be607 Reviewed-on: https://gerrit.libreoffice.org/12146 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30java: Method uses the same code for two switch clausesRobert Antoni Buj i Gelonch1-6/+0
Change-Id: Ied82b0a39ff9dc9c7cc9539dec2b963059f3d4a5 Reviewed-on: https://gerrit.libreoffice.org/12139 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky2-3/+3
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15