summaryrefslogtreecommitdiff
path: root/toolkit
AgeCommit message (Collapse)AuthorFilesLines
2015-04-24loplugin:simplifyboolStephan Bergmann6-8/+8
Change-Id: Ib238714477fdeadad07c470e1d9ed64b2b18f25d
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann6-8/+8
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-21Get rid of trivial comphelper::in-/decrement wrappersStephan Bergmann1-4/+4
Change-Id: Id3a12ef9d56c30719f483e610c8a8b08caf05def
2015-04-20java: remove some unused codeNoel Grandin1-3/+0
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin2-4/+4
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-07loplugin:staticmethodsNoel Grandin1-2/+2
Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann3-3/+3
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann3-3/+3
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-01loplugin:staticfunctionNoel Grandin5-5/+5
Change-Id: I89f5984d73e7d42269189dc1d1bc2d59e5ab193f
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann6-24/+24
Change-Id: I2f084bd6de707d21857e2182aebb96b446b51dcc
2015-03-31Resolves: tdf#90228 1.06 turns into a monsterCaolán McNamara1-2/+3
Change-Id: I8ebb57fe8b94da2569593ffa7cf374cae64a846a
2015-03-29Clean up template-parameter-dependent C-style castsStephan Bergmann1-1/+1
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann8-28/+28
Change-Id: I98cf0c0eee558662d1e3dd20cca99ec1ca8c9a2c
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann2-3/+3
Change-Id: I17a03b41555a6c9fd7fab90c2c47ac910219f3a6
2015-03-26tdf#67990: Management of case in comboboxJulien Nabet1-2/+2
I noticed these 2 points: 1) Combobox were used with autocomplete with default (false) value for matchCase => so initialize autocomplete with true value for matchCase 2) FindMatchingEntry uses bLazy as !matchCase but when bLazy = false, no autocomplete can work since you must type the whole word so just use "entryCombo" startsWith "typed string" instead of "entryCombo" == "typed string" (thank you Lionel for this tip: http://nabble.documentfoundation.org/Finding-the-right-location-for-tdf-67990-Base-module-td4143324.html) Change-Id: Ib1063002c3284122fd5279f27c1ccbc177bbac7c Reviewed-on: https://gerrit.libreoffice.org/14885 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann16-51/+832
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann1-1/+4
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-09V801: Decreased performanceCaolán McNamara1-2/+2
Change-Id: I9e9a00acf9503980f0c6c7cd0a20378e5ca7390d
2015-03-06Idle Timer: Invented Base ClassTobias Madl1-2/+2
Change-Id: I03db46afcc0cb5e5d7a134b1bdd327abb542e63c
2015-03-06Idle and Timer are now completely independentTobias Madl1-1/+2
And everything is functionating pretty well. Change-Id: Id7f5a995362f6f7c5235f2e9facb7c7f119f3140
2015-03-04V813: Decreased performanceCaolán McNamara3-4/+4
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-02-24Avoid unnecessary bad downcasts to ButtonStephan Bergmann1-2/+5
Change-Id: I36baaa1cd46385430474f8a841eafaaba07a18fc
2015-02-18TyposJulien Nabet1-1/+1
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
2015-02-16tdf#78174: toolkit: work around GCC 4.9 -Os link failureMichael Stahl1-0/+9
A build with gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) for 32-bit x86 fails because of these undefined symbols: > nm --demangle workdir/CxxObject/svx/source/fmcomp/fmgridif.o | grep \\bWindowListenerMultiplexer::acquire U non-virtual thunk to WindowListenerMultiplexer::acquire() They should probably be generated inline. Work around by out-lining the definition of the methods. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64812 Change-Id: I318f7c39bdf1243be385bc6dc0a47862b22e92c5
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara3-55/+53
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara1-13/+13
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara3-56/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-27Resolves: #i98734# save/load ScaleMode property of image control on dialogsTsutomu Uchino1-1/+1
Suggested by: Frank Schönheit <frank.schoenheit@gmx.de> (cherry picked from commit 350c4f9a01b88d4fd1006465151348ac5d459f1a) Conflicts: xmlscript/source/xmldlg_imexp/exp_share.hxx xmlscript/source/xmldlg_imexp/xmldlg_expmodels.cxx xmlscript/source/xmldlg_imexp/xmldlg_export.cxx xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx xmlscript/source/xmldlg_imexp/xmldlg_import.cxx Change-Id: I2a11809112c0b1b53349f5b74dca20897d4a6acd
2015-01-23calling alloca() requires #include <sal/alloca.h>Michael Stahl2-0/+2
Change-Id: I59e5ede0c0cfb10f4196d79ae762132ae4ecb9bb
2015-01-20Some more loplugin:cstylecast: toolkitStephan Bergmann4-7/+7
Change-Id: I8f2963e7bbd1053ea12af22424f4f7a0f65a3486
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin1-1/+1
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin1-1/+1
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin3-41/+10
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-10Fix long/sal_IntPtr mismatch on x86_64 platform on windowsDavid Ostrovsky1-2/+2
25e291438231611823dadc195fd26d26a1b8ece4 changed Link class to use sal_IntPtr instead of long, but missed to adjust number of occurrences. Change-Id: I966185083a41b41c7385947a03369a8ce65c61b8 Reviewed-on: https://gerrit.libreoffice.org/13852 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-01-09Revert "Use SVLIBRARY instead of gb_Library_get_runtime_filename"Matúš Kukan2-1/+2
$(call gb_Library__get_name,foo) returns "libmerged" if library foo is merged. This reverts commit ee567a63fad9e755b11ca28696da35f00ed3b0fc. Change-Id: I6ab9b7f0b01262a6f9d5a6834a6cffdd6ffc6f8a
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl2-2/+2
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin2-3/+3
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-06Use SVLIBRARY instead of gb_Library_get_runtime_filenameStephan Bergmann2-2/+1
Change-Id: I0d21d9685cdc801f7d6975a752999788c1f132e4
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann1-1/+1
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05java: unnecessary method overridesNoel Grandin1-6/+0
these methods did nothing but call their super implementation. found by CodePro Change-Id: Iba40d10ca1db0b4a3b4b971cacc2f299c4d5f389
2015-01-05java: remove more dead codeNoel Grandin4-7/+9
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05java: was passing the wrong thing to the remove methodNoel Grandin1-2/+2
on a Map, we need to pass the key, not the value, to be deleted Found by FindBugs. Change-Id: If6fd3d8d56a7c7dfabac31d8ee268939e582f4eb
2015-01-05java: remove unnecessary reflection in toolkit testsNoel Grandin3-323/+29
and delete a dead class Change-Id: I7822ecff670d6036d0cf35f4b2d299b738f9061b
2015-01-05java: remove dead codeNoel Grandin27-1501/+1
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-04cppcheck: Possible inefficient checking for <var> emptinessJulien Nabet1-1/+1
Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara2-7/+7
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-1/+1
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: fix access to always null fieldNoel Grandin1-4/+1
this cannot have ever worked, but at least it'll stop bugging me now Change-Id: Idd9738358d18770258ca0648afe4b9256458a4d6
2014-12-19java: synching on a global object is not very usefulNoel Grandin1-2/+1
when you're using it as a local lock Change-Id: Ie7f42176f7b582c6dad426d9f8eb0a846a3519c2
2014-12-19java: dodgy synchronisation around clearNoel Grandin1-1/+1
if we want to synchronize access to this datastructure, and we want to use it as a lock object, creating a new one is not a good idea Change-Id: I99c2f665242ef16611bc15a0690b8da222085efb