summaryrefslogtreecommitdiff
path: root/toolkit/test
AgeCommit message (Collapse)AuthorFilesLines
2015-01-05java: unnecessary method overridesNoel Grandin1-6/+0
these methods did nothing but call their super implementation. found by CodePro Change-Id: Iba40d10ca1db0b4a3b4b971cacc2f299c4d5f389
2015-01-05java: remove more dead codeNoel Grandin4-7/+9
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05java: was passing the wrong thing to the remove methodNoel Grandin1-2/+2
on a Map, we need to pass the key, not the value, to be deleted Found by FindBugs. Change-Id: If6fd3d8d56a7c7dfabac31d8ee268939e582f4eb
2015-01-05java: remove unnecessary reflection in toolkit testsNoel Grandin3-323/+29
and delete a dead class Change-Id: I7822ecff670d6036d0cf35f4b2d299b738f9061b
2015-01-05java: remove dead codeNoel Grandin25-1488/+1
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-1/+1
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: fix access to always null fieldNoel Grandin1-4/+1
this cannot have ever worked, but at least it'll stop bugging me now Change-Id: Idd9738358d18770258ca0648afe4b9256458a4d6
2014-12-19java: synching on a global object is not very usefulNoel Grandin1-2/+1
when you're using it as a local lock Change-Id: Ie7f42176f7b582c6dad426d9f8eb0a846a3519c2
2014-12-19java: dodgy synchronisation around clearNoel Grandin1-1/+1
if we want to synchronize access to this datastructure, and we want to use it as a lock object, creating a new one is not a good idea Change-Id: I99c2f665242ef16611bc15a0690b8da222085efb
2014-12-15java: remove some unused fields and variablesNoel Grandin2-6/+0
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: remove some unnecessary interfacesNoel Grandin2-10/+0
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8 Reviewed-on: https://gerrit.libreoffice.org/13435 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin34-112/+112
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: remove some unused local variablesNoel Grandin2-2/+0
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-11-18java: make fields final where possibleNoel Grandin23-86/+60
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-2/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin5-43/+23
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-20/+16
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10fix spelling implemenation -> implementationNoel Grandin1-1/+1
Change-Id: I5ac499df1f4063a80a5d41f60778106a7b96940d
2014-10-30accessibility: shift by zeroRobert Antoni Buj i Gelonch2-4/+4
Change-Id: I4e25b0a6929cc88aa2ec1d213b8f1115de6be607 Reviewed-on: https://gerrit.libreoffice.org/12146 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30java: Method uses the same code for two switch clausesRobert Antoni Buj i Gelonch1-6/+0
Change-Id: Ied82b0a39ff9dc9c7cc9539dec2b963059f3d4a5 Reviewed-on: https://gerrit.libreoffice.org/12139 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: always use braces for while loopsNoel Grandin7-10/+18
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16java: reduce the depth of some deeply nested if blocksNoel Grandin3-103/+101
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-13java: Collections.addAll for adding an array of elements to a CollectionRobert Antoni Buj i Gelonch1-4/+2
Change-Id: I4689aa73e1e261c6461e04b9e814ffefa5817c09 Reviewed-on: https://gerrit.libreoffice.org/11953 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13accessibility: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch1-4/+31
Change-Id: Ib46d24be831b5c9bda0582bd7064f34528e1d609 Reviewed-on: https://gerrit.libreoffice.org/11938 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11accessibility: Calling String.toString()Robert Antoni Buj i Gelonch1-1/+1
Change-Id: I125d2c337df606c6388ddbd41030e51a558ad054 Reviewed-on: https://gerrit.libreoffice.org/11920 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10unchecked call to getDeclaredMethod(String,Class<?>...)Robert Antoni Buj i Gelonch1-1/+1
http://docs.oracle.com/javase/tutorial/reflect/class/classTrouble.html Change-Id: I293e7ad3ace1a8876c34d7ffd070b49807a8b0a6 Reviewed-on: https://gerrit.libreoffice.org/11882 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09As of JDK version 1.5, show() and hide() in Dialog have been deprecatedRobert Antoni Buj i Gelonch3-4/+5
Change-Id: If96e40ebe2c59f31ca4e2b81c6583eb7f8d5ec81 Reviewed-on: https://gerrit.libreoffice.org/11873 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-08spelling: instanciated -> instantiatedNoel Grandin1-1/+1
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-07java: use isEmpty() instead of "size() == 0"Noel Grandin2-2/+2
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07java: remove unnecessary adding of empty stringsNoel Grandin1-2/+1
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
2014-10-07java: no need to check for null before calling instanceofNoel Grandin1-2/+2
the instanceof check returns false when passed a null value Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin3-12/+0
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20fix exception not caughtNoel Grandin1-22/+27
Change-Id: Idf1942d76f3c13e207f2e54494557ee01013c833
2014-08-20remove some dead Java codeNoel Grandin1-6/+0
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-20double-checked locking is not thread-safe in JavaNoel Grandin1-3/+3
found by PMD Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
2014-08-19java: no need to instantiate String objects directlyNoel Grandin4-4/+4
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin2-148/+148
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin2-2/+2
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin2-2/+2
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-14java: remove commented out codeNoel Grandin7-26/+1
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-12java: fix broken javadoc tagsNoel Grandin1-1/+1
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin37-1/+110
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12java: remove unused parametersNoel Grandin5-55/+14
Change-Id: I25b1976295b736fe3929c481bf9d2d81b523271d
2014-08-11java: remove unused parametersNoel Grandin1-2/+2
Change-Id: I9ae22afc27ac0d2051f06885f363845e9b4ce2ff
2014-08-11java: remove unused parametersNoel Grandin4-27/+10
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-08java: remove exceptions from throws clauses that are notNoel Grandin1-6/+3
.. actually thrown Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08java: redundant assignment, variable can only be nullNoel Grandin1-2/+1
Change-Id: I91209c5c185cf097a1609244419d73d4757d7d18
2014-08-08java: remove unnecessary semi-colonsNoel Grandin2-4/+4
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
2014-08-08java: remove unused importsNoel Grandin2-2/+0
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-22 18:39:02 +0000