summaryrefslogtreecommitdiff
path: root/toolkit/source
AgeCommit message (Collapse)AuthorFilesLines
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-33/+27
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky2-3/+3
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky1-2/+2
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin2-6/+7
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon1-2/+2
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca2-3/+3
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke1-1/+1
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-04fix for invalid dynamic_castNoel Grandin1-3/+4
after my loplugin-cstylecast commits. this is a follow on to the bug reported in fdo#84608 Change-Id: Icc4f4baf3690e939c07a71a949200270bf1f4614
2014-10-01fdo#82577: Handle TimeNoel Grandin1-1/+1
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin1-1/+1
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin2-6/+6
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29toolkit: std::auto_ptr -> std::unique_ptrStephan Bergmann1-42/+43
Change-Id: I4566a0b7215b729f04591bed0ad5bed42f71f227
2014-09-29loplugin: cstylecastNoel Grandin10-259/+261
Change-Id: I20358c271e32b4af11d3258c950bde836596933a
2014-09-26remove unnecessary casts'sNoel Grandin1-1/+1
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-25comphelper: std::auto_ptr -> std::unique_ptrStephan Bergmann1-1/+1
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-23fdo#82577: Handle WindowNoel Grandin18-177/+177
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin8-24/+24
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-12toolkit: sal_Bool -> boolStephan Bergmann2-2/+2
Change-Id: I8819d408e8556bbf38605c2feef2fa87d8dd41c3
2014-09-10Typo: (N|n)ormaly->(N|n)ormallyJulien Nabet1-1/+1
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-10vcl: sal_Bool -> boolStephan Bergmann6-12/+12
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
2014-08-25set names on a bunch more threads...Michael Stahl1-0/+3
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist1-5/+5
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza2-3/+0
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-07Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann19-1/+19
Change-Id: I536353b86ee023eb630ea89786d2205a628d95e3
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud2-2/+12
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-11coverity#736076 Missing break in switch, its got to be wrongCaolán McNamara1-0/+1
Change-Id: I21a3b2b794a431d07df8a1bc250e8f0aacaf3059
2014-07-11new loplugin: externalandnotdefinedNoel Grandin6-13/+63
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-08use SimpleReferenceObject in accessibilityNoel Grandin1-25/+0
to replace hand-rolled version Change-Id: I9dd8d02024702972722b43f2654db91eb3da3794
2014-07-03use assert when followed by derefCaolán McNamara1-1/+1
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-01Related: fdo#80633 cache optimal sizeCaolán McNamara1-1/+1
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01coverity#707416 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I7c67c62622e2b46bc565ae148c1605f4954ffa39
2014-06-30Called C++ object pointer is nullCaolán McNamara1-1/+1
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-27loplugin:unreffun: also warn about unused function templatesStephan Bergmann1-13/+0
Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1
2014-06-25remove spurious com::sun::star::chaosMichael Stahl1-1/+1
Apparently some time before inital CVS import a global search-and-replace went horribly wrong and added spurious namespace prefixes everywhere. Change-Id: I4009bc3ab4b1d4c80412f75ad0e4628a382f99f0
2014-06-24coverity#705322 Missing break in switch, assuming incorrectCaolán McNamara1-0/+1
especially because the setProperty logic now matches the getPropery one Change-Id: I7ebeabc9defed00d1853c3b91fbbf592e1940aa8
2014-06-18Missing SolarMutexGuardsStephan Bergmann1-0/+4
...as can be seen e.g. with CppunitTest_dbaccess_dialog_save: vcl::DisplayConnection::start Application::GetDisplayConnection Window::GetDragSource Window::GetDropTarget (anonymous namespace)::VCLXToolkit::getDropTarget (anonymous namespace)::Frame::implts_startWindowListening (anonymous namespace)::Frame::initialize (anonymous namespace)::TaskCreatorService::implts_createFrame (anonymous namespace)::TaskCreatorService::createInstanceWithArguments framework::TaskCreator::createTask framework::Desktop::findFrame framework::LoadEnv::impl_loadContent framework::LoadEnv::startLoading framework::LoadEnv::loadComponentFromURL framework::Desktop::loadComponentFromURL unotest::MacrosTest::loadFromDesktop DialogSaveTest::test ... Change-Id: I9523ea47cab23d1f23f73a37d2d44453aa7d56a3
2014-06-13loplugin:staticcallStephan Bergmann9-37/+37
Change-Id: I9e643bd43e6e0f027a7e17b2d5d867c0cb452052
2014-06-09gbuild: remove config_libraries.h and gb_Helper_generate_config_librariesMichael Stahl1-3/+1
This much ugly complexity, generating a header on every gbuild startup etc. is really not warranted for 6 callers of the generated macros. Also, the Win32 make has problems with the quoting. Change-Id: If945e09c1730e52174a6084677842dc611d66b2f
2014-06-05coverity#705323 Missing break in switch, assuming its intentionalCaolán McNamara1-1/+1
Change-Id: Ibb8fe4e1d13a24f810fbdf4978606c35890a9cfd
2014-06-05toolkit: remove SAL_THROW macroNoel Grandin5-10/+10
Change-Id: Id9e27c6cbcdc0c229a0dc2a3ad075d62121e6c5d
2014-06-04coverity#705387 Mixing enum typesCaolán McNamara1-2/+2
Change-Id: Iaba60d05b73ca3229aa8b35b338ee54381efd2d3
2014-06-04coverity#705388 Mixing enum typesCaolán McNamara1-1/+56
Change-Id: If80361ac234c5079c9fcadb0a2f5fa05ea6b407b
2014-06-01fdo#68849: Add header guards to all include filesJens Carl1-0/+4
Added header guards to files in directories toolkit/, and ucb/ Change-Id: Ia7ea7d6fad685c7648db22455b5587cf6260318d Reviewed-on: https://gerrit.libreoffice.org/9595 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-29fdo#75364 flat style and 3d style were swappedLionel Elie Mamane1-2/+2
Change-Id: I929f8f63e8017727595be30f4e56f3aabeec2b1e Reviewed-on: https://gerrit.libreoffice.org/9549 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-29remove unnecessary NULL parameter passed to UNO ExceptionNoel Grandin1-2/+2
.. now that we have a default value for that parameter Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-27remove more unnecessary use of OUString constructorNoel Grandin1-2/+1
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin1-1/+1
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-23Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20Julien Nabet6-7/+7
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-16Resolves: #i98216# extract boolean value for AutoFill value of ComboBox modelTsutomu Uchino1-0/+6
(cherry picked from commit 213aafbf006a5099e951f65a472e4f8fa66256a4) Change-Id: I862abc31b69b98f0ec766ca260fdc063d14a2ee4