summaryrefslogtreecommitdiff
path: root/toolkit/qa
AgeCommit message (Collapse)AuthorFilesLines
2015-10-16convert PASSED to COMPLETED in 'make check' test messagesNoel Grandin1-1/+1
Change-Id: I5501f4f40024d3a47bb7007896e07c6252151cf6
2015-09-29Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifddd2533b767924791338555031b848c59980c52 Reviewed-on: https://gerrit.libreoffice.org/18989 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-06-15java: 'final static' to 'static final'Noel Grandin1-2/+2
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11speed up Java unit tests by removing sleepsNoel Grandin3-22/+23
and replacing them with a call to XToolkitExperimental:: processEventsToIdle Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932 Reviewed-on: https://gerrit.libreoffice.org/16201 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-05Let JUnit take care of exceptionsNoel Grandin1-77/+49
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-29split toolkit unoapi test for performanceBjoern Michaelsen5-91/+145
- test previously took 3m18s here - slowest part is now 60s Change-Id: Ibbcdf9a7f408fcca189bcb7b182a864aea1f7159 Reviewed-on: https://gerrit.libreoffice.org/15958 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara1-1/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin3-41/+10
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-05java: remove dead codeNoel Grandin2-13/+0
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-10java: simplify the getMSF() methodsNoel Grandin2-5/+2
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin5-11/+11
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini1-1/+1
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19accessibility: The if statement is redundantRobert Antoni Buj i Gelonch1-9/+6
Change-Id: I70dd50d8d588c71d391936195bb13ccb767470be Reviewed-on: https://gerrit.libreoffice.org/11890 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-08complex: Use 'import com.sun.star.beans.UnknownPropertyException;'Robert Antoni Buj i Gelonch1-3/+3
Change-Id: Ib42baf6f18fd407a879313c042efd74c8f724aa4 Reviewed-on: https://gerrit.libreoffice.org/11864 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-07java: remove unnecessary adding of empty stringsNoel Grandin2-3/+3
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
2014-09-09toolkit: use String.length()==0 instead of String.equals(empty string)rbuj1-1/+1
Change-Id: Id38f28e7138460493fde982cc1ebc75c3cb0b386 Reviewed-on: https://gerrit.libreoffice.org/11365 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02toolkit: fix javadoc errorsrbuj2-6/+6
Change-Id: I6d2268786d22f967be2d5e0dbcda14a074af4475 Reviewed-on: https://gerrit.libreoffice.org/11248 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin2-8/+0
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20use correct loop index variableNoel Grandin1-2/+2
Change-Id: I92531f8fc96c0cb0ca944a7dd50c4fe4ea740b37
2014-08-20double-checked locking is not thread-safe in JavaNoel Grandin1-1/+1
found by PMD Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
2014-08-19java: remove unused methodsNoel Grandin1-18/+0
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-17catch UnknownPropertyExceptionCaolán McNamara1-0/+10
Change-Id: I3134c574a124a2359c40b139eb5b41198b0e4611
2014-08-14java: remove unused importsNoel Grandin1-1/+0
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-13java: remove dead methodsNoel Grandin1-23/+2
found by UCDetector Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13java: reduce scope, make some methods privateNoel Grandin2-3/+3
found by UCDetector Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13java: reduce scope, make member classes privateNoel Grandin1-1/+1
found by UCDetector Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13java: reduce scope, make fields privateNoel Grandin5-12/+12
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13java: reduce scope, make constructors privateNoel Grandin1-1/+1
found by UCDetector Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-12java: remove useless javadoc tagsNoel Grandin5-47/+0
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-05java: remove commented out codeNoel Grandin5-35/+0
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05java: remove various unused variablesNoel Grandin1-15/+9
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin1-1/+1
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-02-26Remove visual noise from toolkitAlexander Wilms2-28/+28
Change-Id: I1704d6ac497f2e47a813813640ead14c5fa480d9 Reviewed-on: https://gerrit.libreoffice.org/8326 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-05Related: #i121514# Remove deprecated UnoControlSimpleAnimationAriel Constenla-Haile2-13/+0
(cherry picked from commit 514bb6777e001d02dbd9be63fc7a6187560aad63) Conflicts: offapi/com/sun/star/awt/UnoControlSimpleAnimation.idl offapi/com/sun/star/awt/UnoControlSimpleAnimationModel.idl offapi/com/sun/star/awt/XSimpleAnimation.idl offapi/com/sun/star/awt/makefile.mk offapi/type_reference/typelibrary_history.txt offapi/type_reference/types.rdb toolkit/inc/toolkit/helper/servicenames.hxx toolkit/source/awt/vclxtoolkit.cxx toolkit/source/awt/xsimpleanimation.cxx toolkit/source/controls/tksimpleanimation.cxx toolkit/source/helper/registerservices.cxx toolkit/source/helper/servicenames.cxx toolkit/util/toolkit.xml Change-Id: If7f8de62713e28434e28975026cf8e5c66c831aa
2013-07-05Related: #i121513# Remove deprecated UnoControlThrobberModelAriel Constenla-Haile2-13/+0
(cherry picked from commit 5569d97f06a0299e41b91ca248bf7eaa038b1f21) Conflicts: icon-themes/human/toolkit/source/awt/spinner03-grey_01.png icon-themes/human/toolkit/source/awt/spinner03-grey_02.png icon-themes/human/toolkit/source/awt/spinner03-grey_03.png icon-themes/human/toolkit/source/awt/spinner03-grey_04.png icon-themes/human/toolkit/source/awt/spinner03-grey_05.png icon-themes/human/toolkit/source/awt/spinner03-grey_06.png icon-themes/human/toolkit/source/awt/spinner03-grey_07.png icon-themes/human/toolkit/source/awt/spinner03-grey_08.png icon-themes/human/toolkit/source/awt/spinner03-grey_09.png icon-themes/human/toolkit/source/awt/spinner03-grey_10.png icon-themes/human/toolkit/source/awt/spinner03-grey_11.png icon-themes/human/toolkit/source/awt/spinner03-grey_12.png offapi/com/sun/star/awt/UnoControlThrobber.idl offapi/com/sun/star/awt/UnoControlThrobberModel.idl offapi/com/sun/star/awt/XThrobber.idl offapi/com/sun/star/awt/makefile.mk offapi/type_reference/typelibrary_history.txt offapi/type_reference/types.rdb rat-excludes swext/mediawiki/help/component.txt swext/mediawiki/src/com/sun/star/wiki/WikiDialog.java swext/mediawiki/src/com/sun/star/wiki/WikiEditSettingDialog.java swext/mediawiki/src/com/sun/star/wiki/WikiPropDialog.java swext/mediawiki/src/description.xml toolkit/AllLangResTarget_tk.mk toolkit/inc/toolkit/helper/servicenames.hxx toolkit/source/awt/vclxtoolkit.cxx toolkit/source/awt/xthrobber.cxx toolkit/source/awt/xthrobber.hrc toolkit/source/awt/xthrobber.src toolkit/source/controls/tkthrobber.cxx toolkit/source/helper/registerservices.cxx toolkit/source/helper/servicenames.cxx toolkit/src2xml/src.lst toolkit/util/toolkit.xml Change-Id: Ic415a96fe6ba7040a3b03fd562f997d2df1516d6
2012-11-29toolkit: s/EventEvent/Event/ in a11y complex testMichael Stahl1-5/+5
Change-Id: Ie8bf5881bb99d1d0c5202aadee69e330a5976528
2012-11-29API CHANGE a11y unpublishing and add/removeListener rename.Thorsten Behrens1-5/+5
The a11y API has never really been picked up by tools vendors, let's not tie ourselves up here for no good reason. This unpublishes all css::accessibility, and dependend API. With that, we can change the rather unfortunately-named add/ removeEventListener to be add/removeAccessibleEventListener, thus not conflicting with the XComponent methods of the same name. Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
2012-11-20fdo#51304: Remove @author annotationJosé Guilherme Vanz5-5/+0
This commit removes some @author annotations and some cleanup. Change-Id: Iaf2c4465825dc73af6c1d7377ae847262721c22b Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1122 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-03re-base on ALv2 code. Includes:Michael Meeks3-44/+46
tkr41: #117828# office crash fixed . (null pointer) + add unit test Patch contributed by Tobias Krause http://svn.apache.org/viewvc?view=revision&revision=1172105 Do not add targets for junit tests when junit is disabled. Patch contributed by Andre Fischer http://svn.apache.org/viewvc?view=revision&revision=1241508 remove the OutDev::GetKernPair* stubs completely Patch contributed by Herbert Duerr http://svn.apache.org/viewvc?view=revision&revision=1179221 reverting un-necessary OS/2 conditionals.
2012-10-03fs34b: integrated complex test cases into GNUMake's subsequentcheck targetFrank Schoenheit [fs]1-97/+0
2012-09-14gridfixes: ensure removal of a column in grid control adjusts the cursorNorbert Thiebaud1-56/+99
Change-Id: I99be214bf12d340cc5e9330d1c21046dd366b07a Reviewed-on: https://gerrit.libreoffice.org/554 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2012-09-14gridfixes: #i117398# XMutableGridDataModel:Norbert Thiebaud2-4/+151
allow inserting rows at arbitrary positions Change-Id: Ia5af125035979951c61d6c8cd9a916e8f81bb6c0 Reviewed-on: https://gerrit.libreoffice.org/545 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2012-09-14gridfixes: #i117398# added XGridDataModel::getRowDataFrank Schoenheit [fs]1-1/+28
Change-Id: Ic08c2d54a76f2a2821822ec4b275883e4445c70c Reviewed-on: https://gerrit.libreoffice.org/543 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2012-08-28Java cleanup - remove unused importsNoel Grandin1-1/+0
Change-Id: I7eb24b2d552ec5da752b58ba790ed58fb88728b0
2012-08-20Remove dead java codeNoel Grandin3-9/+0
Change-Id: I9a86978c4b4da058ddc44a7e79635e232ff6c870
2012-06-29Java5 update - convert to use generics and new Collections classesNoel Grandin5-33/+27
Change-Id: Ibe51b5c8d4065c88cd6bae8cddb42a9b6117312a
2012-06-21re-base on ALv2 code.Michael Meeks1-23/+14
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21re-base on ALv2 code.Michael Meeks10-182/+148
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-05-30i#87757: do not create empty Rectangle bounding box for glyphs:Michael Stahl1-4/+0
Enforce a minimum width and height of 1 in GlyphMetric::SetSize(), preventing X11SalGraphics::GetGlyphBoundRect() from returning a Rectangle that has one side set as RECT_EMPTY. This problem has surfaced due to the change of the status bar in ce14342c4292628a641a72d4f63d9c048e030c6a, causing the AccessibleStatusBarItem to fail in getCharacterBounds() because the text of the control, "Words: 0", now contains a space, for which an empty Rectangle bounding box is created, which results in a wrong return value from getCharacterBounds(): LOG> Character bounds outside component LOG> Character rect: 43, -566, 0, 0 LOG> Component rect: 91, 2, 71, 18 It turns out that the following test was disabled due to this problem, so re-enable it now: toolkit.AccessibleFixedText::com::sun::star::accessibility::XAccessibleText
2012-03-23.java files don't need executable bitsMichael Stahl11-0/+0