summaryrefslogtreecommitdiff
path: root/test/source/vclbootstrapprotector.cxx
AgeCommit message (Collapse)AuthorFilesLines
2020-02-03make some headers privateCaolán McNamara1-1/+1
as shown with ./bin/find-headers-to-move-inside-modules.py Change-Id: I7662417e76fe00c0fc352957560e104b6c2a3d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19tdf#42949 Fix IWYU warnings in test/Gabor Kelemen1-3/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id1ee9b6d44315443d023bdfbf9ae8e5aa2158ab2 Reviewed-on: https://gerrit.libreoffice.org/85171 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-08-02Add missing sal/log.hxx headersGabor Kelemen1-0/+1
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from test to vbahelper Change-Id: Ia7f773511624099505d6a36a8d6e23c0cde4a737 Reviewed-on: https://gerrit.libreoffice.org/58225 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-11loplugin:salcall fix functionsNoel Grandin1-1/+1
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04silence coverity#1421122 Uncaught exceptionCaolán McNamara1-3/+12
Change-Id: I371951b0e5a0f8c6fe796ff94dc60e07944c3f0f Reviewed-on: https://gerrit.libreoffice.org/45758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-23loplugin:includeform: testStephan Bergmann1-1/+1
Change-Id: Ibcbb5b002e8326c484547a825cb295d0f5158a3b
2017-03-18Fix MSVC hang in ThreadPool::shutdown()Michael Stahl1-0/+3
This is the vclbootstrapprotector.cxx part of 9899ffd244dd367ba69dffe1f21f4f0222064a46, which unblocks hanging unit tests on a number of VS2015 tinderbox hosts Change-Id: I6dcfd5a85c078953f0dc6fba0311d9e750f8ce5e Reviewed-on: https://gerrit.libreoffice.org/35393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-13Revert "comphelper: fix MSVC hang in ThreadPool::shutdown()"Miklos Vajna1-3/+0
As it causes "unopkg.bin: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/comphelper/source/misc/threadpool.cxx:96: comphelper::ThreadPool::~ThreadPool(): Assertion `mbTerminate' failed." in <https://ci.libreoffice.org/job/lo_gerrit/8283/Config=linux_clang_dbgutil_64/console> and also locally. Revert till it's clear if that assert() should be a SAL_WARN() or unopkg has to be fixed. This reverts commit 9899ffd244dd367ba69dffe1f21f4f0222064a46. Change-Id: I72902f7da410012340aa8231d84c6871a3f7b976
2017-03-11comphelper: fix MSVC hang in ThreadPool::shutdown()Michael Stahl1-0/+3
Commit aa68c99d88fd7abe08c4aee5206c859a0cdba38e added some code using std::condition_variable to comphelper. Built with MSVC 2017, this causes many cppunittester.exe processes to deadlock in ThreadPool::shutdown(): maTasksChanged.notify_all(); This ultimately calls NtReleaseKeyedEvent(), which never returns. The reason appears to be a bug in Windows 7, for which a "hotfix"[1] is avaiable here, but it's apparently not distributed via Windows Update so we likely can't rely on users or even developers having this installed. However, the documentation of DllMain[2] and ExitProcess[3] indicates that during shutdown, by the time global destructors are invoked all threads other than the one that called ExitProcess have already been terminated. Returning from main() implicitly calls ExitProcess [4]. As it turns out the problem only happens for some CppUnitTests because soffice.bin will call ThreadPool::shutdown() from Desktop::doShutdown() while it is still safe. [1] http://support.microsoft.com/kb/2582203 [2] https://msdn.microsoft.com/en-US/library/windows/desktop/ms682583(v=vs.85).aspx [3] https://msdn.microsoft.com/en-us/library/windows/desktop/ms682658(v=vs.85).aspx [4] https://blogs.msdn.microsoft.com/oldnewthing/20100827-00/?p=13023 Change-Id: I6137461ca7efe9a5fbe4f8f8478fb96de3570469 Reviewed-on: https://gerrit.libreoffice.org/35066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann1-1/+1
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-29Remove duplication of "set up VCL" codeStephan Bergmann1-52/+2
The "this is called from pyuno" version in test/source/bootstrapfixture.cxx had had an empty deinitHook, but it appears to not hurt to give it the same deinitHook as the version in test/source/vclbootstrapprotector.cxx had had. Make test::setUpVcl accessible from outside module test for an upcoming use in <https://gerrit.libreoffice.org/#/c/28322/16> "tdf#99402: fix Metafile Font handling". Change-Id: I1d609445690b6ee5e331aa322cd4bf434a3de78e
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke1-2/+3
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-1/+1
Change-Id: I31e61fc91dff70f32143d84ccf308f2bbc9c740e
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-1/+1
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-10convert Link<> to typedNoel Grandin1-3/+3
Change-Id: Iaca21344f6a38f508f79e6d5983e515162a6dca3
2015-05-10Use IMPL_[STATIC_]LINK_NOARG where applicableStephan Bergmann1-1/+1
Change-Id: I1e24b032bdeea017b0e77c5446e55310899ce752
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann1-1/+1
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann1-1/+1
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2014-12-10CppunitTest --headless is not the same as soffice --headlessStephan Bergmann1-1/+3
...they just "happen" to have the same name Change-Id: Ia602f9a62e07c3af6fba2ffb84a858e1fb4b09ce
2014-06-04Missing new files from previous commitStephan Bergmann1-0/+93
Change-Id: Ic8d7c13602c8831e411181c802eb825124578b19