summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2016-04-20character spacing control possible to use outside sidebarSzymon Kłos1-0/+2
Change-Id: Ic0c6458268b529bd0107d6ed5a35f49241cfb833 Reviewed-on: https://gerrit.libreoffice.org/24146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-04-19drawinglayer, sw: indentation fixesMiklos Vajna4-5/+5
Change-Id: Ia84182629f33220a0d85bde00c16f9c26f45e3c5
2016-04-19cppcheck: silence known condition warning in sw ww8Jochen Nitschke1-51/+47
remove variable bDataImport and if clause correct indentation Change-Id: Ib7dd7b91cecbe9c47a50f7487be055b1247423a1 Reviewed-on: https://gerrit.libreoffice.org/24211 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-19cppcheck: silence known conditions warnings in sw annotshJochen Nitschke1-13/+6
Change-Id: I0e5d0eea0c3d8cd14938f45353ca4f27cf09d176 Reviewed-on: https://gerrit.libreoffice.org/24212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-18cppcheck: silence known condition warning in sw undobjJochen Nitschke1-1/+1
Change-Id: Iedbb6bbdcdccf4ea44a7ad4d2e11ce630431034f Reviewed-on: https://gerrit.libreoffice.org/24210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-18Fix commentStephan Bergmann1-1/+1
...after 9b1307f790c550d91b062cbdf1e3fe41d7e7ea4a "Avoid reserved identifiers" Change-Id: Ieec5e6b46483f557f63fd22855484df5688dd1b4
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann2-4/+4
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann2-3/+3
Change-Id: Iee63999e4953a083783cb5c9811640150616472d
2016-04-18tdf#99352 - Some VclPtrs leak past DeInitVCLNoel Grandin4-8/+9
Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8 Reviewed-on: https://gerrit.libreoffice.org/24204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin48-156/+116
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke6-14/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove the hardly used SyntaxLineSet typedefRyan McCoskrie1-3/+1
Change-Id: Ib38bbbdcc65620329d1471d0d61ede65c4f834e6 Reviewed-on: https://gerrit.libreoffice.org/24176 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15clang-tidy misc-forward-declaration-namespaceNoel Grandin1-1/+0
Change-Id: I0566e9992e0d96ee710c8bce2ae6f44a9e83b4e4
2016-04-15RtfAttributeOutput::StartRuby: guard against nullptr pRubyTextMiklos Vajna1-1/+1
The member function checks for nullptr earlier, so check everywhere to be consistent. Change-Id: Ic357551dd95affe50ff6ef3cfdd44e36af9a0c38 Reviewed-on: https://gerrit.libreoffice.org/24101 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann1-1/+1
"logical ‘or’ of equal expressions" Change-Id: I156cb8f09dadb7b625585cfd28d584ba0ae7633e
2016-04-14Related: tdf#65642 RTF filter: import \pgnucrmMiklos Vajna2-0/+29
This as a side effect also implements support for DOCX <w:pgNumType w:fmt="upperRoman" .../>. Change-Id: Ibf3bedca03c6c2a2b96eecb36ff6c4cf6e2281b4 Reviewed-on: https://gerrit.libreoffice.org/24073 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-14loplugin:passstuffbyref in swNoel Grandin80-169/+169
Change-Id: I124bdd4f28c7d7508e77b902dfa23c398454bf38
2016-04-12Avoid reserved identifiersStephan Bergmann40-84/+84
Change-Id: Ib8cbcdff79ad8d621b8e9567df0afe32e9501279
2016-04-12Avoid reserved identifiersStephan Bergmann3-38/+38
Change-Id: I3149c64903825ddd1f751425436cfa0285c84a6f
2016-04-12Avoid reserved identifierStephan Bergmann1-10/+10
Change-Id: I5f512c2519fa4305527a80ee34ea51a620dcdc2c
2016-04-12Avoid reserved identifiersStephan Bergmann1-16/+16
Change-Id: Ibae35afb647622707b1104cd6e938692951d566e
2016-04-12Avoid reserved identifierStephan Bergmann5-9/+9
Change-Id: Ie3e28611003ae51ba4d0278cec41744f2ca08223
2016-04-12tdf#99135 VML import: handle image cropMiklos Vajna2-0/+6
The spec says in theory a % suffix could be also supported, but let's wait till that is seen in a real-world document. Change-Id: Ie026915e38dcb03c99085a1740075364b00e1c8d
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke14-19/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12Add other tests to check_change_colorslideon1-0/+7
Add tests for GridColor and FootnoteLineColor Change-Id: Ia1112cbff5fd77ae1fa83fac362e917eb35f530d Reviewed-on: https://gerrit.libreoffice.org/24001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-12clang-tidy performance-unnecessary-value-param in swNoel Grandin18-24/+24
Change-Id: I3e030743b640d5a5f6b3bf4a4e9ba50ccd001287
2016-04-11tdf#99161 Change Index/ToC dialog title and tabYousuf Philips1-2/+2
Change-Id: I80349233e4fe3969da98814edaa1df52bb9adb35 Reviewed-on: https://gerrit.libreoffice.org/23959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-04-09valgrind: leak on export of ooo98646-1.doc to docxCaolán McNamara1-9/+8
Change-Id: Idd1015fd9dfe12c085a61756fb9448fb6df09326
2016-04-09coverity#1358391 Inferred misuse of enumCaolán McNamara1-1/+1
might be good to change nId to the enum and use the enums then Change-Id: I302f13fd960227e682f98ce2946b8567442641da
2016-04-08tdf#99140 DOCX import: fix table horizontal aligment to be 'from left' ...Miklos Vajna1-0/+6
... when it was 'manual'. Regression from commit c1e563f6efd09cd3463f1b92a3022ae288c92087 (fdo#76741 [DOCX] Table Alignment and width type, 2014-04-04), DOCX import code had to deal with two kinds of horizontal alignment when it came to floating tables: the alignment of the table itself, and the alignment of the float parameters. The problem is, in general it's wanted that the table is aligned according to the floating parameters, but in Writer the "from left" UI setting is described differently for tables and fly frames: tables use LEFT_AND_WIDTH for that, while fly frames use NONE. Fix the problem by touching the default only in case the floating parameters have something that's different from NONE. With this, the width of tables is no longer lost when they are described to be floating ones in the DOCX markup, but FloatingTableConversion() decides to ignore that. Change-Id: Idd41c3e03e6ded8552e9d15b6080e4b45eb18d3d Reviewed-on: https://gerrit.libreoffice.org/23923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-08tdf#99140 DOCX import: fix table at the bottom of the page to span over ...Miklos Vajna2-0/+9
... multiple pages. In short, one more blacklist entry when conversion should not be performed. Change-Id: I764f02cc58ae1b7af802b81e570e4feaf73ee2c1 Reviewed-on: https://gerrit.libreoffice.org/23912 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-08lok context menu: Expose context menuPranav Kant2-3/+10
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-08SfxTabDialog: rename members missing their prefixesMiklos Vajna3-4/+4
Change-Id: I6c739d4c64fb0b460e993f2a326a0acfec98b1c7 Reviewed-on: https://gerrit.libreoffice.org/23902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-07sw: replace boost::noncopyable with C++11 deleteMichael Stahl7-17/+27
Change-Id: Iac20763c7d1db467420f9c2fbb3cd636839d4c80
2016-04-07sw: replace boost::noncopyable with C++11 deleteMichael Stahl8-18/+44
Change-Id: I5c97c500096dee70bf9208daae38c3f042ac57d3
2016-04-07notebookbar: Reduce the vertical space between buttons.Jan Holesovsky1-22/+0
Change-Id: I6cb7761503e36cfce421b23275dd0bd71f5179ca
2016-04-07notebookbar: More Writer's notebookbar.ui tweaks.Jan Holesovsky1-12/+36
Change-Id: I738c618aa8b3bca91e6616b3f9741630ffb20532
2016-04-07updated notebookbar.ui in the WriterSzymon Kłos1-42/+3022
Change-Id: I5f400ca922e446f7dbc3ad99b18862f088751e13
2016-04-07tdf#99120 DOC import: fix lack of first share after odd section breakMiklos Vajna4-1/+12
Commit 848b1a05c5c41b5e7ff19c984f60c297a8143990 (fix for bnc#659631, 2011-02-04) made wwSectionManager::InsertSegments() use SwPageDesc::WriteUseOn() directly, instead of going via SwPageDesc::SetUseOn() that takes care of not throwing away the higher share bits of the bitfield. This way the "is first shared" flag of the bitfield got cleared, even when the input document had no title page declared, so first header/footer must be shared. Fix the problem by using SetUseOn() in the DOC import as well when it comes to handling odd/even page section breaks. Change-Id: If167f4582919fa177840ed81e0a53aa379485598 Reviewed-on: https://gerrit.libreoffice.org/23885 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-07drop double check of the sameDouglas Mencken1-3/+3
Change-Id: I552b53b18f2b05f71fb9ebf60912c9e8ca1d156c Reviewed-on: https://gerrit.libreoffice.org/23861 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-07Avoid reserved identifiersStephan Bergmann1-2/+2
Change-Id: I63ab4de02702c6f74caa3a65f7d297e2a95a65cd
2016-04-06Elide const varStephan Bergmann1-2/+2
Change-Id: Idbbfd0f3e8fc96550c99a0750ff466629d6007bf
2016-04-06loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I0285ba64213bfd5180e09a40ea6fdf4b210f431b
2016-04-06convert blob's hex bytes to ascii symbolsDouglas Mencken1-22/+20
plus drop some auxiliary variables & assignments Change-Id: I2e9243fb70b46ada46cee09197ba4cecbc62e7fd Reviewed-on: https://gerrit.libreoffice.org/23701 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-04-06Avoid reserved identifierStephan Bergmann1-1/+1
Change-Id: Ica4dc147a49525f0ec65241c2a9f1d3eb75b7285
2016-04-06Indentation fixesMiklos Vajna1-6/+6
Change-Id: Ieba9dfed344e04067278300365172162d6d44aae
2016-04-06Avoid bad downcast from SwViewShell to SwEditShellStephan Bergmann1-3/+3
At least the checkTitleNumbers(complex.XTitle.CheckXTitle) in JunitTest_framework_complex triggered the UBSan failure > sw/source/uibase/uiview/pview.cxx:1139:25: runtime error: downcast of address 0x61300047e500 which does not point to an object of type 'SwEditShell' > 0x61300047e500: note: object is of type 'SwViewShell' > d3 03 80 0d 10 f6 8e e0 fa 2a 00 00 80 b2 1b 00 90 61 00 00 80 b2 1b 00 90 61 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwViewShell' > #0 0x2afadd5b9594 in SwPagePreview::Init() sw/source/uibase/uiview/pview.cxx:1139:25 > #1 0x2afadd5c0e29 in SwPagePreview::SwPagePreview(SfxViewFrame*, SfxViewShell*) sw/source/uibase/uiview/pview.cxx:1251:5 > #2 0x2afadd58c7a5 in SwPagePreview::CreateInstance(SfxViewFrame*, SfxViewShell*) sw/source/uibase/uiview/pview.cxx:85:1 > #3 0x2afa4a476c8c in SfxViewFactory::CreateInstance(SfxViewFrame*, SfxViewShell*) sfx2/source/view/viewfac.cxx:28:12 > #4 0x2afa49b677a5 in SfxBaseModel::createViewController(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/doc/sfxbasemodel.cxx:4255:32 > #5 0x2afa49b6ac45 in non-virtual thunk to SfxBaseModel::createViewController(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/doc/sfxbasemodel.cxx:4217:57 > #6 0x2afa4a38bd08 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) sfx2/source/view/frmload.cxx:600:50 > #7 0x2afa4a37f627 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/frmload.cxx:728:13 > #8 0x2afac3723d1a in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1117:24 > #9 0x2afac3707b02 in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:379:20 > #10 0x2afac37007d5 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:165:9 > #11 0x2afac396848d in (anonymous namespace)::Frame::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/frame.cxx:608:12 > #12 0x2afac39a369a in non-virtual thunk to (anonymous namespace)::Frame::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/frame.cxx:587:62 > #13 0x2afa4a4cdd1a in SfxViewFrame::LoadViewIntoFrame_Impl(SfxObjectShell const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, unsigned short, bool) sfx2/source/view/viewfrm.cxx:1897:5 > #14 0x2afa4a501df3 in SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool) sfx2/source/view/viewfrm.cxx:2096:32 > #15 0x2afa4a4a7491 in SfxViewFrame::ExecView_Impl(SfxRequest&) sfx2/source/view/viewfrm.cxx:2181:29 > #16 0x2afa4a4a5d16 in SfxStubSfxViewFrameExecView_Impl(SfxShell*, SfxRequest&) workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:709:1 > #17 0x2afa483dfe06 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) include/sfx2/shell.hxx:204:35 > #18 0x2afa48392c56 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) sfx2/source/control/dispatch.cxx:262:13 > #19 0x2afa483bf830 in SfxDispatcher::PostMsgHandler(SfxRequest*) sfx2/source/control/dispatch.cxx:1085:17 > #20 0x2afa48398545 in SfxDispatcher::LinkStubPostMsgHandler(void*, SfxRequest*) sfx2/source/control/dispatch.cxx:1065:1 > #21 0x2afa49d320a7 in Link<SfxRequest*, void>::Call(SfxRequest*) const include/tools/link.hxx:84:45 > #22 0x2afa49d31b50 in SfxHintPoster::DoEvent_Impl(void*) sfx2/source/notify/hintpost.cxx:44:5 > #23 0x2afa49d319e5 in SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) sfx2/source/notify/hintpost.cxx:42:1 > #24 0x2afa69f03327 in Link<void*, void>::Call(void*) const include/tools/link.hxx:84:45 > #25 0x2afa69eec39f in ImplHandleUserEvent(ImplSVEvent*) vcl/source/window/winproc.cxx:1959:13 > #26 0x2afa69ed7183 in ImplWindowFrameProc(vcl::Window*, unsigned short, void const*) vcl/source/window/winproc.cxx:2527:13 > #27 0x2afa6cf9a0f9 in SalFrame::CallCallback(unsigned short, void const*) const vcl/inc/salframe.hxx:273:33 > #28 0x2afa6cff0a85 in SvpSalInstance::DoYield(bool, bool, unsigned long) vcl/headless/svpinst.cxx:293:17 > #29 0x2afa6c484a64 in ImplYield(bool, bool, unsigned long) vcl/source/app/svapp.cxx:509:9 > #30 0x2afa6c45ed83 in Application::Yield() vcl/source/app/svapp.cxx:553:5 > #31 0x2afa6c45eb1a in Application::Execute() vcl/source/app/svapp.cxx:473:9 > #32 0x2afa38280294 in desktop::Desktop::DoExecute() desktop/source/app/app.cxx:1322:5 > #33 0x2afa3828ada3 in desktop::Desktop::Main() desktop/source/app/app.cxx:1647:17 > #34 0x2afa6c4de08e in ImplSVMain() vcl/source/app/svmain.cxx:172:19 > #35 0x2afa6c4eb776 in SVMain() vcl/source/app/svmain.cxx:210:16 > #36 0x2afa384c5d01 in soffice_main desktop/source/app/sofficemain.cxx:135:12 > #37 0x4f0f0c in sal_main desktop/source/app/main.c:48:15 > #38 0x4f0ee6 in main desktop/source/app/main.c:47:1 > #39 0x2afa39e4c57f in __libc_start_main (/lib64/libc.so.6+0x2057f) > #40 0x418f48 in _start (instdir/program/soffice.bin+0x418f48) Change-Id: I4a32bcf4dea4616d4726c28ba01adba9083ad1c6
2016-04-06sw: fix typoMichael Stahl1-3/+3
Change-Id: I1f439382dd11a4082cce20e410ecdbcdab31adb9
2016-04-06tdf#99100 DOC import: handle subset of STYLEREF nativelyMiklos Vajna4-2/+51
Commit 4215bca95511af8e4ee96e3c8f521b35f638aef3 (export 'Chapter' field type as 'StyleRef' into .doc, 2015-08-21) mapped SwChapterField to STYLEREF in the DOC export. This field type was handled as a field mark on import. Instead of always handling it as a field mark, recognize the case when it's the subset we write and we can handle natively, and in that case create an SwChapterField again on import. Leave the complex case unchanged as before and keep using field marks for that. Change-Id: Icfa8c4be6538da5e02e2d5071af30a46ccfa712b
2016-04-05tdf#97361 Fix check_table and remove = None assignmentsslideon7-24/+17
The = None (or null) pattern is a Java convention, its not needed in Python. Change-Id: I0041d4030db05234eeefc8606f571da38174f962 Reviewed-on: https://gerrit.libreoffice.org/23669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>