summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2020-01-08Resolves tdf#129793 - Remove "Field codes" optionHeiko Tietze5-27/+3
var m_xFieldNameCB, elem m_bFieldName, ui fieldcode removed Change-Id: I6711f9b8c4f84d6ef19bc295243df0341f8c4f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86350 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-08tdf#94411 use f. and ff. in alphabetical indexSeth Chaiklin1-1/+1
Corrects en_US for index At present en_GB index is defined as en_US, and all other (en_*) are defined as en_US or en_GB Change-Id: Ib4c3e189c1d9a08c8f4eb17a1da526fbf23291d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86080 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-07sw: don't send LOK notifications about redlines during saveMiklos Vajna6-1/+31
SwXMLWriter::Write_() sets redline flags to show insertion and hide deletion, but it resets those flags before the function returns. So LOK notifications for redline changes during save is not useful. Change-Id: I4bf963bbe9c7003cbe85ea6c5538be733a3e3cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86363 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-07Paragraph Dialog Outline Numbering Tab updateandreas kainz1-18/+8
Change-Id: I29d349858b39149b228aa4f6b80eee39f7c6b3f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86318 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-07extract some common code from ImportContext classesNoel Grandin8-49/+9
which reduces code bloat, and lets us log when elements are ignored Change-Id: I5ca12bc1fcbfa3bea49ebde819fd80bd233a96a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-07tdf#129452 DOCX import: fix bottom border of merged columnSzabolcs Toth2-0/+13
Bottom border of a vertically merged column of a table was missing if the inside borders were turned off and the merge included the last cell of the column. This happened because the first cell (topmost) in a set of vertically merged cells determines the borders of the new merged cell, and the turned off inside borders were at the bottom in this case. Change-Id: I3d3defad18a1315117a554a36ad599eb46daffe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85988 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-07fix up TableEditPanelCaolán McNamara1-11/+19
Change-Id: Ibe1a461915d036caf41e761be6970bed9d03b795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07Resolves: tdf#129850 crash inserting tableCaolán McNamara1-4/+4
Change-Id: Ib35363320d7edb67daaadf15d1e0b8584909d84a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86346 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I04c11c4dfcca3b27369a2b2b5fbbb65d5af45a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07most has_tooltip uses are bogusCaolán McNamara5-11/+0
has_tooltip means to use "query-tooltip" to present a tooltip, not that the widget has a literal tooltip, the presence of which is sufficient to set the tooltip Change-Id: I49b35debd1bca1803464096fbc550eb50945509f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-07tdf#77796 DOCX: import table style based cell paddingLászló Németh2-0/+12
Change-Id: Ib86ed45fe816d7e273539798cdebdbb95d575518 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86295 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-07tdf#42949 Fix IWYU warnings in sw/source/uibase/[a-g]*/*cxxGabor Kelemen63-478/+32
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I07178531d1c1edbfcd1ec1feed0dbe96ed2627a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85793 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-07sw: add rendering for semi-transparent textMiklos Vajna3-0/+108
I considered passing the text color's alpha value down to the various vcl backends, but this would need changes everywhere (cairo, opengl, pdf export, etc). It's much easier to go via DrawTransparent(), that's how semi-transparent text in Draw/Impress already works. Change-Id: I96f15e6764c3c88ba67dd72dc8708414d7c6050c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86294 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-07tdf#129841: fix GetTextTableCursorPropertyMap cell background valuesMike Kaganski2-3/+37
... which were accidentally broken in 2003 in commit eba784710e92597282a2284b56dce3a45ac38776. Change-Id: I3dc96dff0a8935f927933bb3946528fb8ac9aed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86315 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06acc. check: move accessibility check strings to own fileTomaž Vajngerl2-27/+49
Change-Id: I455b6f77f75dd3190939c17bf5ffc362030efdbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86290 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06acc. check: table split/merge - check for row span, simplifyTomaž Vajngerl1-15/+23
This extends table split/merge check to also check for row span and simplifies the code a bit by removing code duplication of adding a new accessibility issue for the table to the collecton. Change-Id: If3eb1fa05174f606767e170a61fd0f4af7567aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86249 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06acc. check: add a UI goto for issues with tablesTomaž Vajngerl3-4/+19
Change-Id: Ifa636ce7ee32495d81571754c29b1114f8b56cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86247 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06acc. check: check headings are in incremental orderTomaž Vajngerl1-0/+33
This adds an accessibility check for headings. Headings should be in increemntal order. This means for example that the document can't start with "Heading 2" without first having a "Heading 1", or to skip a heading - for example to go from "Heading 1" and next have "Heading 3", skipping "Heading 2". Change-Id: I6fd3189cc659ad0756cc950b7c0b83b3ec8abf84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86246 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-06tdf#129839: pass initialized shared_ptr to SwDoc::GetBoxAttrMike Kaganski2-1/+26
Regression after commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46 Change-Id: I40acc9e0ffdd292283381366a31eb6647b80324f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86291 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06tdf#129549: hide .uno:BulletsAndNumberingDialog from customization UIMike Kaganski17-21/+21
... and replace its uses with universal .uno:OutlineBullet Change-Id: Ia6bc1c5ca23440af333ffeed9fcd2c8dd47a6af4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86245 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06tdf#129708 speed-up: check if we could create outline instead of creation of itSerge Krot2-2/+2
Change-Id: I0629b4e6ccae4ab9be0142fe39c627f2f9a8f5ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86199 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-06Resolves: tdf#129527 enable/disable edit-style button at the right timeCaolán McNamara1-7/+5
Change-Id: I70b14ad8d96a2564c06a47608e5cf2c438cf7d38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06tdf#129450 DOCX import: fix bottom border of 1-row tablesSzabolcs Toth2-0/+12
Bottom border was missing in a 1-row table with disabled inside borders. This happened because LO applied the empty horizontal borders to the bottom border of the table. Change-Id: I40140bf63297189edad13088f98fc5f869969c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85303 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-06tdf#129442 DOCX import: fix right border of 1-column tablesSzabolcs Toth2-0/+11
Right border was missing in a 1-column table with disabled inside borders. This happened because LO applied the empty vertical borders to the right border of the table. Change-Id: Ib190689bf5059bfd7dbf07b07808cd761015f37e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85301 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-06Removed redundant semicolonsAndrea Gelmini5-15/+15
Change-Id: Ife14b8c3f7d121deb390deb5f405dd42d3016acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-06Don't crash on exiting print preview with NotebookbarMike Kaganski1-2/+2
Crash caused by this sequence (tested in Writer): 1. Closing print preview, frame is attached to controller; 2. This calls SfxNotebookBar::StateMethod 3. There notebookbar's listener is added to list of the controller's context change event listeners 4. Then in SwPagePreview::~SwPagePreview, notebookbar's listener is added to that list again 5. ContextChangeEventMultiplexer::addContextChangeEventListener detects second addition, and throws an unhandled exception. I don't know why starting listening is needed in SwPagePreview dtor; unfortunately commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd doesn't say much about context and reasons. ControlListener is renamed to ControlListenerForCurrentController to emphasize that it operates on the current controller of notebookbar's frame; and its bListen parameter meaning was reverted: previously its "true" value awkwardly meant "stop listening". All direct operations with listener of notebookbar are replaced with calls to notebookbar's methods. In ContextChangeEventMultiplexer::addContextChangeEventListener, uno::UNO_QUERY_THROW was replaced with uno::UNO_QUERY, because not only chart controller may appear here, and it's not an error: e.g. SfxBaseController doesn't implement lang::XServiceInfo. Regression after commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd. Change-Id: Ief1aed188d8f02a6cfe3ea25f4d082dfdf449f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Fix some sw layout tests for 150% UI scalingMike Kaganski1-4/+11
On Windows, with 150% UI scaling, the four values whose tolerance are added are 2099, 2888, 7962, and 4815 respectively. Change-Id: I99bef2f23cc3c117463361bb038d74fda7a2e046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85974 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-06tdf#128996 Chart: Fix disappeared vertical X axis labelsBalazs Varga2-0/+16
Regression from commit: 75ef0e41ea8a9096ac619356d2b837c5333b47e6 (tdf#125334 Chart: allow text break in bar chart axis labels) Change-Id: Ib935de74314b7dec489d94a4aa3c65072e18d9e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86010 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-06sw: prefix members of SwChartDataProvider, SwChartDataSource, ...Miklos Vajna5-69/+69
... SwDataChanged and ZSortFly See tdf#94879 for motivation. Change-Id: I072f14d52f67ec05e068dda4ea0b8e5145143792 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86255 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-06tdf#129798: store SwWrtShell when it's availableMike Kaganski2-24/+35
GetActiveWrtShell may return nullptr when attaching a new component to current frame, e.g. destroying on print preview. OTOH SwWrtShell is passed to SwFieldDBPage::SetWrtShell on creation, so store it to own base class then. Possibly that would be enough, and we could remove all the checks in other methods - but I don't know the code well enough to be sure that SwFieldDlg::PageCreated and SwFieldEditDlg::CreatePage will always set SwWrtShell; to be on the safe side, I kept the checks where SwWrtShell is used, and stored it in those places if not yet stored. Regression after commit 39ba5e3bde93358af1b363da8f850bdc96806cfa. Change-Id: I21f3c8ef24764e98b1bc287db3c6485ce0b3ab48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86253 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-04tdf#129522 ww8import/export: allow char shadow_NONE overridesJustin Luth4-8/+9
An earlier patch did this for paragraphs. The same is needed for character properties. This also applies to borders - where a non-border needs to be processed in order to override a style-defined border. This export change doesn't affect DOCX immediately, because DOCX will do nothing with a NONE-border/shadow until style information is provided to it. So this change is safe to make on it's own as far as DOCX is concerned. RTF just exports the border, but since it doesn't do any of this well, add in the logic so that RTF is unaffected... Change-Id: Ia857dc0db7d7efc83145a14e4fe4052d32b539ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85760 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-01-03Fix typoAndrea Gelmini1-1/+1
Change-Id: I1755566fe28b3a79d7f97875d8986b6f37a0979d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86202 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-03cid#1456612 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: I0160fe9f31dc0716bd862014ca1e8eb7bae7c1ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03tdf#129743 follow-up: implement the other variant of the fixMike Kaganski2-16/+24
Reimplement commit d8a188d8d59ae51621a0540fe931e1c70db285fe Seems that I was overly optimistic. The behaviour of CreateCursor affects many places; first of them is CreateNewShellCursor, which would start returning cursors with selection after the fix from commit d8a188d8d59ae51621a0540fe931e1c70db285fe. Or if we change which cursor is returned from that method, then the order of the chain would reverse. And there are many such places. So just make it like before, and do the conservative fix. Change-Id: Ib6bf414f0e91d6fb59f73fbfc0fbd799457d49c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86151 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-03tdf#129522 SvxShadowItem/writerfilter: allow shadow_NONE overridesJustin Luth5-3/+51
Both editeng and writerfilter were ignoring the case where NONE should override an inherited shadow location. Of course, this situation is very rare. Nearly all unit tests ran when asserting that eLocation is already NONE. The same is true for DOC, except that it is not affected by SvxShadowItem's PutValue problem (and neither is ODT). RTF is not even removing the borderlines themselves, so no point in worrying about the shadow for RTF. Change-Id: I7c1ae67270dde81915daee2f0282aa2074d2ec8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85658 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-03sw: add UNO API for semi-transparent textMiklos Vajna4-0/+22
This makes the ODF filter work out of the box, since the same property was provided by Draw/Impress in the past already. Change-Id: Ie6a053864c9fa41fad6ca4571d7d04a3756b7591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86147 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-02tdf#129423: Make export tests export-only where applicableOnur Yilmaz1-152/+44
Change-Id: I4f143f37154646fd7d4d1df1e680aa1dd9dd1b17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-02tdf#129423: Make export tests export-only where applicableOnur Yilmaz1-77/+27
Change-Id: I15d76ded5342ec2dacfaade3da9e61c8f23deacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85826 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-02tdf#129743: don't delete mark of current cursor when creating new cursorMike Kaganski2-2/+38
The deletion was there since initial import in commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62. It's unclear why would it be necessary and what depend on it. All tests pass => let's drop it. Another (less intrusive, and IMO more of a workaround) way would be to move setting mark of pCursor after the loop over GetNext() in SwCursorShell::SetSelection. Change-Id: I5402db58d8f829799bc16b8f4f6014bcea133995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86142 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-02use same margins etc on writer sidebar panelsCaolán McNamara4-28/+35
Change-Id: I03a490abd6d35967ec5f873a8345c11466e30dc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02weld SlideBackgroundCaolán McNamara1-2/+2
Change-Id: I6f8792d8212807b4be4a24885e237290e298dfa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-02tdf#86731 Don't show 'start from beginning' when dictionary is missingSzymon Kłos1-3/+4
Change-Id: I160e4b15e3c636be0e23dd5bbb2da62dfa6a42ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/82169 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-02tdf#129712: check if outliner view pointer is valid to avoid crashMike Kaganski1-1/+1
Regression after commit 64233bbaa0e91ddf14d59ae7547df6bbfa60adcc. editenglo.dll!std::unique_ptr<EditView,std::default_delete<EditView>>::operator*() at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\memory(1886) editenglo.dll!OutlinerView::GetEditView() at C:\lo\src\core\include\editeng\outliner.hxx(208) sdlo.dll!sd::DrawViewShell::GetAttrState(SfxItemSet & rSet) at C:\lo\src\core\sd\source\ui\view\drviewsf.cxx(514) sdlo.dll!SfxStubGraphicViewShellGetAttrState(SfxShell * pShell, SfxItemSet & rSet) at C:\lo\src\core\workdir\SdiTarget\sd\sdi\sdgslots.hxx(1524) sfxlo.dll!SfxShell::CallState(void(*)(SfxShell *, SfxItemSet &) pFunc, SfxItemSet & rSet) at C:\lo\src\core\include\sfx2\shell.hxx(199) sfxlo.dll!SfxDispatcher::FillState_(const SfxSlotServer & rSvr, SfxItemSet & rState, const SfxSlot * pRealSlot) at C:\lo\src\core\sfx2\source\control\dispatch.cxx(1672) sfxlo.dll!SfxBindings::Update_Impl(SfxStateCache & rCache) at C:\lo\src\core\sfx2\source\control\bindings.cxx(270) sfxlo.dll!SfxBindings::NextJob_Impl(const Timer * pTimer) at C:\lo\src\core\sfx2\source\control\bindings.cxx(1285) sfxlo.dll!SfxBindings::NextJob(Timer * pTimer) at C:\lo\src\core\sfx2\source\control\bindings.cxx(1230) sfxlo.dll!SfxBindings::LinkStubNextJob(void * instance, Timer * data) at C:\lo\src\core\sfx2\source\control\bindings.cxx(1227) vcllo.dll!Link<Timer *,void>::Call(Timer * data) at C:\lo\src\core\include\tools\link.hxx(111) vcllo.dll!Timer::Invoke() at C:\lo\src\core\vcl\source\app\timer.cxx(76) vcllo.dll!Scheduler::ProcessTaskScheduling() at C:\lo\src\core\vcl\source\app\scheduler.cxx(478) vcllo.dll!Scheduler::CallbackTaskScheduling() at C:\lo\src\core\vcl\source\app\scheduler.cxx(288) vcllo.dll!SalTimer::CallCallback() at C:\lo\src\core\vcl\inc\saltimer.hxx(55) vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() at C:\lo\src\core\vcl\win\app\saltimer.cxx(164) vclplug_winlo.dll!WinSalTimer::ImplHandleTimerEvent(unsigned __int64 aWPARAM) at C:\lo\src\core\vcl\win\app\saltimer.cxx(174) vclplug_winlo.dll!SalComWndProc(HWND__ * __formal, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) at C:\lo\src\core\vcl\win\app\salinst.cxx(626) vclplug_winlo.dll!SalComWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) at C:\lo\src\core\vcl\win\app\salinst.cxx(658) user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) at C:\lo\src\core\vcl\win\app\salinst.cxx(420) vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) at C:\lo\src\core\vcl\win\app\salinst.cxx(493) vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) at C:\lo\src\core\vcl\win\app\salinst.cxx(522) vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) at C:\lo\src\core\vcl\source\app\svapp.cxx(446) vcllo.dll!Application::Yield() at C:\lo\src\core\vcl\source\app\svapp.cxx(511) vcllo.dll!Application::Execute() at C:\lo\src\core\vcl\source\app\svapp.cxx(427) sofficeapp.dll!desktop::Desktop::Main() at C:\lo\src\core\desktop\source\app\app.cxx(1609) vcllo.dll!ImplSVMain() at C:\lo\src\core\vcl\source\app\svmain.cxx(191) vcllo.dll!SVMain() at C:\lo\src\core\vcl\source\app\svmain.cxx(226) sofficeapp.dll!soffice_main() at C:\lo\src\core\desktop\source\app\sofficemain.cxx(171) soffice.bin!sal_main() at C:\lo\src\core\desktop\source\app\main.c(48) soffice.bin!main(int argc, char * * argv) at C:\lo\src\core\desktop\source\app\main.c(47) soffice.bin!invoke_main() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(79) soffice.bin!__scrt_common_main_seh() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288) soffice.bin!__scrt_common_main() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(331) soffice.bin!mainCRTStartup() at d:\agent\_work\5\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp(17) kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Change-Id: Ia9ba183bc1be2f22082ac3833e57435dd8462adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86097 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-02tdf#129605 rtfimport: deduplicating borders loses informationJustin Luth3-0/+92
Because at least ONE direct attribute still existes, that SPRM overrides the style SPRM, and therefore the style contents are ignored. But deduplicating has removed the matching parts from the paragraph, so any children properties that match the style revert to default values. In this unit test, only the green border-color was kept, and so a default none-border was created. The UI in writer also directly applies all border properties during a color change, so further style changes in the border-style or thickness no longer have any effect. So there is no reason to try to deduplicate border stuff. UNRESOLVED PROBLEM NOTE: If deduplication is going to happen, then there needs to be a merging of character style child attributes and the directly applied properties - which in practice is the same as not deduplicating at all. (The problem will still come when the paragraph ONLY redefines the border color - then there is nothing to deduplicate and still the style contents are ignored.) This patch affects paragraph-style borders (in a good way), since it fixes tdf#129631 as well. Probably every SPRM that expects children should just avoid deduplication... UNRESOLVED PROBLEM NOTE: Another problem is that the direct properties themselves do not seem to be deduplicated. In addition, deduplication happens against the FIRST instance of the property, not on the LAST instance (which ultimately is the winner). Change-Id: I97333fba66db5cfb5238de426821fe458def329b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85868 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-01weld PageStylesPanelCaolán McNamara3-183/+207
Change-Id: I8e6842a342b242eeaa6d7a27e268dbe5691a9703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-31tdf#59666 AutoCorrect: don't capitalize single Greek lettersLászló Németh1-0/+16
in automatic sentence capitalization (except in Greek texts), to keep the requested lower case scientific and mathematical symbols. Change-Id: I0c658bb69fb90e7159665939f85f1fd99477c730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85955 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-12-30use smaller toolbar icons for sidebarCaolán McNamara1-0/+19
Change-Id: I3f94d23522eb5121e36acbed88ec052208200959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30weld TableEditPanelCaolán McNamara3-94/+138
Change-Id: I380ed08e43e10a5d78e73436b6668abbce1ea23d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-30rename SvxDialControl back to DialControlCaolán McNamara1-1/+1
Change-Id: I4dcf12b6eccf18a0659c5d5f9cd58bd104c4dc6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-29acc. check: implement goto for OLE/Graphic objectsTomaž Vajngerl4-8/+99
This implements goto function for Graphic/OLE objects that are reported in a AccessibilityIssue. So this enables to go to the object inside a document for which we have reported an accessibility issue. Change-Id: I699966b116a76ea032cb1acc9a431687fa204e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85922 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 14:23:28 +0000