summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2017-08-17drop unused SdrCustomShapeAdjustmentItemJochen Nitschke1-1/+0
unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17tdf#55427 ww8export: treat document-end-footnotes as endnotesJustin Luth9-5/+125
MSWord has two choices for footnotes - at page-end or page-bottom. LO has different choices for footnotes - at document-end or page-bottom. Since document-end footnotes act like endnotes, convert those footnotes into endnotes during DOC/DOCX/RTF export. No matter what happens in this situation, some compromises have to be made. The main compromise now is that the anchor numbering for endnotes defaults to i,ii,iii while footnotes are 1,2,3. The conversion obviously will switch to endnote style. This is user adjustable of course and will be retained on following round-trips. Also the (footnote) paragraph style is retained, but future endnotes will use a potentially different endnote paragraph style. Remedying those perceived deficiency is left as an exercise for the motivated reader, who of course will take into account the possibility of both endnotes and chapter-end footnotes existing in the same document... The unit tests' primary purpose is to ensure that footnotes following down the endnote export path don't cause LO to crash. Change-Id: I219d499df7981a14f824a664b15051ad10ff6642 Reviewed-on: https://gerrit.libreoffice.org/38634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-17implementing callback for ruler invalidationAditya Dewan6-1/+68
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin6-11/+8
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17MSWord export: adapt interface to avoid const_castMiklos Vajna7-17/+14
If the implementation uses const_cast anyway, then it's clearer to just not pretend const at the interface level. Change-Id: Ib819efe9204440fde6dc2af890e5ff2769f4b9d3 Reviewed-on: https://gerrit.libreoffice.org/41238 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin28-117/+117
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Removing unused serialisation codeVarun Dhall1-1/+1
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8 Reviewed-on: https://gerrit.libreoffice.org/41233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann3-12/+12
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin22-50/+50
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16i#95698 sw: fix crash on splitting in-table section containing a nested tableMiklos Vajna3-0/+22
Found by crashtesting, ooo95698-1.odt crashed sw layout on load. The intended use-case is splitting section frames inside a table frame, so can just blacklist the non-interesting table-in-section-in-table case that causes the problem here. Change-Id: Ic47cd8c46cc71f7eaa36b03ec2c4a5df8ca8051c Reviewed-on: https://gerrit.libreoffice.org/41224 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-16Translated "Methoden" to complete b1f6e6299cf5Andrea Gelmini1-1/+1
No more "methoden" in the tree... Change-Id: I4deec3c47bfab12beabd1b6d56c9b9c3c2b6c4a7 Reviewed-on: https://gerrit.libreoffice.org/41226 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16tdf#39468 Translate German comments/termsJens Carl2-2/+2
Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea Reviewed-on: https://gerrit.libreoffice.org/41201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16convert dialog result methods from long->sal_Int32Noel Grandin3-5/+5
Change-Id: Id3c56a2c9f8f8813e3bbff4c4ae9156b2185fc9c Reviewed-on: https://gerrit.libreoffice.org/41206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16assert on duplicate listener in SfxListenerNoel Grandin2-4/+8
To enable finding the source of the duplicate calls, I add new SAL API (only for internal use) to retrieve and symbolise stack backtraces. The theory is that it relatively cheap to just store a backtrace, but quite expense to symbolise it to strings. Note that the backtrace() library we use on Linux does not do a particularly good job, but it gives enough information that developers can use the addr2line tool to get more precise info. Explanation of fixes in the code that triggered the assert: In SwFrameHolder, we need to only call StartListening() if the pFrame member is actually changing. We also need to call EndListening() on the old values when pFrame changes. In SwNavigationPI, there is already a StartListening() call in the only place we assign to m_pCreateView. In ImpEditEngine, we need to ignore duplicates, because it is doing a ref-counting thing. By storing duplicates on the listener list, it doesn't need to keep track of which stylesheets its child nodes are using. Given that it therefore will see duplicate events, there is probably some performance optimisation opportunities here. In MasterPageObserver::Implementation::RegisterDocument, we seem to be getting called multiple times with the same SdDrawDocument, so just check if we've been registered already before calling StartListening() In SvxShape::impl_initFromSdrObject, do the same thing we do elsewhere in this class, i.e. only call StartListening() if the model has changed. Change-Id: I7eae5c774e1e8d56f0ad7bec80e4df0017b287ac Reviewed-on: https://gerrit.libreoffice.org/41045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16tdf#107480 RTF import: fix HTML automatic spacing in stylesMiklos Vajna2-0/+23
\htmautsp changes the meaning of \sbauto and \saauto, but the auto keywords may appear early in style definitions before \htmautsp arrives. This wasn't a problem before commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), as there the right auto keyword interpretation was repeated as direct formatting. So fix the regression by not deduplicating these keywords, which brings back the correct layout. A larger rework is necessary in the future to delay the parsing of the stylesheet table, that would be a cleaner approach. Change-Id: I783d2175483bc80ead0a511ad15c4b75e4ab663c Reviewed-on: https://gerrit.libreoffice.org/41187 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-15tdf#111767 Make the Input Field dialog less confusingAdolfo Jayme Barrientos1-57/+42
The first field isn’t editable, so show it visually. Make the actual editable box have the default focus. Drop the unnecessary heading. Change-Id: Icf0d5fc3ddb9b9af6d04045899d9e8476a217bba
2017-08-15tdf#109319 writerfilter: set DropCap.DistanceJustin Luth1-0/+6
Change-Id: I3ec06e9a196897c095f227e9f765243c6c188898 Reviewed-on: https://gerrit.libreoffice.org/41185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-08-15tdf#109318 writerfilter: don't increment DropCap linesJustin Luth2-0/+16
I have no idea why the original implementation used ++nLines when setting aDrop.Lines. Unchanged since mass import from OOo in 2008 commit 614f53dda31f14fe89303dc1809fc29350c1ba29. Change-Id: If427dcea815e91d2cccb2c11044cdb393bff09e3 Reviewed-on: https://gerrit.libreoffice.org/41184 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2017-08-15loplugin:redundantcast, find more functional castsNoel Grandin10-27/+27
In the enum types that caused the problem look like this when I dump then: EnumType 0xdb45770 'enum SvxFrameDirection' `-Enum 0xdb456d8 'SvxFrameDirection' SubstTemplateTypeParmType 0xdb61200 'enum SvxFrameDirection' sugar |-TemplateTypeParmType 0xd7518f0 'EnumT' dependent depth 0 index 0 | `-TemplateTypeParm 0xd7518a8 'EnumT' `-EnumType 0xdb45770 'enum SvxFrameDirection' `-Enum 0xdb456d8 'SvxFrameDirection' Change-Id: Id8fedabe43b7a27df61a2320a9acbf54d2dc7882 Reviewed-on: https://gerrit.libreoffice.org/41169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15sw: prefix members of SwOLENodeMiklos Vajna2-48/+48
Change-Id: I2b79ae40afad8c392f219f1798ce44b41649e5b9 Reviewed-on: https://gerrit.libreoffice.org/41163 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-15remove redundant SvxFrameDirection castsJochen Nitschke2-6/+7
and replace remaining C-style casts Change-Id: Ie83e2706391c05946ab46dfd7d26059101579153 Reviewed-on: https://gerrit.libreoffice.org/41143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15sw RTF export: indentation fixesMiklos Vajna1-2/+2
Change-Id: I33e20b23430483ce318c98a43bde07200802a4d6
2017-08-14Removing unused SetVersionMap from swVarun Dhall3-112/+0
Change-Id: I453efd9fd93941dcdf193b461de1377b76506cde Reviewed-on: https://gerrit.libreoffice.org/41099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-13cppcheck: really remove the memsetJulien Nabet1-2/+0
Change-Id: Ic84e5ca6175d718548e9ee4f9f406ffc899f791a Reviewed-on: https://gerrit.libreoffice.org/41121 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-13cppcheck: Using 'memset' on struct that contains a 'std::unique_ptr'Julien Nabet1-23/+27
+ use constructor initialization Change-Id: I52cb85bf7102dd3f8cf2105fc1c23229b76f28bc Reviewed-on: https://gerrit.libreoffice.org/41107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13cppcheck: variableScopeJochen Nitschke1-24/+26
Change-Id: I4dfbd80cf06acb4968556a78d3eaf394757073dc Reviewed-on: https://gerrit.libreoffice.org/41110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-12tdf#107197: Replace relationship URIChristian Barth1-2/+2
Replaced URIs in sw/source/filter Change-Id: If73c30e9d590742568a3009a6d593f1b3249a5a4 Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/41055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-12Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: I68286aaf7bce262cfc6d371490221e910a3ba7c6 Reviewed-on: https://gerrit.libreoffice.org/41040 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11tdf#89409 Render ruby inside the grid in standard mode.Mark Hung2-11/+16
In standard mode the text grids are rectangle and do not have dedicated space for ruby text. The ruby text either overlap with base text of the last line or clipped ( after scrolling ). Move ruby text inside the grid in standard mode as if there is no grid, and algin text to the center to keep the original text-to-text alignment behavior. Change-Id: Ia75ee016f9d492e4e73da6d7245aaeff40cbe1f3 Reviewed-on: https://gerrit.libreoffice.org/40632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-08-11m_pPostponedVMLDrawings is unused nowTamás Zolnai2-23/+0
Change-Id: Iec685588ef7a1d5284072ebc8fcadc07dae67364 Reviewed-on: https://gerrit.libreoffice.org/40999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-11sw: fix typo in SwXStyle::GetStylePropertyMiklos Vajna1-1/+1
OSL_ENSURE -> SAL_WARN_IF forgot to invert the condition in commit 6abe9cfa924236b9915888470723fec612e1a16d (refactor out to limit scope: RES_PARATR_OUTLINELEVEL, 2016-03-11). Change-Id: Ie0272e7e178e1065d4b619deafbb4e33fcd5d14d Reviewed-on: https://gerrit.libreoffice.org/41018 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-11Resolves: tdf#111571 crash on restarting writer with modeless biblio dialogCaolán McNamara1-2/+2
Change-Id: I2663f84c28721f61c1ed7c8d92a228cafa8f1177 Reviewed-on: https://gerrit.libreoffice.org/41036 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-11convert std::map::insert to std::map::emplace IINoel Grandin7-33/+26
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin5-9/+7
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11tdf#105705 sw: fix another case of bookmarks becoming un-sortedMichael Stahl1-0/+4
The loop in SwTextNode::Update() that reassigns bookmark end positions away from the node to a temporary SwIndexReg can stop prematurely in a particular situation where there is a bookmark that is expanded and with both mark positions at the critical "rPos" insertion position, and also both their SwIndexes consecutive in the SwIndexReg::m_pFirst linked-list. What happens then is that the iteration gets to the first of the 2 consecutive positions of the bookmark, then calls GetMarkEnd() on the mark, which happens to return the other position, which is already stored in the "next" local variable. That other position is then moved to aTmpIdxReg, and in the next loop iteration GetNext() is null as it is the last one in aTmpIdxReg and the loop terminates. Thus various bookmark end positions don't get preserved, or the bAtLeastOneExpandedBookmarkAtInsertionPosition doesn't get set, either of which can cause the bookmark array to lose its sort order. This was found playing around with Zotero 4.0.29.10, while switching between different citation styles. (regression from 6a5dbe73537642b06bcde782118a34b4593d17eb) Change-Id: Ia35ce0656bcb2d6af7ea189458af3942ff83e4da
2017-08-11tdf#108494 fix regressionSzymon Kłos3-0/+101
* correct watermark position * insert also on left and right pages if headers are different Change-Id: Ibacfa6ea14bd8e9c1fd0d0b15de020b30d0a109f Reviewed-on: https://gerrit.libreoffice.org/40891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-11sw: fix inconsistent param naming in interface/implementationMiklos Vajna4-14/+14
SvxPostureItem& rWeight is confusing at best. Change-Id: I70a7e94151f49bf3539af77160cd4a68b8753464 Reviewed-on: https://gerrit.libreoffice.org/41006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-11tweak string convert table dialog to load the same with native gtk builderCaolán McNamara1-7/+8
Change-Id: I5f6753645452b578d30909614cb3cc36ae3d7e64 Reviewed-on: https://gerrit.libreoffice.org/40983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-10tdf#39468: Translate some german commentsChristian Barth4-5/+5
Change-Id: Ie9062738de26b44394d4c91b31fab99a7777813f Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/40994 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-10Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia138abbdb81f0c324721118d487392757f779a96 Reviewed-on: https://gerrit.libreoffice.org/40971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-10editviewoverlay: EditViewSelection reorganizedArmin Le Grand1-1/+1
The Selection visualization in EditVierw is organized to use XOR for visualization, thus DrawSelection is used e.g. before and after changes to the Selection. Ensured athat all changers of selection have to use SetEditSelection by making return of GetEditSelection const. This allows to use a central and safe SelectionChanged which is needed for alternatives of Selection visualization. Change-Id: I994553f3be6b58fd595aa500922d8d1d8ddd36d4
2017-08-10loplugin:unusedenumconstantsNoel Grandin3-57/+21
Change-Id: I54c0c1fca8ea5c89e71c6cd1110fad081ed3d334 Reviewed-on: https://gerrit.libreoffice.org/40953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-10tdf#79167 Change search type through a drop down controlJames Raykowski9-48/+519
drop down control to change 'navigate by' search element small navigation popup relationally linked to drop down control dynamic tool tips added to previous and next 'navigate by' toolbar controls Change-Id: I4b1215b74b488f2571b529d9946f6574de6e270a Reviewed-on: https://gerrit.libreoffice.org/40776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-08-10tdf#111550: A workaround for out-of-order (in-paragraph) tbl on OOXMLMike Kaganski2-0/+66
Word allows <w:tbl> to be direct child of <w:p>, which is illegal according to ECMA-376-1:2016. This allows for import the data in such tables (previously, this text was simply dropped, causing dataloss) - bug-to-bug compatibility with Word. Change-Id: I19c17ab19915ea46685727c635476fe5df593212 Reviewed-on: https://gerrit.libreoffice.org/40909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-09tdf#91384: DOCX: import ActiveX controlsTamás Zolnai3-1/+31
Change-Id: Iebf2ff65fcec3231acfc962fb2f1abc2ed2dc67a Reviewed-on: https://gerrit.libreoffice.org/40930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-09Resolves: tdf#99286 for jpeg dpi use apis that know about MapUnit::MapPixelCaolán McNamara1-15/+3
move the code which can do this from sw to vcl Change-Id: I9940fb80ecdbfe8f70afc500c691288ed0993701 Reviewed-on: https://gerrit.libreoffice.org/40925 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-09tweak string input dialog to load the same with native gtk builderCaolán McNamara1-11/+8
Change-Id: I61d20fe998b1b393c2794e4753f8316511ff7456 Reviewed-on: https://gerrit.libreoffice.org/40920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-09tdf#111480 Circular text was imported horizontallySzymon Kłos2-0/+9
Change-Id: I84a6c3a30fd1dddf104ad8bf037a5e0b2a90d376 Reviewed-on: https://gerrit.libreoffice.org/40912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-09tdf#66212 - Hebrew numbering import/export supportYossi Zahn1-1/+4
Adds support for the new NUMBER_HEBREW numbering format to various import and export filters. Change-Id: I93f928f5d4d43d0cf569a85677df7eef7b088db8 Reviewed-on: https://gerrit.libreoffice.org/36645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-09tdf#97362: TextPortionEnumerationTest partially migrated to python (part 5)jmzambon2-271/+303
Convert tests: - test_range1 - test_range_hyperlink_hyperlink - test_range_hyperlink_ruby - test_range_ruby_hyperlink - test_range_ruby_ruby Change-Id: I6c26f3e0fe910ff56bf38482257340b1c3172461 Reviewed-on: https://gerrit.libreoffice.org/40775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 07:24:24 +0000