summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2016-05-30tdf#99870 writer: don't delete selection with delete-commentJustin Luth1-0/+1
When using the keyboard to select text and then deleting a comment, all the text between the cursor and the comment would also be deleted. (Not necessarily the selected text, but everything from the point or the mark would be included in the delete.) Change-Id: Id15a00d112d118227bc4a34b5102bb09d8d167b0 Reviewed-on: https://gerrit.libreoffice.org/25216 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 12868914a39b0e8fb32f63d1307c1bb1c535fb9c) Reviewed-on: https://gerrit.libreoffice.org/25652 Tested-by: Justin Luth <justin_luth@sil.org>
2016-05-28Improve alignment and use of space in Document Properties dialogAdolfo Jayme Barrientos1-30/+10
Change-Id: Id4da1138931ef1601541b7108a4e90b3656a5ccb (cherry picked from commit 60dd1527d2b59e63c9e6b73cfbe59ba6cefbba16) Reviewed-on: https://gerrit.libreoffice.org/25578 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-05-26VclPtr in container warningsCaolán McNamara1-1/+1
Change-Id: I653aad3a88438faa985466e091e22be1c23ca953 (cherry picked from commit 60041cb237ea73c2c1885dd6afd99d88780c2dfc) Reviewed-on: https://gerrit.libreoffice.org/25519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-26tdf#100051 Partially revert "loplugin:constantparam in sw"Miklos Vajna3-14/+10
This partially reverts commit 9585c8b8c8d8724cc1bad4a2060c828c15599929. Instead of removing the nCount parameters, make use of them in SwXTextViewCursor::go{Left,Right,Down,Up}. For the following testcase: a document with 1000 lines, and calling goDown(1000, true) the spent time goes from 4 secs to 1.8 secs with this for me. (cherry picked from commit cbe78f817da8db78d226b3ad2b1a10d0c2dcf188) Change-Id: I10351a6dbaa6d3fff883520c85701f60b05b4873 Reviewed-on: https://gerrit.libreoffice.org/25495 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-25sw: replace boost::shared_array with std::shared_ptrMichael Stahl2-7/+8
Change-Id: I99eec60db7f6d586b3b424661e03a7891422ab2e
2016-05-25sw: boost::numeric_cast not really ideal in core codeMichael Stahl2-5/+4
... since that can't handle exceptions particularly well anyway. Negative position would be a bug anyway, so assert() is appropriate. Change-Id: Ib246200b3c64ec049fa39835d922092d5a660f55
2016-05-25Resolves: tdf#97879 loop in style hierarchy on odt loopCaolán McNamara1-0/+0
Change-Id: I0098c434b89b6a57e8b888a4d4f643e4d0865d29
2016-05-25Resolves: rhbz#89554 Dragging table to other page causes crashCaolán McNamara1-0/+1
Setting the Cursor pos causes a Calc which deletes the current page and everything blows up, so try a CalcLayout before setting cursor to avoid that. Change-Id: Ia7d132532f19e0164e125a240877caa9cf8bdc04
2016-05-25Window::SetData and Window::GetData are nearly unused nowCaolán McNamara2-8/+6
except for.. a) one use in sw which we can replace with a map b) one use in svx which didn't do anything c) one amusing piece of crazy in cui Change-Id: If66d9f7eab1eaddfb2bdab7815c3a6f22f4d7745
2016-05-25tdf#74795 RTF import: handle row-level default cell marginsMiklos Vajna2-0/+25
Change-Id: I5bdd7b8624a9e2ac1aef963ccc5ed457ebda3f84 Reviewed-on: https://gerrit.libreoffice.org/25443 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-25Convert XmlReader::Result to scoped enumNoel Grandin1-9/+9
Change-Id: I6a0d1dcf5ae51d2ac08aacdfec50865f93e51c21 Reviewed-on: https://gerrit.libreoffice.org/25365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Resolves: tdf#96244 get the right Writer window view for Formula windowCaolán McNamara2-4/+7
if you hit F1 and F2 together, then the help window is a writer window too (in disguise) so asking for the "active view" on processing the F2 in the real writer will get the help window as the active view, which doesn't match expectations. Take the view from the bindings, where its correct from when the event has been dispatched. Investigating a bit further, the F2 formula window only works correctly when its in an "active" window. So get the correct view from the dispatcher but only accept that view if its the active one. Change-Id: I2fd52ca6b68e887d34b07b70b830722f1d00b37a
2016-05-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24sw: prefix members of SwColumnMiklos Vajna2-24/+24
Change-Id: I5f7f0ae87a94e7bdb012bd73dea5cbb5115df448 Reviewed-on: https://gerrit.libreoffice.org/25399 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-24Implement basic TableStyle FamilyJakub Trzebiatowski16-9/+129
Change-Id: I3da13d26ced05e1948d483d432d6268b10c208b5 Implementing: getCount, getElementNames Reviewed-on: https://gerrit.libreoffice.org/25351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-24Convert XMLTextType to scoped enumNoel Grandin2-2/+2
Change-Id: Iac147e57784e11d29f2b34e60dc3c624d6090c8b Reviewed-on: https://gerrit.libreoffice.org/25367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert XmlReader::Text to scoped enumNoel Grandin1-8/+8
Change-Id: I4741b13fcf887a95b85886cb41f8236e128e81a2 Reviewed-on: https://gerrit.libreoffice.org/25364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: Ia30ad12d63423252c527de096cd1ae0ba3fd6aa5
2016-05-23loplugin:unusedmethods in swNoel Grandin48-390/+1
Change-Id: I05e224bcc7d2b08cf1349c14e3acf274d422e109 Reviewed-on: https://gerrit.libreoffice.org/25145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Convert GradientStyle to scoped enumNoel Grandin2-4/+4
Change-Id: I1da151dd25648e363ba88bf88caa3e820f0ee424 Reviewed-on: https://gerrit.libreoffice.org/25270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23loplugin:stringconstantNoel Grandin1-29/+29
Change-Id: I4600970fc1eb288aeb6fd5fb55947d936981f491
2016-05-23Add a test for comparing table cells and table cell rangesslideon2-0/+39
Also add the method sw_CompareCellsByRowFirst into unotbl.hxx so that it can be used elsewhere, just like sw_CompareCellsByColFirst can. Change-Id: I4a88455ba73356013f9f630d07610825568c263c Reviewed-on: https://gerrit.libreoffice.org/25260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-23tdf#89329: use unique_ptr for pImpl in newXisco Fauli1-2/+2
Fix "error: declaration of ‘pImpl’ shadows a member of 'this' [-Werror=shadow]" too Change-Id: Ib0fc66375ed7d9ae700d5a81a2adb5975fcae592 Reviewed-on: https://gerrit.libreoffice.org/25319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin12-23/+6
Change-Id: I7113a13ac36db5beef3a17e9849c1f5506df2374 Reviewed-on: https://gerrit.libreoffice.org/25194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert HYPERDLG_EVENT to scoped enumNoel Grandin1-5/+5
Change-Id: I8a0248bb91ee67596aa44d11ca862d2e127a65ad Reviewed-on: https://gerrit.libreoffice.org/25197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert XOUTBMP to scoped enumNoel Grandin2-9/+9
Change-Id: I8d10cdc78ca73d86bdc9aa08fca591f6eb85eb9e Reviewed-on: https://gerrit.libreoffice.org/25196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin6-10/+13
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20Add test for checking the color of characters and paragraphsslideon1-8/+73
check_change_color.py only checked for page-related colors previously. Change-Id: I3b188db34c1f43ed6ed977f792615bb6646fbcce Reviewed-on: https://gerrit.libreoffice.org/25183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-19tdf#75757: remove inheritance on vector (SwTableBoxes)Bjoern Michaelsen10-45/+34
- move SwTableBoxes::GetPos(..) up to SwTableLine::GetBoxPos(..) - SwTableBoxes is empty over plain vector then, make it an alias Change-Id: I72420d4fe1042a713d3e82f3df66f18ccbfca3f6 Reviewed-on: https://gerrit.libreoffice.org/25166 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin12-24/+36
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19tdf#98985 create merge results at the right timeOliver Specht7-63/+89
When using mail merge toolbar the resulting documents are now created on OK in Save/Print and Send dialogs. Additionally the 'To' is set in the save dialog and the MailMergeConfigItem ist not deleted twice anymore. Change-Id: I21f1f49d8bbd40c11b6f771e15b89e0f6c4bc87a Reviewed-on: https://gerrit.libreoffice.org/25104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-05-19clang-tidy clang-analyzer-alpha.core.IdenticalExprNoel Grandin2-3/+2
Change-Id: I110d8d63d5a6657c18aba97227c046027eb8f7f4 Reviewed-on: https://gerrit.libreoffice.org/25086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18tdf#99935 Fix rulers visible stateMaxim Monastirsky1-2/+2
regression of 5e54d9e9bc856520808a446f20575e29a50d017b Change-Id: I7dd032a7bf29ce8387d880c103852846e743b2e7
2016-05-18tdf#82073 RTF import: handle \clcbpatrawMiklos Vajna2-0/+17
Quoting the RTF spec: "Same as \clcbpatN for use with table styles." Change-Id: Icdb89bac5b41036dadb1901f18aeb21ef2512908 Reviewed-on: https://gerrit.libreoffice.org/25077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-9/+7
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18sfx2 classification: add Type parameter to the UNO commandMiklos Vajna3-4/+12
So that sc/sd/sw doesn't have to hardcode SfxClassificationPolicyType::IntellectualProperty. Change-Id: Ib7c2376622ecaa8c7fc8401cec2ba16d12b8b8d2 Reviewed-on: https://gerrit.libreoffice.org/25078 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-18sfx2 classification: specify policy type when setting a categoryMiklos Vajna1-1/+1
This will allow specifying multiple categories for multiple policy types. Separate storage and .uno: command support is still missing, though. Change-Id: I47f6ac2e2b0ba2632b32349e4e004ffade05784a Reviewed-on: https://gerrit.libreoffice.org/25064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin12-46/+40
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17sfx2 classification: do not hardcode policy type in SfxClassificationParserMiklos Vajna1-6/+8
TSCP_BAILSv1 says: "{type} designates the type of a policy. In BAILS 1.0, the recognized string values are: ExportControl, NationalSecurity and IntellectualProperty" Previously {type} was always assumed to be IntellectualProperty. Change the parser to not hardcode the policy type anymore; also change the getter for the string constants to not contain this prefix. SfxClassificationHelper::Impl still doesn't support multiple policy types, though. Change-Id: If52b40577f1c5751dacb83617fb28862d9d5bdb3 Reviewed-on: https://gerrit.libreoffice.org/25055 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-17sw, writerfilter: indentation fixesMiklos Vajna3-4/+4
These files had a consistent style perviously, don't break that. Change-Id: I8d204e78463e7fe302a172a1af6ad3de51997977
2016-05-17loplugin:stringconstantTor Lillqvist1-1/+1
Change-Id: I3e45e701740f7d4a5698a0df319721bc596a8d94
2016-05-16 tdf#64748: added placeholder option to pdf export dialog in WriterOliver Specht4-7/+21
This patch introduces a setting 'Export placeholders' to File/Export as PDF. It works like the related printer setting. Change-Id: I3a11a4601b1244b57e55c9b73b58116d355e105c Reviewed-on: https://gerrit.libreoffice.org/24976 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-05-16convert VIEWOPT_1 to scoped enumNoel Grandin3-91/+93
Change-Id: I7294c55d455320cabb977df99af14832e48b4136
2016-05-16Convert VIEWOPT_2 to scoped enumNoel Grandin2-43/+48
Change-Id: I605d2fc11c00bce7012a1347fbe5408ac6800027
2016-05-16Convert VIEWOPT flags to scoped enumNoel Grandin5-58/+64
Change-Id: Ia89e397b98f118166737201623288c271d1639e7 Reviewed-on: https://gerrit.libreoffice.org/24952 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Fix typosAndrea Gelmini1-1/+1
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara3-1/+4
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-14tdf#99699 Do nullptr check BEFORE calling methodMichael Weghorn1-2/+3
This fixes a segmentation fault accidently introduced with commit a1fb4ac1991a8da2e527b64a0a01a88a8f2959e3. Change-Id: I244e325934db22e1bffd03486cc5e84f539101f2 Reviewed-on: https://gerrit.libreoffice.org/24994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-13more places we use other than end ellipsizeCaolán McNamara1-1/+1
Change-Id: I72b6cb29a8c32540309dcc20fbe5f66dd1a1b774
2016-05-13sw: document the MoveInvalidXAccToEnd() oddityMichael Stahl1-3/+5
Change-Id: I9e1e3b277a75a2f8c95fa71308af6aff7d81ccc7
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 00:12:39 +0000