summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2016-05-22Convert HYPERDLG_EVENT to scoped enumNoel Grandin1-5/+5
Change-Id: I8a0248bb91ee67596aa44d11ca862d2e127a65ad Reviewed-on: https://gerrit.libreoffice.org/25197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert XOUTBMP to scoped enumNoel Grandin2-9/+9
Change-Id: I8d10cdc78ca73d86bdc9aa08fca591f6eb85eb9e Reviewed-on: https://gerrit.libreoffice.org/25196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin6-10/+13
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20Add test for checking the color of characters and paragraphsslideon1-8/+73
check_change_color.py only checked for page-related colors previously. Change-Id: I3b188db34c1f43ed6ed977f792615bb6646fbcce Reviewed-on: https://gerrit.libreoffice.org/25183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-19tdf#75757: remove inheritance on vector (SwTableBoxes)Bjoern Michaelsen10-45/+34
- move SwTableBoxes::GetPos(..) up to SwTableLine::GetBoxPos(..) - SwTableBoxes is empty over plain vector then, make it an alias Change-Id: I72420d4fe1042a713d3e82f3df66f18ccbfca3f6 Reviewed-on: https://gerrit.libreoffice.org/25166 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin12-24/+36
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19tdf#98985 create merge results at the right timeOliver Specht7-63/+89
When using mail merge toolbar the resulting documents are now created on OK in Save/Print and Send dialogs. Additionally the 'To' is set in the save dialog and the MailMergeConfigItem ist not deleted twice anymore. Change-Id: I21f1f49d8bbd40c11b6f771e15b89e0f6c4bc87a Reviewed-on: https://gerrit.libreoffice.org/25104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-05-19clang-tidy clang-analyzer-alpha.core.IdenticalExprNoel Grandin2-3/+2
Change-Id: I110d8d63d5a6657c18aba97227c046027eb8f7f4 Reviewed-on: https://gerrit.libreoffice.org/25086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18tdf#99935 Fix rulers visible stateMaxim Monastirsky1-2/+2
regression of 5e54d9e9bc856520808a446f20575e29a50d017b Change-Id: I7dd032a7bf29ce8387d880c103852846e743b2e7
2016-05-18tdf#82073 RTF import: handle \clcbpatrawMiklos Vajna2-0/+17
Quoting the RTF spec: "Same as \clcbpatN for use with table styles." Change-Id: Icdb89bac5b41036dadb1901f18aeb21ef2512908 Reviewed-on: https://gerrit.libreoffice.org/25077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-9/+7
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18sfx2 classification: add Type parameter to the UNO commandMiklos Vajna3-4/+12
So that sc/sd/sw doesn't have to hardcode SfxClassificationPolicyType::IntellectualProperty. Change-Id: Ib7c2376622ecaa8c7fc8401cec2ba16d12b8b8d2 Reviewed-on: https://gerrit.libreoffice.org/25078 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-18sfx2 classification: specify policy type when setting a categoryMiklos Vajna1-1/+1
This will allow specifying multiple categories for multiple policy types. Separate storage and .uno: command support is still missing, though. Change-Id: I47f6ac2e2b0ba2632b32349e4e004ffade05784a Reviewed-on: https://gerrit.libreoffice.org/25064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin12-46/+40
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17sfx2 classification: do not hardcode policy type in SfxClassificationParserMiklos Vajna1-6/+8
TSCP_BAILSv1 says: "{type} designates the type of a policy. In BAILS 1.0, the recognized string values are: ExportControl, NationalSecurity and IntellectualProperty" Previously {type} was always assumed to be IntellectualProperty. Change the parser to not hardcode the policy type anymore; also change the getter for the string constants to not contain this prefix. SfxClassificationHelper::Impl still doesn't support multiple policy types, though. Change-Id: If52b40577f1c5751dacb83617fb28862d9d5bdb3 Reviewed-on: https://gerrit.libreoffice.org/25055 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-17sw, writerfilter: indentation fixesMiklos Vajna3-4/+4
These files had a consistent style perviously, don't break that. Change-Id: I8d204e78463e7fe302a172a1af6ad3de51997977
2016-05-17loplugin:stringconstantTor Lillqvist1-1/+1
Change-Id: I3e45e701740f7d4a5698a0df319721bc596a8d94
2016-05-16 tdf#64748: added placeholder option to pdf export dialog in WriterOliver Specht4-7/+21
This patch introduces a setting 'Export placeholders' to File/Export as PDF. It works like the related printer setting. Change-Id: I3a11a4601b1244b57e55c9b73b58116d355e105c Reviewed-on: https://gerrit.libreoffice.org/24976 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-05-16convert VIEWOPT_1 to scoped enumNoel Grandin3-91/+93
Change-Id: I7294c55d455320cabb977df99af14832e48b4136
2016-05-16Convert VIEWOPT_2 to scoped enumNoel Grandin2-43/+48
Change-Id: I605d2fc11c00bce7012a1347fbe5408ac6800027
2016-05-16Convert VIEWOPT flags to scoped enumNoel Grandin5-58/+64
Change-Id: Ia89e397b98f118166737201623288c271d1639e7 Reviewed-on: https://gerrit.libreoffice.org/24952 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Fix typosAndrea Gelmini1-1/+1
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara3-1/+4
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-14tdf#99699 Do nullptr check BEFORE calling methodMichael Weghorn1-2/+3
This fixes a segmentation fault accidently introduced with commit a1fb4ac1991a8da2e527b64a0a01a88a8f2959e3. Change-Id: I244e325934db22e1bffd03486cc5e84f539101f2 Reviewed-on: https://gerrit.libreoffice.org/24994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-13more places we use other than end ellipsizeCaolán McNamara1-1/+1
Change-Id: I72b6cb29a8c32540309dcc20fbe5f66dd1a1b774
2016-05-13sw: document the MoveInvalidXAccToEnd() oddityMichael Stahl1-3/+5
Change-Id: I9e1e3b277a75a2f8c95fa71308af6aff7d81ccc7
2016-05-13tdf#99722 sw: avoid buffering a11y events for not-visible framesMichael Stahl2-5/+13
The problem with the bugdoc is that all pages are moved by 60 twips or so in CheckViewLayout(), which generates a event for every SwTextFrame but there is no SwAccessible for the SwTextFrame yet hence it is a CHILD_POS_CHANGE on the parent, which happens to be (because SwPageFrames are not accessible) the SwRootFrame so that's how we get an enormous number (~90k per 500 pages) WeakReference in the buffered SwAccessibleEvent_Impl pointing to the same object (the SwAccessible of the root frame). Then at a later stage the events are actually sent and SwAccessibleContext::InvalidateChildPosOrSize() discards all but 80 or so that are on the first page. So check the visiblility before buffering the event, to avoid scalability issues in the WeakReference. This brings the cpu-time from 1:37 to 0:17 for the 500 pager, and the full bugdoc is now just 3-4 seconds slower than with a11y disabled. Change-Id: Ia91653fd7572f32ce3cf765a4ecd2b7077ace8f6
2016-05-13Resolves: tdf#99692 crash in SwPostItMgr with change trackingCaolán McNamara1-4/+7
and annotations presumably since the original commit 0761f81643a6890457e9ef7d913ab5c88c2593a4 Author: Oliver-Rainer Wittmann <orw@apache.org> Date: Thu Dec 19 18:50:58 2013 +0000 - rely annotations on text ranges on new annotation marks - support arbitrary text ranges for annotations - fix undo/redo regarding annotations an text ranges - support annotations on overlapping text ranges - fix *.docx import for annotations on overlapping text ranges - fix ODF import of annotations on text ranges Change-Id: If2aa4ba74f03d0af11def55c2bd299211b3d5d77
2016-05-13Convert VIEWOPT_CORE2 to scoped enumNoel Grandin2-24/+29
Change-Id: I2ceda4d350df56e2a70c47cec589d6e8427d2b0a Reviewed-on: https://gerrit.libreoffice.org/24956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13tdf#42949: clean up includes in include/oox/ole with iwyuJorenz Paragas1-0/+1
Change-Id: I9cbdc78b540b0f735c451ac561f0f0ccdaf7efbd Reviewed-on: https://gerrit.libreoffice.org/24911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13docxtablestyleexport: can pass the serializer by const refMiklos Vajna2-2/+2
Change-Id: I32409693ffefe753db5b7a5afc2fbec4030e5e93 Reviewed-on: https://gerrit.libreoffice.org/24950 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-13convert EXCHG_OUT_ACTION_FLAG to scoped enumNoel Grandin5-56/+59
and split it off into its own field and parameter Change-Id: Ib13dea5e9475a74cd66a0da4e5ec50a51fbda9d5 Reviewed-on: https://gerrit.libreoffice.org/24926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Fix wrong commentJulien Nabet1-2/+1
Change-Id: Idcb57eaa43c753bf4920787c5f342e1ac923ff3f Reviewed-on: https://gerrit.libreoffice.org/24939 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-13Convert ACT to scoped enumNoel Grandin10-68/+68
Change-Id: I68ec79c9c85abcd91da379eecf3ed4331a15861b
2016-05-13convert PROT to scoped enumNoel Grandin10-107/+116
Change-Id: I7aaa5c45a224d2f97861864bed00eaddb9b7f317
2016-05-13Typo: ExcecuteContextMenuAction->ExecuteContextMenuActionJulien Nabet3-5/+5
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c Reviewed-on: https://gerrit.libreoffice.org/24942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-12tdf#99722 sw: silly performance issue when firing a11y eventsMichael Stahl1-9/+4
SwAccessibleEventList_Impl::MoveInvalidXAccToEnd() pointlessly copies every single element when iterating over the list and then deletes the copy again (which is expensive due to the WeakReference member). This speeds up loading the first 500 pages of the bugdoc from 4:20 to 1:37 in a Linux dbgutil build. (regression from 76c549eb01dcb7b5bf28a271ce00e386f3d388ba) Change-Id: I7c7299e5e82095f5a51f395bc5076ca899b59f81
2016-05-12CppunitTest_sw_uwriter: fix loplugin:cppunitassertequals warningsMiklos Vajna2-70/+68
Change-Id: I535f28ff9307702e6070bfeaeb6e811d079e373e Reviewed-on: https://gerrit.libreoffice.org/24914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-12Massage code to avoid warningsStephan Bergmann1-3/+2
Change-Id: I51e982f7a1a2434f2e26621f9d26ee09136f38f7
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara8-42/+5
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-12Massage code to avoid warningsStephan Bergmann1-4/+4
Change-Id: Iec529b4750770c52aa0a746390ba272ce6390fb5
2016-05-12Replace comment with SAL_FALLTHROUGHStephan Bergmann1-1/+1
Change-Id: Iff490d06eaf73e0b55bfb7aa6c41b5fd3851ea44
2016-05-12clang-tidy modernize-loop-convert in swNoel Grandin141-684/+544
Change-Id: I1f4a0ad6658bd3154c48940296aa8edc1ea1612c Reviewed-on: https://gerrit.libreoffice.org/24876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin12-15/+15
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12Convert RulerType to scoped enumNoel Grandin2-9/+9
Change-Id: I2233b70e5413bfa3156011e1b3306d539003795b Reviewed-on: https://gerrit.libreoffice.org/24879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12Silence bogus GCC 5.3 -Werror=strict-overflowJulien Nabet1-0/+9
Thank you Stephan for the hint! Change-Id: I22b5a9c9e65297cba5a2894e46d2fee59825a045 Reviewed-on: https://gerrit.libreoffice.org/24900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-11Resolves: tdf#99464 set what parent the dialogs are dialogs forCaolán McNamara4-4/+6
With nullptr a parent is searched for and assigned (unless NoParent is set which means no parent) since... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. I believe an active menu is allowed as a parent (which I'll investigate and see if we can fix or revert that if necessary), but its good practice to explicitly set the right parent rather than depending on what happens to be on top anyway. Change-Id: I744f6d9bc133058a4a9db94d6c27d2e36e22179e
2016-05-11Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???"Stephan Bergmann4-0/+4
Would be great if people knowing about the respective code areas could look into these, and either change them into plain "SAL_FALLTHROUGH;" or "break;". Change-Id: I6bd5e04bbb84452bea57d10946522b456c2ad5f0
2016-05-11Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann5-1/+9
Change-Id: I4394a2e54da7c8a0e998db818211b0935b4cb1cd
2016-05-11SAL_FALLTHROUGH is intended hereStephan Bergmann1-0/+1
...given 8100100298b877765e1781fb0eed285e82749ad1 "fdo#80167 RTF export: don't loose page breaks" (and confirmed by Miklos on IRC) Change-Id: Ib70df00c565c5ec163fb13ead501d2100743d2dc
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-10 14:40:37 +0000