summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2014-11-14coverity#1242518 Arguments in wrong orderCaolán McNamara1-4/+4
doesn't actually matter, they are either the same number or one is 0 in which case it doesn't matter which is zero either Change-Id: If53d4287dfd57b4ce29e2f7251eb523694730e77
2014-11-14switch saxparser from expat to libxml2Luboš Luňák1-0/+1
Using SAX2 interface provides element/attribute names split into prefix/name, and provides namespaces/urls, so FastSaxParserImpl::callbackStartElement() does not have to figure out these on its own (and additionally libxml2 spends a noticeable portion in xmlStrdup() when not in SAX2 mode). The switch saves about 5-10% time. Change-Id: Idd424d7cc9b30c248179a5bad8ec79dbfc62e765
2014-11-14fdo#75757: remove inheritance to std::mapJuan Picca1-13/+51
Change-Id: I26ec60868c7854517b81ade3aec6b7ab29b0aa89 Reviewed-on: https://gerrit.libreoffice.org/12401 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2014-11-14coverity#982483 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I0e6db75e0c1dc5b26f2c251bdb4e37b5df8b3778
2014-11-14loplugin: cstylecastNoel Grandin30-362/+406
Change-Id: I7235a67e85c10ec9fefe7f718cda18f633cda97a
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava47-99/+101
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14Mark as constTakeshi Abe1-2/+2
Change-Id: I3236bbbdddf819afb11d8f80dd80c92a04281bf9
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl8-0/+8
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13coverity#1251590: fascinating what sort of nonsense works by accidentMichael Stahl1-1/+1
Change-Id: I23704604ed2d041075caff4254074e83ae229402
2014-11-13More HIG fixes for swAdolfo Jayme Barrientos13-645/+447
Change-Id: I7aa36de06b70da68625ed860b330fdcf62d48de5 Reviewed-on: https://gerrit.libreoffice.org/12400 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-13fdo#86252: Menu 'Merge Documents' is at wrong positionCor Nouws5-5/+10
Fixing a small mistake that slipped through with the many great improvements Change-Id: I252f2f05e6d624094507cc1f825faab5912e006e Reviewed-on: https://gerrit.libreoffice.org/12407 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-13fdo#75757: remove inheritance to std::mapJuan Picca1-18/+36
Change-Id: Ie42dd57c1d75987ed462aac152426665bf416178 Reviewed-on: https://gerrit.libreoffice.org/12385 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-11-13sw: delete global SwAutoCorrect instance to avoid crash...Michael Stahl1-0/+3
... in exit handlers because VCL and the SolarMutex is gone. (regression from 4404b718bdb547cb9b7b17c73a53574724cdeeb7) Change-Id: I9f33b2cb8c87f7137e3ba0ae033879861f9fe11b
2014-11-12Revert "coverity#735657 Division or modulo by float zero"Caolán McNamara1-1/+2
wrong name, and I intended to get an explicit review of this option This reverts commit c4f821f17cb8c970d1d8abd86a1f780250d96734. Change-Id: I743e79b8cc9493c259b88f50487ef06290ab7318
2014-11-12coverity#735657 Division or modulo by float zeroCaolán McNamara1-2/+1
or maybe this is closed to the original intent Change-Id: I0df98616de0b7612acc35e406d34ef9d56c8585c
2014-11-12fdo#80328: sw: fix inverted conditional in AutoCaption dialogMichael Stahl1-2/+2
(regression from af2d474ff9a91645043c1d4292891c313cceef5e) Change-Id: Ib22be881c82024e545752715bb9eeb2851a64f88
2014-11-12coverity#982189 Unchecked return valueCaolán McNamara2-22/+18
Change-Id: I6f5ef42b38236ea5f70ddbccfa25a81f2f3e976c
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini84-136/+136
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin2-14/+10
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12loplugin: cstylecastNoel Grandin5-63/+64
Change-Id: I8c840d6635f347dcb1b8d9d193a05d509ba6cacb
2014-11-12loplugin: cstylecastNoel Grandin11-51/+65
Change-Id: Ica3b54a7c331f0179294e2b52aadd884f53d53dc
2014-11-11fdo82708 Add missing tooltips to Writer StatusbarSamuel Mehrbrodt10-16/+121
Change-Id: Ie44b8de69b98ebfa789cc8f9a1d8a60b698fc154 Reviewed-on: https://gerrit.libreoffice.org/12368 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11coverity#1242754 Unused valueCaolán McNamara1-2/+1
Change-Id: I5e3d39b8f87e1496550c616928eab9166f624387 Reviewed-on: https://gerrit.libreoffice.org/12364 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-11fdo#85912 Delete surrounding text failing for input method calls regression.Justin Luth1-0/+3
When Apache OpenOffice code was merged in, a few lines were removed for no apparent reason. This just adds the code back in, and resolves the bug. See the comments in fdo#85912 for details about this bug. It is hard for majority language users to reproduce since they don't use ibus/kmfl to type their language's letters. Change-Id: I3963ea0f0eeeab8c8006408a7e229beab1ccf9f6 Reviewed-on: https://gerrit.libreoffice.org/12311 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-11callcatcher: dropping SwChapterNumRules binary Load/Store has knock-on effectCaolán McNamara7-23/+0
Change-Id: I2567026af23dd5fc42812b90bd6098c4c74a4f92
2014-11-11coverity#1130164 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I9d040b0a8862095ff7ac20b07642d60c17e54fce
2014-11-11fdo#86035 added menu items for shapes and text box and did small rearrangementYousuf Philips6-11/+23
Change-Id: If37446116dc4022d88e46af1af610bc70ce7db78 Reviewed-on: https://gerrit.libreoffice.org/12327 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11sw: remove silly assertion that copy constructor "succeeds"Michael Stahl1-14/+0
Change-Id: Ida31220457959d2ccc21ee2a723dd1ad16b2a502
2014-11-11iwyu: remove unneeded includes in sc, sd, swRiccardo Magliocchetti4-4/+0
Remove only include for files where iwyu does not suggest any includes to add. Change-Id: I58f3e956485ce058750c2635db9633736708d7f0 Reviewed-on: https://gerrit.libreoffice.org/12342 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Tested-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
2014-11-11Yet more nEndInvalid/COMPLETE_STRING fixesStephan Bergmann1-2/+4
...to fix -fsanitize=signed-integer-overflow Change-Id: I713dabd49b5a6085b2e40510540a20441f0c3541
2014-11-11Remove unused ShiftRightStephan Bergmann1-2/+0
Change-Id: I0405506b8dc61df023c01c4f0ae63926e3ea1769
2014-11-11More nEndInvalid/COMPLETE_STRING fixesStephan Bergmann2-2/+2
...to fix -fsanitize=signed-integer-overflow Change-Id: Ib8dad09f1ed088c51fb417efecf662e76b2e495a
2014-11-11sw: fix misleading log messageMichael Stahl1-1/+1
Change-Id: Iec87ed441ccdb03646fecaa8102a047c07a9b25d
2014-11-11fdo#39468 Translate German comments - sw/source/core/textPhilipp Weissenbacher5-235/+275
Change-Id: I8f94931ab8e55e8e330350c92251fa8737bfe730 Reviewed-on: https://gerrit.libreoffice.org/12308 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin6-9/+9
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10Resolves fdo#86008: fix a crash when open doc fileJulien Nabet1-1/+1
This was the only block, in this part of the code, which wasn't checking pSFlyPara->pFlyFmt Change-Id: Id467dd601a24ba46391544a79d4eecaf5370812c
2014-11-10Update nEndInvalid if it was COMPLETE_STRINGStephan Bergmann1-1/+1
Change-Id: I850c9083230f44daa722e7f51dbfa73efd088d25
2014-11-10Related: fdo#85111 put a box around xml filter settings controlCaolán McNamara2-6/+10
and writer->insert->table->autoformat and calc->data->consolidate and calc->insert->sheet Change-Id: I7c89d9f01747a00b906afe3c762b747df6872869
2014-11-10loplugin: cstylecastNoel Grandin8-64/+64
Change-Id: I4fbe7d35b66dda16f19019fd1baf0aa03361390c
2014-11-10loplugin: cstylecastNoel Grandin50-176/+180
Change-Id: If7ada4cba0b1098bba304f1ec9b860ec7df75e7a
2014-11-10loplugin: cstylecastNoel Grandin4-6/+6
Change-Id: I1f5823e34d400004ccafc0a6cd539d59929b14fa
2014-11-10loplugin: cstylecastNoel Grandin2-8/+9
Change-Id: I639ac26f4d84ff0a2d573d2e58bc5bd41052a925
2014-11-10loplugin: cstylecastNoel Grandin12-53/+69
Change-Id: Ie57f543681790e662f6ac7d074ccb37925999790
2014-11-10sw: disable failing c&p test on headless buildRiccardo Magliocchetti1-1/+1
Change-Id: If9c3aad600332ae289e05e3b046f8b15292dee57 Reviewed-on: https://gerrit.libreoffice.org/12301 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Tested-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
2014-11-10602 regression testCaolán McNamara6-0/+647
Change-Id: I044b9b445a7911e77424613145c7e4d152789f44
2014-11-10coverity#1242522 silence Arguments in wrong orderCaolán McNamara1-1/+3
Change-Id: I248a99b1c0755c54d4f7dbdd291f382d7d99b9ce
2014-11-10coverity#1000853 Uncaught exceptionCaolán McNamara1-1/+12
Change-Id: Id55768822a6a932dace1e30cb03175880ba3ca6a
2014-11-10Fix build.Jan Holesovsky1-5/+4
Change-Id: I91599766e607b26d2c71006c9543a2bd952e228a
2014-11-09avoid unused argument warningLuboš Luňák1-0/+2
Change-Id: Ib67b804423b521407710f8319cb89977e44494cc
2014-11-09speed up SwDoc::IsInHeaderFooter() by using SwFrmFmtAnchorMapLuboš Luňák1-21/+23
Now that it's possible to quickly find anchored objects for a node, it's actually faster to check the node hiearchy rather than layout. Change-Id: I5f93d5af32c744f1773535e5ec8537334d1ff58a