path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2016-08-18screenshots: add new global make targetArmin Le Grand1-4/+5
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: fix Linux, exclude a few crashing dialogsArmin Le Grand1-1/+1
Change-Id: Ie06bb6b0bfd280e386bc418abdc496cb747f44b6
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand3-76/+7
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for svxArmin Le Grand2-228/+193
All *.ui files create a screenshot, but not all look useful Change-Id: I5aeec438b90488ea19cdb1251fee7dcf23e1c2cb
2016-08-18screenshots: add dialog test cases for writerArmin Le Grand5-2/+470
Writer has currently no known dialogs that get created with an opened writer document. There are some ui files that do not work with fallback (7), but most work (167). Not all look good, though. Change-Id: I92a6a5077e3a8c93148e162455093399ba1f99ed
2016-08-17Resolves: tdf#101245 doc(x) protected areas not protected with disabled cursorMartin Nathansen1-1/+4
Protected areas of imported doc(x) documents are now protected even when the “enable cursor” option is disabled: It is still possible to set the cursor into the protected area, but the text is not editable anymore. Change-Id: If45dfc82fb7cc70e0a6569a9d735eafcafda9bc2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Oliver Specht <>
2016-08-17Drop some iOS-only code that seems unnecessary and in fact crashes nowTor Lillqvist1-8/+0
Change-Id: I146e340548830c18bc6737a723e0b4d3a684d1c9
2016-08-17sw: allow accept/reject of redline by indexMiklos Vajna3-3/+52
Previously .uno:AcceptTrackedChange / .uno:RejectTrackedChange always worked by cursor position, but redlines are stored in the redline table, so they have a unique index. Allow specifying that index when invoking the command, and in that case ignore the cursor position. The index is not stable after an insertion / deletion. Change-Id: I493a22e84800ded224fb6b9c61261744dc0fb64f Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-17tdf#95292 MM: add unit testJan-Marek Glogowski3-23/+91
bEndOfDB was handled inconsistently in ToNextRecord for record selections and normal record iteration. This unit test checks mail merge to generate the correct amount of three pages (actually five with the hidden, empty pages) for a five record data subset, mailing a linked label document with two labels. Previously the third / last page was missing. On Windows, this test originally failed, because the test document for synced labels opens the "synchronize" dialog, which is generated from an UI file, which are missing in the default test configuration. So this patch also switches the mail merge unit test to the "instdir configuration", which has locking enabled and prevents opening a documents twice. As a result we can't use a document for two test and have to load the source document for inspection after the UNO mail merge call, because it can just work with a file name as the source document. This way the document isn't opened twice, and the tests still pass on Windows. Change-Id: I98b33defc403c40b84af44d91ed7fdcf6cf347a3 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jan-Marek Glogowski <>
2016-08-17Use full absolute URL in footer-contain-hyperlink.docxStephan Bergmann1-0/+0
What this binary change does is change in the contained word/_rels/footer1.xml.rels from Target="" to Target="" because of: <sberg> vmiklos, do you know how sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx (introduced with 4654e9b113a66c800161d0ee82d587055fff4f8b ["fdo#74271: Added unit test & code changes for footer contains hyperlink."]) was created? It contains a word/_rels/footer1.xml.rels with a <Relationship Id="rId1" Type="" Target="" TargetMode="External"/>, where that Target="" is not a proper URL, but the testFooterContainHyper link test in sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx expects it to end up as "" <vmiklos> sberg: [...] that sounds like a bug, MSO resolves that as a regular relative file reference, i.e. to file:///...\ooxmlexport\data\ <sberg> vmiklos, ah, that's good to know; I'm trying to fix tdf#86087 ["FILESAVE FILEOPEN VIEWING: Can't open or save relative links in docx"] by turning relative URLs into absolute ones when reading docx etc. in writerfilter/source/dmapper/DomainMapper_Impl.cxx, but that now caused that test to fail <sberg> vmiklos, so I guess it's best to modify sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx to contain <> instead of merely <> <vmiklos> sberg: yes, i think so Change-Id: I7986acb66f260faaf8fe5398f3778cc35fb9930d
2016-08-17GSoC notebookbar: BigToolBoxSzymon Kłos1-24/+29
+ New container: sfxlo-BigToolBox + Writer: Paste button with dropdown menu Change-Id: I8fa9ff2cbf594078cc2347bef790b8647ce4e6ea Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Samuel Mehrbrodt <>
2016-08-17convert SvXMLGraphicHelperMode to scoped enumNoel Grandin4-4/+4
Change-Id: Ib0360b395fafe3c8123a0cc0fd0cbfd581fa5414
2016-08-17convert SvxEscapement to scoped enumNoel Grandin6-37/+37
and fix a potential bug with footnotes and superscripts in writer in ndtxt.cxx, where it was passing bad args to the SvxEscapementItem constructor Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
2016-08-17convert SvxTabAdjust to scoped enumNoel Grandin25-73/+73
Change-Id: I29a33b8ea5daaa4b9059d024ffa4a99ca924f7ef
2016-08-17convert SvxLineSpace to scoped enumNoel Grandin9-27/+27
and rename to be more explicit Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
2016-08-17convert SvxInterLineSpaceRule to scoped enumNoel Grandin12-28/+28
and rename it to be more explicit Change-Id: I3f8bd7928495dba1e94b785cdda06d9819ee66bf
2016-08-17convert SvxSpecialLineSpace to scoped enumNoel Grandin2-6/+6
And move it inside editeng, since it's not really used anywhere else. And fix a bunch of places that were incorrectly calling the constructor with the enum. Change-Id: I74e8ab8bcf315eb5ad0720e74d04a450f0a3e5c9
2016-08-17convert SvxBreak to scoped enumNoel Grandin30-109/+109
Change-Id: If8b79ed617e5662550bd73bd1506d047217f2313
2016-08-17loplugin:unusedenumvalues in swNoel Grandin11-87/+13
Change-Id: Ia5faa65cd7824183cead2634edab96b5d23a6c02 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-08-16LOK unit tests: document what is a view callbackMiklos Vajna1-0/+1
Change-Id: Ic605ca12cebfb6fd8239829942bbc6a70f45ac06 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-16GSoC notebookbar: icon size switchingSzymon Kłos1-41/+41
+ added entry in the Options > View + changed sfxlo-SidebarToolBox to sfxlo-NotebookbarToolBox in the Notebookbar ui files Change-Id: Id5719953be9830b650af96d54e63936c553cda74 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Samuel Mehrbrodt <>
2016-08-16editeng: introduce OutlinerViewShell::NotifyOtherViews()Miklos Vajna1-0/+43
This allows notifying other views about e.g. cursor position changes even if SfxLokHelper::notifyOtherViews() is not accessible from editeng. Change-Id: I921e97344ffe562109a221f241e70b3f68ee9aaf Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-16tdf#100507 RTF import: don't set default para style to the 0th char styleMiklos Vajna2-0/+28
Regression from commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), the problem was that the RTF_PARD handler wanted to set a default paragraph style, but it didn't check if the 0th style is actually a paragraph one. This resulted in using a character style name as a paragraph one, throwing in SwUnoCursorHelper::SetTextFormatColl() -> all paragraph properties were lost, including the left indent. Fix this by tracking the style type, and filtering out character styles when looking up a default paragraph style. Change-Id: I41faab0e72667b89ec9a507014b395a675847abf
2016-08-16GSoC Writer Table Styles; Update by exampleJakub Trzebiatowski10-7/+127
+ Added possibility to update style by example. + Fixed SwTableAutoFormat::GetBoxFormat Change-Id: I80d9334ceda0ef7e0984fb54731850034b44cd44 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Miklos Vajna <>
2016-08-16loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I73fae0d8a7859690b5bc2876f544d812c808dc8e
2016-08-16GSoC notebookbar: multiple .ui implementationsSzymon Kłos4-2/+146
+ added menu controller for .uno:Notebookbar showing all implementations + switching between .ui files + officecfg stores implementation description + added second implementation file notebookbar_groups.ui Change-Id: I9f406daced7a111793f61a2e9f939cba27d92184 Reviewed-on: Reviewed-by: Samuel Mehrbrodt <> Tested-by: Samuel Mehrbrodt <>
2016-08-16new loplugin to check for static OUStringsNoel Grandin1-8/+8
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-08-16tdf#44282 fix missing space for numbered lists in TOCAbhilash Singh1-0/+4
Change-Id: I6baa6c775ac6142e4ba4197ce4d164628ef0ba1e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: jan iversen <>
2016-08-15sw lok: limit undo/redo in SwDrawTextShellMiklos Vajna5-3/+106
So that one view can only undo/redo its own changes. This is used when editing shape text, as that doesn't use sw::UndoManager::GetLastUndoInfo(). Change-Id: Ibc3d6fcbd18398569190f06ed9b7399c54bb7d41
2016-08-15sw: prefix members of SwPagePreviewMiklos Vajna2-145/+145
Change-Id: Ied4c8aa5ead971d7a373ae580cd7bbe6df1859f8
2016-08-15convert SvxSpellArea to scoped enumNoel Grandin3-15/+15
Change-Id: I91d3caabb667e7d4ff23e603026e072074058712
2016-08-15Related: tdf#87686 on refresh from selection, only consider the edit updatedCaolán McNamara1-1/+3
not the category list, which re-guesses the keys. So user input keys remain the same on resync Change-Id: I75a069bb3e828f8d5910f36996c6538c4cde4431
2016-08-15convert SvxCompareMode to scoped enumNoel Grandin6-23/+31
and move it to SW since it is only used there Change-Id: I9cc7869564e24a8ce733f30ef453751a854cf7e0
2016-08-15tdf#100782 have XPropertyList hold unique_ptrJochen Nitschke4-4/+4
Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-08-15tdf#97090 writerfilter - don't fill_SOLID with auto colorJustin Luth2-0/+18
fixes a regression from 24077b2d52ab3d0fd0db5afb25d8b94b62386e3e <w:shd w:val="clear" w:color="auto" w:fill="auto"> seems to be the default "fill disabled" state, so don't force a solid white fill in that case. Change-Id: Ia421e52e228bbf0d3a2cd9af72e0a580042e5dcd Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>
2016-08-15tdf#92218 Another round of tweaks to single toolbar modeYousuf Philips1-2/+10
Change-Id: I685687df630fe1905f18476be8c0266546048ceb Reviewed-on: Reviewed-by: Yousuf Philips <> Tested-by: Yousuf Philips <>
2016-08-13tdf#83054 Remove help button from go to page dialogYousuf Philips1-17/+3
Change-Id: I52922b7029191a45b43579cd8b90f6245a1db19f Reviewed-on: Reviewed-by: Akshay Deep <> Tested-by: Akshay Deep <>
2016-08-13tdf#83830 Change 'Margin' to 'Margins' in Page Format PanelSusobhan Ghosh1-31/+7
Change-Id: I4f47f113705d0841aa1acfc6d273a97843f05ef7 Reviewed-on: Reviewed-by: Yousuf Philips <> Tested-by: Yousuf Philips <>
2016-08-13tdf#83830: Tweaks to page header and footer panelsSusobhan Ghosh2-51/+42
Change-Id: I79b92b39ec1448a662463fb2dcf68fc71509edfb Reviewed-on: Reviewed-by: Yousuf Philips <> Tested-by: Yousuf Philips <>
2016-08-12tdf#91832: ensure GETLINK reports proper contents for reverse selections tooBjoern Michaelsen1-0/+5
Change-Id: I4e77a55de012b5edd0d922b5e534e4dd6bb714b6 Reviewed-on: Reviewed-by: Björn Michaelsen <> Tested-by: Björn Michaelsen <>
2016-08-12add CVE-2016-3133 testcaseCaolán McNamara1-0/+0
Change-Id: Id147f208ff9db1cfdf3859df7090d0790a0e6400
2016-08-12Resolves: tdf#87686 don't refresh index entry from selection on regain focusCaolán McNamara3-35/+53
Remain populating it from the initial selection on popup, but on losing focus and regaining it, leave the contents alone. Provide a refresh button to provide access to optionally updating the contents from the document selection. Change-Id: Ifcde5fac341655f1219f4d2a7057e788d3bb0b18
2016-08-12Tweaks to page deck footer content panelYousuf Philips1-44/+33
Change-Id: Iba59edf038d802530d3758915479dbf19a75e8ca Reviewed-on: Reviewed-by: Yousuf Philips <> Tested-by: Yousuf Philips <>
2016-08-12loplugin:unusedenumconstants in package..svtoolsNoel Grandin3-3/+0
Change-Id: I8136b93b9303ebecafd791159e813c335b1bc172 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-08-11Add more shapes to Insert > Shapes menuYousuf Philips1-0/+4
Change-Id: I58a476199047ab08c74803a560ba63357b77db38 Reviewed-on: Reviewed-by: Yousuf Philips <> Tested-by: Yousuf Philips <>
2016-08-11tdf#96015 (part) links to Askbot in the Help menuOlivier Hallot6-0/+6
Add the entry "~Get help online" to the modules Help menu. on click, the system browser opens<lang> <lang> is obtained from .getLocale() That in turn will redirect to e.g. askbot (but only few languages are using it at the moment) or other nl-specific resources. (nl-projects can request corresponding targets from infa, without the need to change the code – cf rdm#1983) The link can/should be extended to also include the version of LO and the currently used module to allow finer grained redirects. Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56 Reviewed-on: Reviewed-by: Christian Lohmaier <> Tested-by: Christian Lohmaier <>
2016-08-11Notebookbar: Tweaks to the home tabYousuf Philips1-1/+14
Change-Id: Id08b4d579b676ed16b7f7a2d8a20ca8d250cb7a4 Reviewed-on: Reviewed-by: Szymon Kłos <> Tested-by: Szymon Kłos <>
2016-08-10GSoC notebookbar: changed labelsSzymon Kłos1-14/+0
Change-Id: I824e7b871edb9506a25ca7918431bf917e237709
2016-08-10sw undo: add a Repair argument to the .uno:Undo/Redo commandsMiklos Vajna5-3/+79
Undo/redo is limited to undo actions created by the same view in the LOK case, this argument removes this limit. This can be used by a client for "document repair" purposes, where undo/redo of others' changes is intentional. The sfx command dispatch has support for FASTCALL slots (a state function is not called, the command is always enabled) and also has support for state functions, but those functions only get the ID of the slots, not its parameters. What is needed here is a command that's disabled by default, but in case a Repair argument is used, then it's unconditionally enabled. So handle that case in the sfx dispatcher directly for now. Change-Id: I96c1130bf51abcdd722684b1fa4a8277f92fd555
2016-08-10sfx2: make SfxLokHelper::setView() set also the active frameMiklos Vajna1-0/+37
Without this, comphelper::dispatchCommand() doesn't work on the current frame. This causes e.g. undo not working when only a given view is allowed to do undo. In the desktop case vcl::Window::ImplGrabFocus() calls both SfxViewFrame::MakeActive_Impl() and framework::Desktop::setActiveFrame(), but in the LOK case the first was called directly, that's how the active frame was outdated. Change-Id: If97a9de316b4c8dd49e55cd273bdb2dfe9866f38 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>