summaryrefslogtreecommitdiff
path: root/sw/source/uibase
AgeCommit message (Collapse)AuthorFilesLines
2016-09-13Revert "tdf#73797 Enable object rotation (.uno:ToggleObjectRotateMode) for ↵jan iversen2-10/+10
writer" This reverts commit 594182ce7c2551dd1d13a014cfdfd96a057e63de. Change-Id: Idf2580e84d4190ba0aaba1a3394a4318043da458 Reviewed-on: https://gerrit.libreoffice.org/28858 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist1-1/+0
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-13avoid crash with nullptr accessMarkus Mohrhard1-1/+1
e.g. http://crashreport.libreoffice.org/stats/crash_details/7d19c6e6-19cb-4ba0-a51f-7b7eef514ae1 Change-Id: I97c9da78bc30b730843753da677574ae247cb430 Reviewed-on: https://gerrit.libreoffice.org/28853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-12Page size popup converted to use outside sidebarSzymon Kłos8-272/+145
Change-Id: Ia9c4c03a9780dca146adda8f1a126197d3e38643 Reviewed-on: https://gerrit.libreoffice.org/28816 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-12sw: implement SdrMarkView::GetSfxViewShell() APIMiklos Vajna1-1/+1
With this, the graphic selection is no longer lost when creating a new view. That happened as the SwView ctor calls SdrMarkView::SetMarkHandles() while the new view is not yet current, which resulted clearing the graphic selection in the old view, not in the new one. A side-effect of introducing SwDrawView::GetSfxViewShell() is that now SwView::getPart() is called from the SwView dtor, guard against doing any real work there in that situation to avoid potentially reading already deleted data. Change-Id: I4fab39a907d2cbe228c0fc8d44bedc64893387d1 Reviewed-on: https://gerrit.libreoffice.org/28832 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-10tdf#73797 Enable object rotation (.uno:ToggleObjectRotateMode) for writerGulsah Kose2-10/+10
Change-Id: Ida868d0fc077d6697a0c3754b1add6a48c5d426c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/27995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-09-09loplugin:constantparam in sfx2Noel Grandin1-3/+3
Change-Id: If5d401001abb7bf3fc642d47f537b57836e6d9c5 Reviewed-on: https://gerrit.libreoffice.org/28772 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09loplugin:constantparam in svxNoel Grandin3-8/+7
Change-Id: Id08850b90a0e286ff837dd6b0c1691fa7dc793fa Reviewed-on: https://gerrit.libreoffice.org/28746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-08loplugin:constantparam in swNoel Grandin5-19/+15
Change-Id: Ibae4cac28e6ff52298c804519f683017729c07a5
2016-09-08loplugin:constantparam in swNoel Grandin15-33/+24
Change-Id: Ic49d1c3c7b57fb213964ddc21b0f774c762aad94
2016-09-08convert nsRedlineMode_t to typed_flagsNoel Grandin9-55/+53
including fixing a bug in SwXMLExport::exportDoc where it was ORing with a constant from a different type: nsRedlineType_t::REDLINE_INSERT Change-Id: I2bb154c9a35d106e64fd1a8b6e928d0384c9fafe
2016-09-07Make PageColumnPopup Dropdown-onlySamuel Mehrbrodt1-1/+1
Change-Id: I69d8fd528238548521f1e201a19d1681c4ee3ec1
2016-09-07Make PageOrientationPopup Dropdown-onlySamuel Mehrbrodt1-1/+1
Change-Id: I48b119e2bc7571ccaa609e7a8cef7eb4ad8aeb0f
2016-09-07Page column popup converted to use outside the sidebarSzymon Kłos8-225/+126
Change-Id: Iedb239eba5d74d10cef68276c2a03028f8cf81bf Reviewed-on: https://gerrit.libreoffice.org/28703 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07tdf#90597 Revert "Jump to next change when accepting or rejecting a change"Samuel Mehrbrodt1-2/+0
This reverts commit 1deaa9d304239b2d603cc85bbcb8b8f50d8714da. Change-Id: I4718ffea3f288b654cb037a5edbfa66f704a6eb5
2016-09-07Do not change the OBJ_CAPTION code pathMaxim Monastirsky1-9/+10
(and fix static method call) Change-Id: I5a73695eaa8b6b5b3506acd34b303dea28cfb5e5
2016-09-07tdf#101390 Add Arrows toolbox functions on writer drawingbar.Gulsah Kose3-6/+40
Writer arrows toolbox includes following commands .uno:LineArrowEnd .uno:LineCircleArrow .uno:LineSquareArrow .uno:LineArrows .uno:LineArrowStart .uno:LineArrowCircle .uno:LineArrowSquare .uno:Line Change-Id: I91af27826ea411eabfa61c11962cfb85d2d2aab2 Reviewed-on: https://gerrit.libreoffice.org/28363 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2016-09-07loplugin:constantparam in swNoel Grandin18-72/+66
Change-Id: I16badc615e98202668b1b201035b5137cb94c10c
2016-09-05Page orientation popup converted to use outside sidebarSzymon Kłos9-193/+221
* popup converted to .ui file * added .uno:Orientation * label & icon for .uno:Orientation * control inserted to the notebookbar.ui (Page layout tab) Change-Id: I93f35a65c4461635d0cfd1afd4546a9d2a8c4d04 Reviewed-on: https://gerrit.libreoffice.org/28405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-05convert Orientation to scoped enumNoel Grandin1-2/+2
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05convert ScrollType to scoped enumNoel Grandin2-4/+4
Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
2016-09-05convert GradientStyle to scoped enumNoel Grandin2-4/+4
Change-Id: Ib740da708612df7a5f4b8c82262b9b1bd436604d
2016-09-05convert RasterOp to scoped enumNoel Grandin1-1/+1
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-02tdf#76349 SpacingWithoutBorders: enable .doc RTJustin Luth1-0/+13
Microsoft allows spacing in textboxes even if the borders are not shown, but LO does not. Added a compatible setting, used an existing setting to allow the spacing, and changed .doc export not to zero out the spacing if the border was zero-width. Using the compatible setting in the export code is almost redundant, but it does require that the document was LOADED as .doc, and not "save as" from another format. This patch simply allows round-tripping - any user attempt to modify the border settings will enforce normal LO border rules. Change-Id: I60ac036e1bfac381eea15e33c21495ad3800277a Reviewed-on: https://gerrit.libreoffice.org/28601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-01tdf#101361: Fix cursor key movement in RTL textKhaled Hosny1-0/+7
Revert "tdf#32531 Fix for key movement in table cell of different directionality" This reverts commit a215cec969f7401b08cabb686c5b2b1d803399d0. This seems like the wrong fix for the original issue, as it breaks how “visual” cursor movement works in RTL text.
2016-09-01Hide/Disable the Page property Panel for WriterSusobhan Ghosh1-11/+1
Change-Id: I3d8769f59811863ab38abeaefb289213d2c37570 Reviewed-on: https://gerrit.libreoffice.org/28379 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-08-31let's make Impress crash less - SfxStyleFamily editionMichael Stahl1-1/+1
Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to introducing the enum SfxStyleFamily - inconsistently converted one call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily instead of a mysterious "5", but did not adapt all of the code that extracts the SfxUInt16Item that subsequently extracts this value and expects a number 0-5. Since it's clearly inexcusably stupid to have 2 different public sets of integers identifying styles, make the usage of the second "array index" integers private to templdlg.cxx; the SfxUInt16 item now always contains enum SfxStyleFamily. (regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e) Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201
2016-08-31sfx2 lok: introduce SfxViewShell::NotifyCursor()Miklos Vajna1-0/+5
It allows removing the hide/show cursor hack in SfxViewShell::registerLibreOfficeKitViewCallback() introduced in commit 4d211384f048b689f20e46d4d586f342b110cb5c (sfx2 lok: fix missing view cursors in a new view, 2016-06-20), and instead let the application code in sw/sc/sd implement the best way to show existing cursors in a new view. This way the per-app cleanup of view cursors introduced in commit bc9b4fd4c83af3532204237157821d4884c42d8e (lok::Document::destroyView: clean up view cursors/selections, 2016-07-15) has matching per-app init code. This commit just adds the API + adapts existing sw code to use it, sc/sd still has to be implemented. Based on a patch by Marco Cecchetti, thanks! Change-Id: I38510fa4962f405b1b96a79024206c9e7f33cad2 Reviewed-on: https://gerrit.libreoffice.org/28557 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-31convert SW_SERVICE constants to scoped enumNoel Grandin1-2/+2
Change-Id: I731d93f9ab77e60880365c8e2f5e62221d8da5ad
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin1-6/+6
Change-Id: I7c202c6bff8ed405817ea1e7feb4a2c6427825ad
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin3-6/+6
Change-Id: I913a6be200b78790f465d2672d6da22a3b8d2b73
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin1-6/+6
Change-Id: Ibcfac031bb0891b4849dc48904893bb891887788
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin6-13/+13
Change-Id: I81055c6973247e226dc9dc3fda072aef94fa8966
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin5-19/+19
Change-Id: I542a5fb00a5c972230c072d72a745fddb095f708
2016-08-31convert FindRanges to o3tl::typed_flags_setNoel Grandin4-20/+22
Change-Id: I745b2f469e44b79a06a18bc5264aae75b096835c
2016-08-31convert SwDocPositions to scoped enumNoel Grandin5-43/+43
Change-Id: Idd9414b4a10398130337e474fb8fd4063e3bd4f8
2016-08-31Get rid of a pointless indirect function pointer variableNoel Grandin1-6/+6
Change-Id: If6847f55e6a09970375998b6eee82ddefaf3eaed
2016-08-30tdf#76349 writer: make 1column-as-page break a compatibility optionJustin Luth1-0/+13
Unable to find/create a proof .doc document, so only implementing this for .docx Change-Id: I3a0cb2ddf7b3aeecc9200e595f70d8c88af4b122 Reviewed-on: https://gerrit.libreoffice.org/28501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-30rework for coverity#1371269 Missing move assignment operatorCaolán McNamara2-19/+16
Change-Id: I10f9ed448854b4ece61fd84b8aa49674d0828cac
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (sw)Stephan Bergmann7-9/+9
Change-Id: Ifa1a6bafd3628b48ebceb09f8cd864361848e81c
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann14-38/+38
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29sw: use SwModule::GetRedlineAuthor() in SwTextShell::ExecField()Miklos Vajna1-4/+3
This avoids some code duplication, and also means that the redline author set by SwDocShell::SetView() affects the inserted Writer comments as well, while those were 'Unknown Author' in the LOK case. Change-Id: Ib51183302ee6904fdf69fb16f27ecfe6df39e6cb
2016-08-29tdf#83830: Use samecontentlistbox in Header/Footer PanelSusobhan Ghosh2-2/+4
Change-Id: Ib24f6e6ac91859467f105c4db9b094454443ff9d Reviewed-on: https://gerrit.libreoffice.org/28218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-08-29Get rid of a pointless indirect function pointer variableTor Lillqvist4-16/+16
Sure, lots of them left. And actually, I don't know, maybe there is some deeper reason why such are used in the sw coding style. Feel free to revert these commits. Change-Id: I5a1c31fe32b3bdf6d40489d029be165c38a8ba05
2016-08-29Get rid of pointless indirect function pointer variablesTor Lillqvist2-3/+3
Change-Id: Ic8eddec51d59b531ae22421b796a148267b9f3c1
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann9-39/+31
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-29MM don't keep undo informationJan-Marek Glogowski1-0/+3
Doen't make much sense to store undo information for all merge based progress. Actually it even prevents crahes when undoing a merged ODT document. Change-Id: Ic3a3982f3e5eb4f6de9f027a6a5e376c2833e8a5
2016-08-29MM block idle-handling of generated documentsJan-Marek Glogowski1-0/+2
We don't need any background idle jobs for the generated documents, like spell checking, statistics etc. This can be done when (or even if) the document is presented to the user as a background task. Change-Id: I4c72ed6e0d2f90d43e7f04cd0ea4418cbffe1206
2016-08-29Add SAL_INFOs to dump the SwPageFrame lifecycleJan-Marek Glogowski1-0/+2
Debug area name is "sw.pageframe". Change-Id: I136cc8192137a8c682900a6ce2c557f6b6b3a6cd
2016-08-29Add convenience function getOtherTextBoxFormatJan-Marek Glogowski1-6/+5
Since we already have isTextBox to identify a text box, this just adds a call to SwFrameFormat::GetOtherTextBoxFormat() to actually return the corresponding SwFrameFormat. This gets rid off all the remaining occurences of the SwFrameFormat / Textbox sets and maps. Change-Id: Id5f05a1ff71e604658e7d8a0d0825f5671335b3f
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 19:30:42 +0000