Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: If2ecee5c0e97c3955cffe4eb23d2bf651ec4ef2a
|
|
Change-Id: Ifb578244d511af153484d14ee92c5c22c2db0a3f
|
|
Change-Id: I67d8408d410698f0f31738fcc30321c627307c73
|
|
Change-Id: If814b6873796fcfa4cc7a2f62711a8b20f2f7d6b
|
|
Change-Id: I687161aa9295a1b815d11dd10fa83d23b010764a
|
|
Change-Id: If06321f5b353a09985d071290ece612fb98b34a1
|
|
Change-Id: I478eb10315ee0709c43943945d500b82a8d9c8c9
|
|
Change-Id: I368b2a6a6b5c54a962fed637c7e8cd472414be5c
|
|
Change-Id: I306ca1b20af83519f81ca0867eb73cbbaa1874d2
|
|
Change-Id: I53c3f97d35621af9b6c5c0336b8c998d3fe0b270
|
|
Change-Id: I0e7e8309c5d8873b9bde738a00579989d7b105fb
|
|
Change-Id: I0582734a0995638f45888e32c108e56ab3f28e80
|
|
Change-Id: Ic413e08bbaf38a6858926b1309618762a9ed1444
|
|
Change-Id: Icc7c58e847a4087460a86686c790722e6651c85a
|
|
Change-Id: Icfcb4320aef9ebe2c5fcc84106de005934d51a3f
|
|
Change-Id: I136822a0ad581d1490fc6f8842c95f2d25dfeba4
|
|
when it works the way we want it to work, so presumably we can cut out the
middle man and use getDocumentBaseURL directly which does the same thing.
This has the advantage of being in the IEmbeddedHelper api so assignFrom can be
tweaked to pull the src and dest ids arguments to CopyAndGetEmbeddedObject from
the src and dest IEmbeddedHelpers always available there. So we ensure we
have some ids to present to CopyAndGetEmbeddedObject, avoiding the assert
on converting documents such as ooo89433-1.ppt to pdf
So the explicit args can apparently be dropped, bubbling up then means we don't
need a CloneWithShellIDs (introduced with tdf#71076 and tdf#71767) as normal
Clone should now do the right thing.
And various other arguments in various callers of these, which are typically
filled in with an unhelpful empty OUString placeholder, can go
Change-Id: I9c0be0340e72f98b10ee87ada7d2a021fcc39e23
|
|
...as reported by UBSan in CppunitTest_sw_filters_test:
> /sw/inc/format.hxx:110:73: runtime error: downcast of address 0x2af2d8024000 which does not point to an object of type 'const SwFormat'
> 0x2af2d8024000: note: object is of type 'SwModify'
> f2 2a 00 00 70 33 2f 87 f2 2a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> ^~~~~~~~~~~~~~~~~~~~~~~
> vptr for 'SwModify'
> #0 0x2af27bbe8083 in SwFormat::DerivedFrom() const /sw/inc/format.hxx:110:73
> #1 0x2af27bbc8401 in SwFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/format.cxx:282:21
> #2 0x2af27e9934a3 in SwFrameFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/layout/atrfrm.cxx:2597:5
> #3 0x2af27f8207d5 in SwTableBoxFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/table/swtable.cxx:2353:5
> #4 0x2af27bb9cd52 in SwClient::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:68:9
> #5 0x2af27bba4bee in SwModify::CallSwClientNotify(SfxHint const&) const /sw/inc/calbck.hxx:349:9
> #6 0x2af27bba290b in SwModify::ModifyBroadcast(SfxPoolItem const*, SfxPoolItem const*) /sw/inc/calbck.hxx:173:11
> #7 0x2af27bb9fbc0 in SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/calbck.cxx:143:5
> #8 0x2af27bb9e0e7 in SwModify::~SwModify() /sw/source/core/attr/calbck.cxx:101:5
> #9 0x2af27bbc6bb4 in SwFormat::~SwFormat() /sw/source/core/attr/format.cxx:251:1
> #10 0x2af27e98fdf3 in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2534:1
> #11 0x2af27e9900af in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2525:1
> #12 0x2af27cb1646e in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:592:5
> #13 0x2af27cb1993f in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:385:1
> #14 0x2af282d45bb0 in SwDocShell::RemoveLink() /sw/source/uibase/app/docshini.cxx:472:13
> #15 0x2af282d43596 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:394:5
> #16 0x2af282d45f46 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:384:1
> #17 0x2af282d4637f in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:384:1
> #18 0x2af282d464c6 in virtual thunk to SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:383:13
> #19 0x2af27420aade in SvRefBase::ReleaseRef() /include/tools/ref.hxx:138:29
> #20 0x2af27420195a in tools::SvRef<SwDocShell>::~SvRef() /include/tools/ref.hxx:49:30
> #21 0x2af2741f6663 in SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /sw/qa/core/filters-test.cxx:130:1
> #22 0x2af2741f368e in SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) /sw/qa/core/filters-test.cxx:69:12
> #23 0x2af29a05d1fb in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:129:20
> #24 0x2af29a060741 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:154:5
> #25 0x2af2741fa8fa in SwFiltersTest::testCVEs() /sw/qa/core/filters-test.cxx:174:5
> #26 0x2af27421631d in CppUnit::TestCaller<SwFiltersTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6
> #27 0x2af23644866d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
> #28 0x2af24e66d0d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:57:14
> #29 0x2af236403bb7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #30 0x2af2458a1926 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:88:12
> #31 0x2af236403bb7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #32 0x2af241b89d58 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
> #33 0x2af236403bb7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #34 0x2af23638b90c in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
> #35 0x2af236403bb7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #36 0x2af2363ffb61 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18
> #37 0x2af2364c91c5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:10
> #38 0x2af2364451c6 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5
> #39 0x2af23644bc03 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
> #40 0x2af23644ab6d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
> #41 0x2af23644bc03 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
> #42 0x2af23644ab6d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
> #43 0x2af2365078c6 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5
> #44 0x2af2364c7049 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:3
> #45 0x2af236508e86 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3
> #46 0x501b3c in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:281:13
> #47 0x4fc866 in sal_main() /sal/cppunittester/cppunittester.cxx:431:14
> #48 0x4fa822 in main /sal/cppunittester/cppunittester.cxx:338:1
> #49 0x2af2380d2af4 in __libc_start_main (/lib64/libc.so.6+0x21af4)
> #50 0x4323c4 in _start (/workdir/LinkTarget/Executable/cppunittester+0x4323c4)
Change-Id: Ic1ff73d3184ad2cd97555b7a45fb205e9ec84ac6
|
|
Change-Id: I0d15e52100e154bb3681e0092ee663ceeef61f9d
|
|
Clipping was set not only in case of VCL-level double buffering, but
also during printing, which means comments were excluded from the
output.
Change-Id: Iffb7d91ca78c09e2b43133f5049d52bd7dc4e730
|
|
Change-Id: I99d79735c375f3d632382a8efa0202517a293b1f
|
|
Change-Id: I4d987718bf27766c8cd7f3654db6645e5a7f554a
|
|
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
|
|
Change-Id: I23cdf631d7a5854aa41fb24a1bc793019174baf9
|
|
Change-Id: I986a11f56fa8900bc8ee654ed4a614bb01c353c3
|
|
Bullet of non-monospace font that is used as non-printing character
to indicate space might be wider than the space. Drawing the bullet
over the space make the bullet too close to next character.
Shift the bullet accordingly so that bullet is centered with
original space.
Change-Id: I0d8d721041e8a475546fe25fb01bee374fc3e499
Reviewed-on: https://gerrit.libreoffice.org/20112
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: Id8f0c138fb665a19b92f2779aa59ae1778efddc5
Reviewed-on: https://gerrit.libreoffice.org/20789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
|
|
The body frame did get a request to shrink, but because it had fixed
size, nothing happened. Trigger a recalc that does the right thing wrt.
hidden whitespace.
Change-Id: I446978da8b33372c2ab30200b45b1bcec1dea7a0
|
|
Change-Id: Ie9f9c5cc94b87914bcd7d5392f6fd1ee447e94ec
|
|
Change-Id: I9b273543ccf2eaa87116c6e1475860e9e872c445
|
|
Turns out that SfxObjectShell::CreateShellID() will produce the
SfxMedium's base URL if it exists, so
EmbeddedObjectContainer::CopyAndGetEmbeddedObject() already has
parameters, sw just needs to set them.
Change-Id: I36cedfde4e7c2e25c43c66a30d8ca572f099ad69
|
|
Revert "Fix tdf#77514 CJK ruby text in RTL( vertical ) base line issue."
This reverts commit b14861e1dfb9f83d26d6032ae96b664845528f2a.
Conflicts:
sw/source/core/text/itrpaint.cxx
Change-Id: I4b7f7437014032566227f745e5e81b6a01ba022f
Reviewed-on: https://gerrit.libreoffice.org/20358
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
it always paint partial table border which have line style of DOUBLE_THIN.
Becouse the partial of the border line is out of the invalid window rect.
so, we extend it.
Change-Id: I9d95ca71a96cfa869c68d9d2200f29c7cd447eca
Reviewed-on: https://gerrit.libreoffice.org/20701
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
The situation is similar to commit
79fb61efb847405fa47235002b52ee8efad5e339 (tdf#92379: svx: don't
overwrite fo:background-color on ODF import, 2015-08-21), except that
here text frames had the problem of loosing colors when transparency is
set.
Fix the problem by informing getSvxBrushItemFromSourceSet() about if
we're in XML import or not.
Change-Id: Id1adf60b14a3762f0a2a43c49caeed9f6ea039be
|
|
Change-Id: I8f9e74f7fbbff055c67cafba5d534db4635e5399
|
|
this will make it easier to implement native help tips
Change-Id: I984dfadaf02e9b7bf542ba82cf070911c89cb699
|
|
adds detection of css::table::BorderLineStyle::NONE
to the LineListBox and stops painting NONE style lines
Change-Id: Ib24fa25a9e3e3ae685f2000685f01cae42d1653f
Reviewed-on: https://gerrit.libreoffice.org/20639
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
|
|
Change-Id: I5f35e0aeb6cef5920891eaa338c1d9b29e0ce554
|
|
Change-Id: I7141510fbda1158511698f73c48274008f0a41dc
|
|
... and fix the breakages it finds.
Change-Id: Ibc7289cc0cd7fb5648d686bd55afff9016f58b3b
Reviewed-on: https://gerrit.libreoffice.org/20638
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
when used as a mutable data-structure. Plain std::vector halves the time
taken to display the chart dialog
Create a class to represent the std::vector we are going to be passing
around, and move some of the utility methods into it to make the code
prettier.
Also create an optimised append(&&) method for the common case of
appending small temporaries.
Change-Id: I7f5b43fb4a8a84e40e6a52fcb7e9f974091b4485
|
|
Change-Id: Icd719c461613f8c59cad81b256678307f69974e1
|
|
Convert the stingarray in resource strings.
A lot of need a translation in other language
Improve a lot of stuff
Change-Id: I1c97949fa3a3de17efe0a358370b5a7b6a772686
Reviewed-on: https://gerrit.libreoffice.org/20557
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
It's an implementation detail that the used UNO API needs a non-cost
text node, even if only read methods are called on the wrapper object.
Change-Id: If15eaca48339f1531fd54da3422a6b7c41eb48f7
|
|
For SwDoc::AppendDoc we use the StartOfContent node as the
starting copy node to prevent merging of the first node in
CopyRange and to get a 2nd node needed for CopyRange in case
of single content node documents.
This correctly counts StartOfContent as a non-copy node when
adapting the bookmark ranges for copying.
Change-Id: Ia3ee0328a1be5548f8751aa2240812c4662fb73f
Reviewed-on: https://gerrit.libreoffice.org/20383
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
With this, the only thing that blocks the DOC import to handle smart
tags is the lack of RDF metadata initialization in the filter.
Change-Id: I33ab74c7d6ceaac42cc94fdf0b1dfcb0eaf61ab4
|
|
Change-Id: I13e510e305c4aa24c37b1c25b4c3116ef3f06a8a
|
|
Change-Id: I7934bc993e049169a08b835f922da8ef50ea05ee
|
|
...later on during loading of (a local copy of)
<https://wiki.documentfoundation.org/images/5/50/BH40-BaseHandbook.odt> at
> sw/inc/swrect.hxx:249:48: runtime error: signed integer overflow: 1080100 + 9223372036853697509 cannot be represented in type 'long'
> SwRect::Bottom() const sw/inc/swrect.hxx:249:48
> SwTextFly::CalcMinBottom() const sw/source/core/text/txtfly.cxx:996:31
> SwTextFly::GetMinBottom() const sw/source/core/inc/txtfly.hxx:339:45
> SwTextFormatter::CalcBottomLine() const sw/source/core/text/itrform2.cxx:1917:20
> SwTextFrame::FormatAdjust(SwTextFormatter&, WidowsAndOrphans&, int, bool) sw/source/core/text/frmform.cxx:1092:26
> SwTextFrame::_Format(SwTextFormatter&, SwTextFormatInfo&, bool) sw/source/core/text/frmform.cxx:1552:13
> SwTextFrame::_Format(OutputDevice*, SwParaPortion*) sw/source/core/text/frmform.cxx:1662:5
> SwTextFrame::Format(OutputDevice*, SwBorderAttrs const*) sw/source/core/text/frmform.cxx:1809:17
> SwContentFrame::MakeAll(OutputDevice*) sw/source/core/layout/calcmove.cxx:1391:17
> SwFrame::PrepareMake(OutputDevice*) sw/source/core/layout/calcmove.cxx:307:21
> SwFrame::Calc(OutputDevice*) const sw/source/core/layout/trvlfrm.cxx:1798:9
> SwObjectFormatterTextFrame::FormatAnchorFrameAndItsPrevs(SwTextFrame&) sw/source/core/layout/objectformattertxtfrm.cxx:753:9
> SwFlyAtContentFrame::MakeAll(OutputDevice*) sw/source/core/layout/flycnt.cxx:419:21
> SwFrame::PrepareMake(OutputDevice*) sw/source/core/layout/calcmove.cxx:341:5
> SwFlyFrame::Calc(OutputDevice*) const sw/source/core/layout/fly.cxx:2665:9
> SwLayAction::FormatLayoutFly(SwFlyFrame*) sw/source/core/layout/layact.cxx:1428:9
> SwObjectFormatter::_FormatObj(SwAnchoredObject&) sw/source/core/layout/objectformatter.cxx:331:17
> SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject&, bool) sw/source/core/layout/objectformattertxtfrm.cxx:134:9
> SwObjectFormatter::_FormatObjsAtFrame(SwTextFrame*) sw/source/core/layout/objectformatter.cxx:453:19
> SwObjectFormatterTextFrame::DoFormatObjs() sw/source/core/layout/objectformattertxtfrm.cxx:336:20
> SwObjectFormatter::FormatObjsAtFrame(SwFrame&, SwPageFrame const&, SwLayAction*) sw/source/core/layout/objectformatter.cxx:193:20
> SwLayAction::FormatContent(SwPageFrame const*) sw/source/core/layout/layact.cxx:1651:19
> SwLayAction::InternalAction(OutputDevice*) sw/source/core/layout/layact.cxx:572:31
> SwLayAction::Action(OutputDevice*) sw/source/core/layout/layact.cxx:352:5
> SwLayIdle::SwLayIdle(SwRootFrame*, SwViewShellImp*) sw/source/core/layout/layact.cxx:2159:13
> SwViewShell::LayoutIdle() sw/source/core/view/viewsh.cxx:728:19
> sw::DocumentTimerManager::DoIdleJobs(Idle*) sw/source/core/doc/DocumentTimerManager.cxx:119:17
> sw::DocumentTimerManager::LinkStubDoIdleJobs(void*, Idle*) sw/source/core/doc/DocumentTimerManager.cxx:81:1
> Link<Idle*, void>::Call(Idle*) const include/tools/link.hxx:84:45
> Idle::Invoke() vcl/source/app/idle.cxx:25:5
> ImplSchedulerData::Invoke() vcl/source/app/scheduler.cxx:40:5
> Scheduler::ProcessTaskScheduling(bool) vcl/source/app/scheduler.cxx:170:9
> ImplYield(bool, bool, unsigned long) vcl/source/app/svapp.cxx:519:5
> Application::Yield() vcl/source/app/svapp.cxx:535:5
> Application::Execute() vcl/source/app/svapp.cxx:471:9
> desktop::Desktop::DoExecute() desktop/source/app/app.cxx:1284:5
> desktop::Desktop::Main() desktop/source/app/app.cxx:1609:17
> ImplSVMain() vcl/source/app/svmain.cxx:170:19
> SVMain() vcl/source/app/svmain.cxx:207:16
> soffice_main desktop/source/app/sofficemain.cxx:96:12
> sal_main desktop/source/app/main.c:48:15
> main desktop/source/app/main.c:47
...whatever those hardcoded odd values used here, the code is the same ever
since 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import"
Change-Id: I7f10034f97c52256d873b86a683c9204b944e704
|
|
was generated a crash when running 'make check' on my Linux box.
These classes need to hold the SolarMutex when destructing their
SwClient base class.
Change-Id: I448ea00978d003aa37d8663d37b4edf9e54a6a56
Reviewed-on: https://gerrit.libreoffice.org/20391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|