summaryrefslogtreecommitdiff
path: root/sw/source/core/unocore/unodraw.cxx
AgeCommit message (Collapse)AuthorFilesLines
2015-11-25bin/rename-sw-abbreviations.shlibreoffice-5-1-branch-pointRobinson Tryon1-8/+8
This commit renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I77e5134f42f25e3786afa36b7a505c7e3237a9e8
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin1-3/+1
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-3/+1
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-115th step to remove tools/rtti.hxxOliver Specht1-1/+0
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-44/+44
Change-Id: I01e11fa956a249974e77dce9deebe79311f098d0
2015-11-09fix a set of race conditions in the writer uno wrappersBjoern Michaelsen1-0/+3
- whenever SwClients are added or removed, the SolarMutex should be locked - locking the mutex there would be a performance killer - thus only DBG_TESTSOLARMUTEX() and fixing the fallout on DBG_UTL builds Change-Id: I3b10b9a01c40fbe68d15ce6e9c5c74db34eb1eb6 Reviewed-on: https://gerrit.libreoffice.org/19856
2015-11-06com::sun::star->css in sw/source/coreNoel Grandin1-5/+5
Change-Id: I30016977f1be8fb53dd239367d043de92a9467d9
2015-11-05use uno::Reference::set method instead of assignmenNoel Grandin1-3/+3
Change-Id: I76671a74150791e1a74ece3d5bcf40fd6c727ac7
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-5/+5
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht1-5/+5
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-25tdf#94228 comphelper: replace BOOST_PPDaniel Robertson1-2/+1
Remove makeSequence. Change-Id: If07dc8702d811111fc634c9c7eb4c9a331517ca5 Reviewed-on: https://gerrit.libreoffice.org/18647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-07-06improve the returnbyref lopluginNoel Grandin1-3/+3
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann1-4/+4
Change-Id: I8d27ae80d209159690182ab91e272cf00e9f863d
2015-05-29loplugin:redundantcast: const_cast to same typeStephan Bergmann1-1/+1
Change-Id: I7cb919140539d0d573b5fbf786a6041843c2388a
2015-05-26cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I955b04396d27e88ce228f180275955071da83ec6
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier1-176/+176
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-05loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: I90dd921077bbfc57200e398e7959306f26c65cfe
2015-04-30Get rid of initial :: for the svx namespaceTor Lillqvist1-2/+2
Change-Id: I03e428a749bca409ebac9c142acaddafcbfeca23
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin1-20/+20
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann1-12/+12
Change-Id: I2ec58d0bfe13fae4fc2141f9b017b5a72e0ba2c2
2015-03-20tdf#89756 Switched postfix to prefix operator++/--Gulsah Kose1-1/+1
Replaced postfix to prefix operator++/-- to improving performance Change-Id: Iaee7b22dbe21441b82612ae3a3e336cf56eb280f Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/14903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-19move SwIterator into calbck.hxxBjoern Michaelsen1-1/+1
Change-Id: Icdcd46d392bbf1dbe45448328c310d9a327ba60d
2015-03-16unocore: dont use 'shortcut' that is longer than the originalBjoern Michaelsen1-1/+1
Change-Id: I0bc66003528b6603ce46325176973d72dcbac2ac
2015-03-05V801: Decreased performanceCaolán McNamara1-15/+15
Change-Id: I5e7b5327b542f610efb0960b8bcfad10e04025b5
2015-03-02V813: Decreased performanceCaolán McNamara1-2/+2
Change-Id: I49c022b29a2771b5091ba04b85e5117773730b85
2014-12-19fdo#86963 SwXShape: don't ask SwTextBoxHelper for ZOrder of child shapesMiklos Vajna1-2/+11
Regression from commit 01fc08c0b5c57fef8ad3755672f4266d85e849a5 (fdo#85554 SwXShape: fix getting ZOrder property when doc contains TextBoxes, 2014-11-20), the problem was that we returned wrong ZOrder of shapes inside group shapes. In SwXShape::getPropertyValue(), pObj points to the Writer-interfacing outermost group shape in case of shapes contained by group shapes, while GetSvxShape() gives access to the real shape. Given that TextBoxes are only possible at the highest level (and not inside group shapes), just check if the two pointers are the same: when not, then no need to convert anything. With this, child shapes get back their original ZOrder -- before in case the group shape had ZOrder=0, all its child shapes had ZOrder=0 as well. Change-Id: I9c4097154130cd04f6ab2f2082abafc1d4333872
2014-12-10Use Any specializations for bool, instead of SetValueMatteo Casalin1-3/+2
Change-Id: I7a5babe494bdb09a71164ea74d7be3f6bf985ff6 Reviewed-on: https://gerrit.libreoffice.org/13215 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-11-26loplugin: cstylecastNoel Grandin1-2/+2
Change-Id: I19be8b6df10515e195a4d3ecb8f003c85d2349c2
2014-11-25loplugin: cstylecastNoel Grandin1-4/+4
Change-Id: I9f9fef666ee22c54d923f24ce862151d32f4a5a7
2014-11-20fdo#85554 SwXShape: fix getting ZOrder property when doc contains TextBoxesMiklos Vajna1-0/+13
Change-Id: I9b6b83f0f6d627bb14a880a19769ee70564cf52b
2014-11-19comphelper::SequenceAsHashMap: throw IllegalArgumentExceptionStephan Bergmann1-10/+1
...instead of IllegalTypeException (where the latter is not a RuntimeException). Fixes cid#707218, cid#1224993, etc., and reverts previous fix 358f5280e0f6afb968edc295d8f1dce55f05e18f "Fix coverity#1224993 w/o breaking JunitTest_framework_unoapi." Change-Id: I13ce153e1513749fb0be2ee8e560cec86a30c5ba
2014-10-31Removed duplicated includesAndrea Gelmini1-1/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31SwXShapesEnumeration: don't generate a set of TextBoxes for each shapeMiklos Vajna1-4/+22
Instead, generate it once and then pass around that list. Again, this helps ODF export. For a test document of 2000 mail merge records and 16 frames, the times for css::text::MailMerge::execute() are 7m53.575s -> 7m30.261s. Change-Id: Iec993ec34392350b1e26857f7d5434a0a9c494a3
2014-10-21fdo#39468 Translate German comments - sw/source/core/{unocore|text}Philipp Weissenbacher1-4/+6
Change-Id: Ib68eb94b296b002a8cd4e73dd6fd72a4f9d2f7d3 Reviewed-on: https://gerrit.libreoffice.org/12058 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-09Fix coverity#1224993 w/o breaking JunitTest_framework_unoapiStephan Bergmann1-1/+10
Change-Id: Iefa1d79c52c4f951a7a66be98de3c9752bf89daf
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann1-2/+2
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-20i#105557: thread-safe caching of SwXFrame instancesMichael Stahl1-6/+12
Replace SwXFrames::GetObject() with factory functions that use the WeakReference SwFrmFmt::m_wXObject to cache the instance in a thread-safe way. Change-Id: If56e4d7f95cb4f2e112139f228fb832ae9bf7d76
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin1-1/+1
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on. Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as return value in case of failure and in the related tests. Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-15SwTextBoxHelper::findTextBoxes: return a set of const pointersMiklos Vajna1-2/+2
Change-Id: I8e3ea996959bad72e6d15dc9c980ea9d18d31fb3
2014-08-12Refactored IDocumentLayoutAccess out of SwDoc.Valentin Kettner1-9/+10
Into the new class DocumentLayoutManager. Change-Id: I02d0cfcc63633d0bdab380508b2ef563187fd269
2014-07-15Refactored IDocumentContentOperations out of SwDoc.Valentin Kettner1-1/+1
Into the new class DocumentContentOperationsManager. Made SwNodes in sw/inc/ndarr.hxx friend class to DocumentContentOperationsManager so it can call DelNodes at end of DocumentContentOperationsManager::DeleteSection . Added DeleteAutoCorrExceptWord to SwDoc, its needed in the Manager. Added a non const version of SwDoc::GetDfltGrfFmtColl() to SwDoc because its needed in the Manager. Made SwDoc a friend class to DocumentContentOperationsManager so it can call SwDoc::checkRedlining and SwDocL::_MakeFlySection. Moved SwDoc::CopyImpl_ , SwDoc::CopyWithFlyInFly and SwDoc::CopyFlyInFlyImpl into the Manager. Moved "struct ParaRstFmt" and "lcl_RstTxtAttr" from docfmt.cxx in DocumentContentOperationsManager.hxx . Change-Id: Icaab57f4a8c158a85e549ecb4aacc752bc95bbc9
2014-07-13remove code that was commented out more than three years agoPhilipp Riemer1-2/+2
Change-Id: I8bc53b5d940be73d8b4142a72fb247c4e3af2e17
2014-07-13fdo#39468: Translate German comments in sw/source/core/Philipp Riemer1-9/+9
Change-Id: Ib48b281feccd4684571768ca2be6ecca23afbf55
2014-07-01Related: #i124638# Corrected relationship between DrawModel and...Armin Le Grand1-1/+2
DocShell in Writer, made SwDrawModel and handling more known (includes suspicious removal of setting SID_ATTR_LINEEND_WIDTH_DEFAULT) (cherry picked from commit a7ccadbf3b1ac378ca15d3630d48f48734700e5c) Conflicts: sw/inc/IDocumentDrawModelAccess.hxx sw/inc/doc.hxx sw/inc/docsh.hxx sw/inc/dpage.hxx sw/inc/drawdoc.hxx sw/source/core/access/accmap.cxx sw/source/core/doc/doc.cxx sw/source/core/doc/docdesc.cxx sw/source/core/doc/docdraw.cxx sw/source/core/doc/docfly.cxx sw/source/core/doc/doclay.cxx sw/source/core/doc/docnew.cxx sw/source/core/draw/dcontact.cxx sw/source/core/draw/dpage.cxx sw/source/core/draw/drawdoc.cxx sw/source/core/frmedt/feshview.cxx sw/source/core/layout/fly.cxx sw/source/core/layout/frmtool.cxx sw/source/core/layout/newfrm.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/undo/docundo.cxx sw/source/core/undo/unattr.cxx sw/source/core/unocore/unodraw.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/view/vdraw.cxx sw/source/core/view/viewimp.cxx sw/source/core/view/viewsh.cxx sw/source/filter/html/htmldrawreader.cxx sw/source/filter/rtf/rtffly.cxx sw/source/filter/rtf/swparrtf.cxx sw/source/filter/ww8/docxattributeoutput.cxx sw/source/filter/ww8/rtfattributeoutput.cxx sw/source/filter/ww8/wrtw8esh.cxx sw/source/filter/ww8/wrtww8.cxx sw/source/filter/ww8/ww8graf.cxx sw/source/filter/xml/swxml.cxx sw/source/filter/xml/xmlexp.cxx sw/source/filter/xml/xmlimp.cxx sw/source/ui/app/docshdrw.cxx sw/source/ui/uiview/view.cxx sw/source/ui/uno/unodefaults.cxx sw/source/uibase/app/docst.cxx sw/source/uibase/app/docstyle.cxx sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx sw/source/uibase/lingu/sdrhhcwrap.cxx sw/source/uibase/shells/drwbassh.cxx sw/source/uibase/shells/frmsh.cxx sw/source/uibase/shells/grfsh.cxx sw/source/uibase/shells/textsh1.cxx sw/source/uibase/uno/unotxdoc.cxx sw/source/uibase/utlui/content.cxx Conflicts: sw/source/uibase/app/docshdrw.cxx Change-Id: Icb99eaa7bfb1eb8922a9fd928b5e4149821130dd
2014-07-01coverity#707290 Uncaught exceptionCaolán McNamara1-1/+2
Change-Id: If020fd537c15c41fe33134f554b7df1f10f18570
2014-06-25Let SwTextBoxHelper::findTextBoxes() return a setMiklos Vajna1-2/+2
The intention was to have a container where it's fast to look elements up, and list is a linked list, so it doesn't fit. Change-Id: I3196c8dee96ecd4a6f464b74fd5141b27f1773b8
2014-06-24new compilerplugin returnbyrefNoel Grandin1-3/+3
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-19coverity#705037 Unchecked dynamic_castCaolán McNamara1-0/+1
Change-Id: I9f6c8ceafd09b4a5d4e951e01e1a06b2b5265181
2014-06-13SwXShape: getter for ChainNext/PrevName UNO propertyMiklos Vajna1-1/+7
Change-Id: I7e4fffabf6b1d96a458a3afd141f86d0e4565230
2014-06-13SwXShape: add ChainName UNO propertyMiklos Vajna1-0/+5
Shapes may not have a unique name, but TextFrames always have. So in order to be able to link shapes with textboxes, provide a ChainName property that's the name of the underlying TextFrame. This kills two birds with one stone: - we can have a unique name for each shape - the names can be used for TextFrame linking, as they are valid TextFrame names Change-Id: Ie96f267d392d9fe5388c5eacff9b873f1639054c