summaryrefslogtreecommitdiff
path: root/sw/source/core/layout/laycache.cxx
AgeCommit message (Collapse)AuthorFilesLines
2017-06-05Improved loplugin:cstylecast to reference types: swStephan Bergmann1-1/+1
Change-Id: I7206d3325b4bfedb852d559b68dc1678da524b41
2017-05-15loplugin:useuniqueptrNoel Grandin1-6/+5
ignore SAL_LOG type stuff in the destructor Change-Id: If014382ca0c96edd3f2b325a28451d83b3d1f278 Reviewed-on: https://gerrit.libreoffice.org/37539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12sw laycache: clean up debug code that doesn't even build anymoreMiklos Vajna1-10/+0
Change-Id: I52ad9ac6d43881a02c4817ea7527761105a12786 Reviewed-on: https://gerrit.libreoffice.org/37529 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-08loplugin:checkunusedparams in sw(part3)Noel Grandin1-10/+10
Change-Id: I604aa74e737894daa6e1878ac3ed61d9eeb6512a Reviewed-on: https://gerrit.libreoffice.org/37296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02sw: prefix members of SwLayHelperMiklos Vajna1-136/+136
Change-Id: I6beec3d0083f6b2f4055b7cffe9c59a630a89261 Reviewed-on: https://gerrit.libreoffice.org/37135 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10tdf#39468 Translate German comments in swJens Carl1-1/+1
Translate German comments and terms in sw/inc/ and sw/source Change-Id: I1330a358db2c6cdc0512009befeafa0582ac4877 Reviewed-on: https://gerrit.libreoffice.org/36288 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-03sw: [loplugin:sallogareas]Michael Stahl1-3/+3
Change-Id: I94c552e4b2ae95f57b0c667f6072664eab570042
2017-04-03More integer clean-upStephan Bergmann1-3/+4
...after dbaab58c1442e7f62ef0732376fe5a49840e9fd6 "loplugin:loopvartoosmall". Looks like SwLayHelper::nIndex only needs to be initialized to a very large value (so that 'nIndex < pImpl->size()' will be false), not USHRT_MAX exactly. Change-Id: I209faa00894783c468db1440f5663ea9e8ad3e19
2017-04-03loplugin:loopvartoosmallStephan Bergmann1-1/+1
Change-Id: Ief96de6eb6f6276681130a6d16c767ab8ceaa3f1
2017-04-03loplugin:sallogareasStephan Bergmann1-3/+3
Change-Id: Idd4f44b66e67d938a1ba2b9c7ff4be0b0009ff53
2017-04-03tdf#106237 sw: do some basic sanity checking on layout-cacheMichael Stahl1-8/+53
The bugdoc, with claimed generator AOO4.1.1 on Windows, contains a bogus layout-cache: debug:26706:1: nType P nIndex 29 2147483647 debug:26706:1: nType P nIndex 66 2147483647 debug:26706:1: nType P nIndex 105 2147483647 debug:26706:1: nType P nIndex 142 2147483647 debug:26706:1: nType P nIndex 178 2147483647 debug:26706:1: nType P nIndex 205 2147483647 debug:26706:1: nType P nIndex 229 2147483647 debug:26706:1: nType T nIndex 314 65535 Due to a loop-control this causes incorrect pagination if CalcLayout() is called only once. It should look like this: debug:26765:1: nType T nIndex 382 65535 debug:26765:1: nType T nIndex 790 65535 In this case we can easily detect that the indexes and types in the layout-cache are bogus by checking against the node types, so do that in SwLayHelper::SwLayHelper(). Change-Id: I7091af49a8c29bf0a11ceff0be9ba84b1f710fdb
2016-08-17convert SvxBreak to scoped enumNoel Grandin1-4/+4
Change-Id: If8b79ed617e5662550bd73bd1506d047217f2313
2016-06-10remove bBreakAfter& param from SwLayHelper constructorNoel Grandin1-6/+6
the constructor is only called from one spot, which does not care about the output value of bBreakAfter Change-Id: I184091d3862265f0718b52c2cd82cad861274c1c Reviewed-on: https://gerrit.libreoffice.org/26110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-12clang-tidy modernize-loop-convert in swNoel Grandin1-4/+2
Change-Id: I1f4a0ad6658bd3154c48940296aa8edc1ea1612c Reviewed-on: https://gerrit.libreoffice.org/24876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22Avoid reserved identifiersStephan Bergmann1-4/+4
Change-Id: I27ff0f4f0eb395d7e0a60dd604758c220a3134c4
2015-11-25bin/rename-sw-abbreviations.shlibreoffice-5-1-branch-pointRobinson Tryon1-110/+110
This commit renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I77e5134f42f25e3786afa36b7a505c7e3237a9e8
2015-11-12WaE: loplugin:literaltoboolconversionTor Lillqvist1-1/+1
Change-Id: Id953a15b3d6167a2983500d21a215662415bc074
2015-11-12coverity#1338595 Dereference before null checkCaolán McNamara1-2/+2
Change-Id: I8f23fb4fe51f64a82e58dcc150aeca964ac6af38
2015-11-12OSL_ENSURE followed by unconditional dereference -> assertCaolán McNamara1-1/+1
Change-Id: Ife08acfd0defbed7f09a3b8dce089f61b0d7e11c
2015-11-12dynamic cast followed by static castCaolán McNamara1-4/+2
Change-Id: I22a2123265da9d6808d9fd1bcb44666810a9311e
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-15/+15
Change-Id: I01e11fa956a249974e77dce9deebe79311f098d0
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht1-2/+2
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-02sw: replace boost::ptr_vector with std::vectorMichael Stahl1-2/+1
Change-Id: I46bdab6995676c89f353caa3b0cf359f3aa10151
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier1-22/+22
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2014-12-25sal_uInt16 to size_tMatteo Casalin1-2/+2
Change-Id: I66239d89049f1386e5725e540c4dcc2b09c3ebf0
2014-12-18sw: rename SwFrm::Remove to something uniqueMichael Stahl1-2/+2
Change-Id: I4daf01450a4aa8f1d2bc6eae731a735d0d38a074
2014-11-24loplugin: cstylecastNoel Grandin1-35/+35
Change-Id: I2737c5a4f1ad4a5e5588be4f2dc544037df0a693
2014-10-18sw: remaining unused methodsMiklos Vajna1-63/+0
Change-Id: Ie150d2e497053966c5f75cea50c87888fda98659
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin1-1/+1
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary static_cast'sNoel Grandin1-6/+6
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-06SwSortedObjs: Count() to size() and use size_t consistentlyMatteo Casalin1-2/+2
Change-Id: I80fa39e9790a0dfff9d4afb534be119eb593b60d
2014-09-01fdo#75757: remove inheritance to std::vectorTakeshi Abe1-3/+3
from SwLayCacheImpl. Change-Id: I77520495aab1d6a572b25433396202b11e478636 Reviewed-on: https://gerrit.libreoffice.org/11158 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-12Refactored IDocumentLayoutAccess out of SwDoc.Valentin Kettner1-3/+4
Into the new class DocumentLayoutManager. Change-Id: I02d0cfcc63633d0bdab380508b2ef563187fd269
2014-08-12Refactored IDocumentStatistics our of SwDoc.Valentin Kettner1-2/+3
Into the new class DocumentStatisticsManager. Change-Id: I281232dc09dbd79c2faf3c2a78ae49625bbe88ee
2014-06-24new compilerplugin returnbyrefNoel Grandin1-4/+4
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-04-30sw: sal_Bool->boolNoel Grandin1-15/+15
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-21remove comments why a file gets includedThomas Arnhold1-1/+0
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-14typo: avaiable -> availableThomas Arnhold1-1/+1
2014-03-31sw: unused includes in laycacheMiklos Vajna1-12/+0
Change-Id: Ibd168ee6a5da734bc3b20bbab698953eb13f0e73
2014-02-27Remove visual noise from swAlexander Wilms1-6/+1
Conflicts: sw/inc/unodraw.hxx sw/inc/unoframe.hxx sw/sdi/swriter.sdi sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unoparagraph.cxx sw/source/filter/ww8/rtfexportfilter.cxx sw/source/ui/inc/unotxvw.hxx sw/source/ui/lingu/hyp.cxx sw/source/ui/lingu/sdrhhcwrap.cxx sw/source/ui/uno/swdetect.hxx Change-Id: Ic0a3fb2392187c277c9b36915ffb10dcf0317908 Reviewed-on: https://gerrit.libreoffice.org/8322 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms1-1/+1
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-16fdo#62475 - remove visual noisePhilipp Riemer1-3/+0
Change-Id: I36e970c2ed13c50e5f6cebf95aa36ca8194a01ce
2014-02-15fdo#62475 - remove visual noisePhilipp Riemer1-34/+12
- remove "borders" - move method explanations if misplaced - rewrite for Doxygen if needed - "shrink" multiple blank lines Change-Id: Ia4678b7f2456de70eb307e9c0d80c4ecd068048b
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin1-11/+11
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-07coverity#708854 unused pointer valueNoel Grandin1-5/+5
Change-Id: Ide16dee52116d3f437a564b93fad7464382c7213
2014-01-31coverity#984156 : Uninitialized scalar fieldNorbert Thiebaud1-6/+15
Change-Id: I03829d3fe431632f3c2ab585d19f812b9c2a94be
2014-01-31coverity#984157 : Uninitialized scalar fieldNorbert Thiebaud1-0/+1
Change-Id: I301ab920389de23814f8e1ace6daf22a10459b9d
2014-01-17WaE: comparison between signed and unsigned integer expressionsTor Lillqvist1-1/+1
Change-Id: I821b403a14a6c889a2652e766f59ada79b1dcb88
2014-01-15Resolves: #i17171# Writer paragraph cannot be longer than 65534 charactersCaolán McNamara1-14/+14
Change-Id: I2052ae96571cba8fe2191dff53b1c61c95c94c60
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin1-13/+13
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-18 09:41:37 +0000