summaryrefslogtreecommitdiff
path: root/sw/qa
AgeCommit message (Collapse)AuthorFilesLines
8 hourssw: fix unexpected paragraph border inside table cellsMiklos Vajna2-0/+20
The bug document has a table cell, which contains a paragraph with borders. Its left/right/bottom borders are rendered in Writer, but not in Word. The reason for the left/right border is that it's outside the paragraph's frame area, which is not rendered in Word. Fix this by clipping the rendered borders so they don't go outside the paragraph's frame area. (Normally the frame area is the larger rectangle, and then margins may cause a smaller "print area", but in this case we have a negative right margin, so clipping the print area to fit into the frame area actually does something.) This is quite similar to what commit 1e21902106cbe57658bed03ed24d4d0863685cfd (tdf#117884: intersect border with paint area of upper frame., 2018-05-26) did for table borders. The bottom border is a different problem: the cell has a fixed height and enough content so the paragraph is cut off vertically. This means that technically the bottom border would be inside the frame area, but Word cuts it off, because they apply clipping on the not-yet-cut-off rectangle. Fix this by dropping the bottom margin when the frame is cut off. Change-Id: I7f65b68997330b247db65839db8a484e74f78c64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128569 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
9 hoursCppunitTest_sw_odfexport2: rework to avoid mustTestImportOf()Miklos Vajna1-12/+5
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id6d45cfa011a45b0e8ef9f486498d6a89af8e49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128574 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
25 hourstdf#146515: sw_ooxmlexport4: Add unittestXisco Fauli2-0/+7
Change-Id: Ib273156124a677fc774340dbd780393dfbd3070b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128548 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
27 hourstdf#145321: sw_uiwriter3: Add unittestXisco Fauli2-0/+24
Change-Id: Id64d3469ed1bd4c38e684c4af0c20121a81043fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128552 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
4 daysrequest the 2nd rect explicitly instead of one with a particular 'top' valueCaolán McNamara1-1/+1
Change-Id: I04caee2263e5e7345fb3fb0c07830d1bf504bf7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
4 daysResolves tdf#139395 - Redesign of font name and effects pagesHeiko Tietze1-0/+5
* Western/CJK/CTL selection placed into a GtkNotebook * Font color and transparency in one line * Alignment adjusted at font effects page * Char-, para- & style dialogs made non-resizable according the guideline Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
4 daystdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski1-0/+21
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
5 dayssw tests: audit uses of loadAndSave()Miklos Vajna9-16/+16
When it comes to changing import + import-export-import tests to do only import-export instead, this is only safe if we assert the resulting exported XML. Replace calls to loadAndSave() with loadAndReload() when we want to assert the doc model after an export. Thanks to Justin for flagging this, luckily it seems there is only a single test that fails after restoring the lost asserts (and that has already been fixed). Change-Id: I62cd4330c62d801dd9e6c7ef73decab3972c0b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128411 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daystdf#146375: sw: add UItestXisco Fauli2-1/+78
Change-Id: I8d165b257f4bee3921f1a4624a7797ed22327e40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128419 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
5 daysRestore tdf#134951 docxexport: stop duplicating stuff in postponed textMichael Stahl1-0/+3
Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3 to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported by jluth the test case testfdo79008 that failed was apparently somewhat misleading and the test case testTdf134951_duplicates that should test comments erroneously failed to fail because it is doing a loadAndSave() instead of a loadAndReload(). Change-Id: I7e788287da3b1742f65697ec350997d175db9e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
5 daystdf#146605: sw: Add UItestXisco Fauli2-0/+63
Change-Id: I203387db47c3b936ec79bbe951f21bec6c7c26ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128408 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
6 daystdf#134960: sw: Add test for multi-page viewXisco Fauli1-15/+53
Change-Id: Id3292de4eca6ab72d5116b967a619f78ab96082b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128391 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
6 dayssw: fix swapped inner vs outer border for Word-style bottom table bordersMiklos Vajna2-0/+48
This is similar to commit fc04a84f297b78a1049182b6d8cf745f863ffe61 (sw: fix swapped inner vs outer border for Word-style left table borders, 2022-01-11), but that was for vertical borders, this is for horizontal ones. The other difference is that Word mirrors vertical lines, but not horizontal ones. This means that our horizontal line need less mirroring, while our vertical lines needed more mirroring. Change-Id: Iff07adac5c53420673139d5c93ce52f6148fb977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128383 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
7 daystdf#144270 sw: manage tracked table (row) deletion/insertionLászló Németh1-0/+105
in Manage Changes dialog window, where deleted/inserted tables and table rows were shown as multiple cell changes, as a regression. Now a single table deletion/insertion or deleted/inserted consecutive table rows are shown with a single tree item in the dialog window instead of showing multiple cell changes. Add new Action icons to the tracked table row insertion/deletion tree items (re-using table row deletion/insertion icons). Show cell changes as children of the single parent item tracked table row change. Accept/Reject and Accept/Reject All support 1-click acceptance or rejection of table (row) changes, instead of clicking on all cell changes of a single table (row) deletion/insertion. Regression from commit c4cf85766453982f1aa94a7f2cb22af19ed100be "sw: fix crash due to redlines on tables on ooo121112-2.docx". Change-Id: Id03a8075cc6849b70a8d32e1a955b79e7d3a3246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128314 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
7 daysCppunitTest_sw_odfexport: rework to avoid preTest()Miklos Vajna1-40/+31
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ie7187c7a843a191475688a4a6390514199c6a1c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128298 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
8 dayssw: fix swapped inner vs outer border for Word-style left table bordersMiklos Vajna2-0/+48
The minimal DOCX bugdoc has a single cell, the left border style is thinThickMediumGap, the right border style is thickThinMediumGap, which means the doc model already has the left/right mirroring, don't have to do it at layout time. The normal Writer way is to have a single border style and mirror the right/bottom border line. But then looking at the Writer vs Word output, inner vs outer is swapped, so at the end we have to mirror the left border line for Word-style table borders to get compatible output. Change-Id: I10fb95dfac67e466188cfc9ecf35efde806c14b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128289 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
9 daysuitest: executeCommand doesn't return anythingXisco Fauli6-9/+9
Change-Id: Ie59ed6926c42b96471f3b74a9547f7f1f2cd175a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
10 daysMove HAVE_MORE_FONTS into an extra config headerJan-Marek Glogowski8-0/+8
No need to recompile most of LibreOffice, because the --with-fonts configure flag changed. This preprocessor define is just used by unit tests anyway. Change-Id: Ia2eae7d0c74e59e034fdd8513504a34e51ab428e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128197 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
11 daysFix typoAndrea Gelmini1-1/+1
Change-Id: I4d16867dece00154161fef0344d521aae24be288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128130 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
12 daysremove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin2-2/+2
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
12 daysremove debug codeNoel Grandin1-5/+0
accidtionally committed with commit 302b44125aa0c1d5216f986ecf8e341cd6e57418 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Dec 9 11:45:36 2021 +0200 use background XShapeGroup for bar-chart area Change-Id: Id9fd82a94fd2bb046901fcd4373aac71586d0d13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 dayssw: fix too long inner borders intersecting with outer borders for Word cellsMiklos Vajna2-0/+53
This is similar to commit 66ac8e60896f6306bed8fbb34606fd14474f19ce (sw: fix unwanted long vertical border around vertically merged Word cell, 2021-03-04), but this one is about how we handle table border painting when an inner border intersects with an outer border. Previously we used to paint the full outer border and the full inner border, which looks silly in case you have e.g. double border outside and a single border inside -- the inner line stops at the edge of the thick outer border in Word. Do the same by limiting the start of a horizontal line if its start would match the X coordinate of a vertical line (and the remaining 3 combinations of hori/vert line start/end). We always limit the inner line, so this needs extending SwLineEntry if the line is an outer one or not. Change-Id: I669a271ce3a4c3c69916779d4f3167208e999f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128053 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
13 daystdf146491 Revert "tdf121374 ooxmlexport: export H/F to def...Justin Luth2-1/+10
...default section" This reverts LO 6.3 commit e6f5dec3250b4d26bc4bb485fad2100ee29a3528. Something else must have changed because it doesn't seem to be needed anymore. It wouldn't be terrible to duplicate headers/footers unnecessarily, One side effect is that page styles could be duplicated multiple times if there were many non-overlapping sections. If the H/F contained images, that could bloat the filesize, or in this specific bug, it was duplicating fields. Since it doesn't appear to be necessary anymore, let's just revert it. Change-Id: Id95a4f162fb2ecbf6ce0f97db056071db9ebad3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128041 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
13 daysuse background XShapeGroup for bar-chart areaNoel Grandin1-1/+6
which means we don't have to set the Z-order, which is expensive for large charts. Shaves 5% off the load time Change-Id: I8c73df6ddc17a3cfedaa18dbe8ec3aeb768e3e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 daystdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapesAttila Bakos (NISZ)9-52/+74
Text boxes in group shapes were imported as shapes, losing complex text content: tables (tdf#66039), colors (tdf#73022), images (tdf#81958), lists, paragraph styles, hyperlinks (tdf#122960) and track changes. Note: a few unit tests have been deactivated temporarily. Test document "groupshape-trackedchanges.docx" of testGroupshapeTrackedchanges is imported correctly now: with track changes, and the test was modified accordingly. Follow-up to commit 2951cbdf3a6e2b62461665546b47e1d253fcb834 "tdf#143574 OOXML export/import of textboxes in group shapes". Change-Id: I6eb918dbf64393fd723fe43f798f93b5b9a12575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125051 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-05tdf#146489 writerfilter: ensure only character propertiesJustin Luth2-0/+62
This is another RTF regression found against LO 6.0's commit fdfdea4d5af51a68f2d497cc5c3359d74c385fd5 tdf#82173 writerfilter: apply char properties to footnote The original commit in LO 6.0 intended that only character properties were used. A follow-up commit for RTF tried to ensure that these would be on the top of the stack. However, in this case, it seems like somehow the table is getting involved in putting the paragraph context on the top. (Actually, there is no GetTopContextOfType(CONTEXT_CHARACTER) at all.) In any case, aFontProperties should only contain character properties, so ensure that. The unit test shows that there is still some kind of import problem, because the footnote marker should be a large, red character, but it is just normal text. See tdf#108949. Change-Id: I1ea7256891b198046f79f0d3a36e43d6c2ae3383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127943 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-01-05CppunitTest_sw_rtfexport5: rework to avoid mustTestImportOf()Miklos Vajna1-13/+10
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id694d789fdf68dbce4e323b74455798f48be53c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127972 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-04tdf#146264: Add unit testTor Lillqvist2-0/+16
Make sure the text is not duplicated in the output. Change-Id: I1600d18f0921d2ab2cb67898bc02b68f0f9b36c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127935 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-01-04Drop all commented SAL_DEBUG callsJan-Marek Glogowski1-7/+0
Change-Id: I3be7153d27b83766303519e73d1a355ba327871a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127929 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-03tdf#143574 OOXML export/import of textboxes in group shapesAttila Bakos (NISZ)7-12/+36
In this part, oox module has been modified in order to prepare for WPG handling during OOXML import. Note: Wpg is the drawingML equivalent of v:group, supporting text boxes in the group. 1) Added new parameter for WpgContext to support nested Wpg shapes, and WPS enabled for the WPG member shapes. 2) A bug has fixed, where group member line shape and connector shapes have wrong positions before in the group. 3) Unit tests had to be modified, and 3 of them disabled temporarily due to missing Writerfilter implementation (what will be the next commit) Now group shapes can have textboxes and the text is imported for that, but complex content is still missing (this will be fixed in writerfilter by the next commit). Known issue: WPG shapes with textboxes in floating table have issues during import at floating table conversion, so until this is not fixed this function is disabled for shapes in tables (will be fixed a follow-up commit later). Follow-up to commit 19394a924fdc486202ca27e318385287eb0df26f "tdf#143574 sw: textboxes in group shapes -- part 4". Change-Id: I71032187697807087bd8f27f7c3a7b052e174bd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124964 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-03tdf#98736 OOXML export: keep CaptionShape as TextShapeTünde Tóth1-0/+23
Caption shapes were lost during OOXML export. As a workaround, export them as text shapes, losing only the leader lines, but not their text shapes and text content. Change-Id: I372708fa4c9356c807a0a239c722691fd88ec1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126123 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-03tdf#129448: Auto first-line indent should not be effected by line spaceKevin Suo2-0/+56
Previously, if you set the first line indent to auto, then if you change the line height, the first line indent will also change. I do not see a reason to change the first line indent value in case of change in line spacing, even for English language. Some languages (e.g. Chinese) may have set the auto first line indent to be 2 characters of the current font, but if the first line indent changes when line height changes, then this 2-character rule is not possible. For compatibility with old documents, a compatability flag 'AutoFirstLineIndentDisregardLineSpace' is added in this patch, thus this patch only has effect to new ODF documents. DOC/DOCX documents will also benefit from this patch, no matter old or new, because, as Miklos Vajna has pointed out, Word does not have the auto first line height feature. Change-Id: I1e2ddc33cce4ff9b3b2b4122445894f724d5bcd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125627 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-02Fix typoAndrea Gelmini1-1/+1
Change-Id: I01e9575dd37d9e15538ea7e4d6d5d0f382840730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127850 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-30tdf#137737: sw: Add UItestXisco Fauli5-7/+74
Change-Id: I54c7925d9093153ba90d9aaf9a07d7729114b700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127714 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-30lok: don't limit line length in HTMLWriterSzymon Kłos2-0/+26
Problem: https://github.com/CollaboraOnline/online/issues/3645 Test case: 1. Open Collabora Online and paste "Alphabet" section from wikipedia article: https://en.wikipedia.org/wiki/Estonian_language#Alphabet 2. Select last two sentences (starting from "The letter") 3. Open Insert -> Hyperlink dialog Result: notice that some spaces was removed/converted into new line Expected: Text field should contain original text Hyperlink dialog uses current selection which is get as HTML from the core. In the SwHTMLWriter there is a parameter defining how long line should be and it replaces ' ' space into '\n' new line when limit is reached. This patch turns off that feature but only for getting html for current selection in LOK case. For now don't remove new line at the beginning as cypress has to be fixed first. Added FIXME in the code. Change-Id: I03b540b0b2d639a08774ecc4fc75abb7b3f0b7a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125482 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127680 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-12-29tdf#141908: CppUnittests: replace usage of sal_Int32 with ColorVaibhavMalik41871-66/+66
Change-Id: I8ae4004a2c38c418a51768b135cacee2acbfca8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127678 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-29tdf#141908: CppUnittests: replace usage of sal_Int32 with ColorVaibhavMalik41871-17/+17
Change-Id: Ia3060a154c69be198ee12baf90cef9ef7db8e6c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126656 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-12-27Fix typoAndrea Gelmini1-1/+1
Change-Id: I4591b016b087abb49de54f66eb947ba4004500f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127598 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-27tdf#146257: sw: better handling for list numbering = NONEVasily Melenchuk2-0/+32
Previously during refactoring were lost some corner cases with some level having disabled numbering. In this case LO should strip useless delimiters up to next level. For example, if second level has disabled numbering, third level should look like "1.1", but not "1..1". Change-Id: I259a16b456f51bc76d5c8360974d0acadfc36776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127517 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-12-23CppunitTest_sw_uiwriter3: use assert equal instead of !=Xisco Fauli1-2/+3
Change-Id: I27666c608b4265dd7fc515958c59f18d5b977796 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127358 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-23tdf#92161 add GB18030 encoding to iodetectdtm2-0/+14
Change-Id: I0f1201cb9cba13f70cb3430772612aa00fcc4b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127347 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-22tdf#135061: sw_uiwriter3: Add unittestXisco Fauli2-0/+36
Change-Id: Ied2ae576810a9f66e51883375959d372af59abe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127326 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-22tdf#143569: sw: Add UItestXisco Fauli2-0/+69
Change-Id: Ia87441c1b9ea2948981720fcc768d554ba474ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127319 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-22tdf#104823: unittestVasily Melenchuk2-1/+59
Ensure reading and writing to datasources Change-Id: Idbc907a21fe3b881d1b835ed0e8c795c4ea36863 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127311 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-12-22tdf#129625, tdf#144672: sw: Add UItestXisco Fauli2-0/+55
Change-Id: Ie6a4cc8b5d218112c56ff3cbba6a0c51ab30fb59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127309 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-22CppunitTest_sw_rtfexport: rework to avoid mustTestImportOf()Miklos Vajna1-25/+38
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I3937b6e91b5889f4ca0d7b2e9e66f09f505e7af2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127278 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-21tdf#127989 OOXML: fix import of transparent hatchingTünde Tóth1-0/+28
Set FillBackground property of hatching fill to false, if the alpha value is 0 in the <a:bgClr> element, i.e. if it's a transparent hatching. This way the previous non-transparent hatching is transparent now. Change-Id: I483d5c654be55e74c9073769b06f185526429635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126550 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-21tdf#146244 sw: fix Undo of accepting table row insertionLászló Németh1-1/+61
Fix Undo of accepting table row insertion to get back the "false" value of HasTextChangesOnly property and the associated light blue table row background. This fixes also the missing update of the table row background at accepting the table row insertion. Follow-up to commit 8c028b7e41e3d350d0e67005b16faf0159cc5c12 "tdf#146244 sw: update HasTextChangesOnly in modified rows". Change-Id: I8e2436b6b7b67f06037481955ff22cdbc2b22dc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127228 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-21tdf#134960 List hyperlinks in order of apperance in the documentJim Raykowski2-0/+43
in Writer Navigator Hyperlinks content type member list Change-Id: I0473c767478b1125acbb7e1b4bda99ac22934884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-12-20Fix typosAndrea Gelmini1-1/+1
Change-Id: Ib75af11e67cadd3522c2c4b94b0549c8a96b8464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127150 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>