path: root/sw/qa
AgeCommit message (Collapse)AuthorFilesLines
2016-08-18screenshots: fix Linux, exclude a few crashing dialogsArmin Le Grand1-1/+1
Change-Id: Ie06bb6b0bfd280e386bc418abdc496cb747f44b6
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand1-74/+2
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for svxArmin Le Grand2-228/+193
All *.ui files create a screenshot, but not all look useful Change-Id: I5aeec438b90488ea19cdb1251fee7dcf23e1c2cb
2016-08-18screenshots: add dialog test cases for writerArmin Le Grand2-0/+396
Writer has currently no known dialogs that get created with an opened writer document. There are some ui files that do not work with fallback (7), but most work (167). Not all look good, though. Change-Id: I92a6a5077e3a8c93148e162455093399ba1f99ed
2016-08-17sw: allow accept/reject of redline by indexMiklos Vajna1-0/+33
Previously .uno:AcceptTrackedChange / .uno:RejectTrackedChange always worked by cursor position, but redlines are stored in the redline table, so they have a unique index. Allow specifying that index when invoking the command, and in that case ignore the cursor position. The index is not stable after an insertion / deletion. Change-Id: I493a22e84800ded224fb6b9c61261744dc0fb64f Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-17tdf#95292 MM: add unit testJan-Marek Glogowski2-22/+90
bEndOfDB was handled inconsistently in ToNextRecord for record selections and normal record iteration. This unit test checks mail merge to generate the correct amount of three pages (actually five with the hidden, empty pages) for a five record data subset, mailing a linked label document with two labels. Previously the third / last page was missing. On Windows, this test originally failed, because the test document for synced labels opens the "synchronize" dialog, which is generated from an UI file, which are missing in the default test configuration. So this patch also switches the mail merge unit test to the "instdir configuration", which has locking enabled and prevents opening a documents twice. As a result we can't use a document for two test and have to load the source document for inspection after the UNO mail merge call, because it can just work with a file name as the source document. This way the document isn't opened twice, and the tests still pass on Windows. Change-Id: I98b33defc403c40b84af44d91ed7fdcf6cf347a3 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jan-Marek Glogowski <>
2016-08-17Use full absolute URL in footer-contain-hyperlink.docxStephan Bergmann1-0/+0
What this binary change does is change in the contained word/_rels/footer1.xml.rels from Target="" to Target="" because of: <sberg> vmiklos, do you know how sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx (introduced with 4654e9b113a66c800161d0ee82d587055fff4f8b ["fdo#74271: Added unit test & code changes for footer contains hyperlink."]) was created? It contains a word/_rels/footer1.xml.rels with a <Relationship Id="rId1" Type="" Target="" TargetMode="External"/>, where that Target="" is not a proper URL, but the testFooterContainHyper link test in sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx expects it to end up as "" <vmiklos> sberg: [...] that sounds like a bug, MSO resolves that as a regular relative file reference, i.e. to file:///...\ooxmlexport\data\ <sberg> vmiklos, ah, that's good to know; I'm trying to fix tdf#86087 ["FILESAVE FILEOPEN VIEWING: Can't open or save relative links in docx"] by turning relative URLs into absolute ones when reading docx etc. in writerfilter/source/dmapper/DomainMapper_Impl.cxx, but that now caused that test to fail <sberg> vmiklos, so I guess it's best to modify sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx to contain <> instead of merely <> <vmiklos> sberg: yes, i think so Change-Id: I7986acb66f260faaf8fe5398f3778cc35fb9930d
2016-08-16LOK unit tests: document what is a view callbackMiklos Vajna1-0/+1
Change-Id: Ic605ca12cebfb6fd8239829942bbc6a70f45ac06 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-16editeng: introduce OutlinerViewShell::NotifyOtherViews()Miklos Vajna1-0/+43
This allows notifying other views about e.g. cursor position changes even if SfxLokHelper::notifyOtherViews() is not accessible from editeng. Change-Id: I921e97344ffe562109a221f241e70b3f68ee9aaf Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-16tdf#100507 RTF import: don't set default para style to the 0th char styleMiklos Vajna2-0/+28
Regression from commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), the problem was that the RTF_PARD handler wanted to set a default paragraph style, but it didn't check if the 0th style is actually a paragraph one. This resulted in using a character style name as a paragraph one, throwing in SwUnoCursorHelper::SetTextFormatColl() -> all paragraph properties were lost, including the left indent. Fix this by tracking the style type, and filtering out character styles when looking up a default paragraph style. Change-Id: I41faab0e72667b89ec9a507014b395a675847abf
2016-08-16GSoC Writer Table Styles; Update by exampleJakub Trzebiatowski1-1/+25
+ Added possibility to update style by example. + Fixed SwTableAutoFormat::GetBoxFormat Change-Id: I80d9334ceda0ef7e0984fb54731850034b44cd44 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Miklos Vajna <>
2016-08-16new loplugin to check for static OUStringsNoel Grandin1-8/+8
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-08-15sw lok: limit undo/redo in SwDrawTextShellMiklos Vajna1-0/+34
So that one view can only undo/redo its own changes. This is used when editing shape text, as that doesn't use sw::UndoManager::GetLastUndoInfo(). Change-Id: Ibc3d6fcbd18398569190f06ed9b7399c54bb7d41
2016-08-15tdf#97090 writerfilter - don't fill_SOLID with auto colorJustin Luth2-0/+18
fixes a regression from 24077b2d52ab3d0fd0db5afb25d8b94b62386e3e <w:shd w:val="clear" w:color="auto" w:fill="auto"> seems to be the default "fill disabled" state, so don't force a solid white fill in that case. Change-Id: Ia421e52e228bbf0d3a2cd9af72e0a580042e5dcd Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>
2016-08-12add CVE-2016-3133 testcaseCaolán McNamara1-0/+0
Change-Id: Id147f208ff9db1cfdf3859df7090d0790a0e6400
2016-08-10sw undo: add a Repair argument to the .uno:Undo/Redo commandsMiklos Vajna1-0/+41
Undo/redo is limited to undo actions created by the same view in the LOK case, this argument removes this limit. This can be used by a client for "document repair" purposes, where undo/redo of others' changes is intentional. The sfx command dispatch has support for FASTCALL slots (a state function is not called, the command is always enabled) and also has support for state functions, but those functions only get the ID of the slots, not its parameters. What is needed here is a command that's disabled by default, but in case a Repair argument is used, then it's unconditionally enabled. So handle that case in the sfx dispatcher directly for now. Change-Id: I96c1130bf51abcdd722684b1fa4a8277f92fd555
2016-08-10sfx2: make SfxLokHelper::setView() set also the active frameMiklos Vajna1-0/+37
Without this, comphelper::dispatchCommand() doesn't work on the current frame. This causes e.g. undo not working when only a given view is allowed to do undo. In the desktop case vcl::Window::ImplGrabFocus() calls both SfxViewFrame::MakeActive_Impl() and framework::Desktop::setActiveFrame(), but in the LOK case the first was called directly, that's how the active frame was outdated. Change-Id: If97a9de316b4c8dd49e55cd273bdb2dfe9866f38 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-10GSoC Writer Table Styles; Create by example; fix undoJakub Trzebiatowski1-0/+35
- Create style by example, tracked by undo; - Fixed delete style, now is tracked by undo Change-Id: Ic39b549b0b970b1b15001d527a82fb26e4a630aa Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2016-08-09sw lok: limit undo/redo access to undo actions created by the same viewMiklos Vajna1-0/+28
So one view can't undo the changes of an other view by accident. If this is found to be useful in the desktop case, perhaps a dedicated config option can be added for it; for now the behavior is LOK-only. Change-Id: I7ff505d021bd6f6be36953ecc8f8bb971ce8927e Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-07Fix string concatenation in ww8export that breaks the build.Mark Hung1-7/+2
Fix what has been done in commit 07966a9. Replace string constant concatenation with a single constructor. Change-Id: I8a848cd0211a75321263b0b7413c079db9245471 Reviewed-on: Reviewed-by: Markus Mohrhard <> Tested-by: Markus Mohrhard <>
2016-08-05tdf#98739 recover CJK and CTL fonts after symbols.Mark Hung1-0/+15
This fix what has been done in 203e3c0f1190473d2e587a0801dc9f3883a6874a , which set CJK and CTL font in SwWW8ImplReader::Read_Symbol but didn't close CJK and CTL fonts in SwWW8ImplReader::ReadChars. Change-Id: I7c1d3b2a284d00a524a61785a5a94ca2d589295e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mark Hung <>
2016-08-04tdf#78506 RTF import: fix handling of invalid \levelnumbersMiklos Vajna2-0/+41
In case ';' is written in \u form in \levelnumbers, then Word ignores the whole \levelnumbers contents, do the same. Change-Id: I93ce5810af2b5ed703e804199c0b236d2c4c36b5 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-02editeng: track view shells in SfxListUndoActionsMiklos Vajna1-0/+32
This is needed for e.g. tracking deletions by backspace in Writer shape text. Change-Id: I6f873872566313096c2c57f4a13ac2f1db67e77d Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-08-02editeng: implement SfxUndoAction::GetViewShellId() interface in EditUndoMiklos Vajna1-0/+31
With this, e.g. inserting a character in a Writer shape text remembers its view shell. Change-Id: Ic82a3f45a66cf622496e3131390d365440dffb3b Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-07-28tdf#101168 sw: fix missing repaint on undo with multiple windowsMiklos Vajna1-0/+36
Need to lock / unlock all view shells, not just the current one. Change-Id: I754214a202c6bbb74daac6f933481cb3fe7b9dbb Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-07-28unit test for docprotection only when enforcedJustin Luth1-0/+7
Change-Id: I99cd5424855892846120c62b333d0e66aa3c7071 Reviewed-on: Reviewed-by: Justin Luth <> Tested-by: Justin Luth <>
2016-07-27tdf#75573 - docx don't remove frame anchor paragraphJustin Luth1-1/+1
frames anchor to the following paragraph. Don't remove an empty paragraph if it follows a frame or else the frame will jump to the next page. This gets a bit complicated because headers/footers contain paragraphs that aren't really "following" the frame paragraph, and so wouldn't be used as anchor paragraphs. There may be similar sub-paragraphs for comments etc, but exceptions for those can be added when proof documents are found. Change-Id: I46988b40abe65e23a5c407dde38a951937978005 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>
2016-07-27GSoC Writer Table Styles; Import bugfixJakub Trzebiatowski3-2/+16
+ Binary autoformats are loaded into document on document creation + Imported table styles overwrite existing styles. Change-Id: I88c08d1356e1c54a03624a051611357670f225ba Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2016-07-26tdf#75573 allow style to define vAnchorJustin Luth1-2/+2
If the default property value is valid, a style is never able to override. oddball default caused by commit 20c1a485774c7586401f6c1821c52f0bc39cb84a Rüdiger Timm <> 2008-04-18 11:36:12 (GMT) INTEGRATION: CWS xmlfilter04 (1.22.14); FILE MERGED 2008/03/05 11:07:44 os default vAnchor changed Change-Id: I665b52ae75a9282d51c79f3351315cf3fed4776c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>
2016-07-26svx lok: draw text edits in all viewsMiklos Vajna1-0/+35
Use case: a document has a shape with text, and two views. If one view starts to edit the shape text, the model text is hidden (via TextHierarchyEditPrimitive2D), and the in-progress text was painted directly only in the view that edits it. The remaining views presented the shape as if it had no text. This commit addresses the subset of this use case when the views are already created and they already show the same draw page. Fix the problem by looking for other views showing the same draw page, create a view of the text edit for them, and paint them in all views after the own text edit is painted. There is not much LOK-specific in this code, except that some extra code would be needed to not paint the blinking cursor of the text edit in other views, and then it could be enabled in the non-LOK case as well. Change-Id: Ib3096a3369fa56663ee209794e102090d362de66 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-07-25tdf#75573 - docx handle frame properties at stylesJustin Luth1-2/+14
A frame with only a style defined doesn't create paragraph properties, so the settings were just being ignored. If the stylesheet is the top context, then the settings belong to the style. If this slightly aggressive approach causes a regression, then just use the style only if the paragraph properties don't exist. Change-Id: I3b14205dc2bc5305f1eeb4cb72a812e877b532c7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>
2016-07-25new loplugin overrideparamNoel Grandin1-6/+6
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-07-22Fix --disable-pdfimport buildMiklos Vajna1-0/+3
Change-Id: Ida06b892aea92cfe26fd62372e21ca611d8838d3 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-07-22sw: add new LOK_CALLBACK_VIEW_LOCK callbackMiklos Vajna1-1/+48
When we're after SdrBeginTextEdit(), but before SdrEndTextEdit(), and have multiple views, then only the active view paints the edited text, the other views look like the shape has no text at all. Add a new callback that exposes the position and size of the rectangle where the shape text will be painted after text edit ended, so clients can draw some kind of locking indicator there. This way the rendered result can differ in the "shape has no text" and the "shape text is edited in an other view" cases. Change-Id: I6096479a8a05c2547d15222e6d997b848af02945 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-07-22Resolves: tdf#59896 ww6 plcf generation reversed checkCaolán McNamara2-0/+7
regression since... commit 69e040a59e1c6497b606da8a27e8f605edd041bb Author: Caolán McNamara <> Date: Sun Jul 17 00:19:00 2011 +0100 check seeks, check available size, pointers to ref Change-Id: Idfcde46959e5693d200a91a619e7196f00f40ca0
2016-07-19tdf#61901 RTF export: fix implicit font name of non-ascii textMiklos Vajna2-0/+27
The problem was that in case we used \loch, then \f only had an affect on ascii characters, not on every other character range. Change-Id: I30a851fe28131f18f5c429273a24c1424d2cec22 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-07-18Resolves: tdf#100731 include palette in checksumCaolán McNamara1-1/+1
Change-Id: I084d840b9fa078ebea3ff1471d8c8bc88171abc7
2016-07-18CppunitTest_sw_tiledrendering: blind stack-use-after-return fixMiklos Vajna1-0/+4
Change-Id: I23c0324979939955f94408a452020e9776358967
2016-07-15GSoC Writer Table Styles; Cell Style XPropertyStateJakub Trzebiatowski2-0/+59
Implemented XPropertyState for SwXTextCellStyle, that allows to skip export of default valued attributes. Implemented odfexport tests. Change-Id: I906c63d4937e378cf89750616fc9ec929c7f3e44 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Miklos Vajna <>
2016-07-15lok::Document::destroyView: clean up view cursors/selectionsMiklos Vajna1-1/+50
Change-Id: Icd3f96a922e7d1aec0d52e90df87ec45790c9807
2016-07-13GSoC Writer Table Styles export of paragraph and char propertiesJakub Trzebiatowski2-0/+208
+ Export of paragraph and character properties + Tests Change-Id: I689deb2c524fdcd462c69a33ad9bc2865890793d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page1-1/+0
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-07-12tdf75573 docx - complete frames before starting alternate streamsJustin Luth2-0/+7
An unused odd header was set to be discarded. The handling of unregistered frames occurred at the same time, and thus ended up being discarded as well. Since a frame shouldn't encompass both the alternate stream and the current stream, finalize any unfinished frames first. Change-Id: Ie9123769724da461dd265936aa6b97de7f4dfbbc Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2016-07-11tdf#99090 docx export page-break only inside a paragraphJustin Luth2-0/+7
If a paragraph hadn't been started yet, a w:r was being written directly in the /document/body which caused MSWord to complain about a corrupt document. Change-Id: Ie7f629869aab0f3d2405660a033c3f23bbd6baca Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>
2016-07-08sw lok: add LOK_CALLBACK_VIEW_CURSOR_VISIBLEMiklos Vajna1-2/+41
With this, in case a text cursor is turned into a graphic selection in view#0, then view#1 can also hide the text cursor of view#0. Change-Id: I7de89b8537ef8b0985336793b719d93733604bff Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-07-08tdf#64372 docx import: don't ignore continuous section breakJustin Luth4-0/+27
If the previous break was also a continuous section break, this break was simply ignored ever since commit 1fdd61db155cf63d5dd55cc2bfb45af33796e131. Thus, the default handler took over and assigned PROP_PAGE_DESC if there was some kind of page style known (either the first page/Standard defaults or any "converted" styles that had been created) which effectively became a new page break. Change-Id: I839570b0330ba274552cc671014e997c42765f4b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>
2016-07-08oox: indentation fixesMiklos Vajna1-1/+1
These files had consistently no space between the "const" and "&", keep it that way. Change-Id: I5463c488d807344d67fb22ad544c049ea749be94
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann3-6/+6
Change-Id: I7e7cdfa5efaf18bb47d40947d4e1d91a2c9b5a57
2016-07-07GSoC Writer Table Styles ImportJakub Trzebiatowski2-0/+40
This patch is implementing import of table styles (table-template). Modified shared code: Added "background" to the cell styles export. To make cell export properties map accessible by both export and import code, moved from xmloff/source/table/XMLTableExport.cxx to xmloff/txtprmap.hxx. To avoid export of default valued properties implemented XPropertyState for SwXTextCellStyle Change-Id: I8b4f12e4b51f478f8ce8fde1203cd4611d7ae852 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2016-07-07tdf#95367 inherit page style if no new one importedJustin Luth2-0/+5
CopyLastHeaderFooter doesn't do much good if the previous section has blank stylenames. (usually because of continuous section breaks). Change-Id: Ida1e42ab0b650c7c43f06539b3cc058fe5c27919 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Justin Luth <> Reviewed-by: Miklos Vajna <>