summaryrefslogtreecommitdiff
path: root/sw/qa/uitest
AgeCommit message (Collapse)AuthorFilesLines
2020-10-08tdf#137274: sw: Add UItestXisco Fauli1-0/+70
Change-Id: If0fbdb14ae4cc335dc99dc4e7df56356cf85f348 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104088 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-01uitest: factor out common duplicated codeXisco Fauli10-178/+24
Change-Id: Ib6d4edaf3bd1b0a4078c277d1139d7b0db479e2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103757 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-20Replace "Bahnschrift Light" with "DejaVu Sans"Caolán McNamara1-0/+0
Change-Id: Iebe86f54a8aa30de87db80f55ae201ec02ffb80c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11tdf#135693: sw: Add UItestXisco Fauli2-0/+37
Change-Id: If38daeb35ae8ba09aac50490a15c66dc0650f784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102485 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-11tdf#131581: sw: Add UItestXisco Fauli1-0/+44
Change-Id: Ie6fd0f0e9894f2795e87580e00f4d75272bb3c68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102462 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-10tdf#135950: sw: Add UItestXisco Fauli1-3/+26
I'm reusing the test for tdf#93068. We already have other tests where the Character dialog is used so a test only testing the dialog opens is recurrent Change-Id: I5b75be6a2b4ccef9a794be76f089a70ec0903665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102369 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-04tdf#117703: sw: Add UItestXisco Fauli2-0/+33
Change-Id: I4f5e5daf95171036489a5c67256e153154309b6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102049 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-03UITest_writer_tests: at least check the number of pages has changedXisco Fauli1-0/+3
and the tracked changes are shown follow-up of a658ece9f9fa308084c3e0f4662dda7afb9a0879 Change-Id: Icf4a482ad7e23cd34a063e3c1076e2b7849dd78c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101995 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-03UITest_writer_tests: don't assert exact page count at test_tdf135018() endMiklos Vajna1-2/+0
For example cd sw; make -sr UITest_writer_tests UITEST_TEST_NAME="trackedChanges.trackedchanges.test_tdf135018" fails for me like this: self.assertEqual(18, document.CurrentController.PageCount) AssertionError: 18 != 17 This is likely because the test document is not carefully preparted to only use bundled fonts. The test mentions that the primary point is to make sure we don't crash, so just give up on asserting the exact page number. Change-Id: I212c02995fd487526d4e2fab7b351d383f9b8459 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101980 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-02tdf#135018: sw: Add UItestXisco Fauli2-0/+32
Change-Id: Ia88e28b1569ea69df81d905cb76a6791a887ef3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101883 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-08-30Fix typosAndrea Gelmini1-7/+7
Change-Id: I041e65166eab9fc497742635fe59e11f63d55c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-27uitest : Change all the ValueSet uitest statments to CHOOSEAhmed ElShreif1-2/+2
instead of using "SELECT" which similar to other UIObjects we will write "CHOOSE" Change-Id: I32c1ab5f8a5dd21df87d90923d5821f8f0b16e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101265 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-21Add demo for FontWork SelectorAhmed ElShreif1-0/+42
As this selector is a ValueSet object so the support is added in this patch : https://gerrit.libreoffice.org/c/core/+/100373 The test case just test the selector by selecting different items . Change-Id: I0590c9b853572894130f17a05c0178e04b0fec41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100628 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-12Avoid repeated calls to document.DrawPage.getByIndex(0)Stephan Bergmann1-14/+16
I have seen various failures with (slow) ASan+UBSan builds where some other than the first one of those self.assertEqual failed. I would assume that they rather either all succeed or all fail (in which case consistently the first one in each of those self.assertEqual blocks should fail). To rule out the possibility that, for some timing/race reason, the identity of the element provided by document.DrawPage.getByIndex(0) changes midway through those blocks, only obtain that element once per block. Examples of such failures during UITest_writer_tests3 are <https://ci.libreoffice.org//job/lo_ubsan/1725/> > FAIL: test_insert_signature_line (insertSignatureLine.insertSignatureLine) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/insertSignatureLine.py", line 53, in test_insert_signature_line > self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerEmail, "Email") > AssertionError: None != 'Email' and my local build > FAIL: test_insert_signature_line2 (insertSignatureLine.insertSignatureLine) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/sbergman/lo/core/sw/qa/uitest/writer_tests3/insertSignatureLine.py", line 91, in test_insert_signature_line2 > self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineShowSignDate, False) > AssertionError: None != False Change-Id: I2739edb12ed39892f5b29999b9e3d632e166c1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100572 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-01Use a more conventional START/END_POS rangeStephan Bergmann1-1/+1
For the content of the selection it should not make a difference if that range is "backward" or "forward", but the latter looks cleaner. Change-Id: Ibc27ac257c9338f9b17ace10fbec938b1db394eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99932 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-01Remove the wait_until_property_is_updated calls againStephan Bergmann1-2/+0
They had been added with 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" and 1cdda798def040fe778348061c0e18b28aa0e6bd "Further timing issues with test_insert_hyperlink", but 63049e98a659290229d3356e76d49cea44575011 "Reliably set up controls of hyperlink dialog in constructor" now argues that they are probably not necessary after all: For one, they had presumably been added as blind fixes, without actually understanding what's going on (that's at least true for the second, monkey-see-monkey-do one by me). And for another, after I had seen their failures frequently with my local ASan+UBSan Linux build, I haven't seen them at all in lots of executions of that test with the 63049e98a659290229d3356e76d49cea44575011 fix included. So lets assume that those "magic" calls are indeed not necessary after all. If we run into trouble again, they can be added back. Change-Id: I6f4417c9fd243758a03a4de05270f342e7147d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99931 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-29Further timing issues with test_insert_hyperlinkStephan Bergmann1-0/+1
<https://ci.libreoffice.org/job/lo_ubsan/1709/> still failed with > FAIL: test_insert_hyperlink (hyperlinkdialog.HyperlinkDialog) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/hyperlinkdialog.py", line 71, in test_insert_hyperlink > self.assertEqual(get_state_as_dict(xindication)["Text"], "link") > AssertionError: '' != 'link' > + link > so try a fix similar to 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" Change-Id: I04b1616f3c5028065aafadbd73e0e52ef220ce5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99669 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-28uitest : Avoid any timing issue in test_insert_hyperlinkAhmed ElShreif1-0/+1
Change-Id: I090e28fb6d902ff0e2f9e7a9ef447133a29a85a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99520 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-16tdf#127652: move UItest to CppunitTestIlmari Lauhakangas2-56/+0
Change-Id: Id04414d00f92a0c32c38a9dd706d6656ba280746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98597 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-14uitest : Add demo for "bottom find bar" using ToolBox supportAhmed ElShreif1-0/+71
Change-Id: Ie586851be1e9131394ac0103837b26f408026dca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98596 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-09uitest : Fix the old demo of writer commentsAhmed ElShreif1-0/+160
This test case is added as the old test case here: https://gerrit.libreoffice.org/c/core/+/96295 makes some randomly fail. I tried to fix this in the new test case . By trying to run the old test case multiple times locally . The problem was when you execute Command to add new comment . Sometimes the comment doesn't have enough time to be created and added as a child in the MainWindow Object So test case fails . So the fix was to use this function: "ui_test.wait_until_child_is_available(parent, childName)" This will make sure that that the comment was created successfully and added as a child in the MainWindow to be selected in next lines . I tried to run the test case again multiple times in my laptop and it never fails . Change-Id: I51e4b0802f3fa92139cbc6cdc7092c119e49d1b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96752 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-08uitest : sw: Add UItest for Hyperlink DialogAhmed ElShreif1-0/+83
This test case tests the Hyperlink Dialog in inserting a Hyperlink . Also it tests the Vertical TabControl Support that added here: https://gerrit.libreoffice.org/c/core/+/98135 Change-Id: Ic7975cc12425dbcba24b0261404585ded006e5e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98160 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-03uitest : Add demo for SvxNumValueSet supportAhmed ElShreif1-0/+81
The demo is just a test case added to BulletsAndNumbering Dialog test cases . The BulletsAndNumbering Dialog has 4 SvxNumValueSet so The test case works with each one of them . We now have support for "Writer: Format-Bullets and numbering dialog- Selection" item . Change-Id: I3a0827991a5fd004489459feb7c49214c9e2b766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97341 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-30tdf#134243: sw: Add UItestXisco Fauli3-0/+30
Change-Id: I59376419048ddddff3e4fbbd6d3eb7436ee87747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97029 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26UITest_writer_tests7: wait until the child is available (blind fix)Xisco Fauli1-0/+4
it fails spuriously with Traceback (most recent call last): File "sw/qa/uitest/writer_tests7/tdf99711.py", line 43, in test_tdf99711 self.assertEqual(get_state_as_dict(xWriterEdit.getChild('selectwidth'))['Text'], '10.00 mm') uno.com.sun.star.uno.RuntimeException: Could not find child with id: selectwidth Change-Id: If80dac67880a1f4200331a7894ba2ecae4504bb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97184 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25UITest_writer_tests7: Wait for async events (blind fix)Xisco Fauli1-0/+4
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62483/> failed spuriously with ERROR: test_tdf133348 (tdf133348.tdf133348) ---------------------------------------------------------------------- Traceback (most recent call last): File "sw/qa/uitest/writer_tests7/tdf133348.py", line 44, in test_tdf133348 self.assertEqual(xEnum.nextElement().Author.strip(), 'Known Author') tdf133348.com.sun.star.container.NoSuchElementException: SwXFieldEnumeration::nextElement Change-Id: I5504f6febb20eb174b480f0d38176b1a70407716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97097 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-18Revert "uitest: Add demo for Writer-comments"Stephan Bergmann1-156/+0
This reverts commit ba33a51ff1eb34a5983870dcb50e975002e6d3a4. Reason for revert: These new tests do not only occasionally fail for <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/> (see comment at <https://gerrit.libreoffice.org/c/core/+/96295/11# message-50341d16b29be9704f1c25bf59e27ab6aa20a1ec> "uitest: Add demo for Writer-comments", they also appear to massively impact Jenkins builds of Gerrit master changes, see e.g. <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62008/>, <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62002/>, and <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/61999/>. Change-Id: Ibad0e0523fa15491212c283cada4b1c51b22dea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96636 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-18uitest: Add demo for Writer-commentsShiko1-0/+156
Change-Id: Iaf7c4c646a1f64f0a97c95fd7133da89da44c7d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96295 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-10tdf#132597: sw: Add UItestXisco Fauli2-0/+48
Change-Id: I0f577b5124c871e9ba766958d81511ad3ad0e5e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96014 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-09tdf#132596: sw: Add UItestXisco Fauli2-0/+49
Change-Id: I899de72a02a7501917b13346d304338bb4548ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95902 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-09tdf#133169: sw: Add UItestXisco Fauli1-0/+6
Change-Id: I6d86e8f8ef1b1ffe32e45c7ead75387f6fcee2fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95901 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-05-29tdf#131963: sw: Add UItestXisco Fauli2-0/+43
Change-Id: I44a3ce4c4a032a22882563567fdb966e6c14922c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95134 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-05-28tdf#133348: sw: Add UItestXisco Fauli1-0/+59
Change-Id: I8074efe8f65131c6f1ebb030c9e8cf8b9c60aaa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95039 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-05-26uitest: replace sleep with processEventsToIdleXisco Fauli1-4/+4
Change-Id: I48798e98718cae11b9ef7902cb48fe2d8ab9c2b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94812 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-26tdf#130456 sw: enable semi-transparent text for char style dialogMiklos Vajna1-0/+39
The code is shared, so this fixed the para style dialog as well. Change-Id: I742231bf76c562b3255700fc4eeb4c870c3deb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94805 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-25UITest_writer_tests4: fix this under high loadMiklos Vajna1-1/+3
The failure I had: ====================================================================== FAIL: test_tdf113284 (tdf113284.tdf113284) ---------------------------------------------------------------------- Traceback (most recent call last): File "sw/qa/uitest/writer_tests4/tdf113284.py", line 34, in test_tdf113284 self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], str(xPageCount)) AssertionError: '1' != '91' - 1 + 91 ? + And with this in place 'make check' passes just fine. I assume the go to page dialog goes to the relevant page in an async way. Change-Id: Ic4b2a755c589f113af58b5fb3e43f537a52a50d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94803 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-25uitest: use fixed values for width and heightXisco Fauli1-25/+36
Change-Id: Id7217392a94ba79f5737a95b056a8f53281e5844 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94792 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-25Do not time out execute_dialog_through_commandStephan Bergmann1-2/+1
If something goes wrong, better keep the testing Python and the tested soffice process in a state in which the actual problem can (hopefully) be debugged better. I happened to run into a hung UITest_options on Linux, where soffice.bin was still at > Thread 1 (Thread 0x7fa6371d9fc0 (LWP 1210042)): > #0 futex_abstimed_wait_cancelable (private=0, abstime=0x7fa633a17f80, clockid=<optimized out>, expected=0, futex_word=0x60e000024e88) at /usr/src/debug/glibc-2.31-17-gab029a2801/sysdeps/nptl/futex-internal.h:320 > #1 __pthread_cond_wait_common (abstime=0x7fa633a17f80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:520 > #2 __pthread_cond_clockwait (abstime=0x7fa633a17f80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:677 > #3 __pthread_cond_clockwait (cond=0x60e000024e60, mutex=0x60e000024e38, clockid=<optimized out>, abstime=0x7fa633a17f80) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:665 > #4 0x00007fa66899be08 in std::condition_variable::__wait_until_impl<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:210 > #5 0x00007fa66899b895 in std::condition_variable::wait_until<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:120 > #6 0x00007fa668997505 in std::condition_variable::wait_until<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> >, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __atime=..., __p=...) at include/c++/10.0.1/condition_variable:159 > #7 0x00007fa668995460 in std::condition_variable::wait_for<long, std::ratio<1l, 1000l>, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::duration<long, std::ratio<1l, 1000l> > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __rtime=..., __p=...) at include/c++/10.0.1/condition_variable:186 > #8 0x00007fa66899408e in SvpSalInstance::DoYield(bool, bool) (this=0x611000001bc0, bWait=true, bHandleAllCurrentEvents=false) at vcl/headless/svpinst.cxx:497 > #9 0x00007fa667e7114d in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:455 > #10 0x00007fa667e70708 in Application::Yield() () at vcl/source/app/svapp.cxx:519 > #11 0x00007fa66498f6cd in Dialog::Execute() (this=0x618003c16480) at vcl/source/window/dialog.cxx:1030 > #12 0x00007fa667a93812 in SalInstanceDialog::run() (this=0x616000575780) at vcl/source/app/salvtables.cxx:1482 > #13 0x00007fa2e8711b8d in weld::DialogController::run() (this=0x60c004e70d80) at include/vcl/weld.hxx:2289 > #14 0x00007fa2e98a6cbc in OfaTreeOptionsDialog::run() (this=0x60c004e70d80) at cui/source/options/treeopt.cxx:1937 > #15 0x00007fa2e90c4d15 in CuiAbstractController_Impl::Execute() (this=0x60300187b4f0) at cui/source/factory/dlgfact.cxx:103 > #16 0x00007fa688bc9b2d in SfxApplication::OfaExec_Impl(SfxRequest&) (this=0x604006f2fe10, rReq=...) at sfx2/source/appl/appserv.cxx:1311 > #17 0x00007fa688b17655 in SfxStubSfxApplicationOfaExec_Impl(SfxShell*, SfxRequest&) (pShell=0x604006f2fe10, rReq=...) at workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:1270 > #18 0x00007fa6892521f6 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (this=0x604006f2fe10, pFunc=0x7fa688b17530 <SfxStubSfxApplicationOfaExec_Impl(SfxShell*, SfxRequest&)>, rReq=...) at include/sfx2/shell.hxx:197 > #19 0x00007fa6891dbb1f in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x6020013430b0, rShell=..., rSlot=..., rReq=..., bRecord=true) at sfx2/source/control/dispatch.cxx:252 > #20 0x00007fa6891defd6 in SfxDispatcher::PostMsgHandler(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) (this=0x6020013430b0, pReq=std::unique_ptr<class SfxRequest> = {...}) at sfx2/source/control/dispatch.cxx:989 [...] but the Python process was already at > Traceback (most recent call first): > <built-in method waitpid of module object at remote 0x60800002d140> > File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1611, in _try_wait > (pid, sts) = os.waitpid(self.pid, wait_flags) > File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1653, in _wait > (pid, sts) = self._try_wait(0) > File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1019, in wait > return self._wait(timeout=timeout) > File "uitest/libreoffice/connection.py", line 133, in tearDown > ret = self.soffice.wait() > File "uitest/libreoffice/connection.py", line 178, in tearDown > self.connection.tearDown() > File "uitest/uitest/framework.py", line 46, in tearDown > self.connection.tearDown() > File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 631, in run > self.tearDown() > File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 676, in __call__ > return self.run(*args, **kwds) > File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 122, in run > test(result) > File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 84, in __call__ > return self.run(*args, **kwds) > File "instdir/program/python-core-3.7.7/lib/unittest/runner.py", line 176, in run > test(result) > File "uitest/test_main.py", line 128, in <module> > result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(test_suite) and the relevant > ====================================================================== > ERROR: test_tdf78133_options_app_colors (tdf78133.tdf78133) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sw/qa/uitest/options/tdf78133.py", line 38, in test_tdf78133_options_app_colors > self.ui_test.execute_dialog_through_command(".uno:OptionsTreeDialog") #optionsdialog > File "uitest/uitest/test.py", line 78, in execute_dialog_through_command > raise DialogNotExecutedException(command) > uitest.test.DialogNotExecutedException: Dialog not executed for: .uno:OptionsTreeDialog had not yet been written to workdir/UITest/options/done.log (Python's unittest appears to unhelpfully hold back such vital information until the very end of the full test run). There appears to be no test code that relies on a timed-out execute_dialog_through_command throwing an exception instead of hanging (at least, there is no explicit catching of DialogNotExecutedException anywhere in the code, and a full `make check screenshot` on Linux kept working with this change). (This is similar to 19d3dba72fd744ab8dc1288b1c7c4c811b24ca28 "Do not time out close_dialog_through_button".) Change-Id: Ie907a091ae09b59e65c4b2676298e147c9d2da2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94786 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-25uitest: rework test that fails at timesXisco Fauli1-5/+12
sometimes it fails with self.assertEqual(get_state_as_dict(xLineMetric)["Text"], "5.0 pt") AssertionError: '8.8 pt' != '5.0 pt' - 8.8 pt + 5.0 pt Change-Id: I5287d5ebbd92ef82bd384f609b92fbcfeef7fd44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94778 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-24tdf#133189, tdf#129267: sw: Add UItestXisco Fauli1-0/+82
Change-Id: I01cf8e0b263c927fd03e715640e7f825dbb1bbd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94755 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-23uitest: add wrapper for macro editorXisco Fauli1-0/+11
Change-Id: I729c5cdbc3ba925a0c08750eba199a400babba1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94445 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-05-22uitest: Add wait methods for slow elementsXisco Fauli2-14/+7
some elements take some time to be updated, specially with slow machines or ASan+UBSan builds Use the same time based approach used for launching the dialogs also reintroduce 634ce6f2d87a30b8abd2e8c67668e3bb5d87406b Change-Id: Ia1cca74474ef65578bbc60a53a8a511402a082b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94648 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-20tdf#132169: sw: Add UItestXisco Fauli1-0/+61
Change-Id: I7f0f17bc96d73cead6c8fd4269ea7cee1d85bca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94552 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-20tdf#tdf99711: sw: Add UITestXisco Fauli2-0/+51
Change-Id: Ic03d43de5b83addcc25e857ae198ffcdd769f775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94551 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-18tdf#128782: move UItest to CppunitTestXisco Fauli2-45/+0
Change-Id: I98319183a7bd9abb9ed6b1dd9f85cf00ee701fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94405 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-18sw: UITest_writer_dialogs: disable MailMergeWizardMichael Stahl1-1/+2
In a build via ssh, the test hangs while trying to connect to Evolution Data Server that presumably isn't running: 1 in g_cond_wait () at /lib64/libglib-2.0.so.0 2 in e_flag_wait () at /lib64/libedataserver-1.2.so.24 3 in e_client_wait_for_connected_sync () at /lib64/libedataserver-1.2.so.24 4 in e_book_client_connect_sync () at /lib64/libebook-1.2.so.20 5 in e_book_client_connect_direct_sync () at /lib64/libebook-1.2.so.20 6 in connectivity::evoab::(anonymous namespace)::OEvoabVersion38Helper::createClient(ESource*) (this=0x912d150, pSource=0x90c0660) at connectivity/source/drivers/evoab2/NResultSet.cxx:480 ... 35 in SwMailMergeConfigItem::GetResultSet() const (this=0x8f10b30) at sw/source/uibase/dbui/mmconfigitem.cxx:875 ... 63 in SwMailMergeWizard::SwMailMergeWizard(SwView&, std::shared_ptr<SwMailMergeConfigItem> const&) (this=0x8f0f340, rView=..., rItem=std::shared_ptr<SwMailMergeConfigItem> (use count 3, weak count 0) = {...}) at sw/source/ui/dbui/mailmergewizard.cxx:60 Change-Id: I1b43b05509f4e293ce1f00044a05f045bf975ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94364 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-06Resolves: tdf#123801 captioning issuesCaolán McNamara1-2/+2
revert attempt to by default create a msword roundtrip friendly caption. commit 2333786aa0eaf70c45c80e546239fb3565b1b4e7 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Mar 20 11:48:28 2018 +0000 Resolves: tdf#116474 bring hidden text property under undo control commit ebd43aee5b9cf98ed96ce28985267ad0bc980b7a Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Apr 7 13:41:38 2017 +0100 rework setting hidden property on line break commit feedd45ba2dd308af2d3a1b2f64681b9467535b6 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Oct 27 14:37:03 2016 +0100 in msword the hard-break between image and caption has a width commit ba401ee10be2fb051bc961680f35b04e4e77a32d Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 1 09:39:37 2016 +0100 coverity#1372378 Dereference null return value commit 93ab0ff24cb71c36c9e7958046e96d7472b5af90 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 10 15:46:57 2015 +0100 Related: tdf#93676 default to as-char inside captions Change-Id: I460046a10f36bed13e2f4651b4c0a9b9b0662015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-06tdf#132373 Remove blinking character property from the UI/editorGabor Kelemen2-6/+0
So far from document body and Character properties tab only. Importing and exporting existing files still works. Change-Id: I42179b47c64fe5c7db0393d0d4373363d772b51e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92875 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-03Related tdf#131125: Improperly used ampersandJulien Nabet1-1/+1
Really search all occurences of Find & Replace Change-Id: I1c1301451afa4d339902a275594ecb4cd46030db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93331 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-29[API CHANGE] uitest: make HasInfoBarWithID accessible from APIXisco Fauli1-10/+24
This is useful for checking in uitests whether the infobar exists Change-Id: I436c2659abd40756673634f7cd1f8e4846c03836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92635 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>