summaryrefslogtreecommitdiff
path: root/sw/qa/extras
AgeCommit message (Collapse)AuthorFilesLines
11 hourstdf#140731: sw: move UItest to CppUnittestXisco Fauli1-0/+72
Change-Id: Ib72e03d2ca089ee86fa6d9dd4ae7d555be56ff4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128710 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
34 hourstdf#128375: sw_uiwriter3: Add unittestXisco Fauli2-0/+22
Change-Id: I24b862d23d2e8dd9fbe930043457963f4cceec1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128636 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2 daystdf#139638: sw_uiwriter3: Add unittestXisco Fauli2-0/+14
Change-Id: I7b98453b629734b4b07830687d1ec26b4bd468ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111834 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2 daysCppunitTest_sw_odfexport2: rework to avoid mustTestImportOf()Miklos Vajna1-12/+5
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id6d45cfa011a45b0e8ef9f486498d6a89af8e49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128574 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
3 daystdf#146515: sw_ooxmlexport4: Add unittestXisco Fauli2-0/+7
Change-Id: Ib273156124a677fc774340dbd780393dfbd3070b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128548 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#145321: sw_uiwriter3: Add unittestXisco Fauli2-0/+24
Change-Id: Id64d3469ed1bd4c38e684c4af0c20121a81043fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128552 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
6 daysrequest the 2nd rect explicitly instead of one with a particular 'top' valueCaolán McNamara1-1/+1
Change-Id: I04caee2263e5e7345fb3fb0c07830d1bf504bf7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
7 dayssw tests: audit uses of loadAndSave()Miklos Vajna9-16/+16
When it comes to changing import + import-export-import tests to do only import-export instead, this is only safe if we assert the resulting exported XML. Replace calls to loadAndSave() with loadAndReload() when we want to assert the doc model after an export. Thanks to Justin for flagging this, luckily it seems there is only a single test that fails after restoring the lost asserts (and that has already been fixed). Change-Id: I62cd4330c62d801dd9e6c7ef73decab3972c0b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128411 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
7 daysRestore tdf#134951 docxexport: stop duplicating stuff in postponed textMichael Stahl1-0/+3
Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3 to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported by jluth the test case testfdo79008 that failed was apparently somewhat misleading and the test case testTdf134951_duplicates that should test comments erroneously failed to fail because it is doing a loadAndSave() instead of a loadAndReload(). Change-Id: I7e788287da3b1742f65697ec350997d175db9e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
9 daysCppunitTest_sw_odfexport: rework to avoid preTest()Miklos Vajna1-40/+31
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ie7187c7a843a191475688a4a6390514199c6a1c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128298 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
12 daysMove HAVE_MORE_FONTS into an extra config headerJan-Marek Glogowski8-0/+8
No need to recompile most of LibreOffice, because the --with-fonts configure flag changed. This preprocessor define is just used by unit tests anyway. Change-Id: Ia2eae7d0c74e59e034fdd8513504a34e51ab428e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128197 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin1-1/+1
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07remove debug codeNoel Grandin1-5/+0
accidtionally committed with commit 302b44125aa0c1d5216f986ecf8e341cd6e57418 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Dec 9 11:45:36 2021 +0200 use background XShapeGroup for bar-chart area Change-Id: Id9fd82a94fd2bb046901fcd4373aac71586d0d13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128057 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06tdf146491 Revert "tdf121374 ooxmlexport: export H/F to def...Justin Luth2-1/+10
...default section" This reverts LO 6.3 commit e6f5dec3250b4d26bc4bb485fad2100ee29a3528. Something else must have changed because it doesn't seem to be needed anymore. It wouldn't be terrible to duplicate headers/footers unnecessarily, One side effect is that page styles could be duplicated multiple times if there were many non-overlapping sections. If the H/F contained images, that could bloat the filesize, or in this specific bug, it was duplicating fields. Since it doesn't appear to be necessary anymore, let's just revert it. Change-Id: Id95a4f162fb2ecbf6ce0f97db056071db9ebad3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128041 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-01-06use background XShapeGroup for bar-chart areaNoel Grandin1-1/+6
which means we don't have to set the Z-order, which is expensive for large charts. Shaves 5% off the load time Change-Id: I8c73df6ddc17a3cfedaa18dbe8ec3aeb768e3e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapesAttila Bakos (NISZ)9-52/+74
Text boxes in group shapes were imported as shapes, losing complex text content: tables (tdf#66039), colors (tdf#73022), images (tdf#81958), lists, paragraph styles, hyperlinks (tdf#122960) and track changes. Note: a few unit tests have been deactivated temporarily. Test document "groupshape-trackedchanges.docx" of testGroupshapeTrackedchanges is imported correctly now: with track changes, and the test was modified accordingly. Follow-up to commit 2951cbdf3a6e2b62461665546b47e1d253fcb834 "tdf#143574 OOXML export/import of textboxes in group shapes". Change-Id: I6eb918dbf64393fd723fe43f798f93b5b9a12575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125051 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-05tdf#146489 writerfilter: ensure only character propertiesJustin Luth2-0/+62
This is another RTF regression found against LO 6.0's commit fdfdea4d5af51a68f2d497cc5c3359d74c385fd5 tdf#82173 writerfilter: apply char properties to footnote The original commit in LO 6.0 intended that only character properties were used. A follow-up commit for RTF tried to ensure that these would be on the top of the stack. However, in this case, it seems like somehow the table is getting involved in putting the paragraph context on the top. (Actually, there is no GetTopContextOfType(CONTEXT_CHARACTER) at all.) In any case, aFontProperties should only contain character properties, so ensure that. The unit test shows that there is still some kind of import problem, because the footnote marker should be a large, red character, but it is just normal text. See tdf#108949. Change-Id: I1ea7256891b198046f79f0d3a36e43d6c2ae3383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127943 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-01-05CppunitTest_sw_rtfexport5: rework to avoid mustTestImportOf()Miklos Vajna1-13/+10
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Id694d789fdf68dbce4e323b74455798f48be53c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127972 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-04tdf#146264: Add unit testTor Lillqvist2-0/+16
Make sure the text is not duplicated in the output. Change-Id: I1600d18f0921d2ab2cb67898bc02b68f0f9b36c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127935 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-01-03tdf#143574 OOXML export/import of textboxes in group shapesAttila Bakos (NISZ)7-12/+36
In this part, oox module has been modified in order to prepare for WPG handling during OOXML import. Note: Wpg is the drawingML equivalent of v:group, supporting text boxes in the group. 1) Added new parameter for WpgContext to support nested Wpg shapes, and WPS enabled for the WPG member shapes. 2) A bug has fixed, where group member line shape and connector shapes have wrong positions before in the group. 3) Unit tests had to be modified, and 3 of them disabled temporarily due to missing Writerfilter implementation (what will be the next commit) Now group shapes can have textboxes and the text is imported for that, but complex content is still missing (this will be fixed in writerfilter by the next commit). Known issue: WPG shapes with textboxes in floating table have issues during import at floating table conversion, so until this is not fixed this function is disabled for shapes in tables (will be fixed a follow-up commit later). Follow-up to commit 19394a924fdc486202ca27e318385287eb0df26f "tdf#143574 sw: textboxes in group shapes -- part 4". Change-Id: I71032187697807087bd8f27f7c3a7b052e174bd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124964 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-03tdf#98736 OOXML export: keep CaptionShape as TextShapeTünde Tóth1-0/+23
Caption shapes were lost during OOXML export. As a workaround, export them as text shapes, losing only the leader lines, but not their text shapes and text content. Change-Id: I372708fa4c9356c807a0a239c722691fd88ec1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126123 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-02Fix typoAndrea Gelmini1-1/+1
Change-Id: I01e9575dd37d9e15538ea7e4d6d5d0f382840730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127850 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-30lok: don't limit line length in HTMLWriterSzymon Kłos2-0/+26
Problem: https://github.com/CollaboraOnline/online/issues/3645 Test case: 1. Open Collabora Online and paste "Alphabet" section from wikipedia article: https://en.wikipedia.org/wiki/Estonian_language#Alphabet 2. Select last two sentences (starting from "The letter") 3. Open Insert -> Hyperlink dialog Result: notice that some spaces was removed/converted into new line Expected: Text field should contain original text Hyperlink dialog uses current selection which is get as HTML from the core. In the SwHTMLWriter there is a parameter defining how long line should be and it replaces ' ' space into '\n' new line when limit is reached. This patch turns off that feature but only for getting html for current selection in LOK case. For now don't remove new line at the beginning as cypress has to be fixed first. Added FIXME in the code. Change-Id: I03b540b0b2d639a08774ecc4fc75abb7b3f0b7a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125482 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127680 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-12-29tdf#141908: CppUnittests: replace usage of sal_Int32 with ColorVaibhavMalik41871-66/+66
Change-Id: I8ae4004a2c38c418a51768b135cacee2acbfca8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127678 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-29tdf#141908: CppUnittests: replace usage of sal_Int32 with ColorVaibhavMalik41871-17/+17
Change-Id: Ia3060a154c69be198ee12baf90cef9ef7db8e6c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126656 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-12-27Fix typoAndrea Gelmini1-1/+1
Change-Id: I4591b016b087abb49de54f66eb947ba4004500f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127598 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-27tdf#146257: sw: better handling for list numbering = NONEVasily Melenchuk2-0/+32
Previously during refactoring were lost some corner cases with some level having disabled numbering. In this case LO should strip useless delimiters up to next level. For example, if second level has disabled numbering, third level should look like "1.1", but not "1..1". Change-Id: I259a16b456f51bc76d5c8360974d0acadfc36776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127517 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-12-23CppunitTest_sw_uiwriter3: use assert equal instead of !=Xisco Fauli1-2/+3
Change-Id: I27666c608b4265dd7fc515958c59f18d5b977796 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127358 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-23tdf#92161 add GB18030 encoding to iodetectdtm2-0/+14
Change-Id: I0f1201cb9cba13f70cb3430772612aa00fcc4b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127347 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-22tdf#135061: sw_uiwriter3: Add unittestXisco Fauli2-0/+36
Change-Id: Ied2ae576810a9f66e51883375959d372af59abe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127326 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-22tdf#104823: unittestVasily Melenchuk2-1/+59
Ensure reading and writing to datasources Change-Id: Idbc907a21fe3b881d1b835ed0e8c795c4ea36863 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127311 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-12-22CppunitTest_sw_rtfexport: rework to avoid mustTestImportOf()Miklos Vajna1-25/+38
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I3937b6e91b5889f4ca0d7b2e9e66f09f505e7af2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127278 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-21tdf#127989 OOXML: fix import of transparent hatchingTünde Tóth1-0/+28
Set FillBackground property of hatching fill to false, if the alpha value is 0 in the <a:bgClr> element, i.e. if it's a transparent hatching. This way the previous non-transparent hatching is transparent now. Change-Id: I483d5c654be55e74c9073769b06f185526429635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126550 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-21tdf#146244 sw: fix Undo of accepting table row insertionLászló Németh1-1/+61
Fix Undo of accepting table row insertion to get back the "false" value of HasTextChangesOnly property and the associated light blue table row background. This fixes also the missing update of the table row background at accepting the table row insertion. Follow-up to commit 8c028b7e41e3d350d0e67005b16faf0159cc5c12 "tdf#146244 sw: update HasTextChangesOnly in modified rows". Change-Id: I8e2436b6b7b67f06037481955ff22cdbc2b22dc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127228 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-20Fix typosAndrea Gelmini1-1/+1
Change-Id: Ib75af11e67cadd3522c2c4b94b0549c8a96b8464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127150 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-20tdf#104823: support for sdt plain text fieldsVasily Melenchuk6-23/+24
This is a squashed commit containing set of changes: * Create a input field from sdt text block. * Advanced support for reading field data from data bindings which can point to custom xml or properties xml. For this XOOXMLDocumentPropertiesImporter idl interface was extrended with extra getterrs to get properties as xml dom elements. * Support for exporting of this feature back to docx. For this some extra parameters for sdt block are kept in newly introduced grabbag for input fields. If field does not contain grabbag it being exported as before (FILLIN or whatsoever), otherwise sdt block is counstructed based on data from grabbag. * Basic support for updating custom xml values back into custom xmls with usage of xslt transformations. To achieve this extra parameters were introduced to XXSLTTransformer: now it is able to support in-memory transformation stylesheets. Some unittests were corrected: since sdt plain text edit area is a field located inside paragraph in outout corresponding sdt is also located inside paragraph (instead of Word's approach with paragraph inside sdt). Seems this is not critical. Change-Id: I1a73ef300db3619804f7adf18579bea708764c14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127015 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-18tdf#144364 sw: Revert "Use FastParser in SwXMLTextBlocks"Justin Luth1-0/+19
This reverts 7.0 commit fd6feb4f538b0c5c9061529ff002be9f62a7239a. Noel said this was just a performance fix, so just go ahead and revert it. It caused the regression documented in bug 144364. Change-Id: I044c49e42873db120a94d93a00e9b35105778b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127012 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2021-12-17tdf#137318 sw_redlinehide: fix JoinNext() if deleted node contains redlinesMichael Stahl1-0/+68
The GetRedlineMergeFlag() of the deleted node is None also if there are deletions contained completely inside the node, but in this case the merged node does need a MergedPara, so check if the deleted node had a frame that has a MergedPara in addition to the flag (which remains as an "optimization"). (regression from d258fc29560baa5ecae03ebc2740e11420643e27) Change-Id: I44456f230374ec1de159106678e80fb4670c9f33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127011 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-12-17loplugin:unusedvariablecheck improveNoel Grandin1-1/+0
to find unused smart pointer variables Change-Id: I200bdd8949032a0e061de61f7903a156651793e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127006 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-17tdf#146244 sw: update HasTextChangesOnly in modified rowsLászló Németh1-0/+75
It's not forbidden to write in rows deleted or inserted with change tracking, also Accept/Reject only part of the text changes here. Improve to handle these in SwTableLine::UpdateTextChangesOnly() by keeping property HasTextChangesOnly = false (tracked row change) only if 1) there is an insert redline, which is the oldest redline in the row (tracked row insertion) or 2) there is a delete redline, which is the newest redline in the row, and no text outside of redlines, and no insert redline in the row, i.e. whole text content is deleted (tracked row deletion). Also update HasTextChangesOnly table row property at accepting SwRangeRedlines in changed table rows. Change-Id: I426c445da760f36f718d737f34ccdb904e87aac3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126919 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I66feced8bed05c7859e36a6d2f746a7faf30c7a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-15tdf#141175: sw_uiwriter3: Add unittestXisco Fauli2-0/+30
Change-Id: Iba615528f8515fe60dc71bc61c0d815c0e1962e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126851 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-15CppunitTest_sw_rtfexport: rework to simplify mustTestImportOf()Miklos Vajna1-17/+15
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I21b08893f726f13a09a905f28f354f74b1b423ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126845 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-14tdf#143574 sw: textboxes in group shapes -- part 4Attila Bakos (NISZ)2-0/+41
A new UNO property has been added and implemented for the filters. This provides the possibility of assigning textboxes in the filter at import time via UNO. Follow-up to commit e5650de86072b9db586a4532b5239acda77598c4 "tdf#143574 sw: textboxes in group shapes - part 3 take 2". Change-Id: I58c445cb7f6d865c1d82dbe68f985e4c11ff832e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126162 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-13tdf#146208 sw DOCX: fix crash at Redo of tracked table changesLászló Németh2-0/+19
Importing DOCX tables with tracked row deletion and insertion, accepting them, Undo, and accepting them again (or Redo) crashed LibreOffice, related to the missing Undo support of deletions in SwExtraRedlineTable. SwTableRowRedline is not used for DOCX export since commit dbc2bdffbec9b3f7eba485652cdd43634458b5a6 "tdf#145091 DOCX: don't export obsolete table row change data", so it's possible to switch off deletion of row changes in SwExtraRedlineTable to fix crashing, keeping SwTableRowRedline only to fix the round-trip of the original row change Date temporarily. Change-Id: I6ac571656e45c4299a07a63646bb28d6d1fcd081 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126662 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-11tdf#146173: combine non-BMP characters' surrogates correctlyMike Kaganski2-0/+8
Change-Id: Ib3af1f9e461f133d2f5b09b9db4fb87c1ede0b9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126658 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-11tdf#146140 sw DOCX import: fix moveFrom regression with broken text contentLászló Németh2-4/+31
(Also a small clean-up: increase the character limit for tracked text moving detection: Only 2 or more (non-whitespace) character deletions are checked for it, because single characters are often typos or some control-like characters, e.g. soft hyphen, not real text movings.) Details of the regression: commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be "tdf#123460 DOCX track changes: moveFrom completely" fixed the missing redline import of the end of the moved paragraphs, but paragraph end was imported as w:del, not w:moveFrom explicitly. From commit f51fa7534421a195a58b4a737a2e836d8c25ba81 "tdf#145718 sw, DOCX import: complete tracked text moving" this resulted two deletions (a moved one and a plain one) instead of the previous single one. Moreover, exporting these double deletions at the same position to ODT, raised a back-compatibility issue with broken text content, see tdf#107292 (solved recently, but not in older LibreOffice versions). Removing the explicit w:del code path in writerfilter, it solved the regression from commit f51fa7534421a195a58b4a737a2e836d8c25ba81 "tdf#145718 sw, DOCX import: complete tracked text moving". See also commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519 "tdf#145720 DOCX export: fix loss of tracked moving". Change-Id: I15bfc83b87dd42a762ff84edf5bae765fe02a5ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126631 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-08tdf#146120 sw: show tracked table changes with different colorLászló Németh2-0/+222
In Change Tracking, show deleted table rows in cyan and inserted rows in pink. In this case, don't show original table row or cell background. Follow-up to commit f481c2c8e74bded11fac754e493560391229dbcd "tdf#144057 sw track changes: hide deleted table rows". Change-Id: Ib9cc411b62b92bc8a83dda7589f3e798f7e96f41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126482 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-08tdf#107292: ODT import: fix order of deletions at same positionLászló Németh2-0/+11
Tracked deletions at the same position were loaded in reverse order, resulting broken text content. Note: FODT format is not applicable for the unit test document, because it's not affected by the problem. Change-Id: Id13f8d23ae5964cbf82095a3d1ce2f6c9fdd59e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126529 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-12-08CppunitTest_sw_rtfexport: avoid DECLARE_RTFEXPORT_TEST() for export-only testsMiklos Vajna1-4/+5
Convert just one test before mass-converting all such tests in this suite. See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I9eb0a6458ae9ea31608dcb5e02f6ba59d3f2a669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126488 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>