Age | Commit message (Collapse) | Author | Files | Lines |
|
It already has 3 cxx files, and takes by far the longest to run.
The split isn't ideal at 241/71/162 but still an improvement.
Change-Id: I59215475724cbf0e38b890d7be6d60a23dccf0a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108030
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Otherwise, from-scratch `make CppunitTest_sw_uiwriter` failed for me on Linux
with
> warn:vcl.builder:1934376:1934376:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66
and
> warn:vcl.builder:1939531:1939531:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66
and
> warn:vcl.builder:1943074:1943074:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///~/lo/core/instdir/share/config/soffice.cfg/sfx/ui/infobar.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66
Change-Id: I8f1ece408b8c5f0e389378f15a2652a45cb93103
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104235
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
So it is no longer necessary to define all SwModelTestBase functions
inline.
Change-Id: Ia1055ff967b3614102275ec92607c85ec063fce7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99820
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: If22d82d506c365ae956de3d15e64c7065ad6b585
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89625
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
So move it one level up, this way more tests can share code in the
future.
Change-Id: I35300b3c88ac9a5c39916f53b1b1743aa85869a0
Reviewed-on: https://gerrit.libreoffice.org/82252
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
I suppose a number of these should even better use a shared PCH that
also includes Writer headers.
Change-Id: I3227bff71ddc2cd2e59ef18c1481606de16f9ea5
Reviewed-on: https://gerrit.libreoffice.org/79816
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
`make clean && make CppunitTest_sw_uiconfig` failed with
> warn:oox:29131:29131:oox/source/drawingml/customshapepresetdata.cxx:718: failed to open oox-drawingml-cs-presets
[...]
> tdf98987.docx:
> .../sw/qa/extras/uiwriter/uiwriter.cxx:5055:SwUiWriterTest::testTdf98987
> greater assertion failed
> - Expected greater than: 1701
> - Actual : 1701
Change-Id: I84477f31def0305d2148cee36820869551273f15
Reviewed-on: https://gerrit.libreoffice.org/79375
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
`make clean && make CppunitTest_sw_uiconfig` failed with
> Test name: SwUiWriterTest::testClassificationPaste
> An uncaught exception of type com.sun.star.io.NotConnectedException
> -
because instdir/share/classification/example.xml was missing in
SfxClassificationHelper::Impl::parsePolicy
(sfx2/source/view/classificationhelper.cxx).
Change-Id: I0c2aeff1a6192d8fac3b01f63fc75f4ce758b809
Reviewed-on: https://gerrit.libreoffice.org/79308
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: If99059383039e65aacfc55baec660eb6fde47032
Reviewed-on: https://gerrit.libreoffice.org/77376
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
(1) Migrated all still existing binary load/save stuff
in SfxPoolItem to legacy files. Isolated from Item
implementations. Adapted all usages. No more methods
Create/Store needed, also GetVersion removed
(2) Removed operator= for SfxPoolItem. Adapted all
usages. Goal ist to handle Items more as Objects
('Object-Oriented') in the sense to move/handle
instances, not to copy one instance over another one
(which is more and more problematic with hard to copy
content as UNO API stuff or similar). This lead to
much more usages of std::shared_ptr which correlates
well with future plans fr Items (see dev branch).
Next logic step will be to also remove copy constructor
Linux build and corrections done
Fixed Writer test and removed unused defines
Fixed another unused m,acro
Started to unify the AutoFormat stuff
Changes to OUString constructor usages, tests completely
No idea why, but SfxStringItem constructor which
takes a OUString& now insists of not getting ::OUString's
handed in - changed all 'SfxStringItem.*OUString.*".*"'
accordingly
Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29
Reviewed-on: https://gerrit.libreoffice.org/71075
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
This reverts commit 06742182e5306d6d06e3253981723a69a3c978ab
and implements the same thing without altering the original document.
Thanks Miklos for pointing out that shortcoming.
Change-Id: I0eca9a730853f97251bc2a1cb1ee4128acf31c1f
Reviewed-on: https://gerrit.libreoffice.org/68358
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Instead of depending on individual font packages.
Most didn't depend on fonts at all.
Change-Id: I190295bbecb1b44aa34aaf0874afadd35b5daeb4
Reviewed-on: https://gerrit.libreoffice.org/61159
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Commit aa91dc0ccbe53ffcec9dbfec2265de057775d4e3 (CWS-TOOLING: integrate
CWS sw32numbf01, 2009-09-08) replaced the SwDoc::ReplaceNumRule() call
with SwDoc::SetNumRule(), as the later handles list ids. This required a
decision if resetting of the indent attributes is needed or not, but it
did not document why resetting was chosen.
On the other hand, the current bugdoc shows why resetting is a bad idea:
this way if you paste into a numbered paragraph which has a non-zero
paragraph indent inherited from the numbering + zero indent as direct
formatting, then this later is lost during paste.
Change-Id: Ie5dcf6ed86c240fd61c4d5bfed886910aea3648f
Reviewed-on: https://gerrit.libreoffice.org/57727
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
|
|
Generate Application.DocumentChange and Application.Quit events.
SfxHintId::DocChanged seems to correspond nicely enough to
Application.DocumentChange. It is generated a bit eagerly, but as its
documentation is fairly vague and no specific detailed information is
passed in parameters anyway, it probably doesn't hurt if a client gets
it a bit more often with LO than with some other product.
Can now remove the FIXME-marked Quit event things in SwVbaApplication.
Now need oovbaapi in many makefiles for them to compile.
Change-Id: I4d0c5b93b584f198bcc854002eec7aaba7909ecc
Reviewed-on: https://gerrit.libreoffice.org/55106
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
As in the copy part of copy&paste. The problem was that the document has
an empty base URL during copy, and this was images were not exported at
all.
An alternative fix would be to use embedded images, but sadly Word's
HTML import doesn't understand that markup, so use tempfiles instead.
Change-Id: Iab8c555ac244d943c4958f24f8ac61cba4ec3aba
Reviewed-on: https://gerrit.libreoffice.org/52003
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
external/more_fonts/ExternalPackage_liberation.mk not installed caused
SwUiWriterTest::testTdf112860 (sw/qa/extras/uiwriter/uiwriter.cxx) to fail, see
63d845dc88690b9c5c8194e1512a8e4390c7ee24 "Fix -fsanitize=signed-integer-
overflow"
Change-Id: Ied4dcf9cfe167e741c3bb0c1f4fe853cb44b0d2b
|
|
Change-Id: I03eb1ad3b25cab5e2d8cf9b91d13bb5d97cfdfa2
|
|
Uwinapi is discontinued.
Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01
Reviewed-on: https://gerrit.libreoffice.org/23198
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
|
|
This patch changes occurences in makefiles
from
$(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \
udkapi \
offapi \
))
to
$(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config))
(corrected instead of abandon, jani)
Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e
Reviewed-on: https://gerrit.libreoffice.org/23426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I549116095255426dd2036a2122097567bf40a204
|
|
Change-Id: Iebe72287f62da7382f12e7645b48fa666610a8c5
|
|
Change-Id: I59e03895f8676bd7f91e8aaf4994e4f4b8231773
|
|
The sc_subsequent_filters_test was failing because of a lock file
because it did not use the unittest configuration.
Refactor gb_CppunitTest_use_configuration so it uses both the instdir
and unittest configuration to prevent such errors.
In case there ever is a test that does not work with the unittest
configuration it should call gb_CppunitTest_use_instdir_configuration.
Change-Id: Ibc00d42f8b6102d50d922f51173120798fa45c6e
|
|
I can't easily see what component is missing for SVM saving, and we do
the same in CppunitTest_sw_htmlimport already, so why bother.
Change-Id: Iba917e211fc721f8e275b3ce04a0e02c0759485b
|
|
At first we test normal replacement of wrong words.
Second part of the test is about style changes during autocorrection.
And at the end we replace a word with a table.
The rules for the autocorrection are in
test/user-template/user/autocorr/acor_fr.dat
I needed to make SwAutoCorrect public for my test.
Conflicts:
sw/qa/extras/uiwriter/uiwriter.cxx
Change-Id: Ie753c2187c1f4eddaefe0cc428a605107112c24f
Reviewed-on: https://gerrit.libreoffice.org/13131
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Don't require vcl.unx component on headless build
Change-Id: I33c3d90b67dd4ef3fc52ae2555b41ca2deb191de
Reviewed-on: https://gerrit.libreoffice.org/12267
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Iaad40befcde683e8b85eefa5b58bcd350fea9f71
|
|
Changing a document with redlines to two columns and then using undo
set some redlines to point to the end of the document (done by
the call to RemoveIdxFromSection() in SwUndoInsSection::UndoImpl()).
Change-Id: I88b563b88beebcd1c3cb21fe61bb56cdb12cdc41
|
|
If we delete a shape that had a textbox, then delete that textbox as
well. Without that, the doc model would be still consistent, but most
probably would not be what the user expects.
Change-Id: Id5075233ce66d7a398c88ff3e63b05a6b2133571
|
|
This required some changes to the framework:
* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
the exisiting unobootstrapprotector). CppunitTests that need VCL now need to
declare gb_CppunitTest_use_vcl.
* For things to work properly, the UNO component context needs to be disposed
from within DeInitVCL (cf. Desktop's Application::DeInit called from
DeInitVCL). The easiest solution was to introduce an
Application::setDeInitHook (where the hook is called from DeInitVCL)
specifically for vclbootstrapprotector to call.
* PythonTests don't (yet) call DeInitVCL; they still hook into
BootstrapFixture's original test_init functionality (to call InitVCL), and do
not make use of the vclbootstrapprotector.
Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
|
|
It's too confusing to have UI code inside of core; the important part is
that it's separated from the optional UI code in swui library.
Change-Id: I640a52723d5802faf08f3b8eaa03cd937fd93449
|
|
Change-Id: Ic731c1c4c76d8d6779868d7e3e4c02cb3cadc844
Reviewed-on: https://gerrit.libreoffice.org/9222
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: Ie861b7db8a507177b330ade23e94771a0811c2f9
|
|
Moved the files linked in sw/Library_sw.mk from sw/source/ui to
sw/source/core/uibase and modified the make files as per the new
directory location.
Reviewed on:
https://gerrit.libreoffice.org/8447
Change-Id: I05f6ccdeee5e76fb0ae477d16721d9ddc6eaff32
|
|
Change-Id: Ia991a4c85a9e79f03d0f3fb45d6daeed5db27c39
|
|
Change-Id: I334b21532337c1895a148c949dde60ad774b4759
|
|
We don't have too much testcases where we assert directly the resulting
zipped XML files, but where we did, we actully invoked filter() 5 times,
even if 3 times is enough, fix this.
That causes the testcase to run in 1m24.754s (previously it was
1m30.278s). Additionally, at one case the XML result is an expected
one, having matching testcase and manual results is always good.
Change-Id: Ie905002b113bc84f1e517c35f14739f423fd8ea2
|
|
Change-Id: I4c688a4aeedcae56ed6404574bd1bb392d4190cb
Reviewed-on: https://gerrit.libreoffice.org/6311
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5ee33965a511c7730610377a2e41f4728a0fe4d2
Reviewed-on: https://gerrit.libreoffice.org/6184
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
|