summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2021-02-17tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara12-3/+24
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110956 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-16tdf#139511 Correct calculation of minimum row height during resize.Gülşah Köse1-1/+1
Change-Id: Id47b5877d56850c80395897a83daae8e24f5c099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110662 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110974
2021-02-16svx: fix import of multiple paragraphs into title shapesMiklos Vajna2-12/+33
Title shapes try hard to have a single paragraph only, the Impress UI inserts linebreaks instead of paragraphs breaks in sd::FuText::KeyInput(), ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b (initial import, 2000-09-18). This matches the PowerPoint behavior. This is most visible when the paragraph has a bullet associated with it. Interestingly you can still put multiple paragraphs into title shapes using paste special -> plain text. In that case, it was inconsistent that we exported these multiple paragraphs to ODP, but merged them to a single paragraph on import since commit 0a783c1a041e2b74b7bf238d11ee2c303f6708f4 (#100190# don't allow more then one paragraph on title text objects, 2002-06-25). This results in loosing your bullets on save + open, both in the ODP and PPTX cases, since removeActionLock() on the XShape triggers this tweak. Also, PowerPoint does not do this merging on import. So fix the problem by removing the import-time tweak but leave the UI unchanged. (cherry picked from commit 043690eff82d5798774452a8364e1566b866a320) Change-Id: I6796f83c40e83f65cfb0f6c7e66069c3e08c1e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110900 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-13tdf#140274 set an initial minimum sizeCaolán McNamara1-0/+1
Change-Id: I93f0ac3d63b4864a0a5d98370407f9444b58b75c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110687 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-31tdf#140013 change icon for list view in Remote Files dialogRizal Muttaqin1-1/+1
Change-Id: Ia91e17e6afeac56f5f770cee030ed63db6605529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110191 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-27tdf#138590 use the highlighted menu entry, not the combobox active textCaolán McNamara1-1/+9
Change-Id: I2fb68c1491d129d5fd9b963ae4db1fb83171a154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109981 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-26tdf#135550 ListBox should triger an event when changed non-interactivelyCaolán McNamara2-10/+20
not just when changed by the user Change-Id: If2238341ff8465fee6375dad1ea9b4d7ec0110e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109800 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-26tdf#139590 Drag and drop doesn't work in SdrObjEditViewCaolán McNamara1-0/+7
Change-Id: Id8deeee0c1a919f330bc6623f708453279a214c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109793 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-25similar to tdf#139774 for a combobox sx10601 is probably a better choiceCaolán McNamara1-1/+1
see extensions/inc/bitmaps.hlst and framework/inc/bitmaps.hlst for the two similar cases which use sx10601 too Change-Id: If44c0dcdbabc83cf35e9c1320c20aac9fdb68523 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 53486257c0a3aaf5559d5f336db2e4245a33277f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109807 Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-20Resolves: tdf#135617 grab focus to widget matching the line spacing stateCaolán McNamara1-1/+18
instead of leaving it at the first widget in the popup Change-Id: I0bc4c72f7972e339cd28cd6368a4784cdb11275f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109578 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara50-74/+198
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109311 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-14tdf#139567 set no-show-all to TrueCaolán McNamara1-0/+2
so changing child vis to false before parent is shown 'sticks' as a final visibility of false Change-Id: Ieee4e4c7f7bddf6204c61ca788d316d52ef5a6dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109247 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#137083 consider negative width in DrawPageViewGridRegina Henschel1-4/+14
SdrPageView::DrawPageViewGrid is called too for a ScDrawPage of a RTL-sheet. In that case both the width of the SdrPage and the left edge of the passed rectangle are negative. The x-values for drawing the grid were wrong and a right-to-left sheet did not show the grid. The patch adds a case distinction with correct x-values for case RTL. Change-Id: I6d0c15bf7bbe8aff6ab2e72a440ba81f2e0e2281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108989 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 7635a475130a0e9e3b0dded853348659d07a00d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109119 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#83618 Make line spacing values agree crash fixJim Raykowski1-1/+1
The intent of this patch is to fix the crash reported at https:// bugzilla.redhat.com/show_bug.cgi?id=1913828 by reverting changes made to cui/source/tabpages/paragraph.cxx in commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1 and changing the change made to svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx to use the already available pointer to the current SfxViewFrame instead of calling the SfxViewFrame::Current function again. Change-Id: I0c440c576c2afe4fb98ed54d51d91ea16a7f902a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-12rhbz#1913070 null derefCaolán McNamara1-18/+22
its plausible that SfxViewFrame::Current() has returned null, use pSh->GetDispatcher() instead protected by null check against pSh Change-Id: Ibefdcabea09cb3a1a411678585af33a99f8a1c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109003 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-07tdf#134288 svx: fix rendering of text on a zero-width shapeMiklos Vajna3-13/+66
We have conflicting requirements here: on one hand, the shape is zero width, so the text area is also zero. On the other hand, we put some text on the shape, which should be visible. The result was that the left/right text margin (2x250 mm100) was counted as part of the text area, so we put a few (but not 1) characters / line for zero width. Fix this to be PowerPoint-compatible: as the width decreases, we break the text up to more and more lines, but if the width is 0, then we don't break it up at all. An alternative would be to do this later in SdrTextObj::impDecomposeBlockTextPrimitive(), but there we no longer know the width is really 0, because the text margins and some small increase (+1 to be an inclusive range, +1 to have a non-zero scale) is already added to the original width. (cherry picked from commit 65e2ef43f186164729e1cc071b805bc1a7125cfe) Conflicts: svx/qa/unit/sdr.cxx Change-Id: Ieaa3e726bc5d37983b6221452e14f01db315f790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108872 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-17tdf#129961 svx: finish UI for table shadow as direct formatMiklos Vajna4-1/+97
Normally properties on an SdrObject is set using SetAttributes(), but that would take the selection controller into account, so we would call SvxTableController::SetAttributes(), which sets the item set on the selected cells instead. So use SetAttrToMarked() instead, which works on the shape's item set, even in the table case. Don't replace all existing items because we only have shadow properties here and also a disabled shadow is still a (set) SdrOnOffItem (with value=false), so no old SdrOnOffItem will be forgotten in the shape's item set. Also add an outer undo grouping, so once the user presses OK in the table properties dialog, we only create a single user-visible undo action, not two. (cherry picked from commit fdeb04f7c59cf8032fe17072ed779e70505cc6ab) Change-Id: I77b55ba1f07b8d0eeac5070e0ec07d39573d1f9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107864 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-17tdf#138945 update fObjectRotation for NbcResizeRegina Henschel3-0/+106
SdrObjCustomShape::NbcResize uses the inherited SdrTextObj::NbcResize. But a SdrTextObj does not know fObjectRotation. Explicit update to new rotation angle after resize is needed. The error became visible, if you changed width or height of a rotated or sheared custom shape in the Position&Size dialog. Then the shape handles were not on the shape outline. Change-Id: Idbe47a3b1ef2b34e9645d62830cb330f2e49bd3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107792 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit d4ca360f6632f03e9fb7e9af37aac40d23f1249a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107803 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-17tdf#129961 cui: start UI for table shadow as direct formatMiklos Vajna1-0/+12
It reads from the doc model and shows it, but doesn't write it back yet. (cherry picked from commit 74ba28fe238b7f15d1fb7d119e4cef3a7b544e0b) Change-Id: I6611229e71d0a49f09576ca452b901958c33db58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107863 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-11tdf#129961 svx: add rendering for table shadow as direct formatMiklos Vajna4-5/+81
There was already shadow support in ViewContactOfTableObj::createViewIndependentPrimitive2DSequence(), but the UNO API and UI could only set the shadow properties on a shape style, so shadow-as-direct-format is new. One difference between the PowerPoint shadow and our shadow is that we draw shadow for table text as well, while PowerPoint only does it for the borders / cell fill style. This means we're either backwards-compatible or compatible with PowerPoint. Solve this problem by leaving the style case unchanged, but render direct formatting like PowerPoint. (cherry picked from commit a75bf43a8d6c5dec6dcc86908c142ceec541aa8c) Change-Id: I2bc64fea8062f9d8162b95d1eaccb49c3466b5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107565 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-11tdf#129961 svx: add UNO API for table shadow as direct formatMiklos Vajna2-0/+27
Adding it via a style was working already. (cherry picked from commit 55d4c6cfe5bd9b737698c6cd1f28ee8234abb5d0) Change-Id: I122c359716a404159d3521d63d44ef8bfe35c214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107564 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-11tdf#129961 svx: add doc model xml dump for shadow-related pool itemsMiklos Vajna2-0/+70
It seems that sdr::table::SdrTableObj is already capable of storing shadow properties, but this is not easy to inspect, extend the xml dumper to improve the situation. Change-Id: Ideef43dfd6b844e0227632ec2cb6ab5d16171d8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106902 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit a7505356872f981c951b2ec64383a95538890876) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107563
2020-12-10Resolves: tdf#138789 disable widgets on 'none' when status changesCaolán McNamara2-12/+15
instead of when chage is dispatched, the chart case has its own dispatcher that disables the base class one. This fixes the reported problem, and the related problem of updating when moving focus from one line that has style 'none' to one that doesn't, and vice-versa, where no change is dispached on received on context change Change-Id: I6afb396e75ba93c13fcae71c52618cfce7f9cecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107525 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-10Resolves tdf#138127 - Use document color for border widgetHeiko Tietze1-4/+6
Change-Id: I57fdbd37c23f3bd2c20ac04ef598cd8a182aac6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105577 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 6f7d1aaa8c375e6b7a9b80d1ae57efc176c6430f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107388 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02Partially resolve: tdf#113286 Add https:// to URL in Crash ReportSeth Chaiklin1-2/+2
Also: "Don't" --> "Do Not" in another button label Change-Id: I320a2f3fbe1ad1d2ac3efff94c0195be15335a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107018 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit ea9863c0104bfa74e7542f850768c2c0ee63a577) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107026 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-02Resolves: tdf#138549 use GetSpecialTextBoxShadow to identify ScPostItCaolán McNamara1-2/+5
instead of a 'special' name which causes undo-related causes side effects Change-Id: Id36b0b5360ddde3469721a7c837fe3942af08209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9c94bae963ef5019f6ca0394d076b1288969aa53) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107024 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-30tdf#138307 Chart import: fix lost custom shape textBalazs Varga2-5/+6
Do not set empty text to SdrOutliner, if it is already set. Note: Also fix the missing custom shape problem in tdf#72776 and tdf#93641. The wrong position (X:0, Y:0) of these shapes is another problem. Regression from commit 6f62a5c4ee2c1b7654c7fcaa618fb495e0d32f0a (tdf#128985: ODP: Style text directions revert to RTL on save and re-open) Change-Id: I07d8cb12836daf15db347f6bb19c17ed9373189e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104909 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106853 Tested-by: Jenkins
2020-11-24tdf#138430 scrolled windows need to have auto scrolling disabledCaolán McNamara1-1/+1
Change-Id: I8a622f00238d3d20d21d2439d6fc4fb13358f0c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24tdf#138430 toolbar bullet dropdown should have a scrolledwindowCaolán McNamara1-1/+1
as should the matching dialog pages Change-Id: Ib327d3c02d1bc5ae11a6a76d52c9e17803f05534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19Resolves: tdf#114956 skip broadcast optimization for ScPostItsCaolán McNamara1-1/+2
so we can resize the ScPostIt as was the case before commit f06b48a5dddab20fd1bbf9b5f3e8543593f5e590 Date: Fri Aug 4 18:56:43 2017 +0200 editviewoverlay: Allow EditView to run in Overlay Change-Id: Idd92716a9b38058f6f275769d4f2523eddac500c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-18tdf#137397 Faulty Height value in Position and Size content panelCaolán McNamara1-2/+2
Change-Id: Ie7439371cb2d216ca1d95f21db44d203cccd9ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-18Remove unused GraphicObject::SetGraphic pCopyObj and rLink parametersStephan Bergmann1-1/+1
The defaulted pCopyObj parameter of the first SetGraphic overload became unused with ea3d755ac949c1b6dada5c341e018f8c23f5d395 "vcl: detach usage and remove GraphicManager and GraphicCache", and then the rLink parameter of the second overload became unused with e4eb416c3ef81d098ed61caabd2077cbbb2418bc "remove swapping and link from GraphicObject and Graphic" (removing the need to have two different overloads). Change-Id: I15a648845ed474ee302e2a9836776ba74b9c44a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106045 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18Remove unused SdrGrafObj::SetGraphicLink rReferer, rFilterName parametersStephan Bergmann1-5/+2
unused since 9fb7aaf570c03c8a26d763f1205fb8c890e8211a "Make linked graphic register into LinkedManager again", and remove further function parameters and class members that turn out to be unused now, too Change-Id: I3dd2b138fd8787d12b89547526da751ea5954845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106041 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18Clarify signature of some opertor() that must match ColorSelectFunctionStephan Bergmann1-1/+2
Change-Id: Ibb71d1e993bbb0fa453c59f48ab5f7c79e1d8025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106036 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18tdf#137836 Change the label from "_Comments" to "Comme_nts"diwanshu8851-1/+1
Change-Id: Ia624f6be5f0d9bb8613475104e901457cc814eb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105307 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-17Reuse ColorSelectFunction from colorwindow.hxx in PaletteManager.hxxStephan Bergmann1-1/+1
Change-Id: I86b9bf57cbb5ee7e2b0d189d6ff78a3fbc9145fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106021 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-17loplugin:stringviewparam check methods tooNoel3-6/+6
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17tdf#137980 sw textbox: fix automatic size of shapes with rotated textMiklos Vajna1-5/+13
If a shape+fly pair has automatic size for the fly frame, then only the sw layout knows the necessary size, this is then sent to the shape and SdrObjCustomShape::AdjustTextFrameWidthAndHeight() is meant to respect those "suggestion", instead of sizing the shape based on the contained editeng text, which is always empty for shape+fly pairs. Improve this mechanism so it works better when the writing direction of the fly frame is tbrl ("rotate to the right"): make sure we always grow to the left and to the bottom, so the shape and the fly geometry matches. Also improve the testTextBoxSizeAtBottomOfPage "change detector" test which had a hardcoded height, but which did not clearly derive from any in-bugdoc value. Rather just test that the shape wider than taller, which was probably the intention. Change-Id: Ic6a77a1125bbf31b198aaf9048dc4812c87b4d9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105960 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-16Instead of labs, use overloaded absStephan Bergmann4-10/+17
...more likely to pick an appropriate version for the involved integer types, esp. after the recent long -> tools::Long changes Change-Id: Ia91259ca35aaf74b0e907de6831fc926f30057f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-16tdf#138232 don't grab focus if we already have itCaolán McNamara1-1/+1
Change-Id: I6fe852c87937ea4353822474ae1b7e20c9436f94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-16replace std::min(std::max()) with std::clampNoel2-2/+2
Change-Id: I76e34e8020d98292e8ffde387542b7029f85a42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16tdf#123936 Formatting files in module svx with clang-formatPhilipp Hofer71-1012/+906
Change-Id: I482a00c9f65fd08be03f101c0e18f044c9323137 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105716 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-11-16replace std::max(std::min()) with std::clampNoel2-6/+6
Change-Id: I890d19f5e2177294dc1175c90c98b964347f9e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara60-6/+165
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-15Dialog update: docking 3d effectsandreas kainz1-128/+127
Change-Id: I258911b4e4ecf401723f4f7f424129bf0b9f430c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105772 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-13Revert "remove BigInt::operator tools::Long()"Noel Grandin7-17/+17
This reverts commit 1397a1c8e4995b0dd336478e564880fe8ad91d1d. Reason for revert: Some discussion required Change-Id: Id39ee8260790e0722c5bf8338b0b76ca34da83d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105539 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13Fix (some of) fallouts from tools::Long change to 64 bit on _WIN64Mike Kaganski1-2/+2
Change-Id: I297d43c594c5d8c3378e8b7f29ad798e89e4ebaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105776 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-13Make Split Table Cell dialog asyncSzymon Kłos1-35/+36
Change-Id: I4efbb24f721aa50cc4dbbe78ae1e7e6087f8c876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103670 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105594 Tested-by: Jenkins
2020-11-12New loplugin:stringviewparamStephan Bergmann1-1/+1
...to "Find functions that take rtl::O[U]String parameters that can be generalized to take std::[u16]string_view instead." (Which in turn can avoid costly O[U]String constructions, see e.g. loplugin:stringview and subView.) Some of those functions' call sites, passing plain char string literals, needed to be adapted when converting them. Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-12Revert "remove Fraction::operator tools::Long()"Noel Grandin3-24/+24
This reverts commit 48b667a7e7d25f835f95df89162a7849d6972531. Reason for revert: some discussion required Change-Id: Ia0990d280837fb68b7ddc9f472ec78b1467b4311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 15:18:04 +0000