summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2018-07-22Fix typosAndrea Gelmini3-3/+3
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95 Reviewed-on: https://gerrit.libreoffice.org/57761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-20tdf#118662 Cleanup old hack with cloned SdrCaptionObjArmin Le Grand4-47/+90
XclObjComment formally cloned the SdrCaptionObj for a single reason - to suppress functionality of the UNO API implementation in SvxShape::GetBitmap - non-inserted SdrObjects did not create Graphic return values. Changed this to use an exclusive flag at SdrCaptionObj, only accessible for XclObjComment. Due to bad/undefined behaviour of SdrObjects that are not iinserted anywhere (see old comment in XclObjComment) there is no way to return to cloning the SdrObjects just to have them without being added to a SdrPage. Also improved the time eater UNO API implementation SvxShape::GetBitmap to use more modern stuff to create the Graphics needed. All the time constructing a full E3DView and setting SdrObjects selected and getting the selection as graphic is way too expensive. That way save may even get somewhat faster. Last was to cleanup the bInserted flag in SdrObject. It is no longer needed, being inserted now depends on being a member of an SdrObjList (Group or Page) - sounds normal anyways and is a synergy effect of already done AW080 cleanups. Checked now on linux. Problem is UnitTest 'testN777345' which checks file "n777345.docx". First point is that this only happens #if !defined(MACOSX) #if !defined(_WIN32) so it's clear why I detected no problem on Windows. Second point is that this test takes a checksum of a Graphic that is created using getReplacementGraphic() this value *will* change - of course - every time creation of that graphic is even *slightly* modified, so from my POV this UnitTest is defined to fill quite often. It may even create different results on different systems (!). Adaption of the test value will be needed quite often and makes this test questionable. Change-Id: If0918831a9cbd61b31298aeac7342e1913ee6c7a Reviewed-on: https://gerrit.libreoffice.org/57758 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-19loplugin:constantparamNoel Grandin1-6/+3
Change-Id: I8e2e9009f0a70d2fa390e03688a988ac935d5f36 Reviewed-on: https://gerrit.libreoffice.org/57643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:unusedmethodsNoel Grandin2-14/+0
Change-Id: I2b7a055a44c63bfc072b82580811898e177fbb8e Reviewed-on: https://gerrit.libreoffice.org/57628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18tdf#118354 Do not dereference non-exsisting ObjectArmin Le Grand1-1/+8
Change-Id: Ie7323302f3b29dfc19b26e2185321c2e609cab2b Reviewed-on: https://gerrit.libreoffice.org/57629 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-18Fix typosAndrea Gelmini2-8/+8
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-18tdf#118139 Set Default StyleSheet only when availableArmin Le Grand1-2/+11
Change-Id: Id8643895add3181c41737249326bb49e1a2c2493 Reviewed-on: https://gerrit.libreoffice.org/57582 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-17tdf#117707 Correctly Scale ItemSets when pasting from ExternalArmin Le Grand2-51/+55
Change-Id: Id01777a786fa7bb75d46ee0f78da645e94f7b840 Reviewed-on: https://gerrit.libreoffice.org/57556 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-17tdf#118448 style drop downs are staticNoel Grandin1-6/+6
regression from commit d70f53a8269be31f0412926afa5ba826faed6633 tdf#100894 freeze when editing calc file with bazillions of cond formatting Change-Id: Ia2fcb254b5f1ce7cb0512566e2453bd527be3cd9 Reviewed-on: https://gerrit.libreoffice.org/57557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17tdf#118498 Correct CustomShape 3D VisualizationArmin Le Grand2-14/+29
Change-Id: Ic312190616044f37fd92464ad605c6e0cdd5cc4d Reviewed-on: https://gerrit.libreoffice.org/57547 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-17bubble referer to LinkManager::GetGraphicFromAnyCaolán McNamara1-1/+1
Change-Id: Id2c6d629692a365f96f3f81c5686930668389a6a Reviewed-on: https://gerrit.libreoffice.org/57546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-17remove the GL based 3D chartsMarkus Mohrhard4-57/+2
Change-Id: Ia578c71ae70aa0a85b49fa50138edf90f961b1e9 Reviewed-on: https://gerrit.libreoffice.org/57533 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16tdf#118681 make sure we're using the right font char mapCaolán McNamara2-3/+6
Change-Id: I64265dac5d0d18b092d64ef656997d7177a425a4 Reviewed-on: https://gerrit.libreoffice.org/57504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Upgrade to ICU 62.1Eike Rathke1-0/+35
Change-Id: I9426e77aa85cfe068df59db47b8ac50b59cd4eb3 Reviewed-on: https://gerrit.libreoffice.org/57500 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-16return BaseProcessor2D by std::unique_ptrNoel Grandin1-6/+4
Change-Id: Ibad6e989d2d7ba779e7557e41552d06c076f657b Reviewed-on: https://gerrit.libreoffice.org/57448 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16SvPersistBase no longer necessaryNoel Grandin2-19/+10
Change-Id: I928c0898d77d30bd6ca755d07acac6f78b20563b Reviewed-on: https://gerrit.libreoffice.org/57436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-13merge IUndoManager into SfxUndoManagerNoel Grandin1-1/+1
SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some covariant parameters, which will make using std::unique_ptr easier. Change-Id: I6661b9876b18da830bead78794d237886cd3c5c9 Reviewed-on: https://gerrit.libreoffice.org/57317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12tdf#101778: Disable crop and rotate in read-only modeXisco Fauli1-5/+5
Change-Id: I26d6e98a768d40e97209e0a646cbb834d2635f9a Reviewed-on: https://gerrit.libreoffice.org/57158 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-12pdfium: replace FPDFTextObj_GetMatrix() patch with backportMiklos Vajna1-1/+1
Also remove unused FPDFTextObj_GetUnicode() and FPDFTextObj_GetText(). Change-Id: I4b1f88f878f2754ff790b67d286a9d5366acc641 Reviewed-on: https://gerrit.libreoffice.org/57292 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin1-5/+3
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-09loplugin:oncevarNoel Grandin4-5/+4
Change-Id: Id295dc0db174a448ef73db9de34f2de07d47f09a Reviewed-on: https://gerrit.libreoffice.org/57108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-09tdf117058 - Simplify calls to Menu::CheckItemKevin Dubrulle5-6/+6
Change pGearMenu->CheckItem( pGearMenu->GetItemId("gear_iconOnly") ) style to pGearMenu->CheckItem( "gear_iconOnly" ) style, where it is possible. Change-Id: I6ec77eac51be14a8e5d278bd3604cb65b3d1f006 Reviewed-on: https://gerrit.libreoffice.org/57172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08loplugin:passstuffbyrefNoel Grandin1-1/+1
Change-Id: I6e6c47020073ec183c6c8ff9cd026a0bec23b177 Reviewed-on: https://gerrit.libreoffice.org/57088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-07Use UNO ctors for extrusion and fontwork toolbar controlsMaxim Monastirsky6-284/+55
Change-Id: I075b1cbe648dfaf8bb7cee6d353cbdcf26c4465c Reviewed-on: https://gerrit.libreoffice.org/57143 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-07use std::unique_ptr fo CreateObjectSpecificPropertiesNoel Grandin19-42/+44
Change-Id: Ica82eca48719f12535757c81e95d788fe0aaa48e Reviewed-on: https://gerrit.libreoffice.org/57110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-07Fix typosAndrea Gelmini1-1/+1
Change-Id: I02edac50950327ca81acbb25ef1830f8e9130984 Reviewed-on: https://gerrit.libreoffice.org/56943 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-05Fix initial width of the color palette in welded pickerMaxim Monastirsky1-2/+1
Problem can be seen with non-gtk3, if the initial palette has no scrollbar (e.g. "standard" palette). The cause is that in non-gtk3 we don't have overlay scrollbars, so the palette area needs to be enlarged when switching from a palette with a scrollbar to a palette without a scrollbar. In practise, this was happening also on initial show, although the palette already had the correct width. To fix that, start with a never scrollbar policy by default, and add the scrollbar later if needed. Change-Id: I5286f301b3c7ef5c72b650290ace784222f7922d Reviewed-on: https://gerrit.libreoffice.org/56995 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-05tdf#117901 Write signature line images as emf to ooxmlSamuel Mehrbrodt1-22/+27
Change-Id: Idbf60be3cef2d9dde454da0279d2810488b1e157 Reviewed-on: https://gerrit.libreoffice.org/56871 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-04tdf#118506: Disable orientation page in read onlyXisco Fauli1-1/+1
Change-Id: I30994b95e65ddd70df7872f5cc41c339bf906f19 Reviewed-on: https://gerrit.libreoffice.org/56875 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-04tdf#118199 avoid double dispose actionsArmin Le Grand1-2/+7
Cell::dispose may be (and gets in this case) called multiple times. Do not double-cleanup stuff. Change-Id: Icb907968e8211eb4ba0bbb1c4d060eb8be9a874a Reviewed-on: https://gerrit.libreoffice.org/56924 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-03use std::unique_ptr for CreateObjectSpecificViewContactNoel Grandin23-48/+69
Change-Id: I0fed54d345a43fe0bc21ebbe424e6fdc7eac9523 Reviewed-on: https://gerrit.libreoffice.org/56823 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin1-1/+1
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02tdf106792 Get rid of SvxShapePolyPolygonBezierArmin Le Grand9-260/+147
SvxShapePolyPolygonBezier was an implementation for the UNO Shape group of polygons with bezier parts (filled/unfilled/ closed/open), e.g. com.sun.star.drawing.OpenBezierShape. It was differing from SvxShapePolyPolygon just by supporting drawing::PolyPolygonBezierCoords instead of the simple drawing::PointSequenceSequence and some details. This leads to problems - the ShapeType *does change* e.g. when you edit a non-bezier Shape in Draw/Impress and change parts to curve (also when closing, see ShapeTypes above). This is why SvxShape::getShapeType() already detects this identifier by using thze internal ShapePolyType (e.g. OBJ_PATHLINE). So there is no reason to have two separate UNO API imple- mentations for sthe same type of SvxShape at all. Get rid of the extra one and unify this implementation detail. Also cleaned up double basegfx tooling for conversions of UNO API Poly/bezier data and B2DPolygon. Adapted test for "tdf113946.docx", see comment there. Adapted test for "tdf90097.rtf", see comment there. Also needed to use the Linux values, also check comment there. Adapted test for "tdf105127.docx", see comment there. Adapted test for "tdf85232.docx", see comment there. Had to fic a problem with test for "tdf96674.docx"- the adaption of the RotateAngle for line objects goes havoc together with the UNO API when scaling is involved. That old aGeo rotate stuff just kills the existing rotation due to numerical inprecise stuff. The UNP API - in trying not just to apply a rptation, but manipulate the existing one then goes wrong in not re-getting the current rotation value anymore. ARGH! This is the original reason for the ols tdf#96674 task - i doubt that the additional code to make a line not exactly hor/ver is needed. Checked and it is not needed, thus removed the change from tdf#96674 in shape.cxx. Change-Id: I2bb8d4cfe33fee3671f3dad60e5c18609a394f9d Reviewed-on: https://gerrit.libreoffice.org/56614 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-02loplugin:constantparamNoel Grandin2-9/+6
Change-Id: I9fbfa6163c1d4650c52b00dc911972f07fe7c0e5 Reviewed-on: https://gerrit.libreoffice.org/56778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02loplugin:unusedmethodsNoel Grandin6-112/+0
Change-Id: I92665f577bfe39497905063da517a05b8008c3cc Reviewed-on: https://gerrit.libreoffice.org/56743 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02pass OutlinerParaObject around by std::unique_ptrNoel Grandin23-113/+104
SdrText::SetOutlinerParaObject was modified to not check for self-assign, and instead assert because the existing check was no longer possible. Fix bug in SdrUndoObjSetText::Undo(), where it was calling SdrText::SetOutlinerParaObject unnecessarily, because NbcSetOutlinerParaObjectForText already does that. Optimise Outliner::GetEmptyParaObject by creating a new constructor for OutlinerParaObject, so we don't need to copy the new object we get back from GetEmptyTextObject, unnecessarily. Change-Id: I57c475583d6c31658c154e24992b3d587bad9841 Reviewed-on: https://gerrit.libreoffice.org/56730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02loplugin:unusedfields improve checking for write-only fieldsNoel Grandin2-22/+8
we trade off a little accuracy for finding more possible write-only fields. Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269 Reviewed-on: https://gerrit.libreoffice.org/56715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-30Avoid using getTokenCount() to get last token in a stringMatteo Casalin1-3/+2
Change-Id: I6c36394f391850baf641268912e71ebaa3504b5d
2018-06-30Avoid using getTokenCount() to get last token in a stringMatteo Casalin1-2/+1
Change-Id: I1a2d181fdf03926452cb00f49490c9c4151dd8f9
2018-06-30Initialize local variableMatteo Casalin1-1/+1
Change-Id: I07583fe1fb70ffb7ec5cbeaacfdba207dac7eb0d
2018-06-30Avoid getTokenCount() + not empty OUString has at least 1 tokenMatteo Casalin1-5/+5
Change-Id: Ib8771f9621e050c100f2a319e354106bf316b24c
2018-06-30Copy INetURLObject object instead of constructing it twiceMatteo Casalin1-2/+6
Change-Id: Ib20f96fe63218aed4055bd0175ddc9e9c71e3fb3
2018-06-30Avoid getTokenCount()Matteo Casalin1-1/+1
Change-Id: Ia3c7657a89187ff21fca6d07c27ba260a0be36d8
2018-06-30Bail out early and reduce temporariesMatteo Casalin1-16/+12
Change-Id: I78e3d50f0bcbbb482ce79bbb1f14885e1e412569
2018-06-30Avoid getTokenCount()Matteo Casalin1-4/+2
Change-Id: If884a9eb09b55836995d04cd82832d3f79d6531c
2018-06-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic3eadd695a11d4afdefa5ed4192faa47779e84f8 Reviewed-on: https://gerrit.libreoffice.org/54055 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-29Improved loplugin:redundantcast (const-qualified typedefs): svxStephan Bergmann3-5/+5
Change-Id: Id5a26a8b8c23d76f4d26480bb7f37c447902371c Reviewed-on: https://gerrit.libreoffice.org/56703 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-29Fix typosAndrea Gelmini1-1/+1
Change-Id: If6fafa1ef192411a9d59ef9a4ef4d7f522c67f66 Reviewed-on: https://gerrit.libreoffice.org/55964 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-27tdf#117904 Don't allow copying signed shapesSamuel Mehrbrodt1-1/+4
Instead just copy the "unsigned" graphic Change-Id: I5183b0b33be0469dceaace142d73aa403cc32ef2 Reviewed-on: https://gerrit.libreoffice.org/56472 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-26Resolves: tdf#118356 freeze/thaw mass language additionsCaolán McNamara1-0/+6
Change-Id: Ifdc2247594d3ddeea0ca7b3b97eb6e392c54f95b Reviewed-on: https://gerrit.libreoffice.org/56409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 09:28:30 +0000