summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2015-10-20loplugin:defaultparamsStephan Bergmann26-34/+33
Change-Id: I6bd0482967f35a4fc4c2384e775753c413c52162
2015-10-19loplugin:defaultparamsStephan Bergmann28-62/+62
Change-Id: I4e344e780baae6c9828d0d708dfb0a9390af533a
2015-10-19afl-eventtesting: deref of null GetSdrPageViewCaolán McNamara1-2/+5
Change-Id: Iec3266746c78e58e3c3a094e6511d79dadc4e4c6
2015-10-19afl-eventtesting: deref of null MarkedSdrObjCaolán McNamara1-1/+3
Change-Id: I0fe9cb55de114c7e2ad45cd946e94f9c0e93b85c
2015-10-19convert remaing DBG_WARNING to SAL_INFONoel Grandin4-5/+5
and drop the macro Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19cleanup some local var declarationsNoel Grandin2-2/+2
found with git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-18reorganise code, no behaviour change intendedLionel Elie Mamane1-7/+4
... at leat in normal circumstances. assumed that the dialog can only return Yes/No/Cancel if it doesn't, then behaviour change, be more conservative and save only on yes. the order between rController->commitCurrentRecord( ) and GetImpl()->didPrepareClose( true ) is changed, that's on purpose. If commitCurrentRecord( ) throws, then don't do GetImpl()->didPrepareClose( true ) Change-Id: Ieb88c04a27e71b313e7f1386d48f370a1e94c6c2
2015-10-18tdf#72205 when saving changes, mark we did a prepareCloseLionel Elie Mamane1-0/+2
Change-Id: I8a86447bdd227621ff7b0b3551798ee343379c74 Reviewed-on: https://gerrit.libreoffice.org/19434 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-10-18janitorial: indentLionel Elie Mamane1-2/+2
Change-Id: I26030811a5da551482b0cc2a18c302160ada6cd6 Reviewed-on: https://gerrit.libreoffice.org/19435 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-10-17afl-eventtesting: first discovered impress crash via event fuzzingCaolán McNamara3-20/+41
SfxObjectShell::Current can and does return null sometimes protect this init like the other sidebar example and add missing licence header Change-Id: I15d40c08e8ac37116de7d543c16257c8a8090e8a
2015-10-17coverity#1327445 Unchecked dynamic_castCaolán McNamara2-4/+4
and coverity#1327444 Unchecked dynamic_cast Change-Id: I459d588db4a3dd6591b81babb3586fe97ab96c63
2015-10-16typo in commentLionel Elie Mamane1-1/+1
Change-Id: I8af65365c6a405bf0458c26af802d400da51cd57
2015-10-16tdf#93618 teach DbCellControl about "Date"/"Time" as known value propertyLionel Elie Mamane1-0/+4
Change-Id: Icbb575b86ff39ce263271110aae6e49e5b4e7ac2
2015-10-16sfx items: Kill the unreadable & misplaced SFX_ITEMSET_ARG too.Jan Holesovsky2-2/+2
Change-Id: I1e0f96dce2b9cf9da32f4f577cf76e1d8824d37a
2015-10-16sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.Jan Holesovsky1-5/+5
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.Jan Holesovsky1-5/+5
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-16sfx items: The bDeep parameter of SFX_ITEMSET_ARG is always false.Jan Holesovsky2-2/+2
Change-Id: Ifdffc82c9b4ec2e534204294575a78e34e0338c1
2015-10-16convert Link<> to typedNoel Grandin38-231/+169
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15tdf#94495 - protect lstbox usage post-dispose, and fix ItemWin focus.Michael Meeks1-9/+15
Change-Id: I2e4d1c79f57ec048d66111ed393491b7803ee3b9
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin8-27/+14
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15convert Link<> to typedNoel Grandin1-4/+13
Change-Id: I2ef1e5fe5c6dc65c254b3a16b0b12fca5caba16e
2015-10-15convert Link<> to typedNoel Grandin1-1/+6
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-14coverity#735879 Dereference after null checkCaolán McNamara1-2/+1
Change-Id: I2a0fa04be569ae567719a8829b42796eadff28b6
2015-10-14coverity#735880 Dereference after null checkCaolán McNamara1-2/+1
Change-Id: Id7bc74352d6808a074fe227e11f998e95a050329
2015-10-14coverity#736826 Dereference before null checkCaolán McNamara1-6/+4
Change-Id: I155f952f5eda086e3d134b387514968f67de4910
2015-10-14coverity#735862 Unchecked dynamic_castCaolán McNamara1-6/+4
Change-Id: Id23987edcff82621cbe932b4273fec0371bd481b
2015-10-14coverity#735864 Unchecked dynamic_castCaolán McNamara1-4/+5
Change-Id: I669ffab93976a61321f471586256fb52c9bd3451
2015-10-14coverity#735865 Dereference after null checkCaolán McNamara1-4/+4
Change-Id: I6ebe8a0fb2e63b83406434d5fce0af8994f12458
2015-10-14coverity#735877 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I04da87e895d9b6724dd48fa579008944118f87bc
2015-10-14coverity#735878 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I7607cef90750b5a527ff74fd3d793ed7c3a3811c
2015-10-14coverity#735879 Dereference after null checkCaolán McNamara1-1/+0
Change-Id: I07661496c70fba3e012a3bb4f9bc592377eb124c
2015-10-14coverity#735880 Dereference after null checkCaolán McNamara1-1/+0
Change-Id: Id31bac44391f0319ec31c72b77f1b471c32d0a68
2015-10-14coverity#1326208 Unchecked dynamic_castCaolán McNamara1-20/+15
and coverity#1326207 Unchecked dynamic_cast Change-Id: Icaf60592f1be2aeea1d010241965df7f9e76f2c7
2015-10-14convert Link<> to typedNoel Grandin2-8/+6
Change-Id: I1876f327607e0e23292950741df348d4ec31fde1
2015-10-13coverity#735874 Dereference after null checkCaolán McNamara1-3/+1
Change-Id: I74a4a126116638aa33193f267e2f86a3c364fbae
2015-10-13coverity#1326210 Unchecked dynamic_castCaolán McNamara1-5/+3
Change-Id: I729af592a74aff7c40a5ae5311d8c5aff2ddee04
2015-10-13coverity#1326499 Resource leakCaolán McNamara1-3/+4
Change-Id: I561e8f7ff472d7d2578e30145024405e74088ffc
2015-10-13tdf#95002 sd tiled rendering: fix handling of images on page switchMiklos Vajna1-3/+2
It turns out a full invalidation is still needed to trigger the loading of graphics on the new page, so instead of not invalidating just don't emit the notification about it during page switch. Change-Id: Ic99a3d4e268b3db61cf09c78ed0f310c9d365867
2015-10-13remove some useless commentsNoel Grandin1-15/+0
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13cppcheck:variableScopeNoel Grandin1-3/+2
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af Reviewed-on: https://gerrit.libreoffice.org/19329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12disable arrow heads in chart sidebar, tdf#94971Markus Mohrhard1-3/+13
Change-Id: I631f34faf2befeb7cc61027c8fd59ef7b3543785
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann228-2431/+2431
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann13-27/+27
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12sd tiled rendering: make invalidation in DrawViewShell::SwitchPage() optionalMiklos Vajna1-2/+3
In case of tiled rendering clients already get LOK_CALLBACK_SET_PART when switching slides, so it's pointless to additionally invalidate windows for help lines. Change-Id: Ibc15c9862ae85bd72328161fa5f7e72d82fd2a97
2015-10-12convert Link<> to typedNoel Grandin27-365/+321
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12valgrind: fix leakCaolán McNamara1-0/+1
Change-Id: I99ebee5015110144ea00415273b84fd2fc9ad2ba
2015-10-08tdf#89543: Solid line in place of 'none' start|end arrow entryKatarina Behrens1-6/+29
Change-Id: I20edf3b57a0d3ec98d6765825a718fa77a024999 Reviewed-on: https://gerrit.libreoffice.org/19039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-10-07SvxStyleBox_Impl::CalcOptimalExtraUserWidth() is a (very) expensive operation.Jan Holesovsky1-6/+13
Don't call it ~20 times on startup, instead call it once when the user actually opens the styles dropdown. Change-Id: I7bb28d0739bf917d23041f384f60a39a7ed5cbea
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-2/+2
Change-Id: I02a276eb929800692dff51e9241cab9d2345fae1
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+1
Change-Id: I9f495d748c2fe47fe5a91db21f44725fc00a7ed1