summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2021-04-22Resolves: tdf#141721 text from 1st col not clipped if 2nd col is emptyCaolán McNamara1-0/+5
Change-Id: I07257c59c20c3a2aeb789bbb370955e9e70226ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-22if only the first col width is set, the 2nd will take the remaining spaceCaolán McNamara1-1/+1
which looks neater than having the gen headerbar have a blank area to the right of the last col indicator Change-Id: Ia5ffab425e1c4983db941722d118a954aae1d113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-22tdf#141816: fix a thinkoMike Kaganski1-1/+1
This must check if they are different, not the other way around Change-Id: Id9b7a51f13d5d5c48077822ba18f0257b36ea226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114422 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-21tdf#141419 restore use any explicitly set background color in previewsCaolán McNamara1-0/+10
regression since... commit 6f3899b27156591e65f62649a92c727eb6f5dd03 Date: Thu Oct 29 15:03:44 2020 +0100 Resolves tdf#137059 - Use application colors for font preview but continue to use the doc-color setting when there isn't an explicit bg setting in the input propertyset Change-Id: I531b5ddea7700fcd4a731f32d4830b4d0b767d7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21Resolves: tdf#141765 set 'color' GtkToolbar to small-button sizeCaolán McNamara1-0/+3
so its height is as small as possible so it won't force the surrounding toolbar's height to stretch to fit it in Change-Id: Ibfbcfb551cdd82df05faf382d8cb8fcaa142ec14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21Related tdf#139804 Allow activating btn on first clickSamuel Mehrbrodt1-0/+1
Change-Id: I3bcdf8bdd6f25fd30106214f40e72bf1506f6bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114398 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-04-21cid#1476300 Dereference after null checkCaolán McNamara1-2/+2
Change-Id: Ib41b7bd60938aea997187aa3d2d6f9ea319fafc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114391 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20tdf#86321: Revert "Resolves: #i123539# some optimizations for 3D chart..."Xisco Fauli3-67/+25
This reverts commit db1d2af02861b49e4f53d726d59cd71c20cee9b1 The commit was already partically reverted in bca8d8985666d3fd22b91eb280f9baaeb933c2d0 < Resolves: tdf#90583 3D pie-chart missing guide handles >. This partial revert broke the optimization introduced in db1d2af02861b49e4f53d726d59cd71c20cee9b1 <Resolves: #i123539# some optimizations for 3D chart...> for 3D charts like https://bz.apache.org/ooo/attachment.cgi?id=81810 Later, 3D charts were optimized again in 55a7e836a2db662a53adc4f8b98d08b06790c758 < chart2: When creating objects prevent setting object rects dirty > so the remaining code originally introduced can go. Import time of https://bz.apache.org/ooo/attachment.cgi?id=81810 is the same with and without this patch Change-Id: I25338d0dfb4b41651dfe05e7bfbd74c86091dacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114313 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-20lok: Pass object ord num in the uno commandmerttumer3-8/+33
When multiple objects' glue points collide the ordnum will be used to decide which glue point to connect to for the connectors. Without that the default logic chooses the lowest ordered object which is searched and found in the object list Change-Id: I64579d28bbe6cbd92bab745838fe2995585b6a3f Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113517 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114032 Tested-by: Jenkins
2021-04-20Improve dumpGluePointsAsJSONmerttumer1-24/+38
added gridoffset for the shape for calc changed the logic, now the ordnum would be enough Change-Id: Iebe7d29c569a4cb968fe2e5ef1692b59f0c4b2d8 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114031 Tested-by: Jenkins
2021-04-20Get Glue Points in the selection callbackmerttumer1-0/+59
Change-Id: I0d038517710c68f80f8e35b8ebebd34f264434f3 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112324 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114030 Tested-by: Jenkins
2021-04-20lok: Don't invalidate GluePointsmerttumer2-0/+10
Change-Id: Ie579b31e6ee2067f5b88464c62c0870b68a461a2 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112315 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114029 Tested-by: Jenkins
2021-04-20Hide GluePoints in LOKmerttumer1-1/+2
Change-Id: Ibf6bba4cdc69bd8479ccc08b5d9695253ef81890 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112314 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114028 Tested-by: Jenkins
2021-04-20lok: Send gridOffset of the shapemerttumer1-1/+24
In core, the gridOffset is calculated based on the LogicRect's TopLeft coordinate In online, we have the SnapRect and we calculate it based on its TopLeft coordinate SnapRect's TopLeft and LogicRect's TopLeft match when there is no rotation but the rotation is not applied to the LogicRect. Therefore, what we calculate in online does not match in case of the rotated shape. Here we can send the correct gridOffset in the selection callback. whether the shape is rotated or not, we will always have the correct gridOffset Note that the gridOffset is always calculated from the first selected obj Change-Id: Icc62a94879367f9b55ad05887945393452021777 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113078 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114027 Tested-by: Jenkins
2021-04-20LOK: Fix Moving drag handles calculates wrong offsetmerttumer1-4/+9
When dragging the shape handles for resizing, the handle's grid offset must be the shapes grid offset. In small numbered row&column orders, it is not visible much since the difference is very little but as the number gets greater, the difference becomes more visible. Change-Id: I44d03cc67a239c8b7758206930def331ed8e5e42 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113028 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114026 Tested-by: Jenkins
2021-04-20LOK: Fix wrong gridOffset when shape is moved on calcmerttumer1-2/+5
Change-Id: I37501128068943cee8f67a5d91a35ec1a76fe550 Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114024 Tested-by: Jenkins
2021-04-19svx properties: pass SfxItemSet around by valueNoel Grandin29-133/+133
so we avoid heap allocation costs when loading lots of shapes Change-Id: I0de5819acc7f845973a284e68ab709989f27d402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114297 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-19weld SmEditTextWindowCaolán McNamara1-2/+11
reuse the WeldEditAccessible a11y impl and remove the then unused starmath equivalent. Change-Id: I2dc1e0436ffcd0b295e204c21bfcd365dae08bff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19svx: fix crash in DefaultProperties::dumpAsXml()Michael Stahl1-1/+4
mpItemSet can be null Change-Id: I4192f84639116c550bba5303a5fc70528cb3e8c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114263 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-19a11y tests show we should use GetOutputDevice for pixel/logic conversionsCaolán McNamara1-44/+28
Change-Id: I229ffb376b03ff2479385632319661dd35a63fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114258 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-18reduce allocation cost in SvxShape::SetPropertyNoel Grandin1-14/+14
use std::optional so we don't need to heap allocate all the time. note that I couldn't use the normal SfxItemSet constructor, std::optional::emplace on macOS doesn't seem to play nice with the template magic there Change-Id: Ic5de23e9a20dceae56f894cf0706b89ced77ff58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-17remove some cachingNoel Grandin1-13/+2
if we going to recreate it every time we call this method, there is no point in caching the result. Change-Id: Ie1f7bde86eca5cdd998fa8626303d3dead479ad3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-17add lang::XServiceInfo to WeldEditAccessibleCaolán McNamara1-3/+19
Change-Id: I3aa5e0a8d3333560f0f086107cef44a5bb2c353d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114229 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-17tdf#141701 Crash when closing 3D View dialog of 3D chartNoel Grandin1-0/+1
regression from commit 1d2773807f6d2deb1181ef4b14fbdd49ca1d5c14 ref-count SdrPage we need to clear the SdrPage which releases some objects or some unhelpful DBG_UTIL mode code in ~SdrObject will kick in and try and release objects, but it ends up deleting child objects before parent objects, which cau Change-Id: Iaad89a05a30c119807beacc54aaa66b6fde634e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-17tdf#141675 Incorrect position of shapeNoel Grandin1-17/+13
This reverts commit 44711d9eb53eb6247ebdb9293a3eb5e643f78059 tdf#130326 related, speed up drawing because it causes a regression. Change-Id: I19ea236b8541c1fe2557f43375bfef3ba555cfff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-16tdf#131634 Don't redo actions created before text edit begins.Mark Hung2-1/+5
In SdrObjEditView::SdrEndTextEdit(), pSdrUndoManager->Redo() was invoked until all the redo actions created after text edit began were converted to undo actions. Without checking, all the redo actions include the ones created before text edit began were moved to undo stack, and caused the SdrTextObj to be destroyed in SdrUndoManager::SetEndTextEditHdl when removing the undo actions and a use after release problem. The patch add GetRedoActionCountBeforeTextEdit() so the program won't invoke pSdrUndoManager->Redo() on actions created before text edit begin. Change-Id: Ic010bc6e71ee78ef2cb20a5259dc9d6d6579ccaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114102 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-04-16Related tdf#136764 - Minimum width for Styles InspectorHeiko Tietze1-3/+5
Set to 200px; columns made a bit smaller too Change-Id: If146afafead4be2781a132a797b21ff9d67b00b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114088 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-15store ptr to the original entries in SfxItemPropertyMapNoel Grandin8-68/+68
instead of copying them to a new data structure that is practically identical. Helps startup time since we build a ton of these when loading documents. And use o3tl::sorted_vector as a dense map data structure to reduce allocations and improve cache friendliness, since this is a build-once thing. Change-Id: I950be03b1a21c0c81c40f2677d4215f5e8e256cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114015 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin1-5/+5
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14static_cast after dynamic_castNoel Grandin1-35/+22
Change-Id: I77cbf11e26c91bf634d708117eb801c8d8057050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14avoid creating an SfxItemSet hereNoel Grandin1-16/+17
Change-Id: I9bd65c5938c5a500acc026a95de186fdae33e2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13flatten PropertyChangeNotifierNoel Grandin1-38/+14
which removes an allocation hotspot when loading lots of shapes Change-Id: I0121f5bc86c6dfeddcad13e81203a514151d61bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13no need to make copies of these objectsNoel Grandin3-48/+48
when querying their values. The copy triggers heap allocation, which shows up when loading lots of shapes. Change-Id: I4b70e0c64b2397a97216065bd6da61daaac7f3ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-12less copying in SfxItemPropertyMap::getPropertyEntriesNoel Grandin1-9/+8
we can just expose the map now, and avoid copying all the properties Change-Id: Icb22975508582268dfa96e41eb98ac01e7f51317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-12forward decl vcl::Window in uiobject.hxxCaolán McNamara3-5/+4
Change-Id: Ic4355a7cbf15e211b820e8343638100f729b4189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-12svx: prefix members of SdrObjectMiklos Vajna22-357/+357
So that nOrdNum doesn't cause -Wshadow in SwDrawVirtObj::AddToDrawingPage(). Change-Id: Ie7b1401f5c3cb07bfa653c4268dbdce7ba7abea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113966 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-12update PCHsCaolán McNamara1-2/+1
Change-Id: Id3728ac0011d3deed7e56081e3a854c7fa5336f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-11ofz#30962 Timeout: skip slow path for fuzzingCaolán McNamara1-0/+4
Change-Id: I49c3b06e9b54d9d6657b64b153907f995e572a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10tdf#130326 related, speed up drawingNoel Grandin1-13/+17
if we create the list every time we call ViewContact::getViewIndependentPrimitive2DContainer then caching the result is rather worthless. So make the caching worthwhile, which means invalidating it when something changes. Change-Id: I081e9501255ec1c87454bfcc1e0a741109afa99f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10tdf#130326 speed up XLSX loadNoel Grandin1-1/+1
cuts time from 35s to 25s for me. If the model is locked, we should not be broadcasting events. Change-Id: I4d8ca10c9d2a9862b30f88cc00e65aab1e2fad7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113909 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10tdf#130326 speed up opening XLSXNoel Grandin1-6/+8
SvxShape::Notify is called a lot (26%) of CPU, so re-arrange it to do the cheapest checks first. Change-Id: I0e6c6c976ecfe7670e8d4af175606654f839aa66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-10Resolves: tdf#139075 diagonal focus rects contain focus rects of old sizeCaolán McNamara1-0/+3
since... commit 356f6c5d89dd4dd92b2351898e07f99b96cb34cc Date: Tue Jan 15 08:55:00 2013 +0000 teach FrameSelector to be resizable Change-Id: I5ac4d1d12f60086349e7dbb3b78d29977f22c226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09Recheck include/ with IWYUGabor Kelemen30-0/+30
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-09remove need for an intermediate vcl::WindowCaolán McNamara1-1/+1
Change-Id: I59f24888e47ec17e46bf651d8530fc9468f16f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-08update PCHsLuboš Luňák1-1/+3
Change-Id: Ia9d04447f927e270a55500e7f35723a729bc01dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113801 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein1-76/+80
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07avoid pointless O(N^2) dynamic_castLuboš Luňák1-42/+38
I already tried to reduce the cost of this in ef4964a4e598c3c97, but back then I missed the fact that in fact all the casts guaranteed. So partially revert the first commit and simply use static_cast. Change-Id: I4231f698119d56e9f2536f2f0c9d824442d76b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113736 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07rtl::Static -> function local staticNoel Grandin3-18/+6
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-06update pchesCaolán McNamara1-1/+2
Change-Id: I835c8fcc237ece5cf9d7a3b261645139d022e9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06forward declare vcl::window in vcl/event.hxxCaolán McNamara15-2/+16
Change-Id: Ib3fc1b72d3d45377e2d4ccd0ff3e6835d2c29930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 05:44:55 +0000