summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2019-07-15tdf#126180: EndTextEdit on all views before delete/cut slideXisco Fauli4-21/+40
This also reworks the fixes tdf#125824 and tdf#111522 to use EndTextEdit instead of blocking the undoing Change-Id: I73c2289a9d950465f020f684e9e736148380f5c5 Reviewed-on: https://gerrit.libreoffice.org/74989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e6c7a018a0cfee395ce2886d41c908a2447ef5cc) Reviewed-on: https://gerrit.libreoffice.org/75027 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 1aa93766ee3994af9975e96e8ea60e02078de2d8) Reviewed-on: https://gerrit.libreoffice.org/75031
2019-07-02tdf#125824 svx: fix crash with view1 and view2 doing texteditXisco Fauli1-1/+1
Similar to 3a874f1c80c37e8b35666e1d73161ff762eb7e4c Change-Id: I51bffa4d33e82bb90b8a42787f55c12746bcd8c2 Reviewed-on: https://gerrit.libreoffice.org/74931 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 091f573728e7951d5dc4ef138117499b7480885f) Reviewed-on: https://gerrit.libreoffice.org/74949
2019-06-28tdf#126137: Do not dereference non-existing ObjectXisco Fauli1-1/+1
Regression from dfefe448c41921f2f1e54d3f69b8b9e89031d055 Use same logic as in c28ec6d9fbb21b363102faac0171de2754ea5d75 Change-Id: Ia489eb61873d38c31729fedb853b11570e562123 Reviewed-on: https://gerrit.libreoffice.org/74811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b653f21313f3b8ff9da99897e3a0c2df4a685b60) Reviewed-on: https://gerrit.libreoffice.org/74827 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-25Resolves: tdf#126039 erase old content before drawing new contentCaolán McNamara1-0/+3
Change-Id: I0006467f5c172b6a0cb8b9bc4c9a0181fd57a8ac Reviewed-on: https://gerrit.libreoffice.org/74585 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-10Related: tdf#111522 svx: fix crash with view1 doing textedit and resize/rotateMiklos Vajna2-13/+13
The two actually affected functions are SdrEditView::RotateMarkedObj() and SdrDragObjOwn::EndSdrDrag(), but it looks like the other functions in SdrEditView are safe to be changed the same way. I expect IsUndoEnabled() can't be changed, though: that would mean there would be no undo for the text edit itself, either. If other actions still crash, the pattern is the same: put a breakpoint on the SdrUndoAction constructor and see the backtrace to find the function that calls IsUndoEnabled() without calling CanDoSdrUndo() at the same time. Change-Id: If9324e311ec6e9f68a951559e903e14bb72ea31c Reviewed-on: https://gerrit.libreoffice.org/73669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 9870ff897f088563426bee9567dd9cb722c2b929) Reviewed-on: https://gerrit.libreoffice.org/73748 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 79cae65f4725d0a8abd5639dc298002d11b2626c) Reviewed-on: https://gerrit.libreoffice.org/73757
2019-06-10tdf#111522 svx: fix crash with view1 doing text edit and view2 doing sdr undoMiklos Vajna2-2/+18
If one view has an active text edit, then current code doesn't handle manipulating the undo text outside the text edit, so avoid problems by simply not adding an undo action to the undo stack for shape creation or move. Other actions might want to do the same in the future: check for CanDoSdrUndo() before calling SdrUndoFactory member functions. [ Found no existing test suite similar to CppunitTest_sw_uiwriter, so added one. ] (cherry picked from commit 3a874f1c80c37e8b35666e1d73161ff762eb7e4c) Change-Id: I3a364bf4fe6f9b0c13aa07283681b1045368cf7a Reviewed-on: https://gerrit.libreoffice.org/73649 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-08tdf#125062: distort hairline borders only if selection is usedXisco Fauli1-31/+35
Regression from 046df0a876b3d948bb1e14443c00c180bc8cccaa Use the fix for tdf#105998 only when 'selection' option is checked in the save dialog Change-Id: I8c4127c780736408e905ead48e0d3ee6ae149197 Reviewed-on: https://gerrit.libreoffice.org/73391 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 6c31c2b01dd32cc7ba1230f2c4a98b8f7def219b) Reviewed-on: https://gerrit.libreoffice.org/73559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18Resolves: tdf#125104 crash on getting text desc of numberingCaolán McNamara1-4/+27
this seems to have been wrong for a very long time, but we used to get away with it back in the .src era with presumably amusingly random strings from other parts of the ui shown in the summary of changes are of the organizer page of the dialog Change-Id: If223182170ba8519d7899f8044f01c2a12f4e391 Reviewed-on: https://gerrit.libreoffice.org/72491 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-05-02Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann1-2/+2
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit c56a8280bdd605f77f0075a7f2bfa474aa2a26e5) Reviewed-on: https://gerrit.libreoffice.org/71661 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-23Resolves: tdf#124698 bubble down parent for modal dialogCaolán McNamara1-1/+1
Change-Id: If03c6ff8043bb39f2efdf4cde19d8277886bf36f Reviewed-on: https://gerrit.libreoffice.org/70677 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-08Resolves: tdf#120754 on undoing an obj insert use its current ordinalCaolán McNamara1-4/+4
there may have been changes not caught by undo to the object's ordinal, so on use of RemoveObject (or ReplaceObject) call GetOrdNum on the object to get its current position within its parent. We can keep nOrdNum for the desired dest position within the parent for InsertObject Change-Id: I3bdabf387dd630fc1fadaaa1f3d8c05e93865e4f Reviewed-on: https://gerrit.libreoffice.org/70253 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-29Resolves: tdf#123291 set hex input to overwrite by defaultCaolán McNamara1-1/+28
and ensure the modify arrives after the input text has been filtered Change-Id: I16c0bd095700e7d9858e3e74884b5a1ad3eb7e4c Reviewed-on: https://gerrit.libreoffice.org/69764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f1e52cbdd4a9753a9b9d562ef280a00e52db1dae) support overwrite-mode Change-Id: I6133aedbebd3ca358e2b916469873c38fc7453cb Reviewed-on: https://gerrit.libreoffice.org/69761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2f70e6111b61d52bbdfa753257370cb82bfd30eb) Related: tdf#123291 treat overwrite like a selection of 1 for input into ImplTruncateToMaxLen like we do for the following erase Change-Id: I8cd02ff1ba76f61ddc614922068cbe2bc9bc4cb8 Reviewed-on: https://gerrit.libreoffice.org/69763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8622dc09954a1a26661e3524c99e7ed0f456cf6e) Reviewed-on: https://gerrit.libreoffice.org/69800 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-06tdf#123470 textforwarder has stale view of SdrTextObjCaolán McNamara1-1/+17
When we save the document we get a SwXShape for the SdrObject and call getShapeText on it, which creates a TextForwarder for it. The SwXShape is temporary and is discarded afterwards. If we modify the text and save again we get a new SwXShape and a new TextForwarder. If a11y is active, then when the textbox is inserted a11y gets a SwXShape for the object and the SwXShape stays alive while the a11y view of the Sdrobject stays around. The SdrObject will keep a weak ref to the current SwXShape for it, so on save we get the already existing SwXShape instead of a new one. On the first save this is ok, as the TextForwarder is created on demand. On the second save, the problem is that the SvxTextEditSourceImpl of the TextForwarded was initially created without a SdrView so its in sort of a "snapshot" mode, so first time the text is queried, that sticks as the result. So a cached text forwarder cannot be trusted when its for a SdrTextObj that's being edited and HasView is false Change-Id: Ib3d500752f1876086ef1996885a2b86b581f5bc4 Reviewed-on: https://gerrit.libreoffice.org/68475 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-06tdf#123452 EMF Re-enable compression for image/x-emf filesBartosz Kosiorek1-0/+1
Change-Id: I9fd801d5eef6c65f8e68e30723415da7b493d767 Reviewed-on: https://gerrit.libreoffice.org/68716 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit df22e97db5b7608b6d53b15b86b5a83610f9c87b) Reviewed-on: https://gerrit.libreoffice.org/68729 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-03-01tdf#116382 Replace old dialog in header and footer drop-down menuAditya1-1/+1
Remove the Background tabpage in "Border/Background" dialog accessed from Border and Background menu item in Header/Footer drop-down list and replace it with the tabpages "Area" and "Transparency" of the dialog accessed from Page Style > Header > "More.." button. The old dialog does not have the tabpages "Area" and "Transparency". In simpler words, the patch is to match both the dialogs when accessed in two different ways. Reviewed-on: https://gerrit.libreoffice.org/67483 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 55042cb54fea5f7ad777c03af9bf8197127b6736) Change-Id: Ib84435854389360eba41aecb8578a9a67a92ca1e Reviewed-on: https://gerrit.libreoffice.org/68545 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-02-21tdf#123090 Handle removed column with gridSpan.Gülşah Köse2-1/+1
This is a combination of 3 commits. (cherry picked from commit 48ef20f2039d1a300a4324072e9b712c9994b406) (cherry picked from commit 00e89430a2f8cd1f9ec702a7583a1e4c886a2b46) (cherry picked from commit 1f0206d940cd8f7fb627a59cfe4165c0bfebaf46) Change-Id: Ic6fa6f335623e2114fc8bea76dc54833284d2a02 Reviewed-on: https://gerrit.libreoffice.org/68150 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-02-19svx: allow UINameSingular property.Mark Hung1-0/+6
UINameSingular is used in the title of the animation effect. It was missed in media objects, contorl objects, frames, tables, etc., causing the title of the animation effect to become just a number without prefixing object type before it. Change-Id: I7446d59b1b80102c34b8326e20927f60ad24da25 Reviewed-on: https://gerrit.libreoffice.org/67934 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com> (cherry picked from commit b295921c4a78be42f815c6d6e708c931c1ee73ec) Reviewed-on: https://gerrit.libreoffice.org/68015 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-11Resolves: tdf#123122 category is just one bit, date+time is two bits setEike Rathke1-1/+1
DATE|TIME != DATE ... Regression from commit e85966450b770e1169f113183ce1a9a9f4dcc507 CommitDate: Wed Oct 3 12:08:55 2018 +0200 Related: tdf#119613 tdf#118127 suppress duplicated builtins, rework All cat Change-Id: If500dbeae00805f04f61586730479901b27d3901 Reviewed-on: https://gerrit.libreoffice.org/67554 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 8e12e3300592438b06b5649deaf84574de5066ba) Reviewed-on: https://gerrit.libreoffice.org/67575 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-02-08tdf#115941 use same font statusbar does for form navigator barCaolán McNamara1-8/+3
now that we have it the same height as a statusbar Change-Id: I0d5ee3f8dc57e94be5d45581bc4382e3448353c3 Reviewed-on: https://gerrit.libreoffice.org/67462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9a923e1ce53753bb8538054fd1658a67ca0ff354) Reviewed-on: https://gerrit.libreoffice.org/67487 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-29tdf#116051 Right border visible after hiding neighbour columnIlhan Yesil1-15/+32
Added an else statement to take into account that a hidden column has a neighboured left column with a right border. Change-Id: Ia415d422dd2fa305604e48cce55661408b835ea6 Reviewed-on: https://gerrit.libreoffice.org/63326 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 392729c735bb82eecf29bae5527ec786ca293f34) Reviewed-on: https://gerrit.libreoffice.org/67058 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-29Resolves: tdf#123019 give modal dialog a parentCaolán McNamara1-1/+4
Change-Id: I669d8cb18ed78fcdb50aa3f452661500d75ad880 Reviewed-on: https://gerrit.libreoffice.org/67022 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-17Resolves: tdf#122509 we have a second list with generated currency formatsEike Rathke1-8/+23
... which kicks in if SvxNumberFormatShell::FindEntry() determined a format index of NUMBERFORMAT_ENTRY_NEW_CURRENCY instead of a real existing index. Regression from commit e607f1da329a2d4dd91904053d7ff86ac05c77bf CommitDate: Thu Oct 4 15:02:13 2018 +0200 Select the current format if multiple instead of first matching format code The old (now removed as unused) SvxNumberFormatShell::GetListPos4Entry(const OUString&) used before took care of that, add the functionality back but combine into the existing GetListPos4Entry() function, the additional FindEntry() call wasn't necessary anyway because it was just called before in the caller. The actual crash happened elsewhere in SvNumberFormatter::GenerateFormat() because no format exists for the then determined entry, which should be changed independently to prevent such abuses. Change-Id: Id42efa152693119fbde82b234f367679f818cfab Reviewed-on: https://gerrit.libreoffice.org/66472 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit c9d19b70c93b02e5c666414097e835039c598731) Reviewed-on: https://gerrit.libreoffice.org/66477 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-16Resolves: tdf#122695 Content Type selector tooltip missingCaolán McNamara2-0/+23
Change-Id: I0ffe6448d865f569fb59d9facbb1582d2152a9ba Reviewed-on: https://gerrit.libreoffice.org/66291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 423d70f7e45749fad680b3dfe0ccdaed1c1afb19) Reviewed-on: https://gerrit.libreoffice.org/66384 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-15Resolves: tdf#122700 cannot change shadow colorCaolán McNamara1-8/+0
Change-Id: Iee42beb96ff4d059c685173fdde453981b300b3c Reviewed-on: https://gerrit.libreoffice.org/66361 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-21tdf#119180 Use 100th_mm in UNO API implementationArmin Le Grand1-5/+54
Since SvxShape::GetBitmap is UNO API implementation the results have to be in 100th_mm, that is how UNO API is defined. Adapted Bitmap creation common case to do so using primitve embedding if source is not 100_th_mm. Also added a shortcut if object in question already is a SdrGrafObj and contains a Bitmap. Needed to update the checksum of a graphic for testN777345. Change-Id: I995100406a262e2872597dc64e943271e92eb4cb Reviewed-on: https://gerrit.libreoffice.org/65505 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit df57d50e00820d59b2b7104b6e59883405d0f183) Reviewed-on: https://gerrit.libreoffice.org/65523 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-21Resolves: tdf#120885 Crash on choosing 'more styles'Caolán McNamara1-5/+12
switching to the sidebar destroys the control currently active, just post the event to happen on the next event loop Change-Id: I3e9b629821fa43d8f29e419e72f66ed46d72fdbb Reviewed-on: https://gerrit.libreoffice.org/65542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19tdf#122127 Crash in FORM EDIT using drag drop to move control in dataformNoel Grandin1-1/+1
regression from commit 2629aac31142449312f77c5843ea209cc810acb4 Date: Tue Oct 23 09:47:10 2018 +0200 clang-tidy performance-unnecessary-copy-init in svx Change-Id: I4210c328145d062d8b72f09dcff3280e11c6bc36 Reviewed-on: https://gerrit.libreoffice.org/65394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7d8bce646d53d77405b45a50fc6e889ccd0c10e9) Reviewed-on: https://gerrit.libreoffice.org/65399 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-17tdf#121638 , Different angle shown between sidebar & size and position dialogSumit Chauhan1-0/+1
Bug solved , Changed the nTmp = 360+nTmp ,if nTmp <0. Change-Id: I855e634540c55ab91e8bbe5824014d304d87c8e9 Reviewed-on: https://gerrit.libreoffice.org/65211 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> (cherry picked from commit 294c38229a37604fe2d0d82a6ebc7bcd086963f4) Reviewed-on: https://gerrit.libreoffice.org/65224 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-10Resolves: tdf#121946 first time draw uses gray bgCaolán McNamara1-0/+1
Change-Id: Ia0491eebe8fa7ea2c2377ca96c758c681da5470a Reviewed-on: https://gerrit.libreoffice.org/64876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-10Resolves: tdf#121520 duplicate languages in dropdownCaolán McNamara1-6/+9
Change-Id: I5bbde305bf06ac1f754f24eb93e89cb3d9cf6058 Reviewed-on: https://gerrit.libreoffice.org/64869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-07tdf#121022 Do change parent of SdrObj earlyArmin Le Grand1-5/+25
Need to change parent of an SdrObject in the according SdrObjList methods before calling InsertedStateChange - that one relies on asking for the parent of the SdrObject Change-Id: I8c4d39190cafe889b27975941d72afca870e2ce5 Reviewed-on: https://gerrit.libreoffice.org/64608 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit b38f856f234f364199d306226875471ed589b764) Reviewed-on: https://gerrit.libreoffice.org/64706 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-05tdf#120527 svx GraphicObjectShape: handle XBitmap for GraphicURLMiklos Vajna1-0/+14
This restores compatibility for API users who called getByName() on the bitmap table and expected that the result can be set as a value for the GraphicURL property. The case is similar to the Writer images, which was handled in commit 587803ba46055d43b5b108be744fdde17aeabc7c (sw TextGraphicObject: handle XBitmap for GraphicURL, 2018-08-08) already. Change-Id: I3740a68989b306425d0d6c4d4e350ac163cb4170 Reviewed-on: https://gerrit.libreoffice.org/64069 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e30f3e76a9350e2b027d99bba5a46aa0a0ff8256) Reviewed-on: https://gerrit.libreoffice.org/64427
2018-12-04weld OfaAutoCorrDlgCaolán McNamara1-0/+10
Change-Id: Iba217a2998de57bf963872f9b8c1cf38694eb935 Reviewed-on: https://gerrit.libreoffice.org/64507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-30tdf#93005, tdf#100611, remove the incomplete ODC export featureMarkus Mohrhard1-19/+0
Change-Id: I96a3882cd412ea5d993971df7e20b1fd8da73642 Reviewed-on: https://gerrit.libreoffice.org/64283 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d543e8dfd3d8ae718e29304a155e1cf70d08325d) Reviewed-on: https://gerrit.libreoffice.org/64311
2018-11-29weld ActualizeProgressCaolán McNamara1-2/+1
Change-Id: I35c486ac2dcf9818e331816f554a5c414bdb2386 Reviewed-on: https://gerrit.libreoffice.org/64221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-29weld GalleryThemePropertiesCaolán McNamara1-1/+1
Change-Id: I88fbb9ab03f0026ffe0c5fe79ab0a386160738a1 Reviewed-on: https://gerrit.libreoffice.org/64220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-29weld GalleryFilesPageCaolán McNamara1-2/+84
Change-Id: I5fa399144fb12bb19c3b88bf99f99dad6a64e052 Reviewed-on: https://gerrit.libreoffice.org/64211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25weld SfxMacroAssignDlgCaolán McNamara1-1/+1
Change-Id: I80045f1d1ca189fc490dc88b3471d68782df6f1c Reviewed-on: https://gerrit.libreoffice.org/63988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23tdf#114836, only set changed SfxItemSet propertiesMarkus Mohrhard1-1/+5
By always setting all existing properties again the calls started to differ between XMultiPropertySet::setPropertyValues and XPropertySet::setPropertyValue. This patch reduces the changes in the called methods. We can not avoid slight differences but at least the risk is minimized that something is unexpectedly changed. Change-Id: I5866db7be2829e6aba930f620f45db655df4e3f7 Reviewed-on: https://gerrit.libreoffice.org/63854 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 80cf278d365a2d357c70b8c28947c91fa97e7a99) Reviewed-on: https://gerrit.libreoffice.org/63856 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23tdf#118764 Pos&Size and Shadow panels tab stop fixesJim Raykowski2-5/+5
Change-Id: Id6ee2eed8ee96b901be8172cccc9b50e01877e3b Reviewed-on: https://gerrit.libreoffice.org/63844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23weld SwFramePageCaolán McNamara1-674/+19
Change-Id: I12f868611860867df26bd29474aa19189c2b9a96 Reviewed-on: https://gerrit.libreoffice.org/63842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwCondCollPageCaolán McNamara3-9/+9
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 47897fdd936d9b6e9ac8cb6110c79352ab080df7) Reviewed-on: https://gerrit.libreoffice.org/63770
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen2-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 40710c488de3e4eef585c5a5276c9a0943d36f2e) Reviewed-on: https://gerrit.libreoffice.org/63769 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen10-0/+10
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 492ea7e08571e466e37f870b7642a79df55c2e92) Reviewed-on: https://gerrit.libreoffice.org/63768 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22Resolves: tdf#121531 impossible to change angle/rotation by text inputCaolán McNamara1-4/+3
Change-Id: Ic5fb01ac088cc777534e7986001defb61bc6ee60 Reviewed-on: https://gerrit.libreoffice.org/63734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21tdf#121540 crash deleting a form from form navigatorNoel Grandin4-6/+7
regression from commit eec9f6c8b928de38dd9e683f46bfab00f3243048 Date: Mon Jun 4 15:01:43 2018 +0200 loplugin:useuniqueptr in FmEntryDataList and rename the method to make the it's operation clearer Reviewed-on: https://gerrit.libreoffice.org/63694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2edc8c53433be4423d7b009c9f60ed732d554816) Change-Id: Ife366f02c3d8907c397345d825ef7d1721d8930c Reviewed-on: https://gerrit.libreoffice.org/63704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-20Simplify color status handlingMaxim Monastirsky1-106/+38
(cherry picked from commit eb5b353b523ec4d7d6588e2fae5b8b4117bfc2b1) Rename BorderColorStatus to ColorStatus (cherry picked from commit 57f33bfd0c69a4568d1d5840391ab9901d4f4f66) Change-Id: I9335fa2ab94f69853b45f070499d7e18aac458c3 Reviewed-on: https://gerrit.libreoffice.org/63607 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-11-19tdf#121232 set a size request that will result in a 0 m_nXGap by defaultCaolán McNamara1-2/+10
Change-Id: I25ce389bd46beff2dd9b0507581736f2f9511383 Reviewed-on: https://gerrit.libreoffice.org/63575 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19weld TreeViewCaolán McNamara4-1/+6
a) use GtkTreeStores for GtkTreeViews b) ironically can't store GtkTreeStore contents in .ui apparently c) set show_expanders for all non-trees and unconverted cases d) on-demand subtrees Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31 Reviewed-on: https://gerrit.libreoffice.org/63558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19tdf#121267 Handle missing diagonal bordersMaxim Monastirsky1-2/+7
Regression of 9125a4f3f63a7f49fd307908c181e999120063e0 ("Use FeatureStateEvent directly for status updates"). Change-Id: I57856c5707fffcf84f95afa9ef80a394b550c56f Reviewed-on: https://gerrit.libreoffice.org/63497 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit f162066d9df814086c92fa008c563ffc08daaf98) Reviewed-on: https://gerrit.libreoffice.org/63551 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 07:31:31 +0000