summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2017-07-11svx: assert on undisposed AbstractSvxHpLinkDlgMichael Stahl1-0/+5
3 in () at /lib64/libc.so.6 4 in VclPtr<AbstractSvxHpLinkDlg>::~VclPtr() (this=0x88d47e8, __in_chrg=<optimized out>) at include/vcl/vclptr.hxx:115 5 in SvxHlinkDlgWrapper::~SvxHlinkDlgWrapper() (this=0x88d47a0, __in_chrg=<optimized out>) at include/svx/hyperdlg.hxx:34 6 in SvxHlinkDlgWrapper::~SvxHlinkDlgWrapper() (this=0x88d47a0, __in_chrg=<optimized out>) at include/svx/hyperdlg.hxx:34 7 in SfxChildWindow::Destroy() (this=0x88d47a0) at sfx2/source/appl/childwin.cxx:182 8 in SfxWorkWindow::RemoveChildWin_Impl(SfxChildWin_Impl*) (this=0x6c83940, pCW=0x683bc20) at sfx2/source/appl/workwin.cxx:1425 9 in SfxWorkWindow::ToggleChildWindow_Impl(unsigned short, bool) (this=0x6c83940, nId=5678, bSetFocus=true) at sfx2/source/appl/workwin.cxx:1832 10 in SfxViewFrame::ToggleChildWindow(unsigned short) (this=0x6afdae0, nId=5678) at sfx2/source/view/viewfrm.cxx:2964 Change-Id: I84a1ba817dc8449dc1942b6ebd443ec955e8c622 (cherry picked from commit 07341af48ed8ec2368aee87d120942f3e6bb6d49) Reviewed-on: https://gerrit.libreoffice.org/39805 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-11tdf#107666: EDITING: No caret outside the textbox after inserting a textboxTamás Zolnai1-1/+1
This reverts commit 44555103217df34b218787f3dc6a2634b41fe52e. Now revert the related commit, need to revisit the original bug later. Change-Id: I08f42c4e859277ab411e4be5ad065fe3cca8bbb6 Reviewed-on: https://gerrit.libreoffice.org/38924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-27Resolves: tdf#108419 use spinfield preferred size as transparency widget sizeCaolán McNamara1-5/+2
Change-Id: I7b5c8aeb087efe007c687dc1f206bcb0e8b0173e Reviewed-on: https://gerrit.libreoffice.org/38866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-23tdf#93968 bullet char style preview is unreadable, cause uses opensymbolCaolán McNamara1-0/+2
Change-Id: I1bd0a0e85c9d956184680d7e15709b3a7b590c30 Reviewed-on: https://gerrit.libreoffice.org/39010 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/39053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-13tdf#108480: Undo from clone formating does not remove vertical alignmentTamás Zolnai2-14/+14
In the related change: d36aa2ba3132ce62a370b7260ca620642cbf7dbf wrong method was used to set cell properties, which does not handle undo actions, so use the proper function. Other issue was related to undo handling of vertical text alignment in general. In some cases undo actions were lost after user clicked out of the cell. It is because vertical alignment is not affecting the outliner and so the related undo actions were just dropped in EndTextEdit() method. Reviewed-on: https://gerrit.libreoffice.org/38699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 37d8ac12902506f4185e10f1de4f566dbaf53e42) Change-Id: I3a6a95fac711056a658a3dee616733939cd13330 Reviewed-on: https://gerrit.libreoffice.org/38723 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-05tdf#101885: fix crash in AccFrameSelectorJulien Nabet1-0/+2
Deal with no parent case 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 0 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 1 0x00007ffff54f2d1f in svx::a11y::AccFrameSelector::getAccessibleIndexInParent() () See https://bugs.documentfoundation.org/attachment.cgi?id=127141 Change-Id: I795dc4c083d743466b5605d3dcc8f9fca8674c43 Reviewed-on: https://gerrit.libreoffice.org/37575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit c9275062ed745a8c5d52a3863299baf8bcf86ea7) Reviewed-on: https://gerrit.libreoffice.org/38414 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-05-31Related: tdf#107961 ensure notifyhdl is unset after disposeCaolán McNamara1-2/+18
Change-Id: I69790c8d3cfffc09ee6d6c165e17823223c5058a Reviewed-on: https://gerrit.libreoffice.org/38238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-31tdf#100072 zero height of shape's path was causing geometry errorsVasily Melenchuk1-2/+15
DOCX custom geometry shape's path width and height are now used independently for scaling calculations. Reviewed-on: https://gerrit.libreoffice.org/37639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5477f7274e4df1210298c0f503a54eabc0f06bfc) plus: tdf#100072 extra test for DOCX shape import with zero height Corresponding bug is already fixed in tdf#107104. However created tests do care only for width, but not for height, like we have in this testcase. Reviewed-on: https://gerrit.libreoffice.org/37538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit cffc5a04661fc0a84dff9fa5da954236d88a8b38) Change-Id: If5d5499f402379df125b0f31dd071ca51b2553f1 Reviewed-on: https://gerrit.libreoffice.org/38224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-24Resolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entryCaolán McNamara1-0/+9
we don't need MakeHexStr either, the colorbox will do that on its own Reviewed-on: https://gerrit.libreoffice.org/37898 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7539c77fd49889015ad3a952009e33fac5324df6) Change-Id: Ifad523092c0f15cd51d0d829790c0cec1c96bb53 Reviewed-on: https://gerrit.libreoffice.org/37905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-15fix gdi resource leak (svx/compressgraphicdialog)Julien Nabet1-1/+1
Change-Id: Iea6e481384cee4d7e2ff6787c64d3048ba9c9d65 Reviewed-on: https://gerrit.libreoffice.org/37587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 68a1cb23ede1d4ae6195850190fca6953c30417f) Reviewed-on: https://gerrit.libreoffice.org/37592 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-15fix gdi resource leak with unreleased virtual deviceMarkus Mohrhard1-1/+1
Change-Id: I1fd8c76a206cfc940e3d646e4025618785985e52 Reviewed-on: https://gerrit.libreoffice.org/37583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 289711c2a469bfbe06aef3b3870b65f9c788f56d) Reviewed-on: https://gerrit.libreoffice.org/37585 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-05-11tdf#107706 fix crash when closing Calc documentNoel Grandin1-0/+2
regression from commit e8b49f09074fe184374bee5062715357427ae044 "new loplugin: useuniqueptr: vcl" Change-Id: I07ac157a02aa82b1ddbb741797fea093772f93f1 Reviewed-on: https://gerrit.libreoffice.org/37497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-29tdf#107505: Impress - crash with two people co-editing one slideTamás Zolnai1-1/+1
Deleting outliner view removes the pointed Cursor (pTECursorMerker). Change-Id: Iac17386d1d02bf52bd5322073e49da05c6e89d9b Reviewed-on: https://gerrit.libreoffice.org/37085 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 44555103217df34b218787f3dc6a2634b41fe52e) Reviewed-on: https://gerrit.libreoffice.org/37094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-31ofz#974 check SetBorder bounds like the other maHorizontalBorders usersCaolán McNamara1-14/+17
Change-Id: Iac113433ac2317ddfebc68ed793c481384d56551 Reviewed-on: https://gerrit.libreoffice.org/35965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-22Resolves: tdf#105463 convert bmps to pngCaolán McNamara1-1/+1
because bmps aren't seen since... commit c3043a3072465c489d3b20991b17d222771305eb Date: Mon Oct 31 13:28:26 2016 +0100 tdf#103591 icon theme name resolving, ui fixes, prioritize png - Prefer "png" over "svg" because for Tango theme we include both (cherry picked from commit a3c4f39868226151b4b01906cbcf1b6d40740a28) convert from bmp to png (cherry picked from commit 1b7d1d16e3a6826433271b3eed4a2d542585961b) Change-Id: I93755ac95c170c457b32adac07557ed48ad8beee 7fe47f47f19b93eab5d0cef0afde63e6f61c21b4 Reviewed-on: https://gerrit.libreoffice.org/35534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-03-21tdf#106382 - Fix incorrectly shown change tracking comments in dialogPranav Kant1-2/+2
First item in the array is treated as the number of fields followed by their widths. There are only 4 such fields in case of writer, not 5. Change-Id: Iff6f21b54b73d4395d64d83f2acf1de2a19a251e Reviewed-on: https://gerrit.libreoffice.org/35484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 551e86ff278d4608a54d311f387ca57ef4732000) Reviewed-on: https://gerrit.libreoffice.org/35502
2017-03-09tdf#105656 only delete path if less than 2 pointsRegina Henschel1-1/+1
This prevents the crash. It might be related to gerrit #/c/33654 Change-Id: I92907c7874964af722b69ed8afd9249e110b3401 Reviewed-on: https://gerrit.libreoffice.org/33907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 9e8f2afc2e2bbdbe136e74a24fb6c6eb94cde3c6) Reviewed-on: https://gerrit.libreoffice.org/34688 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-02-28prevent crash in PaletteManagerMarkus Mohrhard1-6/+8
Found by the crashreporter: http://crashreport.libreoffice.org/stats/signature/PaletteManager::ReloadColorSet(SvxColorValueSet%20&) Change-Id: I82c5e3f7588615700ec3b5540ac94e331df783bb Reviewed-on: https://gerrit.libreoffice.org/34627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit ece3c97ca6c9aaffbf9dd51785ae2f1d4d3e2c9b) Reviewed-on: https://gerrit.libreoffice.org/34634 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28Resolves: tdf#106099 tweak to restore old behaviourCaolán McNamara1-25/+36
wrt initial default color if none gets set. This doesn't fix the various bizarre things in font and replace by formats, just restore to its historical initial behaviour (cherry picked from commit 0fa4efec2e58ecd8d749972f1e8c2a20d1c3a6bc) Change-Id: I82cc3f05d2f205947a140483537baae882e91530 Reviewed-on: https://gerrit.libreoffice.org/34510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-28mpMediaItem might be nullptrMarkus Mohrhard1-6/+12
This fixes at least two crashes reported through the crashreporter: http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getTime() http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getDuration() Change-Id: I92eeca229fa46921317586d0317e9f00309e793b Reviewed-on: https://gerrit.libreoffice.org/34710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b5987a4148a10e27fe44ecf5d03e697692e07ca9) Reviewed-on: https://gerrit.libreoffice.org/34712 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-27tdf#106082 fix missing statusbar translations (l10ntool is picky about syntax)Christian Lohmaier1-2/+1
having the ; on a separate line made all strings following that have the string-ID of the next unit, altering the msgctx and thus translations wouldn't apply anymore Change-Id: Ia1e3c36a9d2a57725c90e6c3f33de99bed85ec41 (cherry picked from commit 9eaa17e6bb35a2cb71ec59c96ea4a39466789667)
2017-02-21Resolves: tdf#106105 duplicate marks not merged when they are at the startCaolán McNamara1-1/+2
i.e. initial mark isn't compared which goes on to crash under some circumstances regression from... commit aa11e7bae89fe691f914abb27d1c4a03d27a7ee5 Date: Tue Aug 14 16:31:53 2012 +0200 Convert maList in SdrMarkList from Container to std::vector Change-Id: Ib3e9b02aad91c14971656af171d48154507da127 (cherry picked from commit 35bb22c1a834b306c910cb065bc006818c9fa9b3) Reviewed-on: https://gerrit.libreoffice.org/34477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-16Related: tdf#105712 inconsistency with num of a11y children in special charCaolán McNamara2-11/+19
with no visible scrollbar it claims 1 child, but trying to get child at index 0 throws (cherry picked from commit b3098d239f46c8d5965754f275bc62216dcb4f4f) Change-Id: Icf1a0afc4a6f6090e3f14f30b4380db477955561 Reviewed-on: https://gerrit.libreoffice.org/34313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-16Resolves: tdf#105229 restart in normal mode instead of quittingKatarina Behrens3-13/+16
Change-Id: I546629656ada6c7a8a15b4dc77a042e1f1106924 Reviewed-on: https://gerrit.libreoffice.org/33059 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 29b13a24cf5f0e6e58641d4a55cdfa03c83b68ac) Reviewed-on: https://gerrit.libreoffice.org/34096 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-15tdf#106011: The "swing angle" is negative when counter-clockwiseTor Lillqvist1-1/+1
Change-Id: I1ef77e4c8cf0a6d31b36411a79b576115c32c644 (cherry picked from commit 34d8dc19a08e2752a4b8d3b3d83b7cf3ac341f1c) Reviewed-on: https://gerrit.libreoffice.org/34283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-09tdf#105707 PPTX import: warn when SmartArt is missing DrawingML fallbackMiklos Vajna1-0/+6
By the time DiagramGraphicDataContext::onCreateContext() completes, we know if there will be a DrawingML fallback for the SmartArt (called ExtDrawing in the code) or not. Warn about this case once at the end of the import when in interactive mode. Headless mode silently ignores the warning as expected. (cherry picked from commit ae828495be9c2ac5fdb4c1747ed7bdd51e5d87a7) Conflicts: include/svx/dialogs.hrc oox/source/core/xmlfilterbase.cxx Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d Reviewed-on: https://gerrit.libreoffice.org/33872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-30tdf#105502 sd increase font size: handle table selectionMiklos Vajna1-0/+4
In part of a table shape is selected, then only operate on the selected cells, not on all of them. (cherry picked from commit cbc84a6599c08e5c79e544212c69c6946d0cdbf0) Conflicts: sd/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: I3a9ba2b99bcaa2e355b6fcdafdd142d4a809bce6 Reviewed-on: https://gerrit.libreoffice.org/33553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-26tdf#105520: "Selection Count" does not appear on Status bar when selectedTamás Zolnai1-1/+1
Change-Id: I6ade03b39aeafffa08cfbfcca4739cfe5a73d4ac Reviewed-on: https://gerrit.libreoffice.org/33561 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 326729ce54de5296cb2a673ae88d2befa3e245ef) Reviewed-on: https://gerrit.libreoffice.org/33564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-22Dispose unused submenuMaxim Monastirsky1-0/+2
Open Writer, Insert > Form Control > Table Control, draw it, cancel the wizard. Now right click on the table header -> crash. (can't be tested with gtk/gtk3 vclplug, because GtkSalMenu holds reference to the menu). Probably this crashreport: http://crashreport.libreoffice.org/stats/crash_details/ 0bfabafd-3ba4-4c07-8479-399dea07c006 Change-Id: I6588b1e0b5ad4537a4eb98f6a343d0e92264329f (cherry picked from commit 0a849c9315a74754dbbecc529e5c5ccda66fbd86) Reviewed-on: https://gerrit.libreoffice.org/33329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-17tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBarNoel Grandin2-15/+16
caused by VclPtr fixes which meant instead of the dialog staying in an always-zero ref-count state, it went up to a ref-count of 1, then down to zero, which triggered a delete before the dialog had finished displaying. And revert my fix in commit 0c1cd678f71e519f5a4e623d93442e046485005a which just worked around the underlying problem Change-Id: Icb35535dd06a2d1db1016d00d106760847d87430 (cherry picked from commit cd9d8315141c3070f43e145ed4ee390e837eb73f) Reviewed-on: https://gerrit.libreoffice.org/33209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-16Resolves: tdf#101187 colossal page width wraps around if doubledCaolán McNamara1-17/+22
when trying to generate a reasonable upper bound clipping region Change-Id: I53f8ea1bd6c52c88284e1f41369f83492d078b5d (cherry picked from commit 2fd88ab1cbb4690a770ca2ca5d66157ec4906a2e) Reviewed-on: https://gerrit.libreoffice.org/33008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-13SvxFontNameBox_Impl was not disposedMaxim Monastirsky1-14/+23
This is visible after toolbar customization, when the old font box stays visible. Turns out that currently the toolbox controller is supposed to own the item window, not the toolbox. Regression of: commit 970a66f8c919ea0524f216f40d21b3e2a8c88ccc Author: Maxim Monastirsky <momonasmon@gmail.com> Date: Sun Oct 16 01:27:10 2016 +0300 Use UNO registration for font name toolbox control Change-Id: I29a1f06d97c9a981507ff62889e2d7fc6ac9d688 Reviewed-on: https://gerrit.libreoffice.org/32943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit e1f5db9579602dd02a80c1d1ea1d078606542f16) Reviewed-on: https://gerrit.libreoffice.org/32956 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-22tdf#104737: Bullets and Numbering: inconsistent naming of last tab pageTamás Zolnai1-14/+1
Change-Id: Id1d1d92933c110942fd232067620e8224686a915 Reviewed-on: https://gerrit.libreoffice.org/32256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 584c745ea484e1f8047278fc83b41b30a90f884d) Reviewed-on: https://gerrit.libreoffice.org/32321 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-19svx: remove nonsense exception throwing codeMichael Stahl1-30/+2
Commit 60f11adb950e4f9645cc9ecb0f5af8235cc97366 added code to AccessibleShape::getAccessibleStateSet() that tries to retrieve some state from the parent, but the implementation of the base class AccessibleContextBase::getAccessibleParent() throws if it is already disposed, which is the condition checked just before, so surely this doesn't have any other effect than throw DisposedException, except possibly in the mpText == null case which is already handled in the other branch with identical code. Change-Id: Iaf109f69036437989abbbf914ef32cca1528a97e (cherry picked from commit ffb5bf421f5c0c565128116df40318f5b707b821) Reviewed-on: https://gerrit.libreoffice.org/32188 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-12-19tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl1-1/+5
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. (cherry picked from commit 5a3b2111172f106378cbf78aba0fde1db3642275) loplugin:unnecessaryoverride (cherry picked from commit 10bf49c18d56f198e63514953a1c6e2ea17fcc9c) Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee Reviewed-on: https://gerrit.libreoffice.org/32187 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-12-17tdf#104722: Wrong text alignment when text box is smaller than the text insideTamás Zolnai1-1/+9
The default TextHorizontalAlignment is block. Setting paragraph alignment (on UI) works when this text alignment property is set to block (otherwise has no effect). In general this works on this way, but the existing algorithm did not work in those cases when the text was bigger than the container shape. Change-Id: I02dba76f8e3033a465bb14dc826521966bb30987 Reviewed-on: https://gerrit.libreoffice.org/32123 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 5694b4970e3af096130e172ac6968b10ed587a6f) Reviewed-on: https://gerrit.libreoffice.org/32126
2016-12-14fix build, invalid conversion from "const char*" to "int" [-fpermissive]Eike Rathke1-27/+27
Change-Id: Idc50ef5eb250a2a68ae6c6aaed969289baaf38f4 (cherry picked from commit b52167df08511239c3d08904a3d12a3c92141f38) Reviewed-on: https://gerrit.libreoffice.org/31978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-12-14split markers for galaxy theme, when scaling use splitted markersTomaž Vajngerl2-5/+219
For markers (resize markers, anchors,...) we contain them all in one image atlas. This was generally done because of resource limitiations in Windows 95/98 which aren't a problem anymore in present systems. This is however problematic in HiDPI as we scale the image and the coordinates of aren't correct anymore. Another problem is that it uses its own cache instead of common cache in ImplImageTree. So this commit extracts all the markers into its own images for galaxy theme and uses them when we scale. In the future when we extracted all the markers to its own images for all icon themes we can remvoe the old code with the image atlas. Change-Id: Ibee181b529d30e20050df8cd396d338bd53532c0 (cherry picked from commit 681c2c3f59863d1f2d0123a92ee63baf84e18dfc) Reviewed-on: https://gerrit.libreoffice.org/31960 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-12-13add missing legal and modelinesEike Rathke1-1/+22
Change-Id: If828b51fc72ecbeec7db7a2a1af0be1bb4cd753a (cherry picked from commit 1141f178382be0add06ba182cc02c2adb7e96324) Reviewed-on: https://gerrit.libreoffice.org/31967 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt1-0/+1
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 0fda52cc4a5c78c55f96850faa734ea66891808c) Reviewed-on: https://gerrit.libreoffice.org/31937 Tested-by: Jenkins <ci@libreoffice.org>
2016-12-11Remove superfluous jargon from user visible stringKhaled Hosny1-2/+2
No idea what “CTL” is supposed to convey here, they do not even look as well formed strings. Change-Id: I424072fb5efdecd9115649dd3abbd4e9d5dc032c Reviewed-on: https://gerrit.libreoffice.org/31837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 9fb706f9fe216f6157b9052bc42a0601d8ae52d5) Reviewed-on: https://gerrit.libreoffice.org/31847 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-08tdf#104405 Clone Formatting ignores vertical text alignmentNoel Grandin3-50/+91
Reviewed-on: https://gerrit.libreoffice.org/31623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d36aa2ba3132ce62a370b7260ca620642cbf7dbf) Change-Id: I56cce69ddb21f7f9336b8f59e181e91306e92019 Reviewed-on: https://gerrit.libreoffice.org/31746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-06SafeModeDialog: Rename widget to match labelSamuel Mehrbrodt3-8/+8
Change-Id: I6bb02527fa77846343e55ff73497d1b46b5e1ba8 Reviewed-on: https://gerrit.libreoffice.org/31699 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 6ce819eefe8dab8ba38bda160e45ccc4220c40f3) Reviewed-on: https://gerrit.libreoffice.org/31704
2016-12-06SafeModeDialog: Add option to reset bundled extension registrationSamuel Mehrbrodt3-1/+28
Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a Reviewed-on: https://gerrit.libreoffice.org/31694 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 4a4c4d3768eab66c14e9e444e33bca0acb60981e) Reviewed-on: https://gerrit.libreoffice.org/31703
2016-12-06SafeModeDialog: Rename to match realitySamuel Mehrbrodt3-14/+14
This doesn't remove shared&bundled extensions, but resets the registration database from shared extensions. Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5 Reviewed-on: https://gerrit.libreoffice.org/31693 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit a3597a3f370175d0c06887e6691cbfa045937ad4) Reviewed-on: https://gerrit.libreoffice.org/31702
2016-12-06SafeModeDialog: Could not activate checkboxes to remove extensionsSamuel Mehrbrodt1-0/+1
Because of missing event handler Change-Id: Id546a2b22a89321ca09ec29ba7787a1315753bcf Reviewed-on: https://gerrit.libreoffice.org/31692 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 801f578fe43965a7e97cef71081e9a79a6cab72c) Reviewed-on: https://gerrit.libreoffice.org/31697
2016-12-06Simplify codeSamuel Mehrbrodt1-28/+6
Change-Id: Ibb154ebdacb6f445371cb55d795420f92bed0a22 Reviewed-on: https://gerrit.libreoffice.org/31691 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 9da0627254ca31f768740a7b6012ca85d925fb30) Reviewed-on: https://gerrit.libreoffice.org/31698
2016-12-02Add toolbar button for page orientationMuhammet Kara1-1/+1
Change-Id: Ia9458f8ac32bb8c6da6fc08e5fee527ca6fb8bd5 Reviewed-on: https://gerrit.libreoffice.org/31473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 83b7e1f424a3fb0963b064e77d973e5f655fac1a) Reviewed-on: https://gerrit.libreoffice.org/31531 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2016-11-29safe mode: typos, vocabulary, help buttonKatarina Behrens1-16/+31
Reviewed-on: https://gerrit.libreoffice.org/31335 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 603bca03c1b546d627fa7c6fe33021690ce374c5) safe mode: Add help button Change-Id: I8ddeec03ea96eaca873136ccc3100577eba23939 5aa29ccf048dc6f7d927089cc3c9b8b39bf2893c Reviewed-on: https://gerrit.libreoffice.org/31369 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-29tdf#98525 Commit font style change to dimension line objectUlrich Gemkow1-0/+5
Change-Id: I59e19e00fd0fdadaa7bffc4fbd1cb79d7e5a9763 Reviewed-on: https://gerrit.libreoffice.org/30609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit ae95f8b7b1b75d0e367db643ad82821ee371a84a) Reviewed-on: https://gerrit.libreoffice.org/31328 Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 03:27:51 +0000