summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke5-5/+0
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27tdf#79546: Make sure temp copy of inserted media file keeps the same extensionTor Lillqvist1-4/+24
Inserting videos into Impress presentations with 'Insert>Audio or Video' did not work at all for me. This helps. It seems that the AVFoundation APIs are sadly rather picky about file name extensions. Why we need to make a temporary copy of the media file (which after all can be rather large) at all, when inserting it in a slide, I don't understand. But I am not going to dig into that now. Change-Id: I43fcfb5bb3ef0a2c0f8979ac3e7c458a84f180a1 Reviewed-on: https://gerrit.libreoffice.org/50390 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-02-27Fix exporting bitmap table + testTomaž Vajngerl3-1/+102
Change-Id: I0577de02000c6aeb45bf1e950b9212beadacb05b Reviewed-on: https://gerrit.libreoffice.org/50334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin39-90/+90
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert various MessBox to weld::MessageDialogCaolán McNamara2-41/+0
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38 Reviewed-on: https://gerrit.libreoffice.org/50398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara25-28/+0
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-27Styles dialog no longer gives any statusSamuel Mehrbrodt1-3/+0
So always enable the button to activate the styles sidebar. Found by UBSAN: test_asian_phonetic_guide (asianPhoneticGuide.asianPhoneticGuide) ... /svx/source/dialog/rubydialog.cxx:322:68: runtime error: downcast of address 0x602000635e30 which does not point to an object of type 'SfxBoolItem' 0x602000635e30: note: object is of type 'SfxVoidItem' Change-Id: I6ff20c76b4a45189d78707cd258ed2aff80c50a5 Reviewed-on: https://gerrit.libreoffice.org/50367 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara2-7/+8
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26use less TRGB_COLORDATANoel Grandin1-1/+1
part of removing ColorData Change-Id: Id2d5843762227559f97cfb5eb61c01c888a0601e Reviewed-on: https://gerrit.libreoffice.org/50347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26use less RGB_COLORDATANoel Grandin1-2/+2
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26Translate German variable namesJohnny_M1-4/+4
Translated the enum values in editeng, but kept the their translation references in editrids.hrc, to prevent a need to update translations. "UPPERCASE" was used instead of "CAPS", in alignment to style::CaseMap. The values in svxitems.sdi don't seem to be used anywhere, but translated anyway. Change-Id: I1b3a9a68ce814841819b361ce5767764e3b1968c Reviewed-on: https://gerrit.libreoffice.org/50305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin13-29/+14
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26move MovePoint and MoveRect into Rectangle and PointNoel Grandin9-21/+21
Change-Id: Ie75c7c10288da00aac89479879e0b9fb1a4459b2 Reviewed-on: https://gerrit.libreoffice.org/50247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26xmloff: remove unused code when loading/saving the bitmap tableTomaž Vajngerl2-6/+9
Change-Id: I6bffe243e813079538a4cb57111266b41d7c03f1 Reviewed-on: https://gerrit.libreoffice.org/50333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25convert remaining InfoBox to weld::MessageDialogCaolán McNamara4-7/+17
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8 Reviewed-on: https://gerrit.libreoffice.org/50205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25amend Sequence sizeJochen Nitschke1-1/+1
Change-Id: Ib5fd612c2cba6190f414aca261415b3b977971c0 Reviewed-on: https://gerrit.libreoffice.org/50300 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25forcepoint #8 null derefCaolán McNamara1-1/+6
Change-Id: I29450ab45eba5cccfbfff4744c853e2e70ce679e Reviewed-on: https://gerrit.libreoffice.org/50291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25remove "FillBitmapURL" propertyTomaž Vajngerl1-29/+5
Change-Id: Icac13a412ae16e4b367362ca85a37fa29802c68b Reviewed-on: https://gerrit.libreoffice.org/50169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25tdf#115895 - Color picker images missing in ImpressNoel Grandin1-1/+3
VirtualDevice does not have an alpha channel by default. Change-Id: I4eebd7a23546a77dc9df2e2dad12d37eec4560ef Reviewed-on: https://gerrit.libreoffice.org/50248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-25convert all help responses to gtk's -11Caolán McNamara24-58/+58
and ok responses to gtk's -5 and cancel responses to gtk's -6 and close responses to gtk's -7 and yes responses to gtk's -8 and no responses to gtk's -9 Change-Id: Ia1a261a3a711ed9f5d8c0b0c639897c3064bb08c Reviewed-on: https://gerrit.libreoffice.org/50206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22weld native message dialogsCaolán McNamara28-160/+198
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22Replace "ReplacementGraphicURL" with "ReplacementGraphic" propertyTomaž Vajngerl1-5/+3
To transport the replacement graphic we use "ReplacementGraphicURL" property, but as it uses an GraphicObject URL it needs to be replaced. The new "ReplacementGraphic" does this with an XGraphic object as instead of the String URL. Change-Id: Iddf01c9aecb2a31a467e7b9d399495e0428d1859 Reviewed-on: https://gerrit.libreoffice.org/49993 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann1-1/+1
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcopy extend to ColorNoel Grandin9-12/+12
Change-Id: I224cc955d49ee100d328e0171da710f38068d2d4 Reviewed-on: https://gerrit.libreoffice.org/50114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21report the saved mimetype when saving graphic + mime from streamTomaž Vajngerl1-7/+21
When saving we need to determine which mime type to use for the graphic. Return this information back to the caller so the metadata can be written into the file if necessary. Also add function to determine the mime type from the XGraphic by converting it to a stream first (only then we can determine the format that will actually be used and written to the storage file. Change-Id: I796da715e47f29d77dea605a2769a2217ecd6ba5 Reviewed-on: https://gerrit.libreoffice.org/49992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-21Revert "simplify ImpXPolygon"Stephan Bergmann3-125/+332
This reverts commit f9c2bcc8b761f5e21354c0fb7bca6aa432d11ec2. Drawing all sorts of curves and polygons in Draw causes various crashes in svx/source/svdraw/svdopath.cxx, apparently because in the past ImpXPolygon's pPointAry had a "buffer" of more elements (nSize) than it had nPoints, and the code heavily relied on that, assigning to such excess elements of pPointAry past nPoints (and presumably calling XPolygon::SetPointCount later?). Conflicts: svx/source/xoutdev/_xpoly.cxx (Reverted the mostly, if not completely, automatic changes there done by 924c0e34fdc36cd44100dafc2c68656ce32374e6 "loplugin:changetoolsgen in svx"; they will need to be re-done.) Change-Id: I6cb41fd218c3bdd0b3bbeb45f5b3d68649901a48 Reviewed-on: https://gerrit.libreoffice.org/50057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21RGB_Color method is unnecessaryNoel Grandin7-29/+21
it has exactly the same effect as just letting the constant be converted to Color via the Color(ColorData) constructor. This commit is part of the process of removing ColorData. Change-Id: Ie12ad451ba3f43a627ebdbb132a5369f5760ba52 Reviewed-on: https://gerrit.libreoffice.org/50038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21New loplugin:nestedunnamedStephan Bergmann1-7/+4
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: https://gerrit.libreoffice.org/50048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21ColorData->Color in sd..svxNoel Grandin3-8/+7
Change-Id: I70de56b6bfb1ea4655ec03510fad92bf6645f64e Reviewed-on: https://gerrit.libreoffice.org/50046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21loplugin:changetoolsgen in svxNoel Grandin104-1190/+1190
and fix the regex in the plugin for matching += operator Change-Id: I26b3e3fac1d4ef3e756cc9431b983b5f27ee76d6 Reviewed-on: https://gerrit.libreoffice.org/50037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20Resolves: rhbz#1546997 'search not found' at 0,0 when window too narrowCaolán McNamara1-25/+17
if the statusbar hadn't got space for the initial label, then it doesn't get set a position, so when later forced visible it draws at 0,0 call Resize on the toolbox to get it to relayout, and while we're at it set the required size of the label so we might have space for it if that text is shorter than the original len allocation Change-Id: I37d20125d8195b2c75e83e9673c82c2011ceda8e Reviewed-on: https://gerrit.libreoffice.org/50041 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-20use VirtualDevice in ImpCreateShadowObjectCloneNoel Grandin1-31/+12
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: Ia284ae33cd7aa982d27cf1188362226f492fa040 Reviewed-on: https://gerrit.libreoffice.org/49963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20svx: fix deadlock in Gallery::GetGalleryInstance()Michael Stahl1-10/+4
Seen in UITest_writer_tests. Use C++11 thread-safe static initialisation here, which should avoid the deadlock that is caused by relying on osl::Mutex::getGlobalMutex(). Thread #1: 2 in osl_acquireMutex(oslMutexImpl*) (pMutex=0x1ad2c70) at sal/osl/unx/mutex.cxx:97 3 in osl::Mutex::acquire() (this=0x7ff3252b9628 <rtl::Static<osl::Mutex, (anonymous namespace)::theImplHelperInitMutex>::get()::instance>) at include/osl/mutex.hxx:56 4 in osl::Guard<osl::Mutex>::Guard(osl::Mutex&) (this=0x7ffca8bdd6c0, t=...) at include/osl/mutex.hxx:129 5 in cppu::getTypeEntries(cppu::class_data*) (cd=0x7ff31e458fe0 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>, com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>::operator()()::s_cd>) at cppuhelper/source/implbase_ex.cxx:89 6 in cppu::queryDeepNoXInterface(typelib_TypeDescriptionReference const*, cppu::class_data*, void*) (pDemandedTDR=0x2e643b0, cd=0x7ff31e458fe0 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>, com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>::operator()()::s_cd>, that=0x387cbe0) at cppuhelper/source/implbase_ex.cxx:173 [...] 20 in utl::UcbStreamHelper::CreateStream(rtl::OUString const&, StreamMode) (rFileName="file://instdir/program/../share/gallery/sounds.thm", eOpenMode=StreamMode::READ) at unotools/source/ucbhelper/ucbstreamhelper.cxx:149 21 in GalleryTheme::CreateThemeEntry(INetURLObject const&, bool) (rURL=..., bReadOnly=false) at svx/source/gallery2/galtheme.cxx:692 22 in Gallery::ImplLoadSubDirs(INetURLObject const&, bool&) (this=0x38762c0, rBaseURL=..., rbDirIsReadOnly=@0x7ffca8bde7df: false) at svx/source/gallery2/gallery1.cxx:474 23 in Gallery::ImplLoad(rtl::OUString const&) (this=0x38762c0, rMultiPath="file://instdir/program/../share/gallery;file://workdir/UITest/writer_tests/user/user/gallery") at svx/source/gallery2/gallery1.cxx:301 24 in Gallery::Gallery(rtl::OUString const&) (this=0x38762c0, rMultiPath="file://instdir/program/../share/gallery;file://workdir/UITest/writer_tests/user/user/gallery") at svx/source/gallery2/gallery1.cxx:257 25 in Gallery::GetGalleryInstance() () at svx/source/gallery2/gallery1.cxx:273 26 in GalleryExplorer::BeginLocking(unsigned int) (nThemeId=3) at svx/source/gallery2/galexpl.cxx:264 27 in SvxBmpNumValueSet::init() (this=0x3873ed0) at svx/source/dialog/svxbmpnumvalueset.cxx:501 Thread #8 Grammar Checking: 2 in osl_acquireMutex(oslMutexImpl*) (pMutex=0x7ff329045420 <globalMutexImpl>) at sal/osl/unx/mutex.cxx:97 3 in osl::Mutex::acquire() (this=0x7ff32903b780 <osl_getGlobalMutex::globalMutex>) at include/osl/mutex.hxx:56 4 in osl::Guard<osl::Mutex>::Guard(osl::Mutex*) (this=0x7ff2f5b30030, pT_=0x7ff32903b780 <osl_getGlobalMutex::globalMutex>) at include/osl/mutex.hxx:122 5 in com::sun::star::container::cppu_detail_getUnoType(com::sun::star::container::XEnumeration const*) () at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/container/XEnumeration.hpp:69 6 in cppu::UnoType<com::sun::star::container::XEnumeration>::get() () at include/cppu/unotype.hxx:296 7 in cppu::detail::cppu_detail_getUnoType<com::sun::star::container::XEnumeration>(com::sun::star::uno::Reference<com::sun::star::container::XEnumeration> const*) () at include/cppu/unotype.hxx:259 8 in cppu::UnoType<com::sun::star::uno::Reference<com::sun::star::container::XEnumeration> >::get() () at include/cppu/unotype.hxx:296 9 in com::sun::star::reflection::detail::theXTypeDescriptionEnumerationType::operator()() const (this=0x7ff2f5b30177) at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/reflection/XTypeDescriptionEnumeration.hpp:30 10 in rtl::StaticWithInit<com::sun::star::uno::Type*, com::sun::star::reflection::detail::theXTypeDescriptionEnumerationType, com::sun::star::reflection::detail::theXTypeDescriptionEnumerationType, com::sun::star::uno::Type*>::get() () at include/rtl/instance.hxx:603 11 in com::sun::star::reflection::cppu_detail_getUnoType(com::sun::star::reflection::XTypeDescriptionEnumeration const*) () at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/reflection/XTypeDescriptionEnumeration.hpp:57 12 in cppu::UnoType<com::sun::star::reflection::XTypeDescriptionEnumeration>::get() () at include/cppu/unotype.hxx:296 13 in com::sun::star::reflection::XTypeDescriptionEnumeration::static_type(void*) () at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/reflection/XTypeDescriptionEnumeration.hpp:102 14 in cppu::getTypeEntries(cppu::class_data*) (cd=0x7ff3252b8ac0 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::reflection::XTypeDescriptionEnumeration>, com::sun::star::reflection::XTypeDescriptionEnumeration>::operator()()::s_cd>) at cppuhelper/source/implbase_ex.cxx:96 Change-Id: I3aa3167ca8989b3d6be053e1c97f3b7a64bfbfb8 Reviewed-on: https://gerrit.libreoffice.org/49986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-20drop Color::SetColor(ColorData) in favour of operator=Noel Grandin1-1/+1
first stage of getting rid of ColorData Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec Reviewed-on: https://gerrit.libreoffice.org/49997 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20use VirtualDevice in XOutBitmap::DetectEdgesNoel Grandin1-15/+11
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: I8cfc67ff48d4b2a4b9fddf3325651e76642252c3 Reviewed-on: https://gerrit.libreoffice.org/49962 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19Related: tdf#114756 fix up similar casesCaolán McNamara1-11/+100
Change-Id: Id67ccaeda6ebff477f5d86617863280766713f24 Reviewed-on: https://gerrit.libreoffice.org/49974 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#6432 bad-castCaolán McNamara2-7/+4
ofz#6433 head-use-after-free ofz#6435 bad-cast Change-Id: Ic43edbab68d96e852039c3247853074180fd5091 Reviewed-on: https://gerrit.libreoffice.org/49984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19tdf#114756: fix connector dropdownJulien Nabet1-1/+9
bt: 0 0x00007fffef4738d3 in SdrEdgeKindItem::GetValueTextByPos(unsigned short) const (this=0x5555587ff770, nPos=0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdattr.cxx:1307 1 0x00007fffba50f71b in SvxConnectionPage::FillTypeLB() (this=0x55555c4d2a90) at /home/julien/lo/libreoffice/cui/source/tabpages/connect.cxx:507 2 0x00007fffba50be46 in SvxConnectionPage::SvxConnectionPage(vcl::Window*, SfxItemSet const&) (this=0x55555c4d2a90, pWindow=0x55555c46cc70, rInAttrs= SfxItemSet of pool 0x555557883790 with parent 0x0 and Which ranges: [(1000, 1234), (4003, 4057)], __in_chrg=<optimized out>, __vtt_parm=<optimized out>) at /home/julien/lo/libreoffice/cui/source/tabpages/connect.cxx:98 See https://bugs.documentfoundation.org/attachment.cgi?id=139972 Change-Id: I24ba9e0140668d666da686e3f8a05587b46e923f Reviewed-on: https://gerrit.libreoffice.org/49924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-19use std::array in createHistorical8x8FromArrayNoel Grandin4-32/+21
to make the assumption about the size of the array obvious in the code. Change-Id: I7ebe0b037e3be38f7e33c0160742f829288bb474 Reviewed-on: https://gerrit.libreoffice.org/49938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19use VirtualDevice in createHistorical8x8FromArrayNoel Grandin2-23/+13
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: I8b3aa2fdd3c26db0e48b228640cd31b0bd31543c Reviewed-on: https://gerrit.libreoffice.org/49937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in SdrTableRTFParserNoel Grandin1-16/+10
Change-Id: I3d0657bcfcb9fca0d7f8c27499c159ddc5ccf47d Reviewed-on: https://gerrit.libreoffice.org/49935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in SvxLineStyleToolBoxControlNoel Grandin1-6/+2
Change-Id: I83e1536a1d45fffbf4fc5ddb611e382568ebf26c Reviewed-on: https://gerrit.libreoffice.org/49934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in FontPrevWin_ImplNoel Grandin1-12/+5
Change-Id: I0919b8e2c58dbe26154e4a7c7c77e8e63f665842 Reviewed-on: https://gerrit.libreoffice.org/49933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in SvxClipBoardControlNoel Grandin1-5/+3
Change-Id: Ib9e3d20680cba684fea8b586a5ca4c5835ca6b42 Reviewed-on: https://gerrit.libreoffice.org/49932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in AccessibleShapeNoel Grandin1-10/+8
Change-Id: I4c91ce6eb47f2802313fed22357e5c960cea50b2 Reviewed-on: https://gerrit.libreoffice.org/49931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in NavigatorTreeModelNoel Grandin2-4/+5
Change-Id: I53e7e4ab0a1533266ce97d5a093a1742808b6215 Reviewed-on: https://gerrit.libreoffice.org/49930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-18uitest: call base class Activate in modeless dialogsMarkus Mohrhard1-0/+2
Change-Id: I342e925a5dbc178962f720f1efc9ee001d235718 Reviewed-on: https://gerrit.libreoffice.org/49941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18tdf#114817 new bitmap presets for Area Fillandreas kainz1-20/+20
Change-Id: Icc48efc2f6c085ccf0754620dc1cbf5132a7f824 Reviewed-on: https://gerrit.libreoffice.org/49551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-02-18in numbering use "GraphicBitmap" property for image transportTomaž Vajngerl1-2/+9
Change-Id: I43abef3fe4a177f9f7867fe86e18beac812c626b Reviewed-on: https://gerrit.libreoffice.org/49923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18remove use of FillBitmapURL and use FillBitmap as the alternativeTomaž Vajngerl1-10/+3
This is under the ongoing work to get rit of all usage of GraphicObject URLs Change-Id: I900e435ac36a4012ec36a2f0c1d909982c82660a Reviewed-on: https://gerrit.libreoffice.org/49895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 22:01:26 +0000