summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2018-05-12make Bitmap/BitmapEx constructors explicitNoel Grandin2-2/+2
and add BitmapEx::operator=(Bitmap const &) Image::Image(Bitmap const &) to lessen the fallout Change-Id: Iff5fab88d167a7be739c370c9933d36c297bc61c Reviewed-on: https://gerrit.libreoffice.org/54162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-11weld SdPhotoAlbumDialogCaolán McNamara1-0/+1
Change-Id: I46cca94bb43e1b1cd9757b22baad9bb3f61bc15d Reviewed-on: https://gerrit.libreoffice.org/54132 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-11tdf#116993 corrected FontWork to use correct SdrModelArmin Le Grand1-8/+29
Had to adapt FontWorkGalleryDialog::insertSelectedFontwork() to use the correct target-SdrModel when cloning the FontWork SdrObject. This is due to FontWorkGalleryDialog being used differently from Calc - it calls SetSdrObjectRef to set an exceptional SdrModel as target which I took as the always to-be-used target SdrModel - due to it's name 'mpDestModel'. Change-Id: Ia4860283082f041711b8c31952fd2c398eeac30e Reviewed-on: https://gerrit.libreoffice.org/54045 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-10weld SdVectorizeDlgCaolán McNamara1-0/+72
Change-Id: I15469be36807bcfca9882d04dd5d55933692abf7 Reviewed-on: https://gerrit.libreoffice.org/54092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10store Color using boost::optional in EditCharAttribFieldNoel Grandin6-17/+12
Change-Id: If4af5991be51cdb035c0bc0fb7668844df703073 Reviewed-on: https://gerrit.libreoffice.org/54022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-09Typos in change 53934heiko tietze1-1/+1
Change-Id: I7d2dd64beb70d44113c3c548ff6e13ff1d766614 Reviewed-on: https://gerrit.libreoffice.org/54017 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-09tdf#116977 Correctly handle copy-construct of SdrTableObjArmin Le Grand5-156/+239
The new central CloneSdrObject in the case of SdrTableObj has to do some more stuff due to the UNO API TableModel in- volved and stuff. This is done in ::operator= now and thus will work uniformly now (multi-select and copy). At the same time there is functionality to clone/copy only a partial Table in Draw/Impress when e.g some Cells are selected. To reflect this code is needed to 'crop' the just cloned SdrTableObj to the current selection. This again was pretty hard due to side-effects in the implementation using a mix of UNO API and SdrModel-stuff. Change-Id: I9816e1caf34e29021d46d6dd9bb935c634f5ba2e Reviewed-on: https://gerrit.libreoffice.org/53975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-09tdf#114006 - New default set of gradient presetsheiko tietze2-26/+18
New set of gradients incl. l10n and ui test Change-Id: Iee303a39ad721b5a4e8b9adb78ee5a82227b84f4 Reviewed-on: https://gerrit.libreoffice.org/53934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-09vcl: get rid of Bitmap{Ex}::Filter() and Animation::Filter()Chris Sherlock1-8/+13
Change-Id: I510d7b286df732712aa9206b0a7c7910af34c83f Reviewed-on: https://gerrit.libreoffice.org/53206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-08Resolves: tdf#117470 reuse parent window of colorwindow...Caolán McNamara1-2/+3
as parent of color selector window Change-Id: Id96c9eed21c4e99b9e48ab44bab862fea9fd380a Reviewed-on: https://gerrit.libreoffice.org/53972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-08loplugin:useuniqueptr in FmGridListenerNoel Grandin3-59/+45
Change-Id: I774aaf10dd9701f40a098280b68557d8b8045b34 Reviewed-on: https://gerrit.libreoffice.org/53884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-08tdf#116977 secured ::Clone methodsArmin Le Grand51-128/+197
Renamed SdrPage::Clone -> SdrPage::CloneSdrPage Renamed SdrObject::Clone -> SdrObject::CloneSdrObject Giving SdrModel is no longer an option, but a must (as reference). This makes future changes more safe by force usage to think about it. Also equals the constructors which already require a target SdrModel. Done the same for ::CloneSdrPage. Change-Id: I06f0129e15140bd8693db27a445037d7e2f7f652 Reviewed-on: https://gerrit.libreoffice.org/53933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-07[API CHANGE] revert and deprecate *BackGraphicURL add *BackGraphicTomaž Vajngerl1-0/+1
*BackGraphicURL include the following properties: - BackGraphicURL - FooterBackGraphicURL - HeaderBackGraphicURL - ParaBackGraphicURL This were removed, but for backwards compatibility this commit adds them back again and depreactes them in the UNO API. The behaviour also changes as internal vnd.sun.star.GraphicObject scheme URLs aren't supported so this properties can only be set and only if a external URL is provided. If getting such a property then a RuntimeException will be thrown. [ Miklos Vajna: fixed up sw/qa and writerfilter bits. ] Change-Id: If60011837da96197b576bfe2671ecafccad736c7 Reviewed-on: https://gerrit.libreoffice.org/53511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-07loplugin:useuniqueptr in FmXGridPeerNoel Grandin1-14/+8
Change-Id: I05d6fd36bb92e88016ac9cb062c4443ec8796b97 Reviewed-on: https://gerrit.libreoffice.org/53882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in FmGridControlNoel Grandin2-24/+22
Change-Id: I2fc39692bfb42bfff667908d73b3074d5cc04a28 Reviewed-on: https://gerrit.libreoffice.org/53881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SvxTextEditSourceImplNoel Grandin1-38/+19
Change-Id: I69b3fcbdb8a41ed227acdc65232ca013e63bc82d Reviewed-on: https://gerrit.libreoffice.org/53880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SvxTableControllerNoel Grandin1-3/+2
Change-Id: I505f0fe1626e6b935c4194cceaa0f4d0f8756656 Reviewed-on: https://gerrit.libreoffice.org/53879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-07loplugin:useuniqueptr in SdrObjEditViewNoel Grandin1-20/+17
Change-Id: Ie980c0f50483235663e9560fbcf61cf284663228 Reviewed-on: https://gerrit.libreoffice.org/53878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-06coverity#1435443 Arguments in wrong orderCaolán McNamara1-4/+4
and coverity#1435439 Arguments in wrong order coverity#1435437 Arguments in wrong order Change-Id: I8dc4166640613ce25c9d01624d607568e42edac9 Reviewed-on: https://gerrit.libreoffice.org/53915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-05Fix typosAndrea Gelmini1-1/+1
Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: https://gerrit.libreoffice.org/53638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-05loplugin:useuniqueptr in DbGridControlNoel Grandin1-7/+3
Change-Id: Ia5b1181ae58ce69871a66f58080435f8511cc815 Reviewed-on: https://gerrit.libreoffice.org/53883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-04tdf#116879 Separate SdrObjList::Clear() as neededArmin Le Grand3-38/+51
SdrObjList::Clear() does broadcast the SdrObject removals and deletions and a SetChanged() to SdrModel. The old version avoided this in the destructor (with a comment to not call virtual methods in destructor, but the problem is more that the ::Notify triggered works on the SdrPage already in destruction). To allow calls to Clear() without broadcasting I splitted this to a impClearSdrObjList(bool bBrodacast) and rename of ::Clear to ::ClearSdrObjList to get all places. Adapted all places in the code as needed, already pre- checked on Linux that this fixes the problem. Change-Id: Iea46758fb6b57f2b3d9896959a35260c6f6d52d5 Reviewed-on: https://gerrit.libreoffice.org/53839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-03support native focus for drawing sub regionCaolán McNamara1-5/+8
Change-Id: I9862f060b9d5b2c3015c084060887f2d66f1ed01 Reviewed-on: https://gerrit.libreoffice.org/53768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-03weld SvxTextAttrPageCaolán McNamara5-25/+1270
with a a11y rework to be more like the insert special char a11y also, route a11y questions about a custom widgets parent to the gtk toolkits underlying default implementation, keeping only questions about ourself to be handled by the XAccessible focus rectangles in RectCtl work again, seems that got lost somewhere along the way Change-Id: I62237d45668f4438aec6031cc5a48c38de21bf98 Reviewed-on: https://gerrit.libreoffice.org/53767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-03loplugin:useuniqueptr in SdrMarkListNoel Grandin1-30/+15
Change-Id: I36e7af3b1b74a78103c079da58ae1a820b164720 Reviewed-on: https://gerrit.libreoffice.org/53753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03[API CHANGE] revert and deprecate GraphicURL, modify Graphic prop.Tomaž Vajngerl1-0/+22
Revert the state of GraphicURL property so it supports setting a external URL, but getting throws and exception. Modify the Graphic property, so it reflects what was used with GraphicURL before. Change-Id: Ia05b8ea37997b5ed8c75215557cce9979630c898 Reviewed-on: https://gerrit.libreoffice.org/53509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-03tdf#117171 support localized number name numbering stylesLászló Németh1-0/+3
in page number, chapter and outline numbering in ~30 languages by integrating libnumbertext library. - offapi: add linguistic2::NumberText New NumberingType constants: - ordinal indicators (1st, 2nd, 3rd...) - cardinal number names (One, Two, Three...) - ordinal number names (First, Second, Third...) Note: these numberings are parts of OOXML, too. Plain text files of Libnumbertext's language data are installed in share/numbertext (similar to share/fingerprint), allowing further customization. Change-Id: I4034da0a40a8c926f14a3f591749a89a8d807d5a Reviewed-on: https://gerrit.libreoffice.org/53313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-05-03loplugin:useuniqueptr in sdr::table::CellNoel Grandin3-12/+6
Change-Id: Iede820e3e6f3c6d079bab5d7addc1f587ec78104 Reviewed-on: https://gerrit.libreoffice.org/53758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03loplugin:useuniqueptr in SdrItemBrowserControlNoel Grandin2-6/+5
Change-Id: I9da160c4d20109ef539e1877968044a168b3e7e2 Reviewed-on: https://gerrit.libreoffice.org/53757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03loplugin:useuniqueptr in SdrTableObjImplNoel Grandin1-18/+6
Change-Id: Ic59384aef628ff2d34a735ce9b10d38a5e2a8b11 Reviewed-on: https://gerrit.libreoffice.org/53756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03loplugin:useuniqueptr in SdrPaintViewNoel Grandin1-8/+5
Change-Id: I10c9db25dfb0cce7d0815cdc8aff290b3d0c0026 Reviewed-on: https://gerrit.libreoffice.org/53755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03loplugin:useuniqueptr in SdrPageNoel Grandin1-3/+2
Change-Id: Ie3a471e67b7596c967a38b26c250f82f16b80e61 Reviewed-on: https://gerrit.libreoffice.org/53754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03loplugin:useuniqueptr in SdrDragMethodNoel Grandin1-34/+24
Change-Id: I73411368b55d53e83f45e0347663036f1f72c066 Reviewed-on: https://gerrit.libreoffice.org/53752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03loplugin:useuniqueptr in SdrCreateViewNoel Grandin1-7/+2
Change-Id: I41f3441593afa1884d5e8cda4126e97b545fd0a8 Reviewed-on: https://gerrit.libreoffice.org/53750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-03tdf#117145 Cleanup MapMode handling between SdrModel/UNO APIArmin Le Grand9-305/+109
In current versions MapMode handling is done in ::TRSet/Get- BaseGeometry methods. These belong to SdrModel level and should not do any MapMode conversions (else all geometry and Rectangle setters/getters should have to do these, too). Instead, the UNO API implementation should do these, there are already some done there and this is the level which offers pure 100ThMM handling to the caller, independent from the used application. Change-Id: I3d7781440fc0fc6a20b5d4e79c747c988677483d Reviewed-on: https://gerrit.libreoffice.org/53748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-02return std::unique_ptr from SdrMakeOutlinerNoel Grandin8-18/+17
and some of its callers Change-Id: I121a7810e3e35e76da4ffe5fc5405a7bf86cb66d Reviewed-on: https://gerrit.libreoffice.org/53728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02tdf#117205 impress crash when moving an item in a listNoel Grandin1-5/+6
regression from commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 (patch) dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I0db104fcde91597dc71b6cae6c547a0cedac4af2 Reviewed-on: https://gerrit.libreoffice.org/53721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in SdrPaintWindowNoel Grandin1-6/+2
Change-Id: Ia5a57913b607c0c055a525094ac03c5c3022abb4 Reviewed-on: https://gerrit.libreoffice.org/53713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in E3dViewNoel Grandin1-6/+2
Change-Id: I2945d810a05f0f9d44ac17c20f5a82e05bd4981e Reviewed-on: https://gerrit.libreoffice.org/53712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in GalleryTransferableNoel Grandin1-9/+6
Change-Id: Iad9ca26bb94fb1d499d3ce028b2289c11c1771fa Reviewed-on: https://gerrit.libreoffice.org/53711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in GalleryBrowser1Noel Grandin2-8/+6
Change-Id: I0b95beed2c056e10cb40d09bf1040143778724ca Reviewed-on: https://gerrit.libreoffice.org/53710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in E3dSceneNoel Grandin1-6/+2
Change-Id: Ia2de7248406b47539ff40d81491ec1541c0c7bcd Reviewed-on: https://gerrit.libreoffice.org/53709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in SvxCheckListBoxNoel Grandin1-3/+3
Change-Id: Ib867d42363a500ea5acfc0998dd33657d3a701c3 Reviewed-on: https://gerrit.libreoffice.org/53708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02Fix typosAndrea Gelmini1-1/+1
Change-Id: I56bd1a7ac204f4302261e46d0b8c5dd62c4b6df9 Reviewed-on: https://gerrit.libreoffice.org/53624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-30icon-themes: rename pngs with spaces in them since they cause various problemsRene Engelhard1-2/+2
Change-Id: I30c34b9d1c80c339f359abd7e80f6fa0bcc37537 Reviewed-on: https://gerrit.libreoffice.org/53646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2018-04-30weld SmSymbolDialogCaolán McNamara1-1/+1
Change-Id: I163a309fdf79e3eeadeb15b2a1c042666def339f Reviewed-on: https://gerrit.libreoffice.org/53633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-29weld SwEndNoteOptionPageCaolán McNamara1-1/+1
Change-Id: I2313352a66b088a4198ac8a96d2fd218bb2176fd Reviewed-on: https://gerrit.libreoffice.org/53608 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-29cppcheck: knownConditionTrueFalseJochen Nitschke1-13/+10
Change-Id: I1b524568b0c014be381c971cd4152ac3f00db13c Reviewed-on: https://gerrit.libreoffice.org/53622 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-27loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: I360ed9c98a42026f6f3894e93f89be39080af6b5 Reviewed-on: https://gerrit.libreoffice.org/53542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-27restore and deprecate FillBitmapURLTomaž Vajngerl1-6/+31
FillBitmapURL was restored so when setting the property, it loads the Bitmap from the provided URL and creates a XBitmap. Get is not supported anymore however. Change-Id: Ie250d9f751ba33fc45b759dd3a773b4ec5c864d3 Reviewed-on: https://gerrit.libreoffice.org/53443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>