summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2023-08-28svx: fix buildMichael Stahl1-0/+1
Change-Id: I900db1675c110568bc33e4e21babae55a941a626
2023-08-24Reset buffered GridOffset(s) for suspicious valuesArmin Le Grand (allotropia)1-3/+32
Huge offsets of GridOffset(s) are a hint for error -> usually the conditions for calculation have changed. E.g. - I saw errors with +/-5740, that was in the environment of massive external UNO API using LO as target. If condtions for this calculation change, it is usually required to call - ViewObjectContact::resetGridOffset(), or - ObjectContact::resetAllGridOffsets() or - ScDrawView::resetGridOffsetsForAllSdrPageViews() as it is done e.g. when zoom changes (see ScDrawView::RecalcScale()). Theoretically these resets have to be done for any precondition changed that is used in the calculation of that value (see ScDrawView::calculateGridOffsetForSdrObject). This is not complete and would be hard to do so. Since it is just a buffered value and re-calculation is not expensive (linear O(n)) we can just reset suspicious values here what fixes the problem. Hopefully - when that non-linear ViewTransformation problem for the calc-view gets solved one day - all this can be removed again. For now, let's just reset here and force re-calculation. Added a SAL_WARN to inform about this, too. Change-Id: I09137f7703fd00c2351a288a40bf87a2691ba6e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155983 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-06-26svx: replace FPDFTextObj_GetFontNameMichael Stahl1-2/+2
Change-Id: Ib4e11f8aeee932160862d1b9a2b56068a90e9895
2023-05-02put floating frames under managed links controlCaolán McNamara3-21/+111
like we do for sections and ole objects that link to their content individual commits in trunk are: extract a OCommonEmbeddedObject::SetInplaceActiveState for reuse no behaviour change intended Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150341 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 183e34a3f8c429c0698951e24c17844e416a3825) use parent window as dialog parent it makes no odds, but is more convenient for upcoming modification Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f93edf343658abd489bde3639d2ffaefd50c0f99) adjust IFrameObject so it could reuse mxFrame for a reload of content Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150343 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3a727d26fd9eb6fa140bc3f5cadf3db079d42206) query getUserAllowsLinkUpdate for the case of content in a floating frame similarly to how it works for the more common "normal" embedded objects Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 52aa46468531918eabfa2031dedf50377ae72cf7) add a route to get writer Floating Frame links under 'manage links' Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8b8a2844addbd262befb1a2d193dfb590dfa20be) allow SvxOle2Shape::resetModifiedState to survive having no SdrObject Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 02379929bd0e1d1676635f0ca1920422702ebb7c) create the FloatingFrameShape in a separate step to inserting it this is derived from the path taken by the AddShape(const OUString&) function for this case. No change in behavior is intended. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bafec47847a0b9697b3bbe9358e53f8118af3024) add a route to get calc Floating Frame links under 'manage links' much harder than writer because the organization and ordering of properties and object activation etc is different. This ended up ugly, but functions. We set FrameURL before AddShape, we have to do it again later because it gets cleared when the SdrOle2Obj is attached to the XShape. But we want FrameURL to exist when AddShape triggers SetPersistName which itself triggers SdrOle2Obj::CheckFileLink_Impl and at that point we want to know what URL will end up being used. So bodge this by setting FrameURL to the temp pre-SdrOle2Obj attached properties and we can smuggle it eventually into SdrOle2Obj::SetPersistName at the right point after PersistName is set but before SdrOle2Obj::CheckFileLink_Impl is called in order to inform the link manager that this is an IFrame that links to a URL Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 07179a5a5bd00f34acfa8a3f260dd834ae003c63) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150755 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit b91ea614c0b753ab3d378acd0e2db8262e9dbd72) bc5333b137d2da089b3b701ff615c6ddf43063d0 7eec3132a23faafd9a2878215a0a117a67bc9bf2 83e38dfa2f84907c2de9680e91f779d34864a9ad f90ff71d6a96342574799312f764badaf97980eb ea059262c124e3f44249e49b4189732310d28156 d09ae0c65a55a37743ad7c184070fb8dd97d8a7f 67fc199fef9e67fa12ca7873f0fe12137aa16d8f Change-Id: Ia1d12aa5c9afdc1347f6d4364bc6a0b7f41ee168
2023-05-02loplugin:flatten in svx/svdraw [svx/source/svdraw/svdoole2.cxx]Noel Grandin1-310/+310
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit bfc298d02ca6275588d5897d97ced9498a3e91aa) Change-Id: I8379e5ebaee2090d2b4dbd05d55b55000915cd7c
2023-04-11tdf#153880 sc: Make Calc text hyperlinks stand out moreBalazs Varga7-13/+24
Add underlining for links in Calc. TODO: unit test Change-Id: Idd5a7de7464d8ce443cdec756ac803491e73b0ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149913 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150162 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-09-09Update product URLsThorsten Behrens1-1/+1
Change-Id: Ie12bf07849451445ff99a64c07fc05f01860dda8
2022-08-19[CIBO] Update product URLsThorsten Behrens1-1/+1
Change-Id: I4e72c4ba69648a30d5debf13af4276071bde5729
2022-06-20Fix domainSamuel Mehrbrodt1-1/+1
Change-Id: Ic8b21b649ba539d86a2802ddd4f2aaf670d0719b
2022-05-31include memory for GCC12Michael Stahl1-0/+1
Change-Id: Idd92510b66f63b68faa8a8d4fef01a18874e9905
2022-02-17tdf#41995: sxx: ODF export: save SVG to ODF 1.2 as wellMichael Stahl1-1/+2
... and SVM into ODF 1.2 Extended (compatibility mode). Change-Id: I2056ddac40570fdf69178349ff546cd313709b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94575 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit d407019a69773156b0bb9ef0b4a775f67830949e)
2022-02-01Cleanup after fcd156bd3a0e393ad3a546b8d3c16dcca832e2edSamuel Mehrbrodt1-4/+1
Change-Id: Ib5c27024e2e4df654c3907ed3ef8ecb101682e64
2022-02-01Fix support linksSamuel Mehrbrodt1-1/+1
Change-Id: I000a8be2915005587e9e9d40f0da5d6834ef99f0
2022-01-07Adapt crash submitted dialogSamuel Mehrbrodt3-24/+1
Don't link to crashreport site, just show the ID Change-Id: I436b4503657ca42afb98ca5efb5a7f306b102df8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126539 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-11-17external: update pdfium to 4643Miklos Vajna1-1/+2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122485 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 8cecaa622700cecb5b5776bd3e5360ac6cc3dd63) Change-Id: I4e86b163a9abef88f26c6c0ae91ae0a4008658f1
2021-11-17external: update pdfium to 4568Miklos Vajna1-4/+5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118868 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 7707339a7d10225ff2503a852f68427519ae26f6) Change-Id: I2bfd5f806281e747702d423b7e59b5f88a7bea9c
2021-04-25Related tdf#139804 Allow activating btn on first clickSamuel Mehrbrodt1-0/+1
Change-Id: I3bcdf8bdd6f25fd30106214f40e72bf1506f6bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114398 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114437 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-04-25cid#1474166 Deference null return valueCaolán McNamara1-16/+18
Change-Id: I725eff105f963b139ae8646cd1cb193ce737d313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112760 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 229558c0bf257e4e559cc1b84bd2918b04c68305) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114367 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-04-25Remove .uno:QuestionAnswers, direct safeMode help to landing pageThorsten Behrens1-2/+5
Change-Id: I41a456b838508a7904a81ff858de6dada0ed6824
2021-03-16tdf#139804 Focus form controls inside document with Alt-<Mnemonic>Samuel Mehrbrodt1-0/+28
Change-Id: I710a23a53ca0eb256a477a78ce1b7ae01129f717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 67ad205404211a2ae17c430a17ede6e9d04d0b7e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112501 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2020-09-10external: update pdfium from 3963 to 4137Miklos Vajna1-10/+11
This is a combination of 6 commits, which brings pdfium to the same version as libreoffice-7-0. This is the 1st commit message: external: update pdfium to 4021 (cherry picked from commit 1cb70721ba00dd6c6958f0a10e39aa5c1866ec96) This is the commit message #2: external/pdfium: C++20 comparison operator fix Missing const leads to overload resolution ambiguity when a synthesized candidate of operator == for a reversed-argument rewrite conflicts with the actual operator ==, due to the asymmetric const-ness of the implicit object parameter and the RHS parameter: > In file included from workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.cpp:7: > In file included from workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.h:11: > llvm/inst/include/c++/v1/vector:1369:27: error: use of overloaded operator '!=' is ambiguous (with operand types 'std::__1::__vector_base<unsigned char, FxAllocAllocator<unsigned char> >::allocator_type' (aka 'FxAllocAllocator<unsigned char>') and 'std::__1::__vector_base<unsigned char, FxAllocAllocator<unsigned char> >::allocator_type') > if (__base::__alloc() != __c.__alloc()) > ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ > llvm/inst/include/c++/v1/vector:1359:5: note: in instantiation of member function 'std::__1::vector<unsigned char, FxAllocAllocator<unsigned char> >::__move_assign' requested here > __move_assign(__x, integral_constant<bool, > ^ > workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.cpp:384:24: note: in instantiation of member function 'std::__1::vector<unsigned char, FxAllocAllocator<unsigned char> >::operator=' requested here > m_FontDataAllocation = std::vector<uint8_t, FxAllocAllocator<uint8_t>>( > ^ > workdir/UnpackedTarball/pdfium/core/fxcrt/fx_memory_wrappers.h:74:8: note: candidate function > bool operator!=(const FxAllocAllocator& that) { return false; } > ^ > workdir/UnpackedTarball/pdfium/core/fxcrt/fx_memory_wrappers.h:73:8: note: candidate function > bool operator==(const FxAllocAllocator& that) { return true; } > ^ > workdir/UnpackedTarball/pdfium/core/fxcrt/fx_memory_wrappers.h:73:8: note: candidate function (with reversed parameter order) (cherry picked from commit 6e0461d576d9f386e458f98f3c57f0ba385aacb4) This is the commit message #3: pdfium: don't patch out the COMPONENT_BUILD check, define it So next time we update, no need to adapt a failing patch. (cherry picked from commit 9b4ab9bda41a818832c721933986c9c6e07a6e6c) This is the commit message #4: make update_pch also consider files in <module>/src/**/inc With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. [ Just the pdfium part. ] (cherry picked from commit 69e0d871ec1de2260f9213d3113464155eac173c) Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a This is the commit message #5: external: update pdfium to 4083 (cherry picked from commit 9054c36d4ea3bee25fb9a47a96a0ea2cd07148c3) This is the commit message #6: external: update pdfium to 4137 (cherry picked from commit 1ffe59ef31186e36ad0aa7bbcdd32e407ee8d26c) Change-Id: Ib7c12461e04fa97bf55ee967e8d6c9bcf92fdf4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-09pdfium: only init pdfium library once and destroy on LO exitTomaž Vajngerl2-12/+6
With more and more usage of PDFium, it is hard to keep track of the life-time of the PDFium library, so it can happen that a FPDF_DestroyLibrary happens when we still have another instance where PDFium is still use. The result of this is a crash. To prevent this, just initialize the library once and delete, when on LO exit. This can be improved in the future to only keep the library active when in actual use. [ Leaving out the vector graphic search bits, the motivation is to just have this in libreoffice-7-0, so that recent pdf sig verify improvements can be backported. ] (cherry picked from commit 067a8a954c8e1d8d6465a4ab5fb61e93f16c26c2) Conflicts: vcl/source/graphic/VectorGraphicSearch.cxx Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102317 Tested-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-05Resolves: tdf#136189 don't try and sort until treeview is filledCaolán McNamara1-1/+3
Change-Id: Ic5ac71d88bab7627e14220912f4b9c935f2f1f26 and... Related: tdf#136189 don't assert on unsetting non-existing previous sort column Change-Id: If2330cc83ace9ec0133b99eec8c2f0be3919013e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101710 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit c52ac477beefc46802148033adbca9edb9970ac1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101967 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-10tdf#60684: graphic type content must correspond with graphic type extensionJulien Nabet1-1/+4
Change-Id: I8075b1b44aa400268b4022decb2a56770c81d83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 7272a2edf113f29edeb8987ce649f85b776d9d23) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98456 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-09tdf#126025: Non-const GetPropertyValueByName must use non-const Sequence []Stephan Bergmann1-1/+1
...which internally calls getArray to make sure it references a unique sequence. Regression introduced with 85f28ec44a2c169c91dac9346e9c71feda6a6cab "Clean up C- style casts from pointers to void". Change-Id: Id80b75f06322c65fc31040cc0b1892fe3a0aeaab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit b505cd8635171e39d055b9a800f672a6313d8cea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95873 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-01Resolves: tdf#133411 drop CONTENT_FLOWS_TO from dialog to search resultsCaolán McNamara1-57/+0
in the document, looks like only the calc one actually works, and when it works on large quantities of results calc grinds to a complete halt This was introduced with: commit b41332475783c31136673fb44cf4c411bb0148f8 Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 and has been a problem on and off with calc's potentially ~infinite grid There is the on-by-default search results dialog in calc (which has a limit on how many it shows) which provides an alternative route to iterate through the results Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0b94169d820482434dc98a37c3c1633ca46fd0dc) Change-Id: I2685e480d2d15220be0bddbc83baad3992e7d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95014 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-05-19tdf#132169 we always get the value in MapUnit::Map100thMMCaolán McNamara2-10/+16
but must set it in the core metric of the target application since... commit f7c751439d4616f43509301d71af92b13b576a84 Date: Thu Nov 7 15:53:49 2019 +0100 jsdialog: consume .uno:LineWidth double value added parameters for online, but with parameters its no longer considered a simple slot and for non-simple slots the auto-conversion of values to/from twips isn't done. there's probably a much and older deeper bug here, but lets get this known broken line width working Change-Id: I8683431f02d2d14936411d35ba070944b9b80e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94203 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-19tdf#132730: fix assertion on groupJulien Nabet1-2/+15
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=160397 Implement GroupProperties::ClearObjectItem Change-Id: I967f8bda6e4a4edaccdb4a0bd2150bb2af2c1316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93512 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit c7709eb11cddc37883d1a2391a1dd83f03f5cfa3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94271 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-12use the LinkManager persist to determine the RefererCaolán McNamara1-1/+8
Change-Id: I4e93878972492a93af368ffa0560412132431a24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94061 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-08tdf#131956 dispose progressbar when its target is destroyedCaolán McNamara1-0/+6
Change-Id: Id54ac3a0ebfd360e4107583af7fb978aa69d3288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93533 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-16Resolves: tdf#122491 ClassificationDialog::run() is not calledCaolán McNamara1-23/+21
when using DialogController::runAsync so the custom override isn't called so the special setup and save-on-ok aren't called. move the setup into the ctor seeing as the dialog is only run once after ctoring and add a OK handling that does the on-ok setting save and have setupValues call readIn on "m_aInitialValues" because that gets called after the ctor Change-Id: I8183fc4b0f5de2844562c971c86d655f2d4920ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92288 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-04-06rhbz#1820868 deref of null xLayoutManagerCaolán McNamara1-0/+2
Change-Id: Ib396ef9f5b019b08a181eeb5a8eb983bdb401db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91710 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-17tdf#131337: fix range for "Surface angle" (tab "Shading" in "3D Effects")Julien Nabet1-2/+2
Should be to 90° max instead of 1000° Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=11d0c28601dc89c48e67a7b39ba82dd52e660334 author Caolán McNamara <caolanm@redhat.com> 2014-12-28 16:30:18 +0000 committer Caolán McNamara <caolanm@redhat.com> 2014-12-30 15:43:39 +0000 commit 11d0c28601dc89c48e67a7b39ba82dd52e660334 (patch) tree 75e0e9d83694637de1e3b95a25c66de911d381bc parent 04299dba24d04b08d54f4f5945d340d7abfa73e4 (diff) convert RID_SVXFLOAT_3D docking window to .ui This is an epic dialog with lots of moving parts Change-Id: I867723f65273bf46b0693910d88e11a9197384c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90397 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-17tdf#125520 create a persist correctly for OLEArmin Le Grand1-1/+11
If the D&D-Start described as in the task is an OLE object we need to create a Persist-object to copy the included EmbeddedObjectContainer Change-Id: Ib8b9677bbc3e6c5b3895abc55e6da5b0a96e33d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90263 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90336
2020-03-11tdf#131088 Automatic Control Focus not workingNoel Grandin1-1/+1
regression from commit a361231b1363d072d737e9b1d411b71aa9550d84 Date: Fri May 10 10:13:12 2019 +0200 fix wrong SET/QUERY flags passed to uno::Reference Change-Id: Id0dd46c3d40f8acab980147c4c7f64911bc30d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 17c467a66d799bda88d6cdb84b7fecbbd7d1fdf5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90276
2020-02-26tdf#130483 prevent pasting cell exceeds the border.Mark Hung1-5/+15
When pasting a table onto another selected table, cells are cloned from source to target including their column span and row span. In the test case the target table can accomodate the first cell of the merged cells, while the rest go over the table boundary, hence causing some exception later. Change-Id: Iae78a9e1689571d4ea2f1ac4853f68c1f7dccb9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88737 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 5f90c8bc0270f692a38073b1e4aa9e3b6ba106ed) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89442 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-15tdf#130373 substitute color only works if left set to transparent.Noel Grandin1-0/+4
regression from commit e27be9dfbcf8636a7440f828435b1860dfa38977 Date: Wed Jul 3 15:07:44 2019 +0200 move some Bitmap replace logic inside vcl Change-Id: I0d985314367e26134c940e54f485db373d4c3642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 407c45d54c189d5e9488e868e503f02955825b82) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88696 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-13tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'"Xisco Faulí1-11/+2
This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371. Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 09e6824bc868990095233825c415556399dd0652) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88500 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-07tdf#119191 Implement SdrObjCustomShape::AdjustToMaxRectRegina Henschel1-0/+66
and use in ScDrawLayer::RecalcPos and in ScDrawView::FitToCellSize(). Error was, that it was assumed, that SdObjCustomShape::SetSnapRect() changes the shape so, that it fits into the passed rectangle. That is true for other type of shapes, but not for custom shapes. Change-Id: Ib00d52087509f459165000abf43c7f244980a01b Reviewed-on: https://gerrit.libreoffice.org/84216 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit f44140bebb9c493d97ba5aef26c9692c53a6b93f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85043 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-04gtk: resizing video elements has no effect once the video has played onceCaolán McNamara1-1/+19
Change-Id: Ice8e688a7909bcfffc477479110a69e4770996d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87697 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-12Resolves: tdf#129763 resize to request happening on every activateCaolán McNamara1-5/+8
even though the state remains the same, so only do the resize if the EnableClearFormatButton[All] state changes. also change the default to off, which is what writer typically set it to, and make calc the one that enables it explicitly. Its easier to grow a dialog than shrink a dialog. Change-Id: I449df7b7dcf0204b5143b8ad88e528668b84d0a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86614 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-09tdf#129887: fix crash during scrolling down documentSerge Krot1-1/+1
regression from tdf#129708 Change-Id: I6c5d7eb90030234e899ab8ce5b3adec33e03962a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86454 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit a3c3f21a742f7c7f587bd63ee2617a150bb39b96) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86460 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-07tdf#129708 speed-up: check if we could create outline instead of creation of itSerge Krot8-38/+33
Change-Id: I0629b4e6ccae4ab9be0142fe39c627f2f9a8f5ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86199 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 92ccf53b2a8102299ac2c3e2612bb507d3a79c0f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86278
2019-12-21tdf#127481: reset active cell reference during table copyStepas Toliautas1-0/+3
During cloning of 1x1 table, SdrTableObjImpl.mxActiveCell reference is set incorrectly, keeping an address of a temporary cell. I clear that reference so it gets assigned to a cell of a new table on first request. An alternative is to find the position of an active cell in source table and set it to a corresponding cell in cloned table (after call to new TableModel()), but I have no opinion on whether newly-cloned table should have active cell marker, and the assignment seems to work in some other fashion for multi-cell tables. So I just zero-init temp object, which should be done anyway. Change-Id: I965b7afbfedf2e57262d3388be1d045687521eee Reviewed-on: https://gerrit.libreoffice.org/85275 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit f6a4b8ca7f79126569db14b030b46733309dbda6) Reviewed-on: https://gerrit.libreoffice.org/85503 Reviewed-by: Stepas Toliautas <stepas.toliautas@gmail.com>
2019-12-20tdf#122280: Hide Block selection mode from CalcAditya1-0/+13
Currently, the Block Selection Mode in pop-up menu is dysfunctional in Calc. It is unreachable - when the user tries to choose "Block selection" from the pop-up menu that lies in the status bar, it shifts back to "Standard selection". Hide the Block Selection mode from Calc, simply because it is dysfunctional and useless. Change-Id: Ib8618b7f0281de13a5f6ef9d35b67330f43c4318 Reviewed-on: https://gerrit.libreoffice.org/84142 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1e94d803f7a70027d03f1303c19818ca2de0d67f) Reviewed-on: https://gerrit.libreoffice.org/85629
2019-12-16tdf#127481 don't override SdrText::GetItemSet() for cellsThorsten Behrens2-7/+0
No point in overriding GetItemSet() with behaviour similar to parent class (but less robustly so). Change-Id: I2bdff44bfded0a5fa272964b4e0671cacb125f06 Reviewed-on: https://gerrit.libreoffice.org/85148 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 4ddd76a7324c8b035e60a12ac06cf08339f6e366) Reviewed-on: https://gerrit.libreoffice.org/85210 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-12tdf#111922 Fix Position&Size sidebar Height/Width order of magnitudeGabor Kelemen1-6/+6
Change-Id: Ib279199cdca58911b989a146d60ce764742e5008 Reviewed-on: https://gerrit.libreoffice.org/83843 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit a573829438bf4a3dc43e8774bfe4e29989e2e352) Reviewed-on: https://gerrit.libreoffice.org/83980 Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-11tdf#129321 add specific ids for header/footer pagesCaolán McNamara1-0/+2
Change-Id: I8ca6a0067d714b802c1923a7cbc5403d5087a169 Reviewed-on: https://gerrit.libreoffice.org/84944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Resolves: tdf#129250 move redline type into RedlinData so we can sort on itCaolán McNamara1-3/+20
Change-Id: Ia8e6744c1679655240a9a9cee9425030e994e16b Reviewed-on: https://gerrit.libreoffice.org/84806 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-11Related: tdf#129267 change spacing unit when measurement unit changesCaolán McNamara1-1/+6
Change-Id: I2407eb52a18dd06a51b49041df2035099c79c94a Reviewed-on: https://gerrit.libreoffice.org/84788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fc280552a5ee0131a08aeea5ccfd8cb7b9a6225d) Reviewed-on: https://gerrit.libreoffice.org/84791 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 20:36:50 +0000