summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2018-01-17Fix typosAndrea Gelmini2-4/+4
Change-Id: Id1c7ddf6c49ec709e38947a82731fe31a64aad04 Reviewed-on: https://gerrit.libreoffice.org/48076 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17loplugin:unnecessaryparen extend to delete statementsNoel Grandin5-6/+6
Change-Id: Ic4383ea948876a26f791f0e5b0110cef978a26e1 Reviewed-on: https://gerrit.libreoffice.org/48027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-17tdf#114935 Move the focus back to the documentMaxim Monastirsky1-1/+6
... after selecting a color from a floating picker, similar to what we do for the font name/size toolbar controls. But moving the focus didn't work properly under gtk2, as it was cycling the focus between the floater and the main window with each click. The cause for this was the GrabFocus call made by ValueSet/PushButton upon clicking, which resulted in a XSetInputFocus in GtkSalFrame::ToTop. But removing this XSetInputFocus would break keyboard handling inside floating windows (as in tdf#104368), given that GtkSalFrame::Init sets the input hint to false. Setting the input hint to false is a hack needed for some WMs to not steal the focus from the main window, when showing floating toolbars. This mostly affects Compiz and Metacity (and its forks Marco and Muffin, but fixed in recent Mutter - see gnome#773210). Other WMs nowadays seems to deduce the desired no-focus initial state, from the toolbar window type hint. According to wm-spec, one way to make a newly mapped window not steal the focus is to set 0 to _NET_WM_USER_TIME (and this method is indeed used by gtk). This helps for Compiz (w/o messing with the input hint), but not for Metacity, which will anyway unfocus the parent window. The only solution that seems to work so far, is to start with the input hint as false, and change it to true after the window is mapped. And do this craziness only for Metacity and its forks, just in case... (although I didn't actually notice any problems with this in place, under other WMs.) (I also considered fixing tdf#114935 by making ValueSet/ PushButton not grab the focus on click, by setting WB_NOPOINTERFOCUS on them. But that will be just a partial solution, as e.g. if a user selects a different palette from the palettes list, the focus will stuck in that list.) Change-Id: Id8241bc809c445ff4e46f1a747b9af5ed57e5a1c Reviewed-on: https://gerrit.libreoffice.org/47690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-16Fix typosAndrea Gelmini3-3/+3
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16don't bother hyphenating while fuzzingCaolán McNamara1-7/+11
Change-Id: I6b590998ed68d11681063b0c0f4655f501735794 Reviewed-on: https://gerrit.libreoffice.org/47919 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-15More loplugin:cstylecast: svxStephan Bergmann53-159/+158
Change-Id: If370ad12d2885ea9a6348736a3bcab618bc2e6ec
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin3-6/+6
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14Fix typosAndrea Gelmini1-1/+1
Change-Id: I2b4988e1d81fe60f7699362480cd739d2620c053 Reviewed-on: https://gerrit.libreoffice.org/47856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-14xmloff: XmlImageStyle class is pointless as the methods are staticTomaž Vajngerl1-1/+0
When used, we instantiate the XmlImageStyle class but all its methods are static, so instantioation is completely pointless. So change XmlImageStyle to a namespace and static method to functions. Change-Id: I6385bd7eeb08c627cb8e48b79a6820372cf94a65 Reviewed-on: https://gerrit.libreoffice.org/47851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-13tdf#114901 TSCP various advanced TSCP dialog changesTomaž Vajngerl2-108/+92
- rename "Part" to "License" - change Markings from Combo to List box - minimize whitespace - move bold and sign paragraph under text area as it is fixed - remove bold in paragraph dialog Change-Id: I7ec20460d02d3611a1da325eb7d3de3aef10f03f Reviewed-on: https://gerrit.libreoffice.org/47632 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-13loplugin:useuniqueptr in PolyPolygonNoel Grandin1-1/+1
Also - convert to o3tl::cow_wrapper - drop the second param to the constructor and just let vector use it's own resize logic - bump MAX_POLYGONS from 0x3FF0 to 0xffff so that the ios2met filter can load it's files properly. Change-Id: I9db19e4f7b4f946e801ea07c31d2d0ded7837a0e Reviewed-on: https://gerrit.libreoffice.org/47789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: svxStephan Bergmann156-975/+973
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I100e6c14cbf1d780f0e5ebca6b0c9e71ce1caaf7
2018-01-11tdf#105000, related tdf#80196: Make new color names translatableGabor Kelemen2-6/+46
Make the new color names of the Tonal palette translatable These were added in 98419425080f58880f2d0d85749a4a55e8abb40b Change-Id: I9a55fbd50bbb97d294f7e6cfdfbe56c2605d5ae7 Reviewed-on: https://gerrit.libreoffice.org/45838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-11loplugin:redundantcast: svxStephan Bergmann13-45/+45
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: Icd1f084d4ffab286fd3c7c02693444eaf7799354
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin2-3/+3
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-10tdf#83877 Copy signature line properties too when copying shapeSamuel Mehrbrodt1-0/+10
Change-Id: I3265c2fa3b858a1e2ad1c0c73f3912a6c68b1043 Reviewed-on: https://gerrit.libreoffice.org/47659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-09-Werror,-Wformat (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I21be71f795c6c04d63a0103e251448edeb4c54d2 Reviewed-on: https://gerrit.libreoffice.org/47670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-07svx, check HAVE_FEATURE_AVMEDIAjan Iversen2-0/+40
unoshap4.cxx did not obey HAVE_FEATURE_AVMEDIA. Change-Id: Id41cddd0a74c43819adc0b64c0dd84ae9d4f54ed
2018-01-07filter navigator: "Filter for" for first positionJulien Nabet1-1/+2
when opening the navigator with a blank filter Change-Id: Ib019714c3c778506633f4d4fa23e8faa0ac1851d Reviewed-on: https://gerrit.libreoffice.org/47518 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-06convert tolerance params to sal_uInt8 (second try)Noel Grandin1-9/+9
first attempt was in commit e75abe6e0a4ea250366bb29c0ece697e9b1b80a1, reverted in 7accac097688832d8682a88a0176c3e1482ffade Change-Id: I460e9ab5fcca3a99656e5d8434fa04c2387d7183 Reviewed-on: https://gerrit.libreoffice.org/47463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05tdf#114837 FILEOPEN: Image is blankNoel Grandin2-30/+35
revert commit e75abe6e0a4ea250366bb29c0ece697e9b1b80a1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Dec 12 09:33:14 2017 +0200 convert tolerance params to sal_uInt8 for now. Change-Id: Iafaada0fb338f60ecc9f94aafe138500dfb27cf7 Reviewed-on: https://gerrit.libreoffice.org/47453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05remove dead eeitemid.hxxNoel Grandin1-1/+0
and inline the couple of constants still in use from it Change-Id: Icb9f5690b5649140bc0503a8917e6a0f764e3d9c Reviewed-on: https://gerrit.libreoffice.org/47404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04tdf#114013 Do not use string concatenationGabor Kelemen1-1/+0
Instead just give more meaningful custom titles to windows Change-Id: I69b93abe236472914c099bfa42792b39f0995afe Reviewed-on: https://gerrit.libreoffice.org/45438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-04svx: warning C4138 '*/' found outside of commentMichael Stahl1-1/+1
Change-Id: I4f3f30f6fc8423e679220af19a18978aaa15643f
2018-01-04drop FrameDirListBox typedefNoel Grandin1-5/+5
and rename FrameDirListBoxWrapper->FrameDirectionListBoxWrapper Change-Id: I201ab2caeff0a3219efe8ee86024bc48b8701f7e Reviewed-on: https://gerrit.libreoffice.org/47346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin10-34/+12
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03tdf#114788: fix crash in form-based filterJulien Nabet1-1/+1
regression from https://cgit.freedesktop.org/libreoffice/core/diff/svx/source/form/filtnav.cxx?id=85f93697defd9a812a0cda0bc4e9364e28c0339e Change-Id: If6f248b460a55aa1e30902d5edeb807dabb37d7b Reviewed-on: https://gerrit.libreoffice.org/47338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-03Translate German variable nameJohnny_M1-3/+3
Change-Id: Iad2185f13c9171dd7d2627a1d93b49e8c9199bb4 Reviewed-on: https://gerrit.libreoffice.org/47132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-03loplugin:passstuffbyref more return improvementsNoel Grandin3-5/+5
slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02cppcheck: fix prefer ++/-- for non primitive typesJulien Nabet1-15/+1
Here, we can just initialize the iterators with the right increment instead of using while loops to increment them Change-Id: I08b51ba11398dbb705d3ed83bfbf46df0deb7f21 Reviewed-on: https://gerrit.libreoffice.org/47224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02RID_* can be extern global variablesNoel Grandin1-11/+1
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: https://gerrit.libreoffice.org/47245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-01tdf#114775: fix crash when deleting some rowsJulien Nabet1-1/+1
see bt https://bugs.documentfoundation.org/attachment.cgi?id=138757 Change-Id: I493bf47b1541262a5ea78b541bc1f47f93cc73df Reviewed-on: https://gerrit.libreoffice.org/47219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-12-31tdf#51188: allow connector gluepoint undoMark Hung1-0/+6
It should had overwritten the connector data when the connector attach to a different glue point of the same object. Let’s always overwrite it, though it waste a little bit time. Change-Id: Ib4cc4bf105e5ef17289e027dcddd0110f7297190 Reviewed-on: https://gerrit.libreoffice.org/46559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-12-29Fix typosAndrea Gelmini1-1/+1
Change-Id: I0e56430afa65b6b5826d56212ac501c0244fce9b Reviewed-on: https://gerrit.libreoffice.org/47145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29loplugin:passstuffbyref improved return in svxNoel Grandin14-18/+18
Change-Id: I33bdbd416709ce46afb3c17aeab0d2e19a68ab30 Reviewed-on: https://gerrit.libreoffice.org/47150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-28Fix typoAndrea Gelmini1-1/+1
Change-Id: I209c6d62c2e5cfbc6a35da406bc59fc155787ec9 Reviewed-on: https://gerrit.libreoffice.org/47127 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-27Remove leading _ from some variable namesMatteo Casalin1-10/+10
Change-Id: I640bf41ad073fcf1d5b8fcc55c63558f208db73d
2017-12-27Make some bool constMatteo Casalin1-2/+2
Change-Id: Icede71af1edfc0671f5b0bc0dbfd3cfc6af79fcd
2017-12-27Return earlyMatteo Casalin1-11/+11
Change-Id: I2b420141b5986b1d23460d5432c1b7051b11663e
2017-12-27mnHitTolLog is already sal_uInt16Matteo Casalin1-6/+5
Change-Id: I4a0e55818ad8e2f61845484a71b6283e0a7c326a
2017-12-27Avoid temporary PointMatteo Casalin1-21/+16
Change-Id: I09ce2859f7bda468399629fda1336788ed65bcb2
2017-12-27Share common codeMatteo Casalin1-20/+2
Change-Id: Ia6ee42c799e566ad837e89d6456c50c7217da1eb
2017-12-27Do not overwrite data with same valueMatteo Casalin1-2/+0
After emplace_back there are at least 2 elements, and GetPrevPos would point to previous back(). Commit 5e913234da65484778d53179ee2005aec01d0f0e removed a possible modification of such data, so this operation is now pointless. Change-Id: Ia5bec5e9b16e9dc9f34c7cf1dbb8e3f17510d83b
2017-12-27Directly access own data members, remove unused methodsMatteo Casalin1-15/+15
Change-Id: Id86d66738da2f6e4b86d4a4ee8da54940c751787
2017-12-25various coverity exception warningsCaolán McNamara14-67/+57
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-25Adjust includesAron Budea1-0/+1
Change-Id: I11385fc987e6951570454919c110de7167f41f5a Reviewed-on: https://gerrit.libreoffice.org/47036 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-12-22lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky1-3/+2
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22tdf#42949 Fix some Include What You Use warningsMiklos Vajna1-1/+0
Change-Id: I30121764303579a7cb4ded0f0f48cc1f8fff6c33 Reviewed-on: https://gerrit.libreoffice.org/46946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-21chart2: suspend/resume setting rects dirty for 3D shapesTomaž Vajngerl1-2/+7
Previously we bypassed setting rects as dirty for a scene just before we are about to create a 3D object. With this change we do it earlier and suspend for the whole time we are creating the scene - so we guarantee to o it for all 3D objects in that code path. Aferwards we resume with setting rects and mark the whole scene as dirty so we don't miss some update. Change-Id: Ie4dec644102140edf282a2f5f6eb7fc9b81dbe48 Reviewed-on: https://gerrit.libreoffice.org/46901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-21TypedWhichId in svx part 2Noel Grandin2-5/+5
Change-Id: Id927679c9f07f1dd820f4fdca9a45eb7aede037c Reviewed-on: https://gerrit.libreoffice.org/46850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 14:12:23 +0000