path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2018-10-29tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl1-17/+15
This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Michael Stahl <> (cherry picked from commit 0a6813ad5d57d0df72562c797a8b0581bfd65a11) Reviewed-on: Tested-by: Jenkins Reviewed-by: Armin Le Grand <>
2018-08-04tdf#119015: don't call TableModel::optimize in CellCursor::merge()Mike Kaganski2-1/+1
Better do that explicitly in the SvxTableController::MergeRange, so that the UI-driven operation still optimizes the table, but import code gets the initial column count, and not throw trying to access the deleted column. Change-Id: Ib4b4d716935ec2036ccb839c36f1be5b0cb878d5 Reviewed-on: Tested-by: Jenkins Reviewed-by: Mike Kaganski <> Reviewed-on: Reviewed-by: Andras Timar <>
2018-07-27tdf#118860 svx opengl: avoid SalBitmap creation without solar mutexMiklos Vajna1-0/+3
The bugdoc has 2 slides. When switching to the second slide, the graphic is loaded in the background, but OpenGLSalBitmap::Create() can't work correctly if the caller doesn't own the solar mutex. This already asserts in OpenGLContext::prepareForYield() in a less obvious way. Focus on the correctness, so just hold the solar mutex during the whole ImportGrpahic() call. If it turns out that the purpose of running this on a thread is to avoid synchronous network traffic, then the data could be first copied to a memory stream, and only then take the lock + import the graphic. (cherry picked from commit 919ccaba419531d689231b76a43ab29c6a9ec65a) Change-Id: I88203c12b4e7a5f2b689928c01e2ba953c5b13c5 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
2018-07-26Resolves: tdf#118862 new instances cannot be editedCaolán McNamara1-1/+3
Change-Id: I9b10ff4f043949c7140852ac9ad9106ca611c98c Reviewed-on: Tested-by: Jenkins Reviewed-by: Eike Rathke <>
2018-07-10tdf#118022: fix crash when searching record in form by handling SQLExceptionJulien Nabet1-1/+13
See Found thanks on gdb with command catch throw com::sun::star::sdbc::SQLException First SQLException was dealt but not the second one Reviewed-on: (cherry picked from commit f94292e8c4d469bd3123e1649b0f2a94d4b357b3) Change-Id: I7d5d3ad612db132a3bda97cff14367912ae885f9 Reviewed-on: Tested-by: Jenkins Reviewed-by: Christian Lohmaier <>
2018-07-05tdf#118506: Disable orientation page in read onlyXisco Fauli1-1/+1
Change-Id: I30994b95e65ddd70df7872f5cc41c339bf906f19 Reviewed-on: Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <> (cherry picked from commit 0c3f7154f4d2919f7d28a5db9578fc308f2c0d02) Reviewed-on: Reviewed-by: Michael Stahl <>
2018-07-05Resolves: tdf#115816 second 'Insert' menu is pasteCaolán McNamara1-0/+2
reuse existing translation to be backportable wrt no new translations Change-Id: I1fb94f66d696f836e8f6a10ba2d6933f69cfac95 Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
2018-06-25tdf#103913 keep ".emf" file extension and mime typeLászló Németh1-1/+6
in documents, don't change them to wmf and image/x-wmf silently, resulting for example, dropping or rejecting modified documents by firewall packet filtering. Reviewed-on: Reviewed-by: László Németh <> Tested-by: László Németh <> Conflicts: svx/source/xml/xmlgrhlp.cxx (cherry-pick from commit 4cb1e86e5217f09e1d98e51e46803a06fb72f5ce) Change-Id: I3b8634ae022c7c026b0ed4ebc345c1c3b3f96337 Reviewed-on: Reviewed-by: László Németh <> Tested-by: László Németh <> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-06-07Resolves: tdf#116876 don't reselect index on resize if it wouldn't changeCaolán McNamara1-1/+2
selecting the index sets it as active and updates the previews, so if its an inactive index and resize happens, leave it as inactive but selected Change-Id: If823f6b3e8f2ee4e77ba5e5d0202d72893ed614c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-06-06tdf#117537 block rentry to CheckAndMarkUnknownFontCaolán McNamara1-1/+7
Change-Id: I70e75a39d13e93e929c7aef5407b1100bb2a7c12 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-05-29tdf#117172 - Image context menu Save fails to do anythingMarco Cecchetti1-0/+7
Change-Id: I5c0980d85ef5ed050bfafbc368576c5ad72a80a7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <> (cherry picked from commit 796bee47e90efee7c076f6acdc2a95004ed081d0) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-27tdf#117821: fix copy-paste wrong control typeJulien Nabet1-1/+1
Since 5ad8376d1698026ccab0634605fdb17ea3c59f3a Resolves: tdf#111080 framework user of convert menu needs action names set 2017-08-08 Change-Id: I2ec8358005e335941bd1c2530f30ce696d3e808f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <> (cherry picked from commit 1e9e01dff0a8d65bb10d5a886cca7899b43979da) Reviewed-on: Reviewed-by: Adolfo Jayme Barrientos <> Tested-by: Adolfo Jayme Barrientos <>
2018-04-05a11y crash with no chars selected in character mapCaolán McNamara1-1/+2
type gibberish in character map search box, click character map widget, crash Change-Id: Ifa3e4bce2d7e0b84cf3c5033eb819c73076daabe Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-04-04tdf#112997 multiple animated gif only one frameNoel Grandin4-23/+20
Not sure what the problem is, but using a vector and just making sure we insert into the right spot for the sorting fixes it. Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <> (cherry picked from commit d312ff2b52c0ea2e2864518a36f6b432653c8297) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-03-30tdf#116692 (Paragraph) Classification Dialog does not show translated UICor Nouws1-1/+1
Change-Id: I9a08fe3d2d5efc14c8845993d3b18a230df51052 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <> Signed-off-by: Adolfo Jayme Barrientos <> Reviewed-on:
2018-03-19Resolves: tdf#116242 handle negated diacritics correctly and show checkboxEike Rathke1-12/+19
This is a combination of 2 commits. Resolves: tdf#116242 handle negated diacritics correctly and show checkbox The "ignore diacritics" implementation is not only about CTL, whatever its names suggest. It uses an ICU "NFD; [:M:] Remove; NFC" transliteration that decomposes and removes *any* diacritic. Thus treat it as such and don't hide the checkbox if CTL is not enabled, but more important preset the sensitive values, and handle the UI vs implementation oddity correctly; UI "sensitive" / code "include" means to *not* *ignore*, obtain the proper negated value from the checkbox. Unfortunately the setting is stored in the configuration, so an update will still present the user with an unchecked Diacritics-sensitive box s/he has to enable once. The actual failure (diacritics always ignored) is a fallout from commit d4064927a2e83c974d4ee9538081e8a4fcdb1e34 AuthorDate: Tue Oct 3 10:26:28 2017 -0800 CommitDate: Thu Oct 26 17:24:26 2017 +0200 tdf#111846 Find & Replace: Rename diacritics and kashida options (cherry picked from commit d99ae18b68d3889c999b59485006f85f7faa201c) Change IsIgnoreDiacritics_CTL default to false, tdf#116242 follow-up And adapt description to reality. (cherry picked from commit a8959a26e18237c458a853f2ca7524e875d4c1b6) ab35b74f4cbe7dc91fd0570adcc634faba96b5de Change-Id: I65f2a23b66370fdfe2d170c17c7736a3b4177192 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-03-07Resolves: tdf#113805 insert special character fails in insert footnote...Caolán McNamara1-1/+1
etc. dialogs i.e. since commit 710a39414569995bd5a8631a948c939dc73bcef9 Date: Thu May 11 13:27:38 2017 +0530 GSoC: Glyph View and Recent Characters Control in Special Characters dialog Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 it inserts into the document, extend the fix of commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion to do the old thing that existing code depends on if this is not an "insert" dialog, and bubble that setting around from the callers Change-Id: Id8acf16955d0167beffae43e3b201e500ee7a929 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <> Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-02-28tdf#79546: Make sure temp copy of inserted media file keeps the same extensionTor Lillqvist1-4/+24
Inserting videos into Impress presentations with 'Insert>Audio or Video' did not work at all for me. This helps. It seems that the AVFoundation APIs are sadly rather picky about file name extensions. Why we need to make a temporary copy of the media file (which after all can be rather large) at all, when inserting it in a slide, I don't understand. But I am not going to dig into that now. Change-Id: I43fcfb5bb3ef0a2c0f8979ac3e7c458a84f180a1 Reviewed-on: Reviewed-by: Tor Lillqvist <> Tested-by: Tor Lillqvist <> (cherry picked from commit 1aa5a3874bf716acfbded2a09319dce5d4ce8c0d) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <>
2018-02-22tdf#107134: add comparator in form filterJulien Nabet1-0/+34
Change-Id: I86d3b5c4ebd231bdad70dc9f5a364658cfca6df4 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <> (cherry picked from commit 819ba42b3409bd2f66593f619f1934ea7f461364) Reviewed-on: Reviewed-by: Eike Rathke <>
2018-02-22Resolves: rhbz#1546997 'search not found' at 0,0 when window too narrowCaolán McNamara1-25/+17
if the statusbar hadn't got space for the initial label, then it doesn't get set a position, so when later forced visible it draws at 0,0 call Resize on the toolbox to get it to relayout, and while we're at it set the required size of the label so we might have space for it if that text is shorter than the original len allocation Change-Id: I37d20125d8195b2c75e83e9673c82c2011ceda8e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-02-20svx: fix deadlock in Gallery::GetGalleryInstance()Michael Stahl1-10/+4
Seen in UITest_writer_tests. Use C++11 thread-safe static initialisation here, which should avoid the deadlock that is caused by relying on osl::Mutex::getGlobalMutex(). Thread #1: 2 in osl_acquireMutex(oslMutexImpl*) (pMutex=0x1ad2c70) at sal/osl/unx/mutex.cxx:97 3 in osl::Mutex::acquire() (this=0x7ff3252b9628 <rtl::Static<osl::Mutex, (anonymous namespace)::theImplHelperInitMutex>::get()::instance>) at include/osl/mutex.hxx:56 4 in osl::Guard<osl::Mutex>::Guard(osl::Mutex&) (this=0x7ffca8bdd6c0, t=...) at include/osl/mutex.hxx:129 5 in cppu::getTypeEntries(cppu::class_data*) (cd=0x7ff31e458fe0 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>, com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>::operator()()::s_cd>) at cppuhelper/source/implbase_ex.cxx:89 6 in cppu::queryDeepNoXInterface(typelib_TypeDescriptionReference const*, cppu::class_data*, void*) (pDemandedTDR=0x2e643b0, cd=0x7ff31e458fe0 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>, com::sun::star::io::XActiveDataControl, com::sun::star::io::XActiveDataSink>::operator()()::s_cd>, that=0x387cbe0) at cppuhelper/source/implbase_ex.cxx:173 [...] 20 in utl::UcbStreamHelper::CreateStream(rtl::OUString const&, StreamMode) (rFileName="file://instdir/program/../share/gallery/sounds.thm", eOpenMode=StreamMode::READ) at unotools/source/ucbhelper/ucbstreamhelper.cxx:149 21 in GalleryTheme::CreateThemeEntry(INetURLObject const&, bool) (rURL=..., bReadOnly=false) at svx/source/gallery2/galtheme.cxx:692 22 in Gallery::ImplLoadSubDirs(INetURLObject const&, bool&) (this=0x38762c0, rBaseURL=..., rbDirIsReadOnly=@0x7ffca8bde7df: false) at svx/source/gallery2/gallery1.cxx:474 23 in Gallery::ImplLoad(rtl::OUString const&) (this=0x38762c0, rMultiPath="file://instdir/program/../share/gallery;file://workdir/UITest/writer_tests/user/user/gallery") at svx/source/gallery2/gallery1.cxx:301 24 in Gallery::Gallery(rtl::OUString const&) (this=0x38762c0, rMultiPath="file://instdir/program/../share/gallery;file://workdir/UITest/writer_tests/user/user/gallery") at svx/source/gallery2/gallery1.cxx:257 25 in Gallery::GetGalleryInstance() () at svx/source/gallery2/gallery1.cxx:273 26 in GalleryExplorer::BeginLocking(unsigned int) (nThemeId=3) at svx/source/gallery2/galexpl.cxx:264 27 in SvxBmpNumValueSet::init() (this=0x3873ed0) at svx/source/dialog/svxbmpnumvalueset.cxx:501 Thread #8 Grammar Checking: 2 in osl_acquireMutex(oslMutexImpl*) (pMutex=0x7ff329045420 <globalMutexImpl>) at sal/osl/unx/mutex.cxx:97 3 in osl::Mutex::acquire() (this=0x7ff32903b780 <osl_getGlobalMutex::globalMutex>) at include/osl/mutex.hxx:56 4 in osl::Guard<osl::Mutex>::Guard(osl::Mutex*) (this=0x7ff2f5b30030, pT_=0x7ff32903b780 <osl_getGlobalMutex::globalMutex>) at include/osl/mutex.hxx:122 5 in com::sun::star::container::cppu_detail_getUnoType(com::sun::star::container::XEnumeration const*) () at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/container/XEnumeration.hpp:69 6 in cppu::UnoType<com::sun::star::container::XEnumeration>::get() () at include/cppu/unotype.hxx:296 7 in cppu::detail::cppu_detail_getUnoType<com::sun::star::container::XEnumeration>(com::sun::star::uno::Reference<com::sun::star::container::XEnumeration> const*) () at include/cppu/unotype.hxx:259 8 in cppu::UnoType<com::sun::star::uno::Reference<com::sun::star::container::XEnumeration> >::get() () at include/cppu/unotype.hxx:296 9 in com::sun::star::reflection::detail::theXTypeDescriptionEnumerationType::operator()() const (this=0x7ff2f5b30177) at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/reflection/XTypeDescriptionEnumeration.hpp:30 10 in rtl::StaticWithInit<com::sun::star::uno::Type*, com::sun::star::reflection::detail::theXTypeDescriptionEnumerationType, com::sun::star::reflection::detail::theXTypeDescriptionEnumerationType, com::sun::star::uno::Type*>::get() () at include/rtl/instance.hxx:603 11 in com::sun::star::reflection::cppu_detail_getUnoType(com::sun::star::reflection::XTypeDescriptionEnumeration const*) () at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/reflection/XTypeDescriptionEnumeration.hpp:57 12 in cppu::UnoType<com::sun::star::reflection::XTypeDescriptionEnumeration>::get() () at include/cppu/unotype.hxx:296 13 in com::sun::star::reflection::XTypeDescriptionEnumeration::static_type(void*) () at workdir/UnoApiHeadersTarget/udkapi/comprehensive/com/sun/star/reflection/XTypeDescriptionEnumeration.hpp:102 14 in cppu::getTypeEntries(cppu::class_data*) (cd=0x7ff3252b8ac0 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::reflection::XTypeDescriptionEnumeration>, com::sun::star::reflection::XTypeDescriptionEnumeration>::operator()()::s_cd>) at cppuhelper/source/implbase_ex.cxx:96 Change-Id: I3aa3167ca8989b3d6be053e1c97f3b7a64bfbfb8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <> (cherry picked from commit 713ac313c1f053cc5d812843a3b5611f7d1a10e5) Reviewed-on: Reviewed-by: Stephan Bergmann <>
2018-02-19Related: tdf#114756 fix up similar casesCaolán McNamara1-11/+100
Change-Id: Id67ccaeda6ebff477f5d86617863280766713f24 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Katarina Behrens <>
2018-02-19tdf#114756: fix connector dropdownJulien Nabet1-1/+9
bt: 0 0x00007fffef4738d3 in SdrEdgeKindItem::GetValueTextByPos(unsigned short) const (this=0x5555587ff770, nPos=0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdattr.cxx:1307 1 0x00007fffba50f71b in SvxConnectionPage::FillTypeLB() (this=0x55555c4d2a90) at /home/julien/lo/libreoffice/cui/source/tabpages/connect.cxx:507 2 0x00007fffba50be46 in SvxConnectionPage::SvxConnectionPage(vcl::Window*, SfxItemSet const&) (this=0x55555c4d2a90, pWindow=0x55555c46cc70, rInAttrs= SfxItemSet of pool 0x555557883790 with parent 0x0 and Which ranges: [(1000, 1234), (4003, 4057)], __in_chrg=<optimized out>, __vtt_parm=<optimized out>) at /home/julien/lo/libreoffice/cui/source/tabpages/connect.cxx:98 See Change-Id: I24ba9e0140668d666da686e3f8a05587b46e923f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Katarina Behrens <> (cherry picked from commit a2721ba03e61a476838d3c518505b05a12ad2a5b) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-02-16ofz#6311 still problems with SdrEdgeObj listening to same obj at start as endCaolán McNamara4-4/+4
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-02-15tdf#105000, related tdf#80196: Make new color names translatableGabor Kelemen2-6/+46
Make the new color names of the Tonal palette translatable These were added in 98419425080f58880f2d0d85749a4a55e8abb40b Change-Id: I9a55fbd50bbb97d294f7e6cfdfbe56c2605d5ae7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Heiko Tietze <> (cherry picked from commit 8901c7c7bc4db5076a615ef942af6fb65e943ee3) Reviewed-on: Reviewed-by: Miklos Vajna <>
2018-02-13tdf#107403 Don't scale frame icons twiceMaxim Monastirsky1-8/+0
It's already done by ImplImageTree, see loadImageFromStream function in ImplImageTree.cxx. Change-Id: I5aa7439876037fb0168f6c1da264af9697788ef0 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Maxim Monastirsky <> (cherry picked from commit 273d0ee7b7edb24c2c9e15e9f4337f71c175801a) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-02-12tdf#115601: make ImageMap dialog translatableJulien Nabet1-2/+1
Change-Id: Ie1ecb5cd3356144c28de366dbe5e13a3997604e2 Reviewed-on: (cherry picked from commit 6bcd433fe13ab402d2cc8433d98a78db140858e9) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Andras Timar <>
2018-01-30fix tdf#114934 borderline feature regressionsArmin Le Grand6-345/+342
squashing some master commits, fixes the following bugs: - tdf#114934 which contains: - tdf#115169: Calc: Rotated Cells not shown rotated when using Print/PDF/PrintPreview - tdf#113751: Borders for Merged Cells are Partially Shown - tdf#114625: Calc can not print right border of merged cells from LO 6.0 - tdf#114824: Export to PDF and Printing: Borders of Merged Cells Flow to Page Footer BorderlineFix: Need to redesign Borderline paint for Calc To fix some errors, need to change svx::frame::Array conversion to Primitives, especially regarding handling of merged cells. These make problems in the currtent form where the full extended merged cell tries to be converted. This is bad for cropped stuff and also wrong for double-line stuff attaching to a merged cell. The solution is to handle cells single and merge created primitives which is more expensive but will work. This will involve special handling for X-Ed (crossed) and 'roated' Cells. Also need to be very careful since all this is used in the meantime for all visualizations of Tables in multiple apps/situations. Change-Id: If0652a3ba97a6f27dd5d782ea22b1514303f3710 BorderlineFix: Corrected missing borders in print In Print/PDF/PrintPreview border lines were missing, this happened for merged cells. It has to do with access to the involved Styles and/or 'Clip' set (to avoid creating everything). Thus a 'mixed' usage of cell and merged-cell stuff was needed. As it turns out support for this is already there, need to use it. Change-Id: Ic16085b97eef5c79a4501279432f43491bca350e BorderlineFix: Avoid BorderLines to be too prolonged For MergedCells there was an effect that the BorderLines were painted too far in PrintPreview/Print/PDF visualization, found reason and changed. Checked (hopefully) all usages, looks good. Change-Id: I0acf8dcb20548a98533f3ab317ac72c0d0f0a947 BorderlineFix: Corrected handling for 'rotated' CellBorders CellBorders can be rotated (including their Text) and need special visualization that is based on an own sheared/rotated coordinate system. Currently only possible for single cells (not merged ones) and needs to handle all borders (also bottom-right directly in the rotated cell, not in the neighboured ones to have the geometry, plus avoiding these in the non-rotated neighbour cells. Also corrected adding CellRotation data to svx::frame::Array in calc using SetCellRotations() which now gets called in the ScOutputData constructor to ensure it gets called in all places where it is used. Change-Id: I47bdfc29ba5ca76bbc07d98cb64733f867b1ee20 BorderlineFix: Fixed visual updates when scrolling For Cells with DoubleLine the connections to perpendicular DoubleLine-Styles may have to be displayed in a Cell which is 'around' the orig cell in a Cell-Border of one. To represent that and to avoid repaint errors when scrolling in, the preparation of Primitives has to take accordingly more neighbour cells into account. Tested this change with the usages in Calc, UI (Dialogs) and Calc exports Print/PrintPreview/PDF. This does not affect Tables in Writer and/or Draw/Impress. Change-Id: I3bcc68cdf7b4fc1825a87a9773892c359421024e BorderlineFix: Fix WriterPaint if scrolling CellTableBorders Similar to CalcBorders in Writer the overlap regions for FrameBorders have to be taken into account when repainting the CellBordes of WriterTables Change-Id: I488ba158e1de579bfb06b9c8353adaa2cac706c6 BorderlineFix: Corrected Draw/Impress TableStyle accesses In Draw/Impress the indices for accessing the correct neighbouring TableStyles were wrong and thus created wrong visualizations, corrected that. Change-Id: Iebc5f294adb62fa4c6358e2f8c27d29cc3163fbc BorderlineFix: Use svx::frame::Array tooling in Draw/Impress For creating the needed BorderPrimitives for TableCells for the Tables used in Draw/Impress, adapt the ViewContactOfTableObj doing this to use svx::frame::Array tooling now. This will correct the error for not taking the neighboured connects for merged cells into account and unify one more space to the same tooling. Change-Id: I2e6f732985e9b963359f156628bd29ddfec1a80c BorderlineFix: Corrected wrong indexing in Array initialization Change-Id: I4222ef1c82620a05cea9f6db1a0664196cfb3bd4 Reviewed-on: Reviewed-by: Thorsten Behrens <> Tested-by: Thorsten Behrens <>
2018-01-24tdf#114901 TSCP various advanced TSCP dialog changesTomaž Vajngerl2-107/+91
- change Markings from Combo to List box - minimize whitespace - move bold and sign paragraph under text area as it is fixed - remove bold in paragraph dialog Change-Id: I7ec20460d02d3611a1da325eb7d3de3aef10f03f Reviewed-on: Reviewed-by: Tomaž Vajngerl <> Tested-by: Tomaž Vajngerl <> (cherry picked from commit 085852e2e2779de1712cf18b5e67740cb7a4bcb6) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Adolfo Jayme Barrientos <>
2018-01-23tdf#38915: set cProcessed condition on any process outcomeMike Kaganski2-0/+39
When application is initializing, initially request handler is not processing requests (its state is Starting). Requests processing is enabled in Desktop::OpenClients() after recovery had been processed. If another soffice process is started, it communicates over already established pipe, and sends a request to the first process. In IpcThread::process(), it is decided if the request needs to be checked for completion (e.g., if a file or specific module was requested to be open). After that, the prepared request is posted for processing. In case when the completion should be checked, PipeIpcThread::execute() then waits for Processed condition indefinitely. Request is processed in RequestHandler::ExecuteCmdLineRequests, which first checks that handler's state is RequestsEnabled, and if it isn't, then returns. Otherwise, after processing, Processed condition is set. The problem is, thus, in case when the request comes before requests processing is enabled (e.g., when recovery dialog is open): request handler thread waits indefinitely, but the processed condition will not be set. This will not allow to close the pipe to second process, and it will hang indefinitely. The IPC thread will be hung even after user closes recovery dialog, and continues working with program. So, subsequent attempts to open files from file manager (launching new process) will fail, and new zombie soffice processes will wait the first indefinitely. Also, when first process will be closed by user, the deinit sequence will attempt to wait for the IPC thread to finish (in RequestHandler::Disable(), after all visible windows had been closed), which will leave the first process hung, preventing all subsequent attempts to open LibreOffice. This patch ensures that the Processed condition is set at any outcome in RequestHandler::ExecuteCmdLineRequests. Also, it brings (possibly hidden) recovery dialog to front, making the reason why following attempts to open files fail apparent to user. Change-Id: Ibddf7483e5b1d6167ac7f307ea2442119f446129 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Aron Budea <> Reviewed-by: Mike Kaganski <> (cherry picked from commit cf333a878ceed18d0343520a2c65be69fc433b1f) Reviewed-on: Reviewed-by: Michael Stahl <>
2018-01-10tdf#51188: allow connector gluepoint undoMark Hung1-0/+6
It should had overwritten the connector data when the connector attach to a different glue point of the same object. Let’s always overwrite it, though it waste a little bit time. Change-Id: Ib4cc4bf105e5ef17289e027dcddd0110f7297190 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mark Hung <> (cherry picked from commit 4173798ef73d3fc7da8c5b8fa575a36f05cd6f83) Reviewed-on: Reviewed-by: Noel Grandin <> Reviewed-by: Katarina Behrens <>
2018-01-08tdf#113715 Fix .uno: names appearing in the customization dialogMaxim Monastirsky1-4/+4
Based on 591ed2391389120efdf366f207642a98eb9f054c Changes from master: - Revert officecfg string changes. - Instead, hide .uno:AutoSum in Calc for 6-0. Change-Id: Ia4a4231acf2f15ebf58f2acd02b7fc0ab5a88072 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Heiko Tietze <> Tested-by: Heiko Tietze <>
2018-01-04tdf#114788: fix crash in form-based filterJulien Nabet1-1/+1
regression from Change-Id: If6f248b460a55aa1e30902d5edeb807dabb37d7b Reviewed-on: (cherry picked from commit d2c9b749503ef0763a6140a7b509f73adb6015d2) Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Lionel Elie Mamane <>
2018-01-01tdf#114775: fix crash when deleting some rowsJulien Nabet1-1/+1
see bt Change-Id: I493bf47b1541262a5ea78b541bc1f47f93cc73df Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2017-12-19tdf#51188: notify that geometry has changed when dragging the connector.Mark Hung1-0/+2
Change-Id: I7b7cb7719c9c735eeb4f964b1ae6ce6819186aed Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Katarina Behrens <> (cherry picked from commit 98de1ed2e2c49ea52f398f666aef7480b60e4e3c) Reviewed-on: Reviewed-by: Christian Lohmaier <>
2017-12-18TSCP: don't put a non-existing name into doc. propsTomaž Vajngerl1-1/+1
We combined the abbr. name with the name and put that as a value into doc. properties. This is not correct as such a name doesn't exist in the BAPolicy and con't be identified anymore, so removing this. Also use the values that were put into the ClassificationField instead of the extracted text. Change-Id: I3037bc90a7a394d430f7c0cca4d326473eff3147 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <> (cherry picked from commit ec9b555e8094f4552c068820cab633307fcf520f) Reviewed-on: Tested-by: Tomaž Vajngerl <>
2017-12-15tdf113594: marking gluepoints immediately.Mark Hung1-1/+1
pPV was for the parameter of MarkGluePoint that was removed in ec38966951f2, and was kept somehow and is converted to bool here. Just replace the default boolean value to false ( that means marking instead of unmarking. ) Change-Id: I4c4b9dd368537b7b90cc4effae482a7b8a41eec9 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <> (cherry picked from commit bf151f0716910b56e3538579f4af7ede8f51bbcf) Reviewed-on:
2017-12-04Related tdf#72966 Provide replacement graphic also for metafilesSamuel Mehrbrodt1-2/+3
With this, SVM files are still written to ODF, but accompanied by a replacement png graphic. Change-Id: I2c949f100dd5197a10c741baa42ea740f3a1415a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Armin Le Grand <> Reviewed-by: Thorsten Behrens <> Reviewed-on: Reviewed-by: Samuel Mehrbrodt <>
2017-12-03Revert "tdf#105000, related tdf#87538: Make new color names translatable"Yousuf Philips2-67/+0
No need for this if we will be removing tango and we shouldnt have translators waste time translating it if so. This reverts commit 6999bafb8675461a7f1400880eabd2daffe96ba4. Change-Id: I7b6fe1fc84530bdbc002fcb2857942ddf268c88e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Yousuf Philips <> (cherry picked from commit 83638a195dfde7255115cac84b2e9bb7e8e1b440) Reviewed-on: Reviewed-by: Adolfo Jayme Barrientos <>
2017-11-30tdf#111773 tdf#111780 Fix selection after merge cells in an Impress tableDaniel1-2/+2
Change-Id: I800c4fb8c37c07fb771f4310b207e459119a8e60 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2017-11-29tdf#109202: Convert images to desired format in (f)odt filterKatarina Behrens1-45/+38
Pass down mimetype to SvXMLGraphicHelper Change-Id: I9c81c06d2a1d6168704440094081e99d0bcbbff9 Reviewed-on: Reviewed-by: Samuel Mehrbrodt <> Tested-by: Samuel Mehrbrodt <> (cherry picked from commit 082cdbc991a2e31556bab53a5b8214cb89138354) Reviewed-on: Reviewed-by: Thorsten Behrens <> Tested-by: Jenkins <>
2017-11-27tdf#114078 Missing gettext markup on Numbering format stringsCaolán McNamara1-28/+28
Change-Id: I8ac705dc964d23984cba00f51ec25ad07243554e Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2017-11-24TSCP: fix oversizing of ListBox-es by defining max lines & charsTomaž Vajngerl3-17/+25
Change-Id: I47e8018c5f2c0ea890b5a11ac7cc03fafb7d1eed Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-11-24TSCP: Advanced dialog UI improvementsTomaž Vajngerl3-46/+79
- Change the height of TextEdit to ~5 lines (100px) - IPPart: single to double-click to add - IPPartNumber: change to ListBox, same behavior as IPPart - Markings: add on focus change - Category: remove messagebox when the category changed Change-Id: I9e695abc7caa702b2150a96ae15e6ce19fc2458a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-11-24TSCP: remove character limitation of recently used pop-upTomaž Vajngerl1-6/+1
Change-Id: I886fe180e73aea9685e647aaa3283f707344f69f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-11-23svx: loplugin:staticmethodsMichael Stahl1-1/+1
Change-Id: I8786baa0a5142397c157e01d5b99aa2c482bb468
2017-11-23tdf#113657: fix crash when trying to format empty paragraphJulien Nabet1-11/+21
by creating a function to clean line feeds and returns if it's empty or not Change-Id: I3a744c52bdb457c92f38595463099e1cbf17a37e Reviewed-on: Tested-by: Jenkins <> Tested-by: Xisco Faulí <> Reviewed-by: Michael Stahl <>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann1-12/+12
...similar to how <> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: Tested-by: Stephan Bergmann <> Reviewed-by: Stephan Bergmann <>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin3-4/+4
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann14-24/+24
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>