summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2014-06-26fixes for up-casting to Reference<XInterface>Noel Grandin7-11/+11
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 533c6cb6bad6ef0432e8eebbfd4daf90ef71f3b4) Reviewed-on: https://gerrit.libreoffice.org/9919 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-25fdo#37401 - fixed the old vector lengthHideki Ikeda1-1/+1
The center-left point in the area is used to calculate the old vector length but the coordinate was incorrect. Change-Id: I81a88182d11e30ee7a5caee3eac879b082bff160 Reviewed-on: https://gerrit.libreoffice.org/9887 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 03675ab4a8994cb7000fd738d1685720c8b9e584) Related: fdo#37401 adjust fix to original aCenter use i.e. as far as I can see the bug came about during.... commit 74cb1c4cb5f72fd8cf80c6d144eda00841394647 Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Tue Nov 14 12:37:46 2006 +0000 with 2006/10/27 12:14:08 aw 1.2.1208.5: #i39528# ::basegfx -> basegfx adaption in - Vector2D aFullVec(aStartPos - aEndPos); - Vector2D aOldVec(Vector2D(aRect.Left(), aCenter.Y()) - aRect.TopLeft()); ^^^^^^^^^^^ - double fFullLen = aFullVec.GetLength(); - double fOldLen = aOldVec.GetLength(); - double fNewBorder = (fFullLen * 100.0) / fOldLen; - sal_Int32 nNewBorder = 100 - (sal_Int32)(fNewBorder + 0.5); + basegfx::B2DVector aFullVec(aStartPos - aEndPos); + const basegfx::B2DPoint aTopLeft(aRange.getMinX(), aRange.getMinY()); + const basegfx::B2DPoint aCenterLeft(aRange.getMinX(), aRange.getHeight()); ^^^^^^^^^^^^^^^^^^ + const basegfx::B2DVector aOldVec(aCenterLeft - aTopLeft); + const double fFullLen(aFullVec.getLength()); + const double fOldLen(aOldVec.getLength()); + const double fNewBorder((fFullLen * 100.0) / fOldLen); + sal_Int32 nNewBorder(100L - FRound(fNewBorder)); Change-Id: I840caa5e49a04f9b6460c4fa8e3731f3e5ebde05 (cherry picked from commit ef16d765306c932c49254f295f57e5853129c1ea)
2014-06-24fdo#75339: Substituting XInterface* eq. for object eq. requires queryInterfaceStephan Bergmann1-2/+4
Regression introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" which should have left (at least some) "querying upcasts" to XInterface alone. Closer inspection of that commit will probably turn up further regressions that need to be reverted. Change-Id: Ib81afc12d9df205b5b0fe6cec6ce85d012e9629f (cherry picked from commit f8115ce72dad45b82b044d9c8f5c253d0514574d) Reviewed-on: https://gerrit.libreoffice.org/9874 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-24Related bnc#822625: Minimum height was not invalidated when rectangle changes.Matúš Kukan3-14/+9
5792e76cb5beb630c135f57b74f57d74dd2dc2b0 was too optimistic and did not invalidate mnCachedMinHeight often enough. This was resulting in a grey area below table frame when resizing it. So, revert 5792e76cb5beb630c135f57b74f57d74dd2dc2b0 "Related bnc#822625: Cache minimum height for table cells." and istead just use getMinimumWidth() in TableLayouter if that's all we need. getMinimumHeight() is expensive. Change-Id: I34c49dda75d6ccccaa5b4d3746114352621a40dd (cherry picked from commit b8f7ea5da41d61d405adec54dcd10b54ee0e5591) Reviewed-on: https://gerrit.libreoffice.org/9870 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida12-33/+52
(cherry picked from commit 1d38cb365543924f9c50014e6b2227e77de1d0c9) Conflicts: sd/source/ui/view/sdview3.cxx xmloff/source/chart/SchXMLExport.cxx Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a Reviewed-on: https://gerrit.libreoffice.org/9836 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-23Resolves: fdo#80327 Sound list box when non-English UIJulien Nabet1-28/+10
Fallback strings are in English wheresas ImplGetThemeEntry expects localized strings Let's put localized strings in fallback to make ImplGetThemeEntry happy Cherry-picked from e4ca1f900a5585d35af04159bdd854f10b495355 Change-Id: I27dd992bac4f5aaf6e0e6237fe59dac990f11c92 Reviewed-on: https://gerrit.libreoffice.org/9845 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-06-17bnc#882627: Allow to edit spacing to contents even with no borders visible.Matúš Kukan1-1/+1
SfxItemSet::MergeValue changes some items from SFX_ITEM_DEFAULT state to SFX_ITEM_SET which I think is a bug but this patch avoids the problem too. The issue was: visible changes in some tables, after changing e.g. borders spacing, because the cells had wrong SfxItemSet after the process. Change-Id: I676b211e1a4a1d7341c385d63503aa740718ed5d (cherry picked from commit b1d8df61b47e84bf0de64342556049673dd9c543) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2014-06-13Introduce HAVE_FEATURE_GLTF to enable/disable gltf related codeZolnai Tamás1-0/+6
When it is a release build then enable it only on Windows and Linux. Change-Id: I7c462aeb75e6ab60eeaa0fa42ca7853a6369b742 (cherry picked from commit fe70101856332663f600df144b39d2638b3d0570)
2014-06-12fdo#79883 the page view object contact must existDavid Tardon1-3/+6
Change-Id: I5c6bd3ea267f1ea84b46e46aa508a27d00903347 (cherry picked from commit 551c915dcbf3e1d6bfd799c6e13e5700e2c3e535)
2014-06-10avoid problems with poppler's and vcl's FontInfo during runtimeMarkus Mohrhard4-26/+26
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8 Conflicts: include/vcl/metric.hxx svtools/source/control/ctrlbox.cxx svtools/source/control/ctrltool.cxx svtools/source/control/stdmenu.cxx svx/source/sidebar/nbdtmg.cxx
2014-06-03disallow private use language tags in combo box editEike Rathke1-1/+1
Change-Id: I75f0b93507d31a12b07e4bb7d2c86671aa074486 (cherry picked from commit a8c5adabb98d4152527b553f904c1841c7393748)
2014-06-02Resolves: fdo#79506 Some numbers are marked as translatableJulien Nabet1-5/+5
Exception: http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/DocumentRenderer.src#55 Cherry-picked from acdff9f9763847c992e0853022896cff781c5ffe Change-Id: Iecfe49b51ed68de00f1b5adfb5bca9fa793fb1f9 Reviewed-on: https://gerrit.libreoffice.org/9614 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-06-02Pass also const CellRef& to save a lot of getCellByPosition() calls.Matúš Kukan3-10/+7
Change-Id: I86c89a05d263cada38ff54eaccf9ba39458db52e (cherry picked from commit 7b9b57b41936eea673eb678407ed817856ba0912)
2014-05-29reportdesign: Fix applying the last used colorMaxim Monastirsky1-2/+4
The last used color is stored inside SvxColorToolBoxControl, so we must call its Select method to do that. (This also fixes using the last shape, See previous commit for a fix of exactly the same problem in chart2.) For the font color, there was also another problem: The SID used for that button is SID_ATTR_CHAR_COLOR2. The problem is that SvxColorToolBoxControl::Select actually calls for that SID the ".uno:CharColorExt" command instead of ".uno:FontColor" (which activates in writer the format paintbrush mode). Given that since commit 584b415924bba22db23a4258062e54973de0ed7c this command also receives the last used color as argument, the easiest solution is to register ".uno:CharColorExt" here as well. (cherry picked from commit 426033250db0b9b6344980655ca0be59efe6a6a5) Change-Id: I2db25a7fb537ce10dfec7b1c2d049dd77d9f8f6b
2014-05-28Related bnc#822625: Cache minimum height for table cells.Matúš Kukan2-5/+10
Change-Id: I35e295347a046376289f5d4fd5468860d0b8f0ae (cherry picked from commit 5792e76cb5beb630c135f57b74f57d74dd2dc2b0)
2014-05-27various situations where graphic go missing on saveOliver-Rainer Wittmann1-3/+5
Resolves: #i114361# provide and accept changed URL... of embedded graphic file during save (ODF export) (cherry picked from commit a90c007908eb3f66e28a9ea525729065db652b6f) Conflicts: sw/inc/ndgrf.hxx sw/source/core/graphic/ndgrf.cxx sw/source/core/unocore/unoframe.cxx sw/source/filter/xml/xmltexte.cxx xmloff/source/draw/shapeexport2.cxx Change-Id: I9d4a02af2561467fe1a66f036b55d6dcf2429986 (cherry picked from commit 192abfb36b8a4859879fcb49326d59ed62083c8d) Resolves: #i124717# do not mark *.svm graphic files as *.bmp graphic files (cherry picked from commit a5cfb91f3dc4b38055fb920f65101cc45d52f8de) Conflicts: svtools/source/filter/filter.cxx Change-Id: I43f62a453bfa17254cebc07bde95f07f16a329c2 (cherry picked from commit 12dd68e3d20ad36ebe7cb40a600215f6d2b7b6ec) Resolves: #i124946# only apply new embedded stream name... for a graphic, if is already has one. - needed correction for the fix made for issue #i114361# (cherry picked from commit 23a4bd91ceb89e5e0a2413f80fc987db106a0bc9) Conflicts: sw/inc/ndgrf.hxx sw/source/core/graphic/ndgrf.cxx sw/source/filter/xml/xmltexte.cxx Change-Id: Ia9771932ae5b380ccae9b0a3cbb79d41f5d9bdb8 (cherry picked from commit 05e07167e422caf58d23ff883edda30acc3ba88d) Resolves: #i124966# keep picture format information - <GfxLink> instance - also for the reading of preview picture data in order to avoid trouble on save in case that the preview data equals the picture data (cherry picked from commit d6af1b601bb8fe2569d17e01505f67e1becc9366) Conflicts: svx/source/svdraw/svdograf.cxx Change-Id: Ifecb07b4d5d33d593502fccd6f21644893027d2d (cherry picked from commit 597ae8dd9c28ee370874b219d594fa1c105f2c72) Reviewed-on: https://gerrit.libreoffice.org/9455 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-05-27fdo#78920: Number %NUMBERSTRING in tooltipJason Hulme2-38/+3
Fixed string in Bullets and Numbering and changed sidebar to use the same set of strings. Change-Id: Ib8a103e203cf66c979216175d4047bca518290ce Reviewed-on: https://gerrit.libreoffice.org/9492 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit ceb7ea5091bd9b862f92e853fd9f8f2542fb8b41) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2014-05-23feedback color indicator for invalid tagsEike Rathke1-0/+19
Change-Id: I235e32587779369c139aedd1961b37d8fcad8f53 (cherry picked from commit 04ccece7299ac1e57488e5ef36af122edeec2aae)
2014-05-23switch the Western language list box to SvxLanguageComboBoxEike Rathke1-0/+90
This allows the user to assign an arbitrary (but valid) BCP 47 language tag to a portion of text, so that customized spell-checkers or other language-dependent tools can be used without the need to wait for LibreOffice to add yet another language to the list in the next release. +bool SvtLanguageTable::HasLanguageType() (cherry picked from commit 2a8eff589a53c8dd65e18d7a9d11cdb98a937e68) + SvxLanguageComboBox EditModifyHdl(), SaveEditedAsEntry() (cherry picked from commit 29c024afbe6a46459e37c5ceec510de1cd0ca7c8) handle SvxLanguageComboBox edit (cherry picked from commit 1aad7628dcd7fd14d48814d00c3d04e4ec0c59d5) finally switch the Western language list box to SvxLanguageComboBox (cherry picked from commit dbe8b3b6d4f2d2cc2e8c702b78034e9013f71e8f) advance start of edit selection on a matching entry ... to allow continuous typing. (cherry picked from commit fe2b8ef18b11b226fddd1cf3fc7f9133426a1b1a) Change-Id: Id57eb51b69e50be78f85d19a7b3623c1acdf6509 Reviewed-on: https://gerrit.libreoffice.org/9447 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-05-21we have GetEntryPos(), use itEike Rathke1-8/+12
Change-Id: Iebb19951efa81817793a155164862076d1198e6e
2014-05-21Split ZCodec::BeginCompression param into its 3 independent componentsStephan Bergmann1-1/+1
Change-Id: I275abafe81c8bb617c70646244b14f6cecc33854
2014-05-21RID_DLG_UPDATE conversion to .uisk941-5/+5
Conflicts: desktop/source/deployment/gui/descedit.hxx Change-Id: Icf9ee3081b468f99833d1e38182887ad1da6f675 Reviewed-on: https://gerrit.libreoffice.org/9417 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-20Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18Julien Nabet30-363/+363
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20SvxRelativeField: set the unit from the passed stringmapMichael Stahl1-4/+10
In the Paragraph "Indents & Spacing" tab there are fields with unit: <object class="svxlo-SvxRelativeField" id="spinED_LEFTINDENT:0cm"> But the unit is effectively ignored, and the resulting SvxRelativeField with FUNIT_NONE and 9999 max somehow results in 0.18cm max when the dialog sets cm as unit. Change-Id: I6001c93079fd7d899f1e119913b29ea4898b1c34
2014-05-20fdo#77282 Replace "Edit Group" with "Enter Group"Laurent Balland-Poirier1-1/+1
Command to enter in a group of objects should be the same in Writer and Draw Update of Help in commit 8944 Change-Id: I39d9c9f9e969978f4084703d2468bdf8a2bf7372 Reviewed-on: https://gerrit.libreoffice.org/8923 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold19-66/+0
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19loplugin:saloverrideStephan Bergmann1-9/+9
Change-Id: I2c1033358c546adefa4e280f0b6cb577ee7e3b25
2014-05-19loplugin:unreffunStephan Bergmann1-7/+0
Change-Id: I54aabdf4a373c3b7163bfc304ee270ab212d738a
2014-05-19svx: SvxPixelCtl should never be able to have zero linesChris Sherlock1-0/+1
Change-Id: I898d4d8f00a190a57d3402aa6c9da96c960b6fe5
2014-05-19Resolves: fdo#78841 crash because parent isn't SvxTabPageCaolán McNamara2-15/+9
regression from 60f11adb950e4f9645cc9ecb0f5af8235cc97366 Change-Id: I244dd9fba3dc8230fcac8710a1289151b25dcf6c
2014-05-19We apparently don't want to build pixelctl for WNTTor Lillqvist1-1/+2
Change-Id: I01bbafe8a73f6cf71c1040f2d94744922154b896
2014-05-19svx: pixelctl demo - cleanup headersChris Sherlock1-8/+0
Change-Id: I9664a064789f5e072d24cfead6a83d64accce27d
2014-05-19svx: Create pixel control (bitmap editing) demoChris Sherlock3-0/+203
Change-Id: Id2cacd8c080b4df0600ab48b2ce4558f3539bbbe
2014-05-18Correct prefixMaxim Monastirsky1-5/+5
Change-Id: I767501475b0b826a76a8743513c60f25e70dea8a
2014-05-18Fix last color detectionMaxim Monastirsky1-1/+1
Change-Id: Idb0f90a3f2100211689c3ede1dfedda86edb9728
2014-05-18That's actually a pointerMaxim Monastirsky1-3/+3
Change-Id: I9d6333646f8ef366f63ff09e089c84517d9756e7
2014-05-18fdo#46839 Convert line color picker to split buttonMaxim Monastirsky5-81/+93
Change-Id: I4987cc9ffba675009f2d2ae9f6b12ed4ee02fe13
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante5-9/+6
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17fdo#78149: set the ViewPort even when painting to a MetaFileMichael Stahl1-1/+3
ObjectContactOfPageView::DoProcessDisplay() has a special case for painting to MetaFiles, and does not set the ViewPort from the passed-in RedrawArea unless it's a printing or PDF export, with the result that for a plain MetaFile all fly-frames in a Writer document are painted, whether visible or not. Since e2eda70f2746f08376d8cdf5e5360df217335aef now calls GetPreviewMetaFile() after every document load, this issue is more visible. Since there is no obvious reason to ever ignore a passed RedrawArea, simply always use it for the ViewPort, not just when printing. Change-Id: I256710f1476181f567069b45a2a494b0d2064d6b
2014-05-16unused XGradient::VclGradientMiklos Vajna1-16/+0
Change-Id: Ia0c416ce7c1323f9c0c20b969bd57e9a2174a3dc
2014-05-16more SvxLanguageBoxBase interfacingEike Rathke1-4/+97
Change-Id: Ife9317d40756099ae4d8ecb84cccea91bd75a14c
2014-05-16strangely obvious leaky codeCaolán McNamara1-0/+1
Change-Id: I968cbb784d53e0cff0649061c58f752939226a09
2014-05-16ODF filters: fallback glTF model to bitmap for older versionsZolnai Tamás2-1/+7
Change-Id: I33161401a29f511e61429355dd2905d4643fe8ff
2014-05-16clean up, remove eof commentsThomas Arnhold2-8/+0
Change-Id: I166e781cb54181a8e5d08021cf5f6dfcd1fde5cb
2014-05-16introduce SvxLanguageBoxBase, SvxLanguageBox, SvxLanguageComboBoxEike Rathke1-75/+205
In preparation of having a language box available as ComboBox to be able to add language tags. Change-Id: I5af5ea5bb06e558db1fcf9c0668be274d5cec04e
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold96-257/+258
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-14Keep only one class for toolbox color controlsMaxim Monastirsky4-421/+101
instead of 5 (mostly identical) classes. Also the following bugs were fixed: * All pickers now use split buttons. (fdo#45671) * Color palette now indicates the current color. (fdo#73891) (Previous changes related to that bug are reverted as part of this commit.) * Selecting a color from a float panel now updates the button. (fdo#77683) * For Font color/background color in Writer, the color that is shown on the button, is always the one that's actually used. (Can be a different color after hiding the toolbar.) * For Font color/background color in Writer, the button now indicates when we're in the format paintbrush mode. (Removed in 085e8a07e61ef2d3a82e11094d8773ab17cfdb3c for some reason.) Change-Id: Idb4829552240c52fb0882aca627c8177bbe2f839
2014-05-14Revert "fdo#77683 the color in the toolbar buttons doesn't change."Maxim Monastirsky1-2/+7
This reverts commit f5dc536eae7dc28e09112ab9dd69e55fae015ee8. This commit actually created a regression. A split button supposed to show the last used color, not the current one. I'll try to solve fdo#77683 in a different way, in a following commit. Change-Id: I5df1ce49995e4755f54af977ca25d4e4dfdee629
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin2-2/+2
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-13unused XFillStyleItem ctorMiklos Vajna1-5/+0
Change-Id: I28497670242a98fba0f5f507a6f634a6fe59c20e