summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin1-2/+2
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6 Reviewed-on: https://gerrit.libreoffice.org/7008 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02fdo#71748 Fix color pickersMaxim Monastirsky2-29/+5
This commit includes the following changes: 1) Remove boxes from PNG files, and draw them ourselves. This will ensure that the color rec will always fit the box. Also it will make all color pickers look the same, and greatly simplify the code. (a part of the code was not reachable anyway.) 2) Fix color preview for toolbar large icons. (a regression of commit f59c47fc1e79050d3342924e6173b0f4b6ddaf02.) 3) Fix sidebar paragraph color picker initial drawing. reset should be called *after* the icon assignment. Change-Id: I13ae02bc3dd68dd14877ccc949784072c58bf211 Reviewed-on: https://gerrit.libreoffice.org/6882 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e239f372c6abcd8371d0a666c828bf1c31195dd4)
2013-11-30mark non-translatable .ui strings explicitely as suchAndras Timar1-3/+3
so bin/ui-translatable.sh will not find false positives Change-Id: I35e98ba22ba8c0cc9bbf0de40b31be421acc4c15
2013-11-20Don't set Referer when accessing embedded mediaStephan Bergmann1-2/+2
Change-Id: I9a1709eb0d5bb81c6c90c4b9f90ff7bed74cda67
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin1-1/+1
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20avmedia: Implement "block untrusted referer links" featureStephan Bergmann6-18/+20
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block untrusted referer links' feature" for details. This adds some further /*TODO?*/ comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not blocked during a slideshow presentation. Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
2013-11-20wrong border extraction mechanismCaolán McNamara1-7/+3
Change-Id: I70925b9e8f5eb0e735200e2f57a892ada9fad379
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OUString::matchAsciiL callsNoel Grandin1-1/+1
Convert code like: defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) ); to: defaultValue.startsWith( "nextval(" ); Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL callsNoel Grandin1-1/+1
Convert code like: if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aByteStr.startsWith("rem")) Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructorNoel Grandin1-2/+1
Convert code like: OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OStringBuffer aKeyName("NDX"); which compiles down to the same code Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-20String clean-upStephan Bergmann1-5/+1
Change-Id: I56c397d4cd0ad6c328d660f50189ab5f4b5cfca6
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin5-35/+22
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin9-32/+32
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19convert equalsAsciiL calls to startWith calls where possibleNoel Grandin1-2/+2
Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin35-109/+107
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin18-47/+47
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-18Simplify avmedia::MediaItem::setURLStephan Bergmann2-6/+6
Change-Id: I9835b96813c6bf3d8690cdaa5de66ca07afdc801
2013-11-18avmedia::getMediaFloater clean-upStephan Bergmann1-2/+2
Change-Id: I76dcf42267cbb1f028d0501471b569fa6b7b91d5
2013-11-16cppcheck: reduce scopeJulien Nabet1-1/+1
Change-Id: Ifa54cc132f0c6591c57639f85e789b08a60b7f4b
2013-11-15convert 500th dialog (vectorize) to .uiCaolán McNamara1-0/+29
Change-Id: Ib1a8716091a16eb970c9f218f4a8e496de72ff51
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann4-7/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-1/+4
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann15-41/+63
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-3/+0
Change-Id: I7eab6d628cd2bd7a68a79ff69ba835f37fc67711
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-13/+0
Change-Id: Icc6ca35623a53449d812e3f09004b926f379c889
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-4/+0
Change-Id: Ib4a334f1e4b77f1f6e0a0b9a736afaf12b61b1be
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-21/+0
Change-Id: I6dc5e1b5e4be546a837b959ab03f248140aeafbf
2013-11-14remove unnecessary sal_Unicode casts in SVX moduleNoel Grandin8-35/+35
Change-Id: I5d39af3bda3f1197fd1d706e7ef8d28b58d4851a
2013-11-13expand out the A2S macroNoel Grandin5-49/+43
Which is not doing anything useful anymore. Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
2013-11-12Avoid too wide sidebar when writedirection controls are activatedMaxim Monastirsky1-65/+65
Achieved by placing the nearby controls into the same box. Change-Id: I28d04c8c3c5b5d9989e30d0ca18ef536640fb87a Reviewed-on: https://gerrit.libreoffice.org/6609 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-11SAL_WARN_UNUSED INetURLObjectStephan Bergmann1-1/+0
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin3-10/+5
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructorNoel Grandin1-5/+5
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-09TypoJulien Nabet1-1/+1
Change-Id: Ifb3b9c7a33b7faccbf7dad1886d953d845de3196
2013-11-08Resolves: #i123616# be more flexible regarding the data type for polygon dataArmin Le Grand1-3/+18
(cherry picked from commit 66c81c1a26d6d09c75c8b8ced44e4a0cf43819ee) Conflicts: svx/source/unodraw/unoshape.cxx Change-Id: I5ebb7b39a083bb6e007853f205bb39d434eb94ad
2013-11-08Make INetURLObject-from-OUString ctor explicitStephan Bergmann2-13/+12
...and clean up call sites. Change-Id: I7219a33652835e82fdc44e9e801a7e62868e4f38
2013-11-08remove unnecessary use of OUString constructor in SVX moduleNoel Grandin34-143/+133
Change-Id: I1506daaa4a3b736ee6bbb00100fca24df8368298
2013-11-08earlier failure in debug modeLionel Elie Mamane1-1/+8
in the case that mpObj.get() is not a SdrOle2Obj* Change-Id: Idff7324242062665c137685096cd82284e24f0d9
2013-11-06Remove #ifdef TIMELOG'ed SAL_INFOsStephan Bergmann1-24/+0
...the code doesn't make much sense that way. Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
2013-11-06Resolves: #i123500# redefined ColorModifiers and ColorModifierStack...Armin Le Grand3-6/+26
redefined GraphicAttr to be expressed as primitives if needed, enhanced render and export quality if graphic is modified using graphic attributes (cherry picked from commit 1e79e8da3f8042f7d7bd94b2c9f03cff7545b05c) Conflicts: basegfx/inc/basegfx/color/bcolor.hxx basegfx/inc/basegfx/color/bcolormodifier.hxx basegfx/source/color/bcolormodifier.cxx drawinglayer/inc/drawinglayer/primitive2d/graphicprimitivehelper2d.hxx drawinglayer/inc/drawinglayer/primitive2d/modifiedcolorprimitive2d.hxx drawinglayer/inc/drawinglayer/primitive3d/modifiedcolorprimitive3d.hxx drawinglayer/source/primitive2d/graphicprimitive2d.cxx drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx drawinglayer/source/primitive2d/modifiedcolorprimitive2d.cxx drawinglayer/source/primitive3d/modifiedcolorprimitive3d.cxx Change-Id: Ief2172efc9cc1b9838de48ec7f536c05573c7dc3
2013-11-06convert xub_StrLen to sal_Int32Noel Grandin2-2/+2
convert for loops using xub_StrLen to use sal_Int32 Change-Id: I5f635ca078966fefe938dbc7e8dea7c8d0d0b554
2013-11-05Resolves: i123564 corrected some aspects when working with bitmaps...Armin Le Grand1-2/+4
with low color depth or small size (cherry picked from commit ba54ce4fc788605fc96235f432b455311faee406) Conflicts: cui/source/tabpages/tpbitmap.cxx Change-Id: I10677414ab7d1904dbb29cd395a0c0334e0faa03
2013-11-05update pchThomas Arnhold2-1/+5
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
2013-11-05presumably this was intended as include guardThomas Arnhold1-3/+0
remove it, as it's nonsense Change-Id: Id8171b81d42dfd3d391b7c5e6602d9271b6697c7
2013-11-04fdo 70998: Termchange: Graphics->ImageSamuel Mehrbrodt2-2/+2
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38 Reviewed-on: https://gerrit.libreoffice.org/6524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin1-1/+1
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin2-2/+2
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin3-15/+13
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03cppcheck: reduce scope in ctredlin.cxxJulien Nabet1-2/+1
Change-Id: I7bdbea6bfadf0f2ce5e3ecb4803929797ebf7af2
2013-11-01Some Trivial clean-upStephan Bergmann1-3/+1
Change-Id: Ie48e8f5cbc455ef267ad756d82f8c0efee0ef065
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 06:26:33 +0000