summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2016-04-21new plugin stylepoliceNoel Grandin6-36/+36
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20Revert partly some of my previous patchesJulien Nabet4-9/+4
to avoid invalidation of end iterators Change-Id: I0970b6d753ee1dd1f4805d0d27b8eb4f8210581b Reviewed-on: https://gerrit.libreoffice.org/24265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-20tdf#99396 SdrTableObj::EndTextEdit: restore cell format undo itemsMiklos Vajna2-0/+17
As seen by the user: after finishing the text edit of an Impress table cell, the text changes are still on the undo stack, but the table ones (like background color or vertical alignment) get lost. This happens as SdrUndoManager::SetEndTextEditHdl() removes all undo items from the stack which are created after the start of the text edit, and creates a single item, but that doesn't include the table changes, just the text ones. Fix the problem by creating a copy of the CellUndo objects when it text edit mode, and pushing them to the undo stack in SdrTableObj::EndTextEdit(), which already writes the undo stack and runs after the undo manager cleared the text edit items from the undo stack. Change-Id: I7d2768c86b5b262e98be1d09d7fa08d581430bb5 Reviewed-on: https://gerrit.libreoffice.org/24264 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann36-167/+167
Change-Id: Iadc107a89e6c489bf5261042ec6853a1354c434d
2016-04-20Replace vector<sal_Bool> with vector<bool>Stephan Bergmann1-4/+4
Looks like the use of these vectors is simple enough to not have to worry too much about the common wisdom to avoid vector<bool>. Change-Id: Ie4d6b51e42365a7c8d1de59a787bb13f78cd2a11
2016-04-20TextCharacterSpacingControl: Fix loplugin:vclwidgets warning.Jan Holesovsky1-7/+6
Change-Id: I16c0f137d4dbf9b495b4be8ca32c009e2676ee0b
2016-04-20character spacing control possible to use outside sidebarSzymon Kłos10-753/+483
Change-Id: Ic0c6458268b529bd0107d6ed5a35f49241cfb833 Reviewed-on: https://gerrit.libreoffice.org/24146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-04-19tdf#99396 SvxTableController::SetVertical: implement undo supportMiklos Vajna1-1/+17
All the table and cell objects know how to undo this change, what was missing is the begin/end undo calls and the broadcast of the cell format change. Change-Id: I3dfd203faf5c579da2937fedab5647129a8e903a Reviewed-on: https://gerrit.libreoffice.org/24247 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-19cppcheck: silence known condition warning in svx tablecontrollerJochen Nitschke1-13/+10
Change-Id: I5c56c99e6b2cc767e0a7a411f9d66f1eee630b2a Reviewed-on: https://gerrit.libreoffice.org/24207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-19cppcheck: silence known condition warning svx xmlexportJochen Nitschke1-32/+27
Change-Id: If2dcb406d7bd1be8f5552ba75b6cabdbb6c97cb5 Reviewed-on: https://gerrit.libreoffice.org/24208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-18Avoid reserved identifiersStephan Bergmann10-117/+110
Change-Id: Ie20bd7a9b3824ce2208d23ded2eae4959dff7bc4
2016-04-18Elide const varsStephan Bergmann1-14/+6
Change-Id: I859614f65afb783004ca9230d3d4bfc354b5afc5
2016-04-18Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: I527143a87c3793dc899ff25a73209e2997116b73
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann3-5/+5
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann4-6/+6
Change-Id: Iee63999e4953a083783cb5c9811640150616472d
2016-04-18reorg to silence coverity#1358586 Using invalid iteratorCaolán McNamara1-4/+3
Change-Id: If93cead2f4caa203b2d1a3e9c787625e6386dc3e
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin34-102/+72
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke25-75/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Use const_iterator when possible (svx/gallery2,items,sdr,stbctrls)Julien Nabet9-29/+28
Change-Id: Idd8992fcb76c25120202b24a23820d85ca09e434 Reviewed-on: https://gerrit.libreoffice.org/24174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-16Give this dialog a meaningful nameAdolfo Jayme Barrientos1-1/+1
Change-Id: I5eb3aae0e02f3587da441b9771d21520fca3f146
2016-04-15Use an iterator for loop to avoid calling n times std::advanceJulien Nabet1-10/+8
Change-Id: I8ba45094cc86cdef07ebbfe334c6c42a108f073e Reviewed-on: https://gerrit.libreoffice.org/24107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-15clang-tidy misc-forward-declaration-namespaceNoel Grandin1-1/+3
Change-Id: I0566e9992e0d96ee710c8bce2ae6f44a9e83b4e4
2016-04-15svx: Remove unused stringsSamuel Mehrbrodt1-28/+0
Change-Id: Ib5e2ae7ba7ca543f0f03ce4296b60ce4bddf75b9 Reviewed-on: https://gerrit.libreoffice.org/24102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14Drawings: Fix capitalizationSamuel Mehrbrodt1-15/+15
Change-Id: I8372b3349c833218e2851c4248187fd0948b75f3 Reviewed-on: https://gerrit.libreoffice.org/23264 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14tdf#70998 Termchange Graphic/Bitmap -> ImageSamuel Mehrbrodt1-16/+16
Bitmap refered to everything that renders into a bitmap internally while graphic can also be svg/metafile. As the common user cannot differentiate this, we'll use the term "Image" for both. Change-Id: Ibf307f8f286a7974d7967a83b85ce62ebafe4ac9 Reviewed-on: https://gerrit.libreoffice.org/23293 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14loplugin:passstuffbyref in svxNoel Grandin21-29/+29
Change-Id: I7d405830785cb12aaceb65d6ed03dda04aa90fd8
2016-04-14Use const_iterator when possible (svx/dialog,engine3d,fmcomp,form)Julien Nabet11-29/+46
Change-Id: Ie08593a3b5b3043a1f212d51d77ced467c309749 Reviewed-on: https://gerrit.libreoffice.org/24064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke2-2/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#99264 svx: don't pass null pointers to SfxDispatcherMichael Stahl1-5/+13
(regression from 51d7f466df85f679f54e4e690f8b5e602192eb7b) Change-Id: I79863f8e5767acc90dc3c6ef5e94d2d90a03dd0e
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke9-29/+29
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12Avoid reserved identifiersStephan Bergmann9-23/+22
Change-Id: I85135c3fa5e6fe823491739c3c1ab601505f0626
2016-04-12Use const_iterator when possible (svx/customshapes)Julien Nabet3-26/+27
Change-Id: Ieb7b3d2eb8cc2626b21508fed3c6c3f01076c792 Reviewed-on: https://gerrit.libreoffice.org/24025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-12Use const_iterator when possible (svx/accessibility)Julien Nabet5-42/+39
Change-Id: I9bdd0a03f69bb92ed668da2ad596e23164d7f290 Reviewed-on: https://gerrit.libreoffice.org/24022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-12Remove INTERFACE_TYPE macro in svx + 1 OUString ctr callJulien Nabet2-5/+2
Change-Id: I25a189fb7fa4271fb12d7a2e35f9a0989087bf5d Reviewed-on: https://gerrit.libreoffice.org/24018 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-12Typo: PopupPanal_Spacing -> PopupPanel_SpacingJulien Nabet1-1/+1
Change-Id: I0a3ab537a9c14ffe49c3b695ba6f40cf16d201d8 Reviewed-on: https://gerrit.libreoffice.org/24015 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke6-12/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in svxNoel Grandin17-24/+24
Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b
2016-04-11Resolves: tdf#98366 paste document has 10x10 sized SdPages...Caolán McNamara1-23/+25
so long lines in them are clipped out in the preview. Change-Id: I355986ff4a9c9e53f8e8f5d41b63f74c633f41ee
2016-04-11cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Ie25240030fd848a5b30526746206bfd5fe543091
2016-04-11loplugin:constantparamNoel Grandin2-4/+4
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-10Typo: multible->multipleJulien Nabet2-2/+2
Change-Id: I1c61841be58d49132ac3c69a6b227d75e829f769 Reviewed-on: https://gerrit.libreoffice.org/23972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-10Typo: rubust->robustJulien Nabet2-2/+2
Change-Id: Icc6bef40a66d5616667d55bf02f10e19153457a7 Reviewed-on: https://gerrit.libreoffice.org/23971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-07Avoid reserved identifiersStephan Bergmann1-6/+6
Change-Id: I63ab4de02702c6f74caa3a65f7d297e2a95a65cd
2016-04-07Avoid reserved identifiersStephan Bergmann2-9/+9
Change-Id: Id04cfda67c128f038d608699285b6f5500698e04
2016-04-07Avoid reserved identifiersStephan Bergmann2-54/+54
Change-Id: I438a7f28ba6bc68ec4e6244a4343e4040ab1b997
2016-04-06tdf#73070 follow-up: Remove also the InsertPropertyPanel code.Jan Holesovsky6-463/+1
The panel is not visible for 2 years now, so remove the code too. Change-Id: Id02de5fb1fda471763b2aac893ef7d0fc61ef1c0
2016-04-05Resolves; tdf#87120 no keyboard navigation inside floating windowsCaolán McNamara2-33/+0
lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. Change-Id: If447429756cf5d136b9c2e2f62fafb37c167b1ce
2016-04-05convert src line width popup to .ui formatCaolán McNamara15-533/+329
Change-Id: I39e8bfd89538c36c97afb3e4e86c3ba9156274e0
2016-04-05loplugin:salboolStephan Bergmann1-1/+1
Change-Id: I6c1910aeb2866d9646f1ea8e53dbd7a8a351a49d
2016-04-05tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar5-18/+18
I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 in order to reduce debug levels. In some places i also used SAL_INFO(..) and SAL_WARN(..) statements to replace their deprecated OSL_ counterparts Change-Id: I73ecc20ffd654501b16820e3bf748f1bcbcdab79 Reviewed-on: https://gerrit.libreoffice.org/23004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 07:02:49 +0000