summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2020-01-16Resolves: tdf#129763 resize to request happening on every activateCaolán McNamara1-5/+8
even though the state remains the same, so only do the resize if the EnableClearFormatButton[All] state changes. also change the default to off, which is what writer typically set it to, and make calc the one that enables it explicitly. Its easier to grow a dialog than shrink a dialog. Change-Id: I449df7b7dcf0204b5143b8ad88e528668b84d0a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86615 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-23don't put focus into unmapped windowsCaolán McNamara1-3/+13
defer until the color selectors are activated to grab focus, otherwise esc doesn't work to close a dialog under gtk3 until focus is put into some visible widget Change-Id: I297c2738c4103024bbefd70bbcb5d72b8429dd3e Reviewed-on: https://gerrit.libreoffice.org/83917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e55a1dc163165cb79fc9113101d16ee8d3db7298) Reviewed-on: https://gerrit.libreoffice.org/83966 (cherry picked from commit 794d5a3bb225bbfaced4dd968734783f073ba70b) Reviewed-on: https://gerrit.libreoffice.org/84523 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-17tdf#111922 Fix Position&Size sidebar Height/Width order of magnitudeGabor Kelemen1-6/+6
Change-Id: Ib279199cdca58911b989a146d60ce764742e5008 Reviewed-on: https://gerrit.libreoffice.org/83843 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit a573829438bf4a3dc43e8774bfe4e29989e2e352) Reviewed-on: https://gerrit.libreoffice.org/83980 Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit baa365141e8b3c619c7de0b01612ffe0cc3885c7) Reviewed-on: https://gerrit.libreoffice.org/85236 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-17tdf#127481 don't override SdrText::GetItemSet() for cellsThorsten Behrens2-7/+0
No point in overriding GetItemSet() with behaviour similar to parent class (but less robustly so). Change-Id: I2bdff44bfded0a5fa272964b4e0671cacb125f06 Reviewed-on: https://gerrit.libreoffice.org/85148 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 4ddd76a7324c8b035e60a12ac06cf08339f6e366) Reviewed-on: https://gerrit.libreoffice.org/85210 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit d99c2dad7f8479bbbef2a1c1883fadf580200d6a) Reviewed-on: https://gerrit.libreoffice.org/85226 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-12-11Resolves: tdf#129250 move redline type into RedlinData so we can sort on itCaolán McNamara1-3/+20
Change-Id: Ia8e6744c1679655240a9a9cee9425030e994e16b Reviewed-on: https://gerrit.libreoffice.org/84808 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-03Resolves: tdf#99711 update metric for spinbuttons before setting their valuesCaolán McNamara1-1/+1
which avoids the rounding problem Change-Id: I7e6a700037661ded1ba73d08009b9279ee12a140 Reviewed-on: https://gerrit.libreoffice.org/84364 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2019-11-22LinkWarnDialog "ask" checkbox should be aligned with contentCaolán McNamara1-1/+1
there is a special argument to MessageDialogController to acheive that Change-Id: I0990cdc1f07479c23184e9b70914e611708dbd96 Reviewed-on: https://gerrit.libreoffice.org/83202 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-21rhbz#1773525 reducing the amount of saved search/replace entries didn't workCaolán McNamara1-3/+6
Change-Id: I1512ef507130718859271079e603a95cf2105c58 Reviewed-on: https://gerrit.libreoffice.org/83091 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-11-21rhbz#1773525 wrong elements removed from saved entries when limit hitCaolán McNamara1-7/+7
Change-Id: Iaf8a012ffe927cbf38789e97b469d899e7cbf87b Reviewed-on: https://gerrit.libreoffice.org/83096 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-11-21If a SdrOle2Obj object is missing/broken show the preview set for itCaolán McNamara1-0/+8
if the object isn't valid, e.g. link to something that doesn't exist, set the fallback graphic as mxGraphic so SdrOle2Obj::GetGraphic will show the fallback, otherwise the failing mxObjRef.is test in SdrOle2Obj::GetGraphic means it doesn't get used Change-Id: I8f1aea6b25dc216e01a0f888a44d10876bb1bebd Reviewed-on: https://gerrit.libreoffice.org/83329 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-18Related: tdf#128104 extend popup handler to cover all CommandEventsCaolán McNamara3-5/+6
Reviewed-on: https://gerrit.libreoffice.org/80021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 947150821e985c255f6c802322e696eff4257a5d) Change-Id: I26360ce5c696d0e571385d83a15876eb2286e12f Reviewed-on: https://gerrit.libreoffice.org/82741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18Resolves: tdf#128104 Input Engine events are delivered via CommandCaolán McNamara1-0/+6
so editengine needs to get those events too. Change-Id: I528065ef804f0a2dfa98e49034c86e9483bade2d Reviewed-on: https://gerrit.libreoffice.org/82720 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-05tdf#121963 apply GridOffset in isPrimitiveVisibleArmin Le Grand1-1/+25
Need to take evtl. GridOffset into account for Controls in ViewObjectContactOfUnoControl::isPrimitiveVisible to get same coordinates inside adjustControlGeometry_throw Change-Id: Id6f0d1c7a4de4ee5908b50ee1a2217a0b078ecf5 Reviewed-on: https://gerrit.libreoffice.org/82031 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit fd2174d55dadc3b4dcf6b15b5789077bb2951698) Reviewed-on: https://gerrit.libreoffice.org/82050 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-03setting has-default true on an element in a GtkPopover is fatalCaolán McNamara1-6/+8
in gtk 3.24.12 at least. in ColorWindow explicitly track which button is the 'default' one for the two modes instead of using get/use-default and then just grab_focus instead of setting has-default for these popover cases Change-Id: Ia226f847f666d2356c6ea4e8c47f5db8e2535410 Reviewed-on: https://gerrit.libreoffice.org/81835 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-01tdf#128454: Make it possible to delete a table's single row or columnTor Lillqvist1-2/+2
It is already possible to delete all rows or all columns when there are multiple ones. So why it should be impossible to delete the single row or column when there is just one I can't understand. (This change is just one way to provide a workaround for the bug; the ideal would be if it was possible to specifically delete a whole table also in Impress documents, not just Writer ones.) (The change is only for the LibreOfficeKit use case, but maybe it should be in all cases.) Change-Id: If9221d248d59e515a110ff94cfb96fdd76aecafb Reviewed-on: https://gerrit.libreoffice.org/81801 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit f4594ae70f3bcde7a87ec606030ec5217ba53788) Reviewed-on: https://gerrit.libreoffice.org/81868 Tested-by: Jenkins
2019-10-30Prepare for builds against ICU 64Eike Rathke1-0/+29
ICU 64 adds new scripts and Unicode blocks from Unicode 12 that need to be handled. This adds 9 new resource strings that will show up for translators, but are not really necessary to be translated; unless a distribution actually builds against ICU 64 they won't be displayed and even then only in very rare circumstances (in Special Characters for fonts containing the glyphs of these new Unicode blocks, unlikely). TDF builds will not be affected as they are built against internal ICU 63. Change-Id: I3cfdf6d2a4c6a56deb72ef837175ad48b1f521b5 Reviewed-on: https://gerrit.libreoffice.org/81714 Tested-by: Jenkins Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-30tdf#126060 Handle text camera z rotation while pptx import.Gülşah Köse4-4/+66
Reviewed-on: https://gerrit.libreoffice.org/80587 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> tdf#128209 Add check for crash handling 3D rotation. Handling text 3D z rotation works only for custom shapes. Prevent to use it for other services. Reviewed-on: https://gerrit.libreoffice.org/80974 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> 49e0127419dbad8a75f1899db02115a2fe54aacd Change-Id: Ifa4589fb50affc4c5ffb52288db8533c98ec6dd9 Reviewed-on: https://gerrit.libreoffice.org/80928 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-24tdf#127411 improve sizing of status items in the status barNoel Grandin1-1/+5
Change-Id: I6ea3fbb893d0141010ee1abd1720d6cdad97b528 Reviewed-on: https://gerrit.libreoffice.org/80440 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit faa4ebb2cdc99505e9be7e1cbed83b19acfd3c4a) Reviewed-on: https://gerrit.libreoffice.org/81449 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2019-10-24Resolves: tdf#128313 disambiguate flow-to search resultsCaolán McNamara1-3/+21
for a11y between find/replace where our result is a single thing, and find-all/replace-all where the result is potentially many things, which allows that searching in a selected calc column will flow-to the current cell, not the entire ~infinite set of cells in the column plus commit... put together the 'magic' flow-to constants as a side note, there's no actual use of FORSPELLCHECKFLOWTO anywhere that I can see Change-Id: Ib3e56fceb90d869f157427f090cdffe986a5a588 Reviewed-on: https://gerrit.libreoffice.org/81397 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-10tdf#127676: avoid flickering in line width popupXisco Fauli1-0/+5
Change-Id: Ie69a5b4d33d12316e6fd7e443b92851cffc95b8c Reviewed-on: https://gerrit.libreoffice.org/79667 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 25cc6dcef22e51c1bfa01e8fbed5046439bb1428) Reviewed-on: https://gerrit.libreoffice.org/79748 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-08tdf#83618 Make line spacing values agreeJim Raykowski1-1/+3
Change-Id: I372a673bbad442d28314498248b12ce7f86fce09 Reviewed-on: https://gerrit.libreoffice.org/73737 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1) Reviewed-on: https://gerrit.libreoffice.org/80314 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-27Resolves: tdf#127218 allow changes dialog to shrink when button text changesCaolán McNamara1-3/+10
original the dialog has super wide button contents when the initial size is calculated, and then the buttons are changed afterwards, but the dialog remains at its initial size. Change-Id: Ib29ab9ebdec01a93561a8b304572df60b6ad5ad2 Reviewed-on: https://gerrit.libreoffice.org/79635 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-25tdf#127701 Zoom factor percentage calculating faultNoel Grandin1-2/+6
regression from commit c53f3f8f58f55d0978fb968446975856d72a52f8 tdf#126819 Can't retrieve the mouse position written in the statusbar note that this is a workaround - we fire an sfx2 event when we choose one of the "smart" zoom options, and normally we then receive another sfx2 event to notify us of the real zoom value. But when we choose the same smart option twice, we don't receive the second sfx2 event. Change-Id: I31c2e34ff31a4f4e03a447ffbd783589982edc57 Reviewed-on: https://gerrit.libreoffice.org/79516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e39ddbdb5b6f49e3585a03444dce077709b855e6) Reviewed-on: https://gerrit.libreoffice.org/79557
2019-09-17Resolves: tdf#126935 a11y for hosted EditEngineCaolán McNamara2-0/+1409
move it to svx so we can reuse the a11y code in svx for EditEngines hosted in shapes to provide a11y for EditEngines hosted in a native widget Change-Id: I4068c413cdb8ddb0d0ef899774fbe9f65e1bdc60 Reviewed-on: https://gerrit.libreoffice.org/78545 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-13use common WeldEditViewCaolán McNamara2-142/+21
Reviewed-on: https://gerrit.libreoffice.org/74705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2cebba0e4042ca2cab37cf38874c2576c2ac6a6f) Change-Id: I873cb64a167027030c9eeef61344e6f6f885a924 Reviewed-on: https://gerrit.libreoffice.org/78544 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-10tdf#127372: PPTX: Shape's background transparency changes during RTTamás Zolnai1-3/+2
Need to use a better null value for FillTransparenceGradient. Use black-black which has equal effect than having no transparency at all. XFillFloatTransparenceItem has also an enabled attribute, but it can not be accessed via the UNO API. We can acces only the gradient object, so with a better null value we can check whether the API attribute is actually set or not. Change-Id: I480489f588376582f80d5062145b7f398ef61ad7 Reviewed-on: https://gerrit.libreoffice.org/78657 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/78691 Tested-by: Jenkins
2019-09-08tdf#126184 Use max paper dimensions to calculate clip regionMichael Weghorn1-3/+7
Assuming at least A4 for the page size isn't enough if e.g. A2 or larger is used, so too much was clipped in that case. Therefore, use the the maximum paper width/height instead, which is 6 m by default. This is still far from the 19 km that caused tdf#63955 and I cannot reproduce tdf#63955 with that new limit. A big thanks to Regina Henschel for the great analysis in tdf#126184! (Side note: Comments 18 and 19 in tdf#63955 suggest to do the whole clipping elsewhere, so if anybody wants to take a look at this...) Change-Id: Iccacad621675df6c7b4477182d7332c4a3d67139 Reviewed-on: https://gerrit.libreoffice.org/78690 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1dccd6814f1fe7a06f3168d01d18d347269cd3c1) Reviewed-on: https://gerrit.libreoffice.org/78759
2019-09-05tdf#93998 toolkit: restore support for setting dialog background from shapeMiklos Vajna3-5/+38
Regression from commit fb29e6eeeaad5255bb924ff59162a83ed80bfb0a (svx: removing GraphicURL and OWN_ATTR_GRAFURL, fix writerfilter, 2018-03-08), the problem was that an in-document macro tried to assign a bitmap shape to a dialog background, which broke during the image handling rework. Note that in this case the actual type of the "URL" is not interesting, we can just return an XGraphic and then take it on the other side as well, without re-introducing the intentionally removed graphic URLs which point to memory addresses. This also made it necessary to extend UnoDialogControl::ImplModelPropertiesChanged(), so that in case a graphic is assigned to the dialog model, then the dialog model -> dialog sync code doesn't just copy over the empty image URL string. With this, finally clicking on the button of the bugdoc makes the dialog show up with the correct background. (cherry picked from commit 3341986547b69bcb4c38e4ccb2f0853a3a569bb5) Change-Id: Id78269643289efb435b96a6a0b9f8a93fa49ec04 Reviewed-on: https://gerrit.libreoffice.org/78171 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-29tdf#125340 transport preferred dialog parent down the migration dialogCaolán McNamara3-3/+4
Change-Id: Icb7bab35eac3ae08fb82d73f559ef161dd1820c3 Reviewed-on: https://gerrit.libreoffice.org/77638 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-22tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()"Regina Henschel1-27/+44
This reverts commit 26001f4f84b0d921c8612d888856613735ba5314. Change-Id: Ib4df476b405e65be9203ab376c9c68b03198c040 Reviewed-on: https://gerrit.libreoffice.org/77882 Tested-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 59189f3e02acbdf4e5bbd35fc278252b30022f43) Reviewed-on: https://gerrit.libreoffice.org/77939 Tested-by: Jenkins
2019-08-19tdf#126819 Can't retrieve the mouse position written in the statusbarNoel Grandin3-11/+33
regression from commit 77e260f915e0c77ddb1e915e9fd27ab0bdccc763 Date: Mon Jul 8 11:22:12 2019 +0200 tdf#121793 speedup VCLXAccessibleStatusBarItem::GetItemText Make the custom StatusBarControls set better text on their parent StatusBar. Also remove some unnecessary work being done in the Paint methods, to reduce confusion. Change-Id: I3b0a0af3b01d3b01f85ab335a3eb5993c07a50f4 Reviewed-on: https://gerrit.libreoffice.org/77586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c53f3f8f58f55d0978fb968446975856d72a52f8) Reviewed-on: https://gerrit.libreoffice.org/77697
2019-07-31tdf#126605: Do not end TextEdit when changing an attributeXisco Fauli1-2/+0
otherwise, pTextEditOutlinerView becomes nullptr in svx/source/svdraw/svdedxv.cxx:2184 Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921 Reviewed-on: https://gerrit.libreoffice.org/76609 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-15tdf#120495 Providing self adapting height to the Area section of SidebarSumit Chauhan1-0/+18
This problem comes when we switch between different fill tabs in area sidebar and this patch solves the issue. Change-Id: I09936e600214394d26a27d26d47be3ef9942b65f Reviewed-on: https://gerrit.libreoffice.org/67577 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 347afce3a997291313fd88843ba248ccbbcb3990) Reviewed-on: https://gerrit.libreoffice.org/75483 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-03tdf#126180: EndTextEdit on all views before delete/cut slideXisco Fauli4-21/+40
This also reworks the fixes tdf#125824 and tdf#111522 to use EndTextEdit instead of blocking the undoing Change-Id: I73c2289a9d950465f020f684e9e736148380f5c5 Reviewed-on: https://gerrit.libreoffice.org/74989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e6c7a018a0cfee395ce2886d41c908a2447ef5cc) Reviewed-on: https://gerrit.libreoffice.org/75027 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-01tdf#125824 svx: fix crash with view1 and view2 doing texteditXisco Fauli1-1/+1
Similar to 3a874f1c80c37e8b35666e1d73161ff762eb7e4c Change-Id: I51bffa4d33e82bb90b8a42787f55c12746bcd8c2 Reviewed-on: https://gerrit.libreoffice.org/74931 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 091f573728e7951d5dc4ef138117499b7480885f) Reviewed-on: https://gerrit.libreoffice.org/74948 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-28tdf#126137: Do not dereference non-existing ObjectXisco Fauli1-1/+1
Regression from dfefe448c41921f2f1e54d3f69b8b9e89031d055 Use same logic as in c28ec6d9fbb21b363102faac0171de2754ea5d75 Change-Id: Ia489eb61873d38c31729fedb853b11570e562123 Reviewed-on: https://gerrit.libreoffice.org/74811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b653f21313f3b8ff9da99897e3a0c2df4a685b60) Reviewed-on: https://gerrit.libreoffice.org/74826 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-23Resolves: tdf#126039 erase old content before drawing new contentCaolán McNamara1-0/+3
Change-Id: I0006467f5c172b6a0cb8b9bc4c9a0181fd57a8ac Reviewed-on: https://gerrit.libreoffice.org/74584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-22weld SpellDialogCaolán McNamara3-9/+9
a) use EditEngine instead of TextEngine as the former can be hosted in a foreign widget b) use a SfxGrabBagItem to hold the custom spellchecking info inside the EditEngine c) in longer paragraphs the current word is now auto-scrolled into view d) rename Invalidate to InvalidateDialog Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1 Reviewed-on: https://gerrit.libreoffice.org/74535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-19tdf#125782 use correct 'current point' for quadraticcurvetoRegina Henschel3-17/+31
Use the same way to get the 'current point' as in command arcangleto. The error was visible in shape teardrop. Change-Id: Ie7af2b9111150bae7e3ea492eeb439a0cc2bfe7c Reviewed-on: https://gerrit.libreoffice.org/73723 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 39599fc689364b70cf83e834a5742cc2181b13b0) Reviewed-on: https://gerrit.libreoffice.org/74253 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#120170 Prevent escape key press focus to documentJim Raykowski2-3/+8
...from style, fontname, and fontsize comboboxes used in sidebar tool boxes when sidebar is undocked Windows build does not show this bug but Linux does for SAL_USE_VCLPLUGIN's gen, gtk, and gtk3. This patch checks the combobox parent object type for type sidebar tool box and if so skips the release focus call that sets focus to the frames container window which incorrectly sets focus to the document for Linux build. Probably a lower level fix for this but I'm not at that level yet :-) Change-Id: Ie33ea4238f7e8715fbd0389efd9185598a528ced Reviewed-on: https://gerrit.libreoffice.org/72970 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c81055eb075efffa9cd123913a684ac3258903d5) Reviewed-on: https://gerrit.libreoffice.org/74250 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-15remove some unused includesCaolán McNamara1-2/+0
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13Resolves tdf#115858: More button should move the focus to 'Styles' windowMuhammet Kara1-1/+1
Change-Id: I71c834733ff0f3d4b89ecaeecb12631609e84c1d Reviewed-on: https://gerrit.libreoffice.org/73872 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit a025132839b19ba952558b9dbec454c8a34c6489) Reviewed-on: https://gerrit.libreoffice.org/73895 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-10Related: tdf#111522 svx: fix crash with view1 doing textedit and resize/rotateMiklos Vajna2-13/+13
The two actually affected functions are SdrEditView::RotateMarkedObj() and SdrDragObjOwn::EndSdrDrag(), but it looks like the other functions in SdrEditView are safe to be changed the same way. I expect IsUndoEnabled() can't be changed, though: that would mean there would be no undo for the text edit itself, either. If other actions still crash, the pattern is the same: put a breakpoint on the SdrUndoAction constructor and see the backtrace to find the function that calls IsUndoEnabled() without calling CanDoSdrUndo() at the same time. Change-Id: If9324e311ec6e9f68a951559e903e14bb72ea31c Reviewed-on: https://gerrit.libreoffice.org/73669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 9870ff897f088563426bee9567dd9cb722c2b929) Reviewed-on: https://gerrit.libreoffice.org/73748 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-08weld View3DDialogCaolán McNamara2-0/+1136
Change-Id: Ifd689c54574c08f026f6760efb39b5f927cb2625 Reviewed-on: https://gerrit.libreoffice.org/73706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06tdf#111522 svx: fix crash with view1 doing text edit and view2 doing sdr undoMiklos Vajna2-2/+18
If one view has an active text edit, then current code doesn't handle manipulating the undo text outside the text edit, so avoid problems by simply not adding an undo action to the undo stack for shape creation or move. Other actions might want to do the same in the future: check for CanDoSdrUndo() before calling SdrUndoFactory member functions. [ Found no existing test suite similar to CppunitTest_sw_uiwriter, so added one. ] (cherry picked from commit 3a874f1c80c37e8b35666e1d73161ff762eb7e4c) Change-Id: I3a364bf4fe6f9b0c13aa07283681b1045368cf7a Reviewed-on: https://gerrit.libreoffice.org/73594 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-05tdf#125062: distort hairline borders only if selection is usedXisco Fauli1-31/+35
Regression from 046df0a876b3d948bb1e14443c00c180bc8cccaa Use the fix for tdf#105998 only when 'selection' option is checked in the save dialog Change-Id: I8c4127c780736408e905ead48e0d3ee6ae149197 Reviewed-on: https://gerrit.libreoffice.org/73391 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 6c31c2b01dd32cc7ba1230f2c4a98b8f7def219b) Reviewed-on: https://gerrit.libreoffice.org/73555 Tested-by: Jenkins
2019-06-04Resolves tdf#125333 - Crash with FindReplaceRememberedSearches=0heiko tietze1-0/+2
Zero remembered searches crash the app when no result is found minimum set to 1 Change-Id: Ib2b4b195d018f0f11238699458066f4d128f8997 Reviewed-on: https://gerrit.libreoffice.org/72459 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> (cherry picked from commit def76a088dea12dfd9d9b796e975e742cbe44ce1) Reviewed-on: https://gerrit.libreoffice.org/73431
2019-06-03Resolves: tdf#125589 we are initially unsortedCaolán McNamara1-0/+7
so turn on sorting on first sort request Change-Id: I897f64c0695be8cca6d93e234a7d7c4718c94f78 Reviewed-on: https://gerrit.libreoffice.org/73345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-02drop some unneeded includesCaolán McNamara1-2/+0
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73336 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-02move SvxStandardDialog to last consumerCaolán McNamara2-37/+0
Change-Id: I02638b5a1a3c7a27c19320fedd291bbcb17bb9dc Reviewed-on: https://gerrit.libreoffice.org/73324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 17:21:21 +0000