summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2018-03-29loplugin:virtualdown in svl,svtoolsNoel Grandin2-2/+2
I expect a lot of the overriding methods will be removed as soon as I run the unusedmethods plugin Change-Id: I4fb228724fcfba51a98d2113efb93cec1bc15c7c Reviewed-on: https://gerrit.libreoffice.org/52006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:virtualdown in svxNoel Grandin5-34/+0
Change-Id: I953780a4b2879266c415a3c4e8992c8be74dced4 Reviewed-on: https://gerrit.libreoffice.org/52001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28Translate German variable namesJohnny_M2-26/+26
Akt -> Current in svdraw (Other occurrences will be done separately.) Change-Id: I5dc6b52678b4ce4e875f8c1aaf68e7367bf6e922 Reviewed-on: https://gerrit.libreoffice.org/51799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28tdf#63438 Toggle highlight color to no fill if the same value is activeDaniel1-1/+8
Change-Id: I7553bc7bffeb0a8d1275aadc44bf2813564087b5 Reviewed-on: https://gerrit.libreoffice.org/51794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-27tdf#81925 Make messages show in Findbar searchlabel overflow toolbarJim Raykowski2-3/+43
...and add a bit more horizontal space for messages Change-Id: I4a310d7a4a649860a36ce12b775bb6b275cd6ef5 Reviewed-on: https://gerrit.libreoffice.org/51523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-26tdf#112997 multiple animated gif only one frameNoel Grandin4-23/+20
Not sure what the problem is, but using a vector and just making sure we insert into the right spot for the sorting fixes it. Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63 Reviewed-on: https://gerrit.libreoffice.org/51829 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25clang-tidy modernize-use-equals-default in XPolygonJochen Nitschke2-60/+11
Change-Id: I82a4a56bf02c6ff2495bd7a6058640d77e8c0b73 Reviewed-on: https://gerrit.libreoffice.org/51832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-24Fix typosAndrea Gelmini2-3/+3
Change-Id: I6c515e716b232fecfe1750b806f0a5624f648de5
2018-03-23a11y crash with no chars selected in character mapCaolán McNamara1-1/+2
type gibberish in character map search box, click character map widget, crash Change-Id: Ifa3e4bce2d7e0b84cf3c5033eb819c73076daabe Reviewed-on: https://gerrit.libreoffice.org/51773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23Typo: ImplGetSelectEntryPos -> ImplGetSelectedEntryPosSamuel Mehrbrodt1-5/+5
Change-Id: I19233d37b2d72bef73659ddbb6d116d2632145c1 Reviewed-on: https://gerrit.libreoffice.org/51748 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-23ofz#7065 Integer-overflowCaolán McNamara1-1/+1
Change-Id: Ic8837d21d64dc6fd3623ab5d32bc902e6c34dd21 Reviewed-on: https://gerrit.libreoffice.org/51746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23Typo: GetSelectEntryPosLBB -> GetSelectedEntryPosLBBSamuel Mehrbrodt1-1/+1
Change-Id: Id1706d11143ee60216322db1ac51207e658000e1 Reviewed-on: https://gerrit.libreoffice.org/51749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectItemId -> GetSelectedItemIdSamuel Mehrbrodt12-20/+20
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b Reviewed-on: https://gerrit.libreoffice.org/51750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectLanguage -> GetSelectedLanguageSamuel Mehrbrodt1-2/+2
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2 Reviewed-on: https://gerrit.libreoffice.org/51747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: SplittTable -> SplitTableSamuel Mehrbrodt1-1/+1
Change-Id: I6c5947964b3765ea05debe8837bd2f3dc57ae6ed Reviewed-on: https://gerrit.libreoffice.org/51745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-22tdf#83877 Move SignatureLineDialog to svxSamuel Mehrbrodt5-1/+703
To prepare using from Calc Change-Id: I102ecf2c956922dd1458c99bd7cd7be30f6f5ec4 Reviewed-on: https://gerrit.libreoffice.org/51726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-21support both vcl and weld in genericunodialog for interimCaolán McNamara2-11/+4
Change-Id: Ife85dd7a4bd27260514b390ca3928152db0d688f Reviewed-on: https://gerrit.libreoffice.org/51699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20tdf#116482: Fix for Crash on drawingMohammed Abdul Azeem1-1/+7
Making the drawing layer import to use fastParser. Change-Id: I4ff05d65de525aef3e50676072a79c9c329e6afc Reviewed-on: https://gerrit.libreoffice.org/51673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-20drop unnecessary includesCaolán McNamara2-2/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430074 Uncaught exceptionCaolán McNamara1-5/+11
and coverity#1430066 Uncaught exception coverity#1430095 Uncaught exception Change-Id: Idca2e12d3911e3ea768a2a9fb8e7f3b03a2c887f Reviewed-on: https://gerrit.libreoffice.org/51567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430091 Unchecked return valueCaolán McNamara1-1/+2
Change-Id: Id72d3c6714a8c74502247eed9c23c7cf8b5412f4 Reviewed-on: https://gerrit.libreoffice.org/51543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke6-6/+0
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-18tdf#115228 Terminology TSCPheiko tietze1-1/+1
Renamed some terms Change-Id: Ia23f2490155101d59ef2bb3ce181709bb427197e Reviewed-on: https://gerrit.libreoffice.org/48744 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-17OperationSmiley: Corrected shadowing of local variablesArmin Le Grand1-1/+1
Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa
2018-03-17OperationSmiley: Corrected shadowing of local variablesArmin Le Grand1-2/+2
Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa
2018-03-17OperationSmiley: Removed unused param from SdrPathObj constructorArmin Le Grand1-1/+1
Change-Id: Ia69e822c698ea13650d868472ba63744727ff886
2018-03-17OperationSmiley: Secured quite some places using CustomShapeArmin Le Grand4-1/+5
Changed quite some places of SdrObjCustomShape usage to use references instead of pointers, thus forcing to more secure handling. Changed some test and change methods, even found a memory leak by doing so. Added some incudes/predefines for linux builds. Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7
2018-03-17OperationSmiley: Secured quite some places using CustomShapeArmin Le Grand7-186/+307
Changed quite some places of SdrObjCustomShape usage to use references instead of pointers, thus forcing to more secure handling. Changed some test and change methods, even found a memory leak by doing so. Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7
2018-03-17OperationSmiley: Added support for using same FillGeometryArmin Le Grand5-27/+85
It is now possible to use a single FillGeometry to fill objects that are made of multiple filled objects (e.g. CustomShapes) so that they look as using a single fill. This is used for CustomShapes, but may later be 'extended' to be used for more cases. The basic functionality was already in the primitives, but had to be added to SDrObject due to these being used for CustomShapeVisualization (currently - would be better to change this to primitives, too). Change-Id: I1d9fb158191a9ec663e46f3911213be2f3d88986
2018-03-17OperationSmiley: Remove brightness from SdrPathObjArmin Le Grand2-63/+122
There was a member at SdrPathObj called mdBrightness only for holding a blend value during creation of SdrPathObjs for CustomShape visualization. This has nothing to do on the model data, move it to where it belongs Change-Id: Iee101f90a1275ce1ed97e8e8d0ccf7084c83d4f6
2018-03-16don't bother dithering for 256bit displaysNoel Grandin2-31/+1
which surely are a minority by now Also drop the GetColorCount() method on OutputDevice and clean up the remaining call sites to use GetBitCount() Change-Id: I4e2c6f2523796f7df7f54eb005f1539e34d9ea40 Reviewed-on: https://gerrit.libreoffice.org/51389 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16remove some GraphicObject URL funct. from GraphicImportHelperTomaž Vajngerl1-455/+5
GraphicImportHelper is an implementation of XGraphicObjectResolver which is mostly used to "resolve" a GraphicObject URL to the internal storage URL (and save the graphic to the storage in the process). Most of the GraphicObject URL functionality was removed so the required overrides from XGraphicObjectResolver interface now return an empty result or do nothing. Change-Id: Iee6bb71b15411d03ef82ab4d20d234ff0e834425 Reviewed-on: https://gerrit.libreoffice.org/51331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin1-1/+1
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15weld sort dialogCaolán McNamara1-0/+250
rework huge language listbox into a combobox see https://gitlab.gnome.org/GNOME/gtk/issues/94 and the lack of typeahead/search for lists Change-Id: I4a3af695d86bbcb92e5cdd500c4acb7cfaf37f41 Reviewed-on: https://gerrit.libreoffice.org/51340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15move some GDI import code from svx to vclNoel Grandin1-81/+2
part of making ScopedWriteAccess an internal detail of vcl Change-Id: I916f2ca05c9d7c17b62c91e113df6d8454bb4351 Reviewed-on: https://gerrit.libreoffice.org/51283 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14loplugin:constantparamNoel Grandin4-6/+6
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d Reviewed-on: https://gerrit.libreoffice.org/51273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13SDI: don't #define/#undef names of actual classes for slot headersMike Kaganski1-1/+1
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot of intellisense errors. So, just prepend the define with "ShellClass_" Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e Reviewed-on: https://gerrit.libreoffice.org/51135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-13Translate German variable namesJohnny_M1-8/+8
Akt -> Current in svdibrow Change-Id: I3a3a87fdba179ad927226097c53c4f07d36095e8 Reviewed-on: https://gerrit.libreoffice.org/51033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M1-7/+7
Akt -> Current in svdedtv2 Change-Id: Iae43ec7ccd0a220b0296780bafecd5b4d232c3d5 Reviewed-on: https://gerrit.libreoffice.org/51032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13tdf#114552 Convert anchor toggle to anchor menuSamuel Mehrbrodt1-0/+17
Since we now have three, not two anchor types. Change-Id: I9654de574a9d546d2191093cba9c192fac3cd3d7 Reviewed-on: https://gerrit.libreoffice.org/50987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13tdf#114622 Add Numbering in Arabic-Indic numeralsSuhail Alkowaileet1-1/+4
Fix all comments Change-Id: Ib11662de5cac3b073114ab4425e8f45a0c04c8c8 Reviewed-on: https://gerrit.libreoffice.org/47058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin1-1/+1
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-11weld color pickerCaolán McNamara1-0/+63
Change-Id: I487b9a0cc13b2b60a0f1e28667773b5d3b5c66cc Reviewed-on: https://gerrit.libreoffice.org/51001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-11Move (and rename) graphic stuff from svtools to vclTomaž Vajngerl5-6/+6
This is preparing to change how GraphicManager works where it won't base itself around GraphicObject anymore but Graphic. No functional or cosmetic change was made to the classes, only changes that were needed because of the move and rename. The only thing that wasn't moved is the GraphicRenderer as it is not needed in vcl for now (but makes sense to move it in the future to keep graphic stuff together). grfmgr was renamed to GraphicObject as the GraphicManager will be changed a lot and most likely moved out, so the name grfmgr won't make any sense anymore. All the UNO implementations were renamed with a prefix Uno and used the same name as the class name. This is made to be more specific which are the Uno objects (for example graphic.cxx contained the implementation of XGraphic, which is similar to graph.cxx contains Graphic). Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137 Reviewed-on: https://gerrit.libreoffice.org/51068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11svx: convert XBitmap directly to XGraphicTomaž Vajngerl1-17/+15
Change-Id: If2bd8419d9073625f0392f59f671d70193bf990c Reviewed-on: https://gerrit.libreoffice.org/51048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10xmloff: embedded objects can still use GraphicObject URLTomaž Vajngerl1-1/+1
The embedded graphic object don't seem to use the uniqueID of a graphic object, but seem to have the same URL prefix. Let's leave this in for now. Change-Id: I48d9ad2c3b1eca745911f03221988c46c0fdb8d2 Reviewed-on: https://gerrit.libreoffice.org/51041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10remove references to {Header,Footer,Para}GraphicURLTomaž Vajngerl1-1/+1
Change-Id: I559f25ee99f7b8b49545390479cbb06d3c601d3c Reviewed-on: https://gerrit.libreoffice.org/50982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09Remove unused HIDsGabor Kelemen1-9/+0
These were no longer used in the code. This should help me in identifying obsolete and missing HIDs in helpcontent. Found by this somewhat sophisticated method: for mod in $(find -name helpids.h) ; do echo $mod; for i in $(grep ^#define "$mod" | cut -d " " -f2 ) ; do if [ $(git grep -c "$i" $(echo "$mod" | cut -d "/" -f 2 ) | wc -l) -eq 1 ] ; then echo "$i"; fi ; done done Change-Id: Iaf8179322419ce51175bc5a42fedec0add8c5241 Reviewed-on: https://gerrit.libreoffice.org/50680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-09svx, compile error with !HAVE_FEATURE_DESKTOPjan Iversen1-0/+4
solved unused parameter referer in case of !HAVE_FEATURE_DESKTOP Change-Id: I64e2707ad87822ba784ed40c45801c6d101e6386
2018-03-09give color picker explicit parentCaolán McNamara2-3/+4
Change-Id: I73e9a29abd5d767b31850e9a6b1f2b8d757ee928 Reviewed-on: https://gerrit.libreoffice.org/51000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-23 20:22:24 +0000