summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2013-08-23Work around -Werror=unused-local-typedefs from comphelper/stl_types.hxxStephan Bergmann1-7/+5
Change-Id: Id9f588e551b40a64bc86cae7c6d50f99659f94ab (cherry picked from commit 3912e47044f753f82c63ac11e803be5fb756c14f)
2013-07-30fdo#55955 select first column if possibleLionel Elie Mamane1-0/+6
Change-Id: I131cb0395c481d9cc1de210abc207221dab14bf4 Reviewed-on: https://gerrit.libreoffice.org/5179 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-07-15fdo#57631 fix collection of property statesDavid Tardon1-10/+2
Change-Id: I607518da26c9430916d922b8e36143cc6dd76f25 (cherry picked from commit d3d95afe5856ef06659d61c3572c7682e5a03766) Signed-off-by: David Tardon <dtardon@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/4912 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-06-28resolved fdo#35756 import more than 64k HTML table cellsEike Rathke20-97/+96
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used also in RTF import Calc and Writer, so that could benefit as well. * changed all EditEngine,Outliner,... related paragraph index/count variables from sal_uInt16 to sal_Int32 * sal_Int32 instead of sal_uInt32 to match accessibility API * matched some Outliner methods' paragraph parameters from sal_uLong to sal_Int32 * containers capable to hold size_t nevertheless are limited to a maximum of sal_Int32 * changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to SAL_MAX_INT32 + added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize ESelection with what previously were hard coded 0xFFFF all over the place + for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL to initialize an ESelection spanning all available text like aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL) Reviewed-on: https://gerrit.libreoffice.org/3838 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8) Conflicts: editeng/inc/editeng/editeng.hxx editeng/inc/editeng/outliner.hxx editeng/inc/editeng/unoedprx.hxx editeng/inc/editeng/unoedsrc.hxx editeng/inc/editeng/unofored.hxx editeng/inc/editeng/unoforou.hxx editeng/inc/editeng/unotext.hxx editeng/source/accessibility/AccessibleHyperlink.cxx editeng/source/accessibility/AccessibleHyperlink.hxx editeng/source/editeng/editeng.cxx editeng/source/editeng/editobj.cxx editeng/source/editeng/editobj2.hxx editeng/source/editeng/impedit.hxx editeng/source/editeng/impedit3.cxx editeng/source/editeng/impedit4.cxx editeng/source/outliner/outleeng.cxx editeng/source/outliner/outleeng.hxx editeng/source/outliner/outliner.cxx editeng/source/outliner/outlvw.cxx editeng/source/uno/unoedprx.cxx editeng/source/uno/unofored.cxx editeng/source/uno/unoforou.cxx editeng/source/uno/unotext.cxx include/editeng/editobj.hxx sc/inc/editutil.hxx sc/qa/unit/subsequent_filters-test.cxx sc/source/core/data/cellvalue.cxx sc/source/core/tool/editutil.cxx sc/source/filter/xml/xmlcelli.hxx sc/source/ui/unoobj/fielduno.cxx sd/source/ui/inc/OutlineView.hxx sd/source/ui/view/drtxtob1.cxx starmath/source/accessibility.cxx starmath/source/accessibility.hxx svx/inc/svx/svdoutl.hxx svx/source/accessibility/AccessibleEmptyEditSource.cxx svx/source/sdr/properties/textproperties.cxx svx/source/svdraw/svdoutl.cxx Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00 Reviewed-on: https://gerrit.libreoffice.org/4368 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28fix text position for custom shapes with zoom != 100% fdo#59862Noel Power1-1/+3
custom shapes that had text suffered from strange display at zoom levels != 100%, this was because there was a bug in the code to correct the textposition Change-Id: I8d1817cc6be91b3e6379200eb21eb2966d3c2aa9 (cherry picked from commit 443c13e92c6f900a41e6e383684623ead3e088f5) Reviewed-on: https://gerrit.libreoffice.org/4515 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-27fdo#58029: replace quadratic child window loop with linearMichael Stahl3-22/+40
... which should speed things up without introducing problems. (Window::GetChild(n) is inefficient because the children are a linked list) Change-Id: I343d51a6866c5014cbca4c256b0c15f938958c39 (cherry picked from commit 38dcfadda85058a0ee87292c8943aec82e34b81e) Reviewed-on: https://gerrit.libreoffice.org/4491 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-06-27fdo#60444: Revert "fdo#58029 - substantially accelerate re-rendering..."Michael Stahl1-4/+17
This reverts commit 6c98ad71478cb72b51634b32d6e553ccaec30190. This breaks selection of transparent form controls (fdo#60444), because the Update method is not called on the children. Change-Id: Id0b6a34a15aa1ed7bd5aa0d7b5626e60bee57e30 (cherry picked from commit f022f39638fbe970f1b839c757dcccd3baa69445) Reviewed-on: https://gerrit.libreoffice.org/4490 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-06-24FmGridControl: handle non-existing propertiesMichael Stahl1-1/+8
Fix crash with unhandled exception requesting "Description". Change-Id: I6b6cb61273fb042532ab63620729f4129239fe81 (cherry picked from commit 32e2c6456fb3bf3bf75f9b11c90193c537b4ef26) Reviewed-on: https://gerrit.libreoffice.org/4399 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-06-19fdo#62224 set spacing to content tooDavid Tardon1-0/+42
(cherry picked from commit 14c139e3705c537556f493657f9cb01818d1f80d) Change-Id: Idafcd96ff8b01139dfc22cf3d0d2f5e98759488e Signed-off-by: David Tardon <dtardon@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/4358 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-19fdo#62224 reconstruct border state for table dialogDavid Tardon2-1/+226
Change-Id: I68a4cd1974579119a2d6dccba008441a9bec78df (cherry picked from commit 67e87f8b88a5a6a741717cc4a8e64f65f9c9cd52) Conflicts: include/svx/sdr/table/tablecontroller.hxx Change-Id: Id9d72360d234dd1f9dbb9fd252fc0abefff9ad63 Reviewed-on: https://gerrit.libreoffice.org/4144 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-03copy values from the original item setDavid Tardon1-1/+2
... because SfxAbstractDialog::GetOutputItemSet() only contains the items that have been _changed_ in the dialog. Change-Id: Iaf20bb42b65e420fe4e7aff979378eff7b5e5df2 (cherry picked from commit 9cd71f996e3625e8174c46bf85e336c1ee90df7f) Change-Id: I9100dbe05c418a9dd1b819534a08076c9a4aed1c Reviewed-on: https://gerrit.libreoffice.org/4145 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-30WaE: 'static_cast' : truncation of constant valueTor Lillqvist1-1/+1
Change-Id: Icbb624b1441330406c0930aa6f1f15ffc9b138b8 (cherry picked from commit f55c6464fb9ee3ff8c011e815e0b75162ebea3fd) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2013-05-28fdo#64279 do not crash opening report for editingDavid Tardon3-3/+40
There are two problems: 1) The classes derived from SdrObject cache their SvxShape, but do not implement impl_setUnoShape(). 2) There is a lifetime issue in association of a SdrObject and its SvxShape. SvxDrawPage::CreateSdrObject not only creates a new SdrObject for a shape, but also inserts it into the page. At this point, the shape has not been attached to the object yet. That means that the object creates another shape at one point during the InsertObject call, which is then destroyed again. But reportdesign shapes own their objects, which means that destuction of the shape causes destruction of the object too... My first idea was to disable the insertion in SvxDrawPage::CreateSdrObject, but it has been there since the dawn of time, so I did not gather the courage to do that. Instead, I put in a hack to allow to skip the insertion. Change-Id: I888a54067be1934578434d8b476a13a7ff8d02b3 (cherry picked from commit 02d03eb4ad6e64744659c5fe04282b25b66c28d8) Signed-off-by: David Tardon <dtardon@redhat.com> Conflicts: include/svx/svdobj.hxx Change-Id: I36406f399092c2c85278633d2ee7c953fc76f1bc Reviewed-on: https://gerrit.libreoffice.org/4071 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-05-24fdo#63311: Unable to delete text from Shape.Muthu Subramanian1-7/+4
This avoids setting null as text to the shape. [empty_text seems to be the initial value of text for shape rather than null - something recent? We also seem to export empty <text> entries because of this] (cherry picked from commit 19b217505d094577392d8712b9d07f29b3de2081) Signed-off-by: David Tardon <dtardon@redhat.com>
2013-05-17fdo#57079: SvxSuperContourDlg: unregister configuration listenerMichael Stahl1-0/+2
... in destructor. Otherwise it will access freed memory when eventually called. This crashes since OOo 3.2 but no idea why it would appear to not crash in earlier versions. Change-Id: Ie3ab7ddf19fb1086f0b7d824555ab6b063e2b9ad (cherry picked from commit fc63700181ab0f42eab5f98328074fe1682344f8) Reviewed-on: https://gerrit.libreoffice.org/3937 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-17fdo#62965: fix crash in Edit Contour dialogMichael Stahl1-1/+1
The pObjList is 0, so use pObj's GetModel() which should be the same. (regression from 115054fef08998c56cba8f14472df1d15007f635) Change-Id: Ib20e1806518f7b3b33d3fb4472d79d531ea9f1de (cherry picked from commit 71f990d286c603b3bf220c8d93af69f04a45dd7a) Reviewed-on: https://gerrit.libreoffice.org/3936 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-15fdo#63695 revert hackish fix to i#51621Lionel Elie Mamane1-2/+3
Change-Id: I688a659207c4b95cc98ff5dc5c5622d4592b3f89 (cherry picked from commit 7fd1cc18130464a9f09cb7a866e88c4d52e4716d) Reviewed-on: https://gerrit.libreoffice.org/3864 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-05-14fdo#63398 hardcode former list of oneway methodLionel Elie Mamane1-18/+536
adapt to disappearance of oneway qualifier for method by hardcoding list of methods that were oneway. Autogenerated by the following script: SKIP=1; git log -p -1 90eac3e69749a9227c4b6902b1f3cef1e338c6d1 | while read f0 f1 f2 f3 f4; do if [[ "$f0" == "---" ]]; then if printf '%s' "$f1" | egrep -q '^a/(off|udk)api/.*\.idl$'; then LISTENER=$(printf '%s' "$f1" | sed -re 's@^a/(udk|off)api/@@' -e 's|/|.|g' -e 's@\.idl$@@'); SKIP=0; else SKIP=1; fi; elif [[ "$SKIP" -eq 0 ]] && [[ "$f1" == '[oneway]' ]]; then printf $'(pair<OUString,OUString>("%s","%s")) ' "$LISTENER" $(echo -n "$f3" | sed -r -e 's@\(.*@@'); fi; done This is rather atrocious, but ensures the behaviour is exactly the same as before. Left to do: remove methods that are irrelevant here (that is, impl_allowAsynchronousCall_nothrow will never be called with them as argument) (cherry picked from commit 9dfc3807dbff1a40f487d020446265bb85d0ac16) Conflicts: svx/source/form/fmscriptingenv.cxx Change-Id: If4fea164a2fe727048645cd853a9850e59469ba5 Reviewed-on: https://gerrit.libreoffice.org/3863 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-05-01Make uno any types explicit.Thorsten Behrens1-3/+3
This was previously sticking long types into Any - which yields different sal types on different archs. Change-Id: Ifc7a60a052b57f8a83739ec11a97ab32aaa2ee7c Reviewed-on: https://gerrit.libreoffice.org/3703 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-30i#120015# Let SdrUndoAttrObj remember a reference to the used style to surviveArmin Le Grand2-14/+50
removal of the style by UI (which creates no undo actions). Re-add the style when undoing if needed. Change-Id: I6069a1cb42dfaeb0dd35fdc15687fd307f2b641e (cherry picked from commit 4c8ffa01131f2df2b314218731d83bd776944802) Signed-off-by: Thorsten Behrens <tbehrens@suse.com>
2013-04-29fdo#60910: discard UNO shape object in SdrObject::SetPageLuke Deller1-0/+12
The creation of the UNO shape in SdrObject::getUnoShape is influenced by pPage, so when the page changes we need to discard the cached UNO shape so that a new one will be created with the new page. Change-Id: Id37593fe5578afe06cd967bf0b0b7d56922fe4af Reviewed-on: https://gerrit.libreoffice.org/3662 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-15fdo#52179 on copy kb-shortcut, from *current* row, not last painted row (!)Lionel Elie Mamane1-1/+1
Change-Id: I39be862abb7c72234adad9c517d4a0570a1d71ae Reviewed-on: https://gerrit.libreoffice.org/3378 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-24fdo#62617 display groups on multiple layers correctlyDavid Tardon4-1/+27
It is possible to group objects from different layers, so it is an error to rely on layer ID when checking visibility of a group. This problem was partially obscured by the fact that SdrObjGroup::GetLayer() returns 0 if its subobjects are on different layers and 0 is a valid layer ID. Change-Id: I0ef75544a26817154642185864cafd4e6734fa38 (cherry picked from commit 09d4525b11f396a68ca7c5cbb1ae3462db40c77c) Reviewed-on: https://gerrit.libreoffice.org/2962 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-23rhbz#876742 speed up table manipulation in ImpressDavid Tardon6-15/+125
It turns out this is not actually a performance problem but an oversight in implementation (or a bug, if you want .-) Every manipulation with a table (e.g., move, resize; actually even a selection of the table) leads to creation of a full copy of the table (SdrObject::getFullDragClone()). One of the actions the table copy impl. does is to call sdr::CellProperties::SetStyleSheet() on every cell of the new table. CellProperties is derived from sdr::properties::TextProperties and CellProperties::SetStyleSheet() just passes the call to TextProperties::SetStyleSheet(). This is where the trouble begins :-) The SDR representation of a table, SdrTableObj, is derived from SdrTextObj. Because of that, SdrTextObj needs to be able to contain more than one SdrText (because a table needs one for every cell). This is handled correctly by TextProperties. But, because there is no SDR representation of a single cell, CellProperties uses the SdrTableObj as the SDR object it works on. Therefore TextProperties::SetStyleSheet() processes all SdrText objects of the _whole table_, not just a single cell. And this is repeated for every other cell... Change-Id: Iab2e2d0e1e8038710645c0bd24666e6032b0a003 (cherry picked from commit 91864e19c84ae9834d6e97ee5ddc4db5bf957681) Reviewed-on: https://gerrit.libreoffice.org/2925 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-20i#78247# and i#78029# wrong glue points in iscosceles and in right triangleRegina Henschel1-2/+2
(cherry picked from commit 26e91b07a559692b4f8acdd04f5bd28d0daa68b3) Change-Id: I504ec85fa7b94a4473905b7e2720b2169c53e6cf (cherry picked from commit e6a7c555cc6919cbe2fdaf794d57ca0819760c92) Signed-off-by: Eike Rathke <erack@redhat.com>
2013-03-14Resolves the bug fdo#59117 missing borders of last columnkarth1-3/+5
When writingmode is set to RTL, the table is start drawn from Last column to first column. There is no problem with left&right lines, Because these are not depends on the LTR or RTL writingmode. But the bottom & top line depends on writing mode. As these two lines are drawn from previous cell to next cell(left to right) the nX value should be nX-1 in RTL writingmode. Change-Id: I3e21c7dd469ed5ba29e66f79da471b662632182e Reviewed-on: https://gerrit.libreoffice.org/1834 Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa> Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa> (cherry picked from commit 8c200d85cdbece5c65b35211644f1e98491f307a) Signed-off-by: Lior Kaplan <kaplanlior@gmail.com>
2013-03-14Resolves fdo#60554K_Karthikeyan1-1/+1
Resolves fdo#60554 borders disappear while merging cells Change-Id: I3d3464e8b75cc9b72a1592d8ef276243202e68b8 Reviewed-on: https://gerrit.libreoffice.org/2375 Reviewed-by: Ahmad Harthi <aalharthi@kacst.edu.sa> Tested-by: Ahmad Harthi <aalharthi@kacst.edu.sa> (cherry picked from commit 45a5dad0460a1a7d1a44716968b8c9ff4a23e04b) Signed-off-by: Lior Kaplan <kaplanlior@gmail.com>
2013-03-04resolve fdo#54335 type an existing style name into Style box changes hierarchyJoren De Cuyper1-10/+30
Change-Id: If2fd4eecec4f6f031b264a9a1b0c31e938194878 Reviewed-on: https://gerrit.libreoffice.org/2292 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com> Reviewed-on: https://gerrit.libreoffice.org/2440 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-02-26fdo#45879 - fix selected gluepoint rendering.Michael Meeks1-5/+5
Store the glue-point bitmap at a unique index in maRealMarkers for re-use. Change-Id: I2cd5b240619502dfc8634eca331f4163e5bd5ca8 (cherry picked from commit 8d34984116c0841748ae47afa667877dc1b5a444) Signed-off-by: Thorsten Behrens <tbehrens@suse.com>
2013-02-19fdo#34548 don't crash on undoing text frame removalDavid Tardon2-1/+70
Change-Id: I48b95c6c0cbfb2f4c4b09cc90b254b96de40b3e9 (cherry picked from commit 115054fef08998c56cba8f14472df1d15007f635) Reviewed-on: https://gerrit.libreoffice.org/2232 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-01-31fdo#42387 Fixed Merging of cells in RTL Tables in impressGokul1-2/+12
The problem was in calculating the cell area, the width should be subtracted to Right end of cell instead it was adding width to Left end of the origin cell Change-Id: I3f31e0c4e0acae84ab5052823fc49932255137d3 Reviewed-on: https://gerrit.libreoffice.org/1686 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com> Reviewed-on: https://gerrit.libreoffice.org/1911 Tested-by: Lior Kaplan <kaplanlior@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-28Resolves: fdo#59965 crash dialog title area text is missingCaolán McNamara2-2/+2
Change-Id: I19adc5047d744acee243c94ff4e31531ae8c458a (cherry picked from commit ffce5ac51518bbd43ac0ae14dbb0967ae2c50bb4) Reviewed-on: https://gerrit.libreoffice.org/1893 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-01-21PRODUCTEXTENSION: fix various obvious strings and such...Michael Stahl2-2/+2
... to look pretty; most of these expect PRODUCTEXTENSION to be a word like "Beta" but nowadays it is ".micro.rc.alphabeta" numbers so there should be no space before it. ReplaceStringHookProc adds insult to injury by refusing to replace %ABOUTBOX variables unless some %PRODUCT is in the string. Change-Id: Ib676f3837ab0785529a226fc9359e8defacf3459 (cherry picked from commit c106167f5f6ec1bff9b2291ff8791ca6d4d411c3) Reviewed-on: https://gerrit.libreoffice.org/1763 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-21resolve fdo#59619 Spelling error - heigthJoren De Cuyper1-1/+1
Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6 Reviewed-on: https://gerrit.libreoffice.org/1783 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-17Resolves: fdo#59182 make the special character dialog behaveCaolán McNamara2-41/+66
squashed combo of four commits to fix fdo#59182 Related: fdo#59182 stop SvxShowCharSet resizing itself instead of resizing itself when given a size, leading to lots of flicker as the widget fights the layout, instead accept the given size, center the drawing in that area, and tweak the cell highlight drawing code to fill that extra gap space when edge cells are selected (cherry picked from commit 3c8d3ef10267fb0a50686f49c15a3e4ab35503d1) Related: fdo#59182 make SvxShowText::GetOptimalSize match its SetFont logic SetFont takes the window size to determine the best font size, so reverse that SetFont logic to get the desired optimal window size. (cherry picked from commit 463f2d4fe211e991d551be67be74cf2090afdb7e) Resolves: fdo#59182 make the special character dialog behave lock down the sizes of the widgets which depend on the (variable) font in terms of widgets which are invariant so that they don't jump around to their optimal sizes as the selected font changes. (cherry picked from commit f1088250485fa91b4131102c5275e73653bc0c2c) use the theme width for the scrollbar, not a random 16 pixels (cherry picked from commit 26af997c55106fd067b32caaceedde3f2c10c1dc) 0d2e35a780552ca52aec20809bcb77d37b6a1bfb 65ea24adb43f9faa974025b6db1c35766b577cd7 e823124e8f156099e5b1708afa5b830153fcce3e Change-Id: Iee0b44c0939cf32284907ad1fcd57e2e722837d4 Reviewed-on: https://gerrit.libreoffice.org/1716 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-01-17Resolves: fdo#59183 Copy 4 or more slides then crashCaolán McNamara1-2/+2
regression from 17afe4cea7e01aef1e5270cc09f438bc6fde3211 which is totally forgivable as its riddled with asserts that suggest there should be no out-of-bounds accesses and there probably shouldn't and those queries are possibly bugs. But double-checking 3-6 it is the case that non-existant pages were queried for in that version too, so return NULL on out-of-bounds like the original pre-stl conversion code did. Change-Id: Ic918419b6cb76b083de6b6911dde9d6e00258324 (cherry picked from commit 63de2b8f1493f24669c78df3bc2d48d13528bd9f) Reviewed-on: https://gerrit.libreoffice.org/1726 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-01-12'Calculate' string was untranslatableAndras Timar1-1/+1
Change-Id: I289e3f2c16ac1cd109e511af11f9a8fa38894edb Reviewed-on: https://gerrit.libreoffice.org/1663 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-01-10Resolves: fdo#58589 recovery dialog title area text is missingCaolán McNamara2-2/+2
regression since efc6b840a0423099d6c3e0d33c14d34637fbba4c as that changes the order in which windows are drawn Change-Id: I37388229533127ab915bec351f094fcd4786b2a3 (cherry picked from commit f8a4ce67987e5cb47f07dc61eeb450e1d5b9c541) Reviewed-on: https://gerrit.libreoffice.org/1606 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-01-08Make LO buildable again after the GraphicFilter move.Jan Holesovsky14-20/+20
Conflicts: svtools/Library_svt.mk q# Change-Id: I3455a7294b136400f32163626d5a7a7f2bfa898c Signed-off-by: Cor Nouws <oolst@nouenoff.nl> Signed-off-by: Olivier Hallot <olivier.hallot@documentfoundation.org> Signed-off-by: Adolfo Jayme Barrientos <fitoschido@ubuntu.com> Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2013-01-07Bugfix for improper function call, column count was compared with row countK_Karthikeyan1-1/+1
Change-Id: Iacf59548209d2be8b36839ae12bed9cedb7bdded Reviewed-on: https://gerrit.libreoffice.org/1562 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit aaaa5350075ad5f589c242ec40f9f6ab7fe822a5)
2013-01-07Fix calls to SfxPoolItem* Put with a Which-ID of sal_falseWerner Koerner2-2/+2
Change-Id: I39914909fd394532e7a32c791d4480530393c1c0 Reviewed-on: https://gerrit.libreoffice.org/1499 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 475469626b3a92528a9584d6c34f2b44b7eb8d1c)
2012-12-24fdo#56980, fdo#58267 don't leave stale SdrObject refs aroundDavid Tardon1-0/+32
When a new SvxShape is set on this SdrObject, remove itself from the previously set SvxShape (if any). Otherwise it will try to reset the SdrObject's SvxShape in its destructor... Change-Id: I89d952a722b643a06f8eea87aad68f8bd230f811 (cherry picked from commit 31b93b8600a3e219d33173aa68d9ab570e477e50) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-12-20fdo#58427: fix another crash in SvxFontPrevWindow::PaintMichael Stahl1-2/+7
In Writer, Search&replace -> More options -> Formats used to have a window title of "Example" but not any more; let's add another fallback for the example text to makeRepresentativeTextForFont, which seems to give "Lorem ipsum" here. (regression from widget layout) Change-Id: I8dd9c099be31ed4390b04e8069a74960b58c6084 (cherry picked from commit a2dd3acd205cb8df959ac03e99b1d1991cc562a8)
2012-12-19fdo#56267, fdo#56980 propagate shape change to subclassesDavid Tardon3-3/+29
It turns out (as witnessed by fdo#56267) that my fix for fdo#56980 only cured the symptom, not the cause. The real problem is caused by the following sequence of events during ODF import: 1) an SvxCustomShape object is created (XShape iface) 2) an SdrObjCustomShape object is created for the SvxCustomShape, but it is not associated with it (yet) 3) another SvxCustomShape object is created internally by the SdrObjCustomShape and they are associated 4) an EnhancedCustomShapeEngine is created for this SvxCustomShape by SdrObjCustomShape 5) the SvxCustomShape from point 1 is set to the SdrObjCustomShape At some point (I did not follow this explicitly) the SvxCustomShape cached by the EnhancedCustomShapeEngine loses its (weak) reference to the SdrObjCustomShape. This leaves it gutted and all subsequent calls to render() return an empty XShape. The solution is simple: let SdrObjCustomShape know that the associated UNO shape has changed, so it can drop the custom shape engine. Change-Id: I267838ea4857dfcd646f40c811f3ae572237a1e6 (cherry picked from commit 7fec8dfcaca4efc92516f9af51a3157f1a11ccd7) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-12-19Revert "fdo#58399 - revert attempts to untangle and accelerate this mess."David Tardon2-12/+20
This reverts commit bb3f2900a867fdcb6df916fff58199b4ce94dd05. (cherry picked from commit c3fed9f4ea354427c205bd407fcfa3d04093ba50) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-12-18fix assertionDavid Tardon1-2/+2
Change-Id: I67bf571062c5246402979170e0395ede320dac82 Signed-off-by: David Tardon <dtardon@redhat.com>
2012-12-18set numbers in svx/uiconfig/ui/compressgraphicdialog.ui to translatable="no"Rene Engelhard1-7/+7
as otherwise we get uiex's output is invalid: svx uiconfig\ui Change-Id: I39b776cdb3561be0bffb8e9ebe3bf9f2660162f6 Signed-off-by: Caolan McNamara <caolanm@redhat.com>
2012-12-18fix problematic calc object selection after object create (at non 100% zoom)Noel Power1-0/+1
sometimes difficult to select custom shapes etc. created at non 100% zoom levels. workaround was to use selection tool to select an area. Change-Id: I112a60ebf37a37b16f6af5e70358853088e648a8
2012-12-17fdo#58399 - revert attempts to untangle and accelerate this mess.Michael Meeks2-20/+12
Reverts commits: 76350361f386b78e1bc9edb75af89e7ff3afe356 67f899e1d2db0dccde4b9587a52b7157fe1fb0be 1d77d4eada214e14938336070b248c18705939ff 1d16f59023b1b19d01ca69b8c9735be6d3baf5d9 The bug has a great series of linked bugs and stack-traces; the weakref / mixed tools & UNO lifecycle here is simply hideous.
2012-12-16Compress graphics dialog converted to new widget layout.Tomaž Vajngerl8-461/+807
Change-Id: Ibcf6338f33c40fbe6682a843b4771d51ea5a6845
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 12:59:07 +0000